> On 20 Nov 2017, at 10:27, Xueming Shen <xueming.s...@oracle.com> wrote:
>
> Hi Alan,
>
> Here is the updated webrev with
>
> (1) to move JarFile.getRealName into JarEntry
> (2) to hide ZipFile.entryNameStream() from the public
> (3) to reword the JarFile.versionedStream() to scope the "latest versined"
>
> http://cr.openjdk.java.net/~sherman/8189611/webrev
>
JarFile
—
170 private static final JavaUtilZipFileAccess juzfa;
Convert to capitals?
684 JarFileEntry asBasename(String name) {
s/asBasename/withBasename
610 // placeholder for now
611 String getRealName(JarEntry entry) {
612 return entry.getRealName();
613 }
No longer required? I dunno what calls it...
1123 final Enumeration<JarEntry> enum_ =
1124 juzfa.entries(JarFile.this, JarFileEntry::new);
s/enum_/unfilteredEntries
You can also LVTI and replace the left hand type declaration with var if you
like.
Same comments for JarVerifier
ZipFile
—
592 return StreamSupport.stream(new EntrySpliterator<ZipEntry>(0,
zsrc.total,
...
623 new EntrySpliterator<String>(0, zsrc.total,
this::getEntryName), false);
Can you use <> ? Not sure of the type inference will work here.
Paul.
