Re: JDK 11 RFR of JDK-8196995: java.lang.Character should not state UTF-16 encoding is used for strings

Hello, On 2/8/2018 3:53 AM, Alan Bateman wrote: On 07/02/2018 22:12, joe darcy wrote: Hello, Text in java.lang.Character states a UTF-16 character encoding is used for java.lang.String. While was true for many years, it is not necessarily true and not true in practice as of JDK 9 due to the

Re: [PATCH] Reduce Chance Of Mistakenly Early Backing Memory Cleanup

Hi Paul, Following up with the requested loop and vectorization benchmarks ... (Do the vectorization benchmark results imply that the Hotspot compiler has been unable to perform the vectorization optimisation due to the presence of the reachabilityFence ?)

Re: [PATCH] Reduce Chance Of Mistakenly Early Backing Memory Cleanup

Hi Ben, Thanks. I anticipated a performance hit but not necessarily a 10x. Without looking at the generated code of the benchmark method it is hard to be sure [*], but i believe the fence is interfering with loop unrolling and/or vectorization, the comparative differences between byte and int

RFR 8178342: Missing @modules in jdk/jdk/nio/zipfs

Hi. Can you took a quick look on this fix. While adding missing @modules declaration in jdk/nio/zipfs/ZeroDate.java, I noticed that @modules declaration is not in the right location in other tests. Per the agreement it should come before any @run. Bug:

Re: RFR: 8041626: [Event Request] Shutdown reason

Hi Robin, Saving useful information about failures during shutdown is useful. Can the shutdown of JFR be put off? Is the use of shutdown hook still necessary? Thanks, Roger On 2/8/2018 10:50 AM, Robin Westberg wrote: Hi David, On 8 Feb 2018, at 04:28, David Holmes

Re: RFR: 8194154 patch for crash at File.getCanonicalPath()

HI, Alan As in your email to RFR of 8194154 which now has a new fix in canonicalize_md.c, switch back to discuss solution here again. The current fix is not in java, instead, I put it in C function. In the function before the fix, it assumes no more "//" pattern in the string so failed to get

Re: RFR 8178342: Missing @modules in jdk/jdk/nio/zipfs

+1 Mandy On 2/8/18 10:40 AM, Alexandre (Shura) Iline wrote: Hi. Can you took a quick look on this fix. While adding missing @modules declaration in jdk/nio/zipfs/ZeroDate.java, I noticed that @modules declaration is not in the right location in other tests. Per the agreement it should come

Re: JDK 11 RFR of JDK-8196995: java.lang.Character should not state UTF-16 encoding is used for strings

On 2/8/18, 10:59 AM, joe darcy wrote: Hello, On 2/8/2018 3:53 AM, Alan Bateman wrote: On 07/02/2018 22:12, joe darcy wrote: Hello, Text in java.lang.Character states a UTF-16 character encoding is used for java.lang.String. While was true for many years, it is not necessarily true and not

Re: JDK 11 RFR of JDK-8196995: java.lang.Character should not state UTF-16 encoding is used for strings

Since other people who work more closely in the area than me don't seem to find the wording confusing or misleading, I'll just close out the bug. Thanks, -Joe On 2/8/2018 11:13 AM, Xueming Shen wrote: On 2/8/18, 10:59 AM, joe darcy wrote: Hello, On 2/8/2018 3:53 AM, Alan Bateman wrote: On

Re: JDK 11 RFR of JDK-8196995: java.lang.Character should not state UTF-16 encoding is used for strings

Instead of saying something specific about char[], String etc you can be more general and say something about the entire Java Platform. "The Java Platform generally processes human language text represented as sequences of {@code char} values in the UTF-16 encoding of Unicode" But doing this

Re: RFR 8190378: Java EE and CORBA modules removal

On 07/02/2018 16:57, Lance Andersen wrote: Hi all, I think we are at a point where we are ready to start reviewing the changes to remove the Java EE and CORBA modules as JEP 320, JDK-8189188, has been targeted to JDK 11. The CSR for removing the modules has been approved:

Re: RFR (JDK11) 8137326: Methods for comparing CharSequence, StringBuilder, and StringBuffer

Hi all, The CSR for the enhancement is now approved. Thanks Joe! The webrev has been updated accordingly. Please let me know if you have any further comment on the implementation. JBS: https://bugs.openjdk.java.net/browse/JDK-8137326 webrev:

RFR: jsr166 jdk integration 2018-02

http://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/overview.html 8190324: ThreadPoolExecutor should not specify a dependency on finalization http://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/ThreadPoolExecutor-finalize/index.html

Re: RFR: jsr166 jdk integration 2018-02

On 9/02/2018 11:19 AM, Martin Buchholz wrote: http://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/overview.html 8190324: ThreadPoolExecutor should not specify a dependency on finalization

Re: RFR: jsr166 jdk integration 2018-02

On Thu, Feb 8, 2018 at 7:39 PM, David Holmes wrote: > On 9/02/2018 11:19 AM, Martin Buchholz wrote: > >> http://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integr >> ation/overview.html >> >> 8190324: ThreadPoolExecutor should not specify a dependency on >>

RFR 8197462 : Inconsistent exception messages for invalid capturing group names

Hello! Capturing group name can be used in a regular expression in two contexts: When introducing a group (?...) or when referring it \k. If the name is invalid (i.e. does not start with a Latin letter, or contains wrong chars) then we may see different error messages, some of which look

Re: RFR: jsr166 jdk integration 2018-02

Hi Martin, On 9/02/2018 2:07 PM, Martin Buchholz wrote: On Thu, Feb 8, 2018 at 7:39 PM, David Holmes > wrote: On 9/02/2018 11:19 AM, Martin Buchholz wrote:

Re: RFR: jsr166 jdk integration 2018-02

On 9/02/2018 3:35 PM, Martin Buchholz wrote: On Thu, Feb 8, 2018 at 8:39 PM, David Holmes > wrote: Wow! DelegatedExecutorService doesn't even have a finalize() method that does a shutdown. So we have to put the reachabilityFence

Re: RFR: 8041626: [Event Request] Shutdown reason

Hi Robin, On 9/02/2018 1:50 AM, Robin Westberg wrote: Hi David, On 8 Feb 2018, at 04:28, David Holmes wrote: Hi Robin, Adding in hotspot-runtime-dev as all the hotspot changes belong to runtime. Thanks, sorry about that.. I had an initial look through this. To

Re: RFR: jsr166 jdk integration 2018-02

On Thu, Feb 8, 2018 at 8:39 PM, David Holmes wrote: > > Wow! DelegatedExecutorService doesn't even have a finalize() method that > does a shutdown. So we have to put the reachabilityFence in it to prevent > the delegatee from becoming unreachable due to the delegator

Re: RFR: jsr166 jdk integration 2018-02

On Thu, Feb 8, 2018 at 10:39 PM, David Holmes wrote: > > Well at least it's only an issue if there does exist a finalize() method > that could interfere with the executing method. I have to assume that > somehow the VM is clever enough that if 'this' is in a register and

Re: RFR 8190378: Java EE and CORBA modules removal

> On Feb 8, 2018, at 3:04 AM, Alan Bateman wrote: > > On 07/02/2018 16:57, Lance Andersen wrote: >> Hi all, >> >> I think we are at a point where we are ready to start reviewing the changes >> to remove the Java EE and CORBA modules as JEP 320, JDK-8189188, has been

Re: JDK 11 RFR of JDK-8196995: java.lang.Character should not state UTF-16 encoding is used for strings

On 07/02/2018 22:12, joe darcy wrote: Hello, Text in java.lang.Character states a UTF-16 character encoding is used for java.lang.String. While was true for many years, it is not necessarily true and not true in practice as of JDK 9 due to the improvements from JEP 254: Compact Strings.

Re: RFR : 8196854 :TestFlushableGZIPOutputStream failing with IndexOutOfBoundsException

Hi Sean, Looks fine, Roger On 2/7/2018 1:03 PM, Seán Coffey wrote: A jdk8u (and earlier) issue where some new/recent test code meant that IndexOutOfBoundsException could be thrown. https://bugs.openjdk.java.net/browse/JDK-8196854 http://cr.openjdk.java.net/~coffeys/webrev.8196854/webrev/

Re: RFR [11] (JAXP): 6857903: SAXException.initCause() does not correctly set Exception

Aleksei, Looks good to me. Jason From: Aleks Efimov Sent: Wednesday, February 7, 2018 7:24 PM To: Roger Riggs; Jason Mehrens Cc: core-libs-dev@openjdk.java.net Subject: Re: RFR [11] (JAXP): 6857903: SAXException.initCause()

Re: RFR : 8196854 :TestFlushableGZIPOutputStream failing with IndexOutOfBoundsException

+1 On Feb 7, 2018, at 10:03 AM, Seán Coffey wrote: A jdk8u (and earlier) issue where some new/recent test code meant that IndexOutOfBoundsException could be thrown. https://bugs.openjdk.java.net/browse/JDK-8196854

Re: RFR [11] (JAXP): 6857903: SAXException.initCause() does not correctly set Exception

Looks fine  +1 Thanks, Roger On 2/8/2018 10:13 AM, Jason Mehrens wrote: Aleksei, Looks good to me. Jason From: Aleks Efimov Sent: Wednesday, February 7, 2018 7:24 PM To: Roger Riggs; Jason Mehrens Cc:

Re: RFR: 8041626: [Event Request] Shutdown reason

Hi David, > On 8 Feb 2018, at 04:28, David Holmes wrote: > > Hi Robin, > > Adding in hotspot-runtime-dev as all the hotspot changes belong to runtime. Thanks, sorry about that.. > I had an initial look through this. > > To be honest I don't like it. We seem to have