Re: RFR 8204310 : Simpler RandomAccessFile.setLength() on Windows

We had BTW problems (on Windows) with SMB hosted files where appending causes sometimes the filepointer to not increase. We fixed that by closing the file in such conditions. It does however look like a smb Cache and not Jav

Re: Ping!! Re: RFR: 8203357 Container Metrics

Hi Bob, On 06/07/2018 07:43 PM, Bob Vandette wrote: Can I get one more reviewer for this RFE so I can integrate it? http://cr.openjdk.java.net/~bobv/8203357/webrev.01 Seems okay. Metrics.java "Returns the length of the operating system time slice" Note that is is only true if you are using

Re: Ping!! Re: RFR: 8203357 Container Metrics

Sorry Bob I haven't had a chance to look at this detail. For the Java code ... methods that return arrays should return zero-length arrays when something is not available rather than null. For getCpuPeriod() the term "operating system time slice" can be misconstrued as being related to the sc

Re: Durations in existing JDK APIs

Finally got to check the logic in convert(Duration), and it looks fine to me. All three look good thanks Stephen (not an OpenJDK reviewer). On 6 June 2018 at 18:03, Martin Buchholz wrote: > OK, here is a RFR for low-hanging changes (some of these changes have > already been reviewed by some of y

Proposal: optimization of Map.copyOf and Collectors.toUnmodifiableMap

Hi, Those two methods were added in JDK 10 and they are not very optimal. Map.copyOf(Map map) 1st dumps the source map into an array of Map.Entry(s) (map.entrySet().toArray(new Entry[0])), which typically creates new Map.Entry objects, then passes the array to Map.ofEntries(Map.Entry[] entrie

BiCollector

Hi, Have you ever wanted to perform a collection of the same Stream into two different targets using two Collectors? Say you wanted to collect Map.Entry elements into two parallel lists, each of them containing keys and values respectively. Or you wanted to collect elements into  groups by so

RFR(xs): 8204663: clean up remaining native parts after JDK-8187631

Hi, may I please have reviews for this small cleanup. Bug: https://bugs.openjdk.java.net/browse/JDK-8204663 Webrev: http://cr.openjdk.java.net/~stuefe/webrevs/JDK-8204663-clean-up-after-JDK-8187631/webrev.00/webrev/ This change removes some native functions from FOS/FIS which are orphaned and u

Re: Ping!! Re: RFR: 8203357 Container Metrics

> On Jun 11, 2018, at 4:32 AM, David Holmes wrote: > > Sorry Bob I haven't had a chance to look at this detail. > > For the Java code ... methods that return arrays should return zero-length > arrays when something is not available rather than null. All methods do return zero length arrays e

Re: RFR(xs): 8204663: clean up remaining native parts after JDK-8187631

On 6/11/18 9:13 AM, Thomas Stüfe wrote: Hi, may I please have reviews for this small cleanup. Bug: https://bugs.openjdk.java.net/browse/JDK-8204663 Webrev: http://cr.openjdk.java.net/~stuefe/webrevs/JDK-8204663-clean-up-after-JDK-8187631/webrev.00/webrev/ This change removes some native fu

Re: RFR(xs): 8204663: clean up remaining native parts after JDK-8187631

Hi Thomas, Looks fine.  (And also passed the tests I ran). Thanks, Roger On 6/11/18 9:13 AM, Thomas Stüfe wrote: Hi, may I please have reviews for this small cleanup. Bug: https://bugs.openjdk.java.net/browse/JDK-8204663 Webrev: http://cr.openjdk.java.net/~stuefe/webrevs/JDK-8204663-clean-

Re: RFR(xs): 8204663: clean up remaining native parts after JDK-8187631

Thank you Roger! I re-ran submission tests and all went well this time. Must have been a windows specific fluke. ..Thomas On Mon, Jun 11, 2018 at 5:56 PM, Roger Riggs wrote: > Hi Thomas, > > Looks fine. (And also passed the tests I ran). > > Thanks, Roger > > > On 6/11/18 9:13 AM, Thomas Stüfe

Re: BiCollector

Hi Peter, I like it and can see it being useful, thanks for sharing. I am hesitating a little about it being in the JDK because there is the larger abstraction of a BiStream, where a similar form of collection would naturally fit (but perhaps without the intersection constraints for the chara

Re: BiCollector

Note also that this has some overlappings with Collectors.partitioningBy - which currently wraps results into a Map, where O is the desired collector output type. Without commenting on the feasibility of its inclusion in the JDK (Paul rules here :-)), I note that BiStream would obviously allow

Re: BiCollector

Hi, I’ve created one of my own and I’d happily toss it for a standard implementation. — Kirk > On Jun 11, 2018, at 8:10 PM, Paul Sandoz wrote: > > Hi Peter, > > I like it and can see it being useful, thanks for sharing. > > I am hesitating a little about it being in the JDK because there i

Re: [JDK 11] RFR 8201528: Add new test to check for package versioning information in OpenJDK

On 6/10/18 10:12 PM, Chris Yin wrote: Hi, Mandy Thanks lot for your suggestions, update webrev as below and comment inline, thanks http://cr.openjdk.java.net/~xyin/8201528/webrev.02/ Looks good. Thanks for the update and this is much easier to understand the test cases. Mandy

Re: Ping!! Re: RFR: 8203357 Container Metrics

> On Jun 11, 2018, at 4:07 AM, Robbin Ehn wrote: > > Hi Bob, > > On 06/07/2018 07:43 PM, Bob Vandette wrote: >> Can I get one more reviewer for this RFE so I can integrate it? >>> http://cr.openjdk.java.net/~bobv/8203357/webrev.01 > > Seems okay. > > Metrics.java > "Returns the length of the

Re: BiCollector

Hi Paul, Can you point me to some BiStream code (if it is available publicly)? Thanks, Peter On 06/11/18 19:10, Paul Sandoz wrote: Hi Peter, I like it and can see it being useful, thanks for sharing. I am hesitating a little about it being in the JDK because there is the larger abstraction

Re: BiCollector

Hi Peter, You may find something on lambda-dev, i remember that we discussed about BiStream, and as Paul said we decide to not include it because the performance were not great and it adds another axis to the API making it even harder to retrofitted it when we will introduce specialization. reg

Re: Ping!! Re: RFR: 8203357 Container Metrics

On 12/06/2018 12:12 AM, Bob Vandette wrote: On Jun 11, 2018, at 4:32 AM, David Holmes > wrote: Sorry Bob I haven't had a chance to look at this detail. For the Java code ... methods that return arrays should return zero-length arrays when something is not avai

Re: Ping!! Re: RFR: 8203357 Container Metrics

> On Jun 11, 2018, at 5:21 PM, David Holmes wrote: > > On 12/06/2018 12:12 AM, Bob Vandette wrote: >>> On Jun 11, 2018, at 4:32 AM, David Holmes >> > wrote: >>> >>> Sorry Bob I haven't had a chance to look at this detail. >>> >>> For the Java code ... methods

Re: [JDK 11] RFR 8201528: Add new test to check for package versioning information in OpenJDK

Thank you, Mandy Regards, Chris > On 12 Jun 2018, at 1:48 AM, mandy chung wrote: > > > > On 6/10/18 10:12 PM, Chris Yin wrote: >> Hi, Mandy >> Thanks lot for your suggestions, update webrev as below and comment inline, >> thanks >> http://cr.openjdk.java.net/~xyin/8201528/webrev.02/ > > >

Re: Ping!! Re: RFR: 8203357 Container Metrics

On 12/06/2018 9:30 AM, Bob Vandette wrote: On Jun 11, 2018, at 5:21 PM, David Holmes wrote: On 12/06/2018 12:12 AM, Bob Vandette wrote: On Jun 11, 2018, at 4:32 AM, David Holmes mailto:david.hol...@oracle.com>> wrote: Sorry Bob I haven't had a chance to look at this detail. For the Java c

Re: [core-libs] RFR (L): 8010319: Implementation of JEP 181: Nest-Based Access Control

Here is one further minor update from the CSR discussions: http://cr.openjdk.java.net/~dholmes/8010319-JEP181/webrev.corelibs.v5-incr/src/java.base/share/classes/java/lang/Class.java.cdiff.html Thanks, David On 25/05/2018 3:52 PM, David Holmes wrote: Here are the further minor updates so far in

RE: RFR: 8196993: Resolve disabled warnings for libunpack

Gentle reminder . May I have review for the below changeset. Regards, Srinivas -Original Message- From: Srinivas Dama Sent: Friday, June 08, 2018 6:33 PM To: Core-Libs-Dev Subject: RFR: 8196993: Resolve disabled warnings for libunpack Hi, Please review http://cr.openjdk.java.net/~sdam

RE: RFR: 8196988 (Resolve disabled warnings for libjimage)

Gentle reminder. May I have review for the below changeset. Regards, Srinivas -Original Message- From: Srinivas Dama Sent: Friday, June 08, 2018 11:47 AM To: core-libs-dev@openjdk.java.net Subject: Re: RFR: 8196988 (Resolve disabled warnings for libjimage) Hi, Please review http://cr.o

Re: Ping!! Re: RFR: 8203357 Container Metrics

On 6/11/18 10:12 PM, David Holmes wrote: For the Java code ... methods that return arrays should return zero-length arrays when something is not available rather than null. All methods do return zero length arrays except I missed the getPerCpuUsage.  I’ll fix that one and correct the javado

Re: RFR: 8196993: Resolve disabled warnings for libunpack

Looks fine. Mandy On 6/11/18 10:21 PM, Srinivas Dama wrote: Gentle reminder . May I have review for the below changeset. Regards, Srinivas -Original Message- From: Srinivas Dama Sent: Friday, June 08, 2018 6:33 PM To: Core-Libs-Dev Subject: RFR: 8196993: Resolve disabled warnings for

Re: [core-libs] RFR (L): 8010319: Implementation of JEP 181: Nest-Based Access Control

On 6/11/18 10:16 PM, David Holmes wrote: Here is one further minor update from the CSR discussions: http://cr.openjdk.java.net/~dholmes/8010319-JEP181/webrev.corelibs.v5-incr/src/java.base/share/classes/java/lang/Class.java.cdiff.html "This implementation" is fine, as used in many @implNot

Re: Ping!! Re: RFR: 8203357 Container Metrics

On 12/06/2018 3:31 PM, mandy chung wrote: On 6/11/18 10:12 PM, David Holmes wrote: For the Java code ... methods that return arrays should return zero-length arrays when something is not available rather than null. All methods do return zero length arrays except I missed the getPerCpuUsage. 

Re: Ping!! Re: RFR: 8203357 Container Metrics

On 6/11/18 10:43 PM, David Holmes wrote: On 12/06/2018 3:31 PM, mandy chung wrote: On 6/11/18 10:12 PM, David Holmes wrote: For the Java code ... methods that return arrays should return zero-length arrays when something is not available rather than null. All methods do return zero length