RE: [RFR] 8205525 : Improve exception messages during manifest parsing of jar archives

2018-07-31 Thread Baesken, Matthias
Hello , looks like the generalization of the `includeInExceptions` security property is now in jdk/jdk after "8207846: Generalize the jdk.net.includeInExceptions security property" was added, great news and thanks to Chris for driving this ! I use this security property now as well

Re: RFR: 8207851 JEP Draft: Support ByteBuffer mapped over non-volatile memory

2018-07-31 Thread Andrew Dinn
Well, given the lack of any further input I am left wondering, JEP neophyte that I am, whether: i) said happy lacuna implies that it is appropriate to submit this JEP (as prompted by both the process blurb provided in JEP 1 and the accordingly labelled button in the JEP JIRA interface) or ii

[12] RFR 8208560: ChoiceFormat class has unused constants needs cleanup

2018-07-31 Thread Nishit Jain
Hi, Please review this cleanup fix for 8208560 Bug: https://bugs.openjdk.java.net/browse/JDK-8208560 Webrev: http://cr.openjdk.java.net/~nishjain/8208560/webrev.00/ Cause and Fix: Changes made for JDK-8021322 has left some unused static fields, not sure why these fields have package private ac

Re: RFR 8208524: IntelliJ support broken since 2018.2

2018-07-31 Thread Thomas Stüfe
Hi Maurizio, thank you for fixing this. I tested it and it works. I did not dive deeply into the issue, but your changes look like they do what you claim they do. Thanks, Thomas On Mon, Jul 30, 2018 at 7:50 PM, Maurizio Cimadamore wrote: > Hi, > support for IntelliJ projects (both langtools spe

Re: [12] RFR 8208560: ChoiceFormat class has unused constants needs cleanup

2018-07-31 Thread Roger Riggs
Looks fine. On 7/31/18 4:27 AM, Nishit Jain wrote: Hi, Please review this cleanup fix for 8208560 Bug: https://bugs.openjdk.java.net/browse/JDK-8208560 Webrev: http://cr.openjdk.java.net/~nishjain/8208560/webrev.00/ Cause and Fix: Changes made for JDK-8021322 has left some unused static fiel

Re: RFR 8208524: IntelliJ support broken since 2018.2

2018-07-31 Thread Maurizio Cimadamore
Thanks for testing and reviewing Thomas! P.S. I'll be pushing shortly another RFR in code tools for the jtreg plugin source code, which is also broken by the latest IJ update. Cheers Maurizio On 31/07/18 14:36, Thomas Stüfe wrote: Hi Maurizio, thank you for fixing this. I tested it and it

Re: RFR: 8207851 JEP Draft: Support ByteBuffer mapped over non-volatile memory

2018-07-31 Thread Roger Riggs
Hi Andrew, The JEP is clear on the concept and has many more details than are necessary to submit it.  Supplying so much detail at the earliest stage invites more discussion about the implementation than the concept. Usually, the details of API and implementation are added as the JEP progresses

Re: [12] RFR 8208560: ChoiceFormat class has unused constants needs cleanup

2018-07-31 Thread Naoto Sato
+1 Naoto On 7/31/18 7:57 AM, Roger Riggs wrote: Looks fine. On 7/31/18 4:27 AM, Nishit Jain wrote: Hi, Please review this cleanup fix for 8208560 Bug: https://bugs.openjdk.java.net/browse/JDK-8208560 Webrev: http://cr.openjdk.java.net/~nishjain/8208560/webrev.00/ Cause and Fix: Changes mad

Re: 8143850: retrofit ArrayDeque to implement List

2018-07-31 Thread Stuart Marks
OK, great. It looks like a heavily modified version of ArrayDeque.java. This makes it a bit difficult to understand what the changes are. Would you mind if I rehosted this to cr.openjdk.java.net and generated a webrev for it? Thanks, s'marks On 7/28/18 11:05 PM, Alex Foster wrote: Hi,

[PING] Re: [12] (AIX) 8207744: Clean up inconsistent use of opendir/closedir versus opendir64/closedir64

2018-07-31 Thread Brian Burkhalter
Hi, Does anyone have any further comments on this? Is there anyone willing to volunteer to build and test it on AIX? Thanks, Brian On Jul 30, 2018, at 1:35 PM, Brian Burkhalter wrote: > Hi Bernard, > > Yes we agree. I believe I already had that change to those two files in the > revised (

Re: 8143850: retrofit ArrayDeque to implement List

2018-07-31 Thread Alex Foster
Sure, I don't mind. I would have done that myself but I don't think I have access to upload to cr.openjdk.java.net. Alex From: Stuart Marks Sent: July 31, 2018 2:40 PM To: Alex Foster Cc: core-libs-dev@openjdk.java.net Subject: Re: 8143850: retrofit ArrayDeque

Re: 8143850: retrofit ArrayDeque to implement List

2018-07-31 Thread Patrick Reinhart
Hi Alex, I can do that for you -Patrick Am 31.07.2018 um 21:08 schrieb Alex Foster: > Sure, I don't mind. I would have done that myself but I don't think I have > access to upload to cr.openjdk.java.net. > > > Alex > > > From: Stuart Marks > Sent: July 31,

Re: 8143850: retrofit ArrayDeque to implement List

2018-07-31 Thread Patrick Reinhart
Am 31.07.2018 um 21:10 schrieb Patrick Reinhart: > Hi Alex, > > I can do that for you > > -Patrick > Here it is: http://cr.openjdk.java.net/~reinhapa/reviews/8143850/webrev -Patrick

[12] Review Request: 8205537 Drop of sun.applet package

2018-07-31 Thread Sergey Bylokhov
Hello. Please review the fix for jdk11. Bug: https://bugs.openjdk.java.net/browse/JDK-8205537 Webrev: http://cr.openjdk.java.net/~serb/8205537/webrev.00/ sun.applet is an internal package contained some code related to implementation of applets and appletviewer. Some of its classes were dropped

Re: [12] Review Request: 8205537 Drop of sun.applet package

2018-07-31 Thread Sergey Bylokhov
On 31/07/2018 16:39, Sergey Bylokhov wrote: Hello. Please review the fix for jdk11. typo, I meant jdk12. Bug: https://bugs.openjdk.java.net/browse/JDK-8205537 Webrev: http://cr.openjdk.java.net/~serb/8205537/webrev.00/ sun.applet is an internal package contained some code related to impleme

Re: RFR: 8207851 JEP Draft: Support ByteBuffer mapped over non-volatile memory

2018-07-31 Thread Vladimir Kozlov
Hi Andrew, I think most people are concentrating on JVMLS/OJW currently. That could explain a lack of comments. But from the discussion on this thread I see that your proposal is well received. On 7/31/18 4:01 AM, Andrew Dinn wrote: Well, given the lack of any further input I am left wonderin

RE: core-libs-dev Digest, Vol 135, Issue 86

2018-07-31 Thread Baesken, Matthias
Hi Brian , I'll build it on AIX + in case it builds fine put it into our test patch queue . Best regards , Matthias > > -- > > Message: 1 > Date: Tue, 31 Jul 2018 11:47:57 -0700 > From: Brian Burkhalter > To: "B. Blase