Re: (XS) java.logging Level.java minor cleanups

Hi Bernd, Mandy, Sorry I missed answering your question! On 23/08/2018 21:02, mandy chung wrote: On 8/23/18 2:49 PM, Bernd Eckenfels wrote: Did you had any opinion on the synthetic accessors as well? : BTW: I get a synthetic Accessor warning on l.name/value, is this what  nestmates will

RFR: 8209937: Enhance java.io.Console - provide methods to query console width and height

Hi, please review and give feedback for this augmentation of java.io.Console. We have users that have the need to query for Width and Height of the console device in Java. In our own JVM implementation we had given them this hook as a custom extension already quite some time ago. We think, howe

Re: RFR: 8209837: Avoid initializing ExpiringCache during bootstrap

Hi, On 2018-08-23 17:12, Remi Forax wrote: Hi Claes, useCanonPrefixCache = useCanonCaches ? getBooleanProperty("sun.io.useCanonPrefixCache",false) : false; can be written useCanonPrefixCache = useCanonCaches && getBooleanProperty("sun.io.useCanonPrefixCache",false); sure. and the nam

Re: RFR: 8209837: Avoid initializing ExpiringCache during bootstrap

- Mail original - > De: "Claes Redestad" > À: "Remi Forax" > Cc: "core-libs-dev" > Envoyé: Vendredi 24 Août 2018 11:38:35 > Objet: Re: RFR: 8209837: Avoid initializing ExpiringCache during bootstrap > Hi, > > On 2018-08-23 17:12, Remi Forax wrote: >> Hi Claes, >> >>useCanonPrefi

Re: RFR: 8209937: Enhance java.io.Console - provide methods to query console width and height

Hi Christoph, getWidth() and getHeight() should be instance methods and not static methods, providing the weight or the height if there is no console seems weird. Also, they should be named width() and height() given the rest of the methods of java.io.Console doesn't use the "get" convention. re

RFR:8205330 InitialDirContext ctor sometimes throws NPE if the server has sent a disconnection

Hi All, Please review this simple fix below webrev: http://cr.openjdk.java.net/~vtewari/8205330/webrev0.0/index.html bugid: https://bugs.openjdk.java.net/browse/JDK-8205330 This fix will resolve the race in LdapClient  where we are explicitly making "null" to LdapClient.conn. Thanks, Vyom

Re: Javac Compiler

Hi, if you are looking at the compiler code base and would like some specific help, please consider posting at the compiler-dev mailing list: http://mail.openjdk.java.net/pipermail/compiler-dev/ Cheers Maurizio On 24/08/18 04:03, Ioi Lam wrote: $ find . -name main | grep javac ./src/jdk.c

Re: RFR: 8209937: Enhance java.io.Console - provide methods to query console width and height

On 08/24/2018 12:09 PM, Remi Forax wrote: Hi Christoph, getWidth() and getHeight() should be instance methods and not static methods, providing the weight or the height if there is no console seems weird. Also, they should be named width() and height() given the rest of the methods of java.i

RFR - CSR JDK-8200435 - String::align, String::indent (after revisions)

After further discussion, the API specs for these methods have been extensively reworked and the CSR moved back to Proposal stage. Please review https://bugs.openjdk.java.net/browse/JDK-8200435 Cheers, — Jim

RE: RFR: 8209937: Enhance java.io.Console - provide methods to query console width and height

Hi Rémi, Hi Peter, thanks for your quick answers. What you've suggested, Rémi, is perfectly right. I've updated my webrev. The methods were copied from our old implementation (of a different class) where they were provided as static. I will also think of using an optional. I'm furthermore wond

Re: RFR: 8209937: Enhance java.io.Console - provide methods to query console width and height

On 08/24/2018 03:18 PM, Langer, Christoph wrote: Hi Rémi, Hi Peter, thanks for your quick answers. What you've suggested, Rémi, is perfectly right. I've updated my webrev. The methods were copied from our old implementation (of a different class) where they were provided as static. I will

RE: [RFR] 8205525 : Improve exception messages during manifest parsing of jar archives

Hello, I created another webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8205525.5/ - use now jarPath instead of jarpath in the java security file - moved the parsing of the property to a more general location (separate class jdk/internal/util/SecuritySystemPropertyHelper.java ) -

Re: RFR:8205330 InitialDirContext ctor sometimes throws NPE if the server has sent a disconnection

Hi Vyom, On 24/08/18 11:35, vyom tewari wrote: Hi All, Please review this simple fix below webrev: http://cr.openjdk.java.net/~vtewari/8205330/webrev0.0/index.html bugid: https://bugs.openjdk.java.net/browse/JDK-8205330 This fix will resolve the race in LdapClient  where we are explicitly m

Re: RFR: 8209937: Enhance java.io.Console - provide methods to query console width and height

To the core-libs ... On 8/24/18, 9:56 AM, Xueming Shen wrote: Hi Langer, I would suggest to add explicit wording to emphasize the "size" means the rows and columns in characters, not the pixels. It appears attractive to have a Console.Dimension to abstract the size and make it an "atomic" a

JEP 330 class loader getResourceAsStream

JEP 330 (launch single-file source programs) uses a MemoryClassLoader. the compiled bytecode is stored in byte arrays in memory and is never written to file. currently, the bytecode is not exposed as resources and it would be advantageous to do so (enabling the use of eg ASM to modify the classes t

Re: RFR: 8209937: Enhance java.io.Console - provide methods to query console width and height

Hi, This feels like a pretty slippery slope; not enough for real terminal emulation; what kind of terminal is it?, etc.  Not enough for jshell/nashorn, which imported a whole package to support command line editing.   (jline - module jdk.internal.le/ed) Regardless, keep it simple! There are

Re: JEP 330 class loader getResourceAsStream

Why not go ahead and implement getResource as well? It's not *that* big of a deal to add a URL handler, and it would be a fairly trivial one. On Fri, Aug 24, 2018 at 12:21 PM seth lytle wrote: > > JEP 330 (launch single-file source programs) uses a MemoryClassLoader. the > compiled bytecode is st

Re: [12] (AIX) 8207744: Clean up inconsistent use of opendir/closedir versus opendir64/closedir64

This one could still use a Reviewer approval or rejection. Thanks, Brian On Aug 14, 2018, at 1:34 PM, Brian Burkhalter wrote: > Hi Bernard, > > On Aug 14, 2018, at 4:13 AM, B. Blaser wrote: > >> Seems quite good to me, last notes: >> >> 1) dealing with 'stat/stat64' in 'UnixFileSystem_md.

Re: [12] (AIX) 8207744: Clean up inconsistent use of opendir/closedir versus opendir64/closedir64

Hi, Brian The change looks fine to me. From my search, I believe all usages have been covered. -Brent On 8/24/18 11:01 AM, Brian Burkhalter wrote: This one could still use a Reviewer approval or rejection. Thanks, Brian On Aug 14, 2018, at 1:34 PM, Brian Burkhalter wrote: Hi Bernard, O

Re: [12] (AIX) 8207744: Clean up inconsistent use of opendir/closedir versus opendir64/closedir64

Thanks, Brent! Brian On Aug 24, 2018, at 12:14 PM, Brent Christian wrote: > The change looks fine to me. > From my search, I believe all usages have been covered.