On 28/11/2018 22:49, Henry Jen wrote:
Since there is no header file in JDK provides the function prototypes, I don’t
think this is considered public(supported) APIs.
Anyway, in case a tools is build with launcher code, and shipped separately
from JDK, that would be impacted by this bug. So
On Thu, Nov 29, 2018 at 8:02 PM, Tagir Valeev wrote:
>
> I can file an issue and create a webrev, but I still need a sponsor
> and review for such change. Martin, can you help with this?
>
As usual, I'm only half paying attention, but I can be your shepherd.
You're optimizing hashCode to be
On Fri, Nov 30, 2018 at 12:20 PM Steve Groeger wrote:
>
> Hi Goetz,
>
> I disabled IPv6 on my xLinux box and the MulticastSocket tests pass, as
> they detected that IPv6 is not enabled and then didnt try and set the IPv6
> options.
Not being a network expert either, I think there's two things to
Looks good. Please add noreg-* keyword to the issue.
Naoto
On 11/29/18 10:14 PM, Nishit Jain wrote:
Hi,
Please review the fix for 8213294, which upgrades the IANA LSR data to
the latest available version.
Bug: https://bugs.openjdk.java.net/browse/JDK-8213294
Webrev:
Hi Nishit,
Some comments, a couple of possible bugs and several performance
related issues
could be deferred. Both formatting and parsing seem to be quite heavyweight
due to looping and combinatorics.
CompactNumberFormat.java
661, 727, 1507: Is there a reason to convert the divisor to a
> On Sep 18, 2018, at 11:52 AM, Jim Laskey wrote:
>
> Please review the code for String::detab and String::entab. Used to expand
> tabs into spaces, and spaces back to tabs.
>
> webrev: http://cr.openjdk.java.net/~jlaskey/8210717/webrev/index.html
> jbs:
On 11/30/18 11:54 AM, Roger Riggs wrote:
Hi Phil,
The patch looks fine.
Ok, thanks.
Where does it die? SystemProps should skip null values in putIfAbsent().
You are right it checks and that explains why I didn't see it when I tested.
I saw the NPE only after I noticed the code and it
Thanks for the review, Alan and Magnus.
Cheers,
Henry
> On Nov 30, 2018, at 7:20 AM, Alan Bateman wrote:
>
>
>
> On 28/11/2018 22:49, Henry Jen wrote:
>> Since there is no header file in JDK provides the function prototypes, I
>> don’t think this is considered public(supported) APIs.
>>
>>
I fully agree with Stephen.
Rémi
- Mail original -
> De: "Stephen Colebourne"
> À: "core-libs-dev"
> Envoyé: Vendredi 30 Novembre 2018 12:06:23
> Objet: Re: RFR - JDK-8203442 String::transform (Code Review)
> I see from Twitter (!!!) that this has been pushed. This appears to have
>
Loathe though I am to resurrect this thread, one problem arose after testing
with assertions enabled which I had neglected previously to do. A few small
changes to test/jdk/java/io/InputStream/Skip.java are required. A delta versus
webrev.08 (link at bottom) is at
Sorry, but its actually 8130264 that I meant
https://bugs.openjdk.java.net/browse/JDK-8130264
-phil.
On 11/30/18 11:54 AM, Mandy Chung wrote:
On 11/30/18 11:43 AM, Phil Race wrote:
Roger,
I just pushed 8130266 which had the CSR approved a couple of days ago
only
to find that it clashed
On 11/30/18 11:56 AM, Phil Race wrote:
Sorry, but its actually 8130264 that I meant
https://bugs.openjdk.java.net/browse/JDK-8130264
I see it now. System.c has been updated.
Your patch looks good.
Separately I think the SystemProps code ought to consider whether
it ought to error out
Hi Roger,
I updated the CSR according to your feedback. I'm a bit at a loss
about the specification though. How should I specify the behavior of
the API without describing the implementation?
Also, since this patch only extends an existing implementation to
Linux, I would have thought there are
Hi Thomas,
On 11/30/2018 02:06 PM, Thomas Stüfe wrote:
Hi Roger,
I updated the CSR according to your feedback. I'm a bit at a loss
about the specification though. How should I specify the behavior of
the API without describing the implementation?
What you wrote is fine. It does need to
Hi Phil,
That looks fine.
Too bad it introduces a new shell test, we're trying to get rid of them.
The other alternative would have the test program needed to set the
environment
and launch a java program.
Thanks, Roger
On 11/30/2018 05:56 PM, Phil Race wrote:
Bug :
On 11/30/18 8:52 AM, Martin Buchholz wrote:
On Thu, Nov 29, 2018 at 8:02 PM, Tagir Valeev wrote:
I can file an issue and create a webrev, but I still need a sponsor
and review for such change. Martin, can you help with this?
As usual, I'm only half paying attention, but I can be your
Bug : https://bugs.openjdk.java.net/browse/JDK-8212703
Webrev : http://cr.openjdk.java.net/~prr/8212703/
This removes the code in the launcher that sets the sun.java2d.fontpath
property
from the JAVA2D_FONTPATH environment variable.
We can still set the system property directly when using for
I think we should choose Tagir's version so you don't need my OCA.
сб, 1 дек. 2018 г. в 06:38, Stuart Marks :
>
>
> On 11/30/18 8:52 AM, Martin Buchholz wrote:
> > On Thu, Nov 29, 2018 at 8:02 PM, Tagir Valeev wrote:
> >
> >> I can file an issue and create a webrev, but I still need a sponsor
>
Hello,
The java.sql.DataTruncation Exception/warning has a few detail members,
especially the index of the field in question. Yet it will not be reflected in
getMessage/toString. I wonder if the message should be dynamic to at least
include the index (if known).
Hello.
Could you review the fix again ?
Bug:https://bugs.openjdk.java.net/browse/JDK-8212794
Change: https://cr.openjdk.java.net/~itakiguchi/8212794/webrev.02/
I just fixed only IBM964 for JDK-8212794.
(IBM29626C fix is not included)
On non AIX platform (Linux),
ibm-euctw alias is added
CSR for jdk12: https://bugs.openjdk.java.net/browse/JDK-8214511
..Thomas
On Fri, Nov 30, 2018 at 7:23 AM Thomas Stüfe wrote:
>
> Hi all,
>
> I updated the Release note, please have a look.
>
> Note that the linked style guide under [3] was not accessible to me
> outside Oracle. So I did my best
I see from Twitter (!!!) that this has been pushed. This appears to have
happened without this thread coming to a clear conclusion, particularly wrt
criticism of transform() as a suitable method name in the broader context.
I also do not think that the code review was completed correctly and in
Hi Goetz,
I disabled IPv6 on my xLinux box and the MulticastSocket tests pass, as
they detected that IPv6 is not enabled and then didnt try and set the IPv6
options.
I am currently unable to disable IPv6 on my AIX box to test this but would
assume it would also work as the code checks to see
Hi Thomas,
The updates to the release note look fine.
Usually they are brief, containing just enough information to quickly
recognize the function and feature that has changed.
The complete information can be found in the original Jira issue.
Sorry about the lack of an external release note
Thanks Florian, the "-isystem /usr/include" is helpful to my case, I see
gcc.gnu.org says that "it gets the same special treatment that is applied to
the standard system directories". As such the issue gets hidden (error
suppressed).
Hi David,
Thanks for your suggestion. My intention was to
Hi Steve,
I'm not that familiar with the network coding.
But if the VM thinks that IPv6 is enabled, but later
on something fails, shouldn't the check for IPv6
be improved?
Especially, if my and your box have been configured
the same, this is probably the default on aix boxes.
And I guess the
Roger,
I just pushed 8130266 which had the CSR approved a couple of days ago only
to find that it clashed badly with the change you made in 4947890 to reduce
the cost of system property initialisation.
It appears that the new code there is not happy if there is no value for the
system property.
On 11/30/18 11:43 AM, Phil Race wrote:
Roger,
I just pushed 8130266 which had the CSR approved a couple of days ago
only
to find that it clashed badly with the change you made in 4947890 to
reduce
the cost of system property initialisation.
It appears that the new code there is not happy
Hi Phil,
The patch looks fine.
Where does it die? SystemProps should skip null values in putIfAbsent().
Sorry for the turbulence.
Roger
On 11/30/2018 02:43 PM, Phil Race wrote:
Roger,
I just pushed 8130266 which had the CSR approved a couple of days ago
only
to find that it clashed
Hi Thomas,
Looks pretty good.
Usually 'we' avoid the first person writing in the jira.
It makes them more readable in the long term, when there is no context
for 'we'.
- Describing it as 'experimental' gives the wrong impression
and has some magnified implications as that term is being used
On 2018-11-28 23:49, Henry Jen wrote:
Since there is no header file in JDK provides the function prototypes, I don’t
think this is considered public(supported) APIs.
Anyway, in case a tools is build with launcher code, and shipped separately
from JDK, that would be impacted by this bug. So I
On 2018-11-30 10:49, Ichiroh Takiguchi wrote:
Hello.
Could you review the fix again ?
Bug:https://bugs.openjdk.java.net/browse/JDK-8212794
Change: https://cr.openjdk.java.net/~itakiguchi/8212794/webrev.02/
I think it looks good but please let someone from core-libs review it too.
32 matches
Mail list logo
