Actually, it's not a bug, it a tradition of English spacing.
It will not affect the resulting HTML, of course.
With kind regards,
Ivan
On 2/18/19 11:23 PM, Andrey Turbanov wrote:
+ * {@code RMISocketFactory.setFailureHandler}. If no failure
One redundant space before "If"
Andrey
Hi Arno,
Although I don't know if turning off or no swap is expected for a test
environment, but tried reproducing the issue locally on a 8Gb Ubuntu
linux VM with swap turned off, the test case was passing until I started
some other app (like browser) in parallel, in which case it failed with
Hi All,
Please review the backport of the following bug fixes to jdk8u-dev:
HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8206120"JDK-8206120 : Add
test cases for lenient Japanese era parsing
HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8211398"JDK-8211398 :
Square character
Hi Nishit,
thanks for testing!
Best regards,
Arno
>-Original Message-
>From: Nishit Jain
>Sent: Dienstag, 19. Februar 2019 10:05
>To: Zeller, Arno ; core-libs-dev d...@openjdk.java.net>
>Subject: Re: RFR(XS):JDK-8219228:
>java/util/Base64/TestEncodingDecodingLength.java failing on 8GB
Hi Naoto,
Why is the default region set to "US" if there is no region specified in
the locale? is this the default behavior of "first day of week" and
"minimal days in first week" when a region is missing or the default
behavior is that it returns "1"? Can't we just return "1" instead of
On 19/02/2019 14:25, Aleksey Shipilev wrote:
Hi Deepak,
Please follow the jdk-updates approval process:
https://openjdk.java.net/projects/jdk-updates/approval.html
You need to put appropriate tags at the issues, explain why they are needed,
how the changes apply
(if changes do not apply
Looks good to me (not a Reviewer however).
Best regards, Matthias
>
> Message: 2
> Date: Mon, 18 Feb 2019 15:35:20 +
> From: "Langer, Christoph"
> To: "Zeller, Arno" , Nishit Jain
> , Naoto Sato ,
> Roger
> Riggs
> Cc: core-libs-dev
> Subject: RE: RFR(XS):JDK-8219228:
>
Correcting typo for release.
From: Deepak Kejriwal
Sent: Tuesday, February 19, 2019 7:42 PM
To: 'core-libs-dev' ;
'jdk-updates-...@openjdk.java.net'
Subject: RFR: JDK11U JDK-8206120, JDK-8211398, JDK-8218915
Hi All,
Please review the backport of the following bug fixes to jdk11u-dev:
Looks good to me Ivan!
Thanks for updating the file with {@code }.
best regards,
-- daniel
On 19/02/2019 06:51, Ivan Gerasimov wrote:
I took opportunity to update the copyright year and replace tags
...<\code> with {@code ...}, so that this code can be left
untouched for next 21 years :)
Hi All,
Please review the backport of the following bug fixes to jdk8u-dev:
HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8202088"JDK-8202088:
Japanese new era implementation.
HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8207152"JDK-8207152:
Placeholder for Japanese new era should
JDK-8217798: modular jar linking in jpackage
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1] https://bugs.openjdk.java.net/browse/JDK-8217798
[2] http://cr.openjdk.java.net/~herrick/8217798/
This is a very nice patch, complete with spec and tests, and evidence of
OCA.
But, before we talk about patches and code, let's step back and talk
about stewardship. With API proposals, we like to start with problems,
rather than solutions: what problems we are concerned with, and are
these
Hi,
I have been looking at how to implement this in Java using
StackWalker and ASM.
Either I oversee something or there is a row of deficiencies with
these tools to solve my issue.
StackWalker allows me to collect class name, method name, method
description and BCI. Given the current
On 18/02/2019 11:15, Andrew Dinn wrote:
:
Alan, I'll wait for your follow-up note before responding regarding the
arguments to force. I'll just note that the latest JEP draft accepts
start position and length [i.e. force(from, length)] rather than start
position and end position [i.e.
Looks fine to me.
some minor comments on formatting :
space after "//" style comments in your new tests :
e.g
//List of new code points are not present in Unicode 6.2.
39 add(0x20BB); //NORDIC MARK SIGN
40
Please can I request a sponsor for this fix to ReflectionFactory where
langReflectAccess is not always correctly initialized.
Webrev: http://cr.openjdk.java.net/~aleonard/8219378/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8219378
Thanks
Andrew
Andrew Leonard
Java Runtimes
Hi Deepak,
Here are my comments to the webrev (other than what Sean pointed out):
TestIsJavaIdentifierMethods.java
- @summary: "testIsJavaLetter" -> "isJavaLetter",
"testIsJavaLetterOrDigit" -> "isJavaLetterOrDigit".
- Line 34: "newCodePoint" does not represent the era character, as "new"
Looks fine, Reviewed.
On 02/19/2019 04:05 AM, Nishit Jain wrote:
Hi Arno,
Although I don't know if turning off or no swap is expected for a test
environment, but tried reproducing the issue locally on a 8Gb Ubuntu
linux VM with swap turned off, the test case was passing until I
started
Deepak,
changes look fine to me. Some minor comments on formatting :
make a space after all "//" comments
e.g.
+ //isJavaIdentifierStart strictly conforms to code points assigned
+ //in Unicode 10.0. Since code point {32FF} is not from Unicode
10.0,
+ //return false.
Hi Alexander,
Some files appear to be moved with hg, but others are copied and deleted.
Please use hg mv to retain the continuity of the history.
Thanks, Roger
On 02/15/2019 10:03 PM, Alexander Matveev wrote:
Hi Magnus,
http://cr.openjdk.java.net/~almatvee/8212091/webrev.01/
Moved all
Hi Roger,
Some deleted files are actually deleted files, since I did code cleanup
as well.
Added files contain code from splitting original source files. This was
needed to re-arrange code.
Not sure how to log with hg file split.
Also, we already moved files without keeping history, since we
On 2/19/19 8:08 AM, Lindenmaier, Goetz wrote:
Hi,
I have been looking at how to implement this in Java using
StackWalker and ASM.
Either I oversee something or there is a row of deficiencies with
these tools to solve my issue.
StackWalker allows me to collect class name, method name, method
+1
Naoto
On 2/19/19 7:10 AM, Roger Riggs wrote:
Looks fine, Reviewed.
On 02/19/2019 04:05 AM, Nishit Jain wrote:
Hi Arno,
Although I don't know if turning off or no swap is expected for a test
environment, but tried reproducing the issue locally on a 8Gb Ubuntu
linux VM with swap turned
Hi Andy,
Looks good.
Thanks,
Alexander
On 2/19/2019 7:59 AM, Andy Herrick wrote:
JDK-8217798: modular jar linking in jpackage
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1]
Hi Deepak,
Please follow the jdk-updates approval process:
https://openjdk.java.net/projects/jdk-updates/approval.html
You need to put appropriate tags at the issues, explain why they are needed,
how the changes apply
(if changes do not apply cleanly, ask for RFR -- is this what this thread
>+ * {@code RMISocketFactory.setFailureHandler}. If no failure
One redundant space before "If"
Andrey Turbanov
Hi Alan,
Thanks for following this up.
On 19/02/2019 16:55, Alan Bateman wrote:
> The issues with the 2-arg force method that I think need discussion are:
>
> 1. long from/to vs. from/length vs int index/length. Elements in
> buffers, or the starting index of a region, are addressed by an int
Hi Deepak,
Almost all the comments for the 11u changes [1] applies here, except the
"newCodePoint" comment. For this one, I'd suggest renaming
"newCodePoints" to "UNASSIGNED_CODEPOINTS_IN_6_2"
Naoto
[1]
https://mail.openjdk.java.net/pipermail/core-libs-dev/2019-February/058610.html
On
Hi Nishit,
The reason is that "US" is the only required locale in the JDK (cf.
Locale.getAvailableLocales(). In fact, initially I supplied "001" with
it, as it means the "world" in CLDR, but it broke some existing tests.
"001" returns "MONDAY" as the first day of week, whereas "SUNDAY" in US.
Looks fine to me, too. Are you going to add any tests for this case?
-- Kevin
On 2/19/2019 12:11 PM, Alexander Matveev wrote:
Hi Andy,
Looks good.
Thanks,
Alexander
On 2/19/2019 7:59 AM, Andy Herrick wrote:
JDK-8217798: modular jar linking in jpackage
Please review the jpackage fix for
30 matches
Mail list logo
