Milan,
I'm observing the latest version (.04) of this test failing quite frequently
(4/100) on Windows (Windows Server 2012 R2 6.3 (amd64)) machines. The test
passes fine on macOS and Linux. Here's the typical output I see in the logs:
java.lang.RuntimeException: Query took 4997 ms. .
Hi Goetz,
A bit of wordsmithing on the javadoc of NullPointerException.getMessage
and separating out the implementation specific description to an @implNote
75:
/**
* Returns the detail message string of this throwable.
*
* If a non-null message was supplied in a constructor
Hi,
Updated to wrap long lines and remove unneeded @SuppressWarnings.
http://cr.openjdk.java.net/~rriggs/webrev-warn-serializable-8231314-2/
On 9/23/19 4:44 AM, Peter Levart wrote:
Once more, for the list (sorry)...
Hi,
On 9/21/19 12:31 PM, Chris Hegarty wrote:
Roger,
On 20 Sep 2019, at
- Mail original -
> De: "Goetz Lindenmaier"
> À: "Remi Forax"
> Cc: "hotspot-runtime-dev" ,
> "core-libs-dev"
> Envoyé: Lundi 23 Septembre 2019 12:03:30
> Objet: RE: RFR (L, final): 8218626: Add detailed message to
> NullPointerException describing what is null.
> Hi Remi,
Hi Goetz,
Hi Joe,
I've been thinking of this example:
83 final class Ser implements Externalizable {
84
...
99 /** The object being serialized. */
100 @SuppressWarnings("serial") // Not statically typed as
Serializable
101 private Object object;
Externalizable does extend
Hi Remi,
what do you think about dealing with the problem like this:
http://cr.openjdk.java.net/~goetz/wr19/8218628-exMsg-NPE/18-obfuscation/
It's at the cost of one 64-bit field per bytecode in the analysis data.
Also, if there is a real assignment to a parameter it's not named 'parameteri'
Hi Brent,
On 19/09/2019 20:08, Brent Christian wrote:
Well-spotted.
JMH defaults to using 1 worker thread, but can be configured to use
more. I tried with '-t max' (8 threads on my machine), and the
benchmark NPE'd, as you predicted.
I've updated the benchmark to use a separate handler
Hi Brent,
I was able to generate a webrev without any missing sdiffs (using gawk
instead of awk with webrev.ksh) and made the requested changes below.
src/java.base/share/classes/java/util/ResourceBundle.java
I believe the tag spanning L2801-2 can be changed:
2801 * Special
Looks good. -B
On 9/23/19 11:17 AM, Julia Boes wrote:
Hi Brent,
I was able to generate a webrev without any missing sdiffs (using gawk
instead of awk with webrev.ksh) and made the requested changes below.
src/java.base/share/classes/java/util/ResourceBundle.java
I believe the tag
We now have a fix-up integration that removes all the previously excluded
tests from their exclude lists.
https://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/overview.html
8231031: runtime/ReservedStack/ReservedStackTest.java fails after jsr166
refresh
Hi Julia,
I made a quick pass and the changes seem OK
> On Sep 23, 2019, at 2:17 PM, Julia Boes wrote:
>
> Hi Brent,
>
> I was able to generate a webrev without any missing sdiffs (using gawk
> instead of awk with webrev.ksh) and made the requested changes below.
>
>>>
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8230531
Relevant CSR (in draft) and proposed changeset are located at:
[CSR]: https://bugs.openjdk.java.net/browse/JDK-8231319
[changeset]: https://cr.openjdk.java.net/~naoto/8230531/webrev.00/
The
On 9/23/2019 6:05 PM, Alexander Matveev wrote:
Hi Alexey,
http://cr.openjdk.java.net/~asemenyuk/8231279/webrev.01/src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxDebBundler.java.frames.html
Maybe add new line between 41-42 and remove 43 to align import static
with other static
Hi Alexey,
http://cr.openjdk.java.net/~asemenyuk/8231279/webrev.01/src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxDebBundler.java.frames.html
Maybe add new line between 41-42 and remove 43 to align import static
with other static imports.
Looks fine.
Thanks,
Alexander
On
On 9/23/19 2:15 AM, Daniel Fuchs wrote:
>> ...
since logging is no longer using Throwable to examine
the call stack, maybe it makes more sense to move the logging
benchmarks to their own file under:
test/micro/org/openjdk/bench/java/util/logging/ >
Well, I'll let you decide on that. That
On 9/19/19 12:08 PM, Brent Christian wrote:
Hi, Daniel
http://cr.openjdk.java.net/~bchristi/8221623/webrev09-loggerPerThread/
I think doing the measurement for one of these would be adequate.
StackWalkBench.forEach_AllOpts
StackWalkBench.forEach_DefaultOpts
LGTM
On Mon, Sep 23, 2019 at 1:48 PM wrote:
> Hello,
>
> Please review the fix to the following issue:
>
> https://bugs.openjdk.java.net/browse/JDK-8230531
>
> Relevant CSR (in draft) and proposed changeset are located at:
>
> [CSR]: https://bugs.openjdk.java.net/browse/JDK-8231319
>
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
This fix:
- remove --linux-deb-copyright option.
- add tests to verify that placing copyright template in custom resource
dir provides the same
Looks good.
On 9/23/2019 4:55 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
This fix:
- remove --linux-deb-copyright option.
- add tests to verify that placing
Hi Martin,
That all seems fine to me.
Thanks,
David
On 24/09/2019 3:43 am, Martin Buchholz wrote:
We now have a fix-up integration that removes all the previously
excluded tests from their exclude lists.
https://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/overview.html
Thanks for the review !
Alan, may I add you as reviewer too ?
Best regards, Matthias
> -Original Message-
> From: David Holmes
> Sent: Freitag, 20. September 2019 11:41
> To: Baesken, Matthias ; 'hotspot-
> d...@openjdk.java.net' ; core-libs-
> d...@openjdk.java.net
> Cc: Alan Bateman
Once more, for the list (sorry)...
Hi,
On 9/21/19 12:31 PM, Chris Hegarty wrote:
Roger,
On 20 Sep 2019, at 19:51, Roger Riggs wrote:
Please review code cleanup that will remove the need to suppress soon
to be introduced
warnings [1] about static typing of serialization related fields.
A
Got it. Thanks Pavel!
On Mon, 23 Sep 2019 at 13:37, Pavel Rappo wrote:
>
> Milan,
>
> How do you check which tests are run? That's what I see in the
> /test-support/jtreg_open_test_jdk_com_sun_jndi_dns_ConfigTests_TcpTimeout_java/com/sun/jndi/dns/ConfigTests/TcpTimeout.jtr
> file after I have
Hi Peter,
Good observation. Adding transient would negate on of the conditions for
warning, so no warning.
And there would be no need to look at the static types more closely.
If the Ser proxy were for a non-serializable type that would be a good
option.
I think there's a different problem
looks good.
/Andy
On 9/23/2019 7:49 AM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
Baseline for the fix is [3] patch.
[1]
On 23/09/2019 08:06, Baesken, Matthias wrote:
Thanks for the review !
Alan, may I add you as reviewer too ?
Yes, okay with me too.
-Alan
Milan,
How do you check which tests are run? That's what I see in the
/test-support/jtreg_open_test_jdk_com_sun_jndi_dns_ConfigTests_TcpTimeout_java/com/sun/jndi/dns/ConfigTests/TcpTimeout.jtr
file after I have run the test locally on my machine:
--messages:(5/233)--
command:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
Baseline for the fix is [3] patch.
[1] https://bugs.openjdk.java.net/browse/JDK-8231279
[2] http://cr.openjdk.java.net/~asemenyuk/8231279/webrev.01/
This looks good far as I can tell.
/Andy
On 9/18/2019 11:23 AM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
This fix:
- Move common deb and rpm packaging code in the
Looks good.
/Andy
On 9/20/2019 5:54 PM, Alexander Matveev wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Version from main module (if exist) will be used as --app-version if
30 matches
Mail list logo
