Re: [15] RFR: 8202117: com/sun/jndi/ldap/RemoveNamingListenerTest.java fails intermittently: Connection reset

Hi Chris, Thanks for taking care of this issue, changes looks OK to me. I am happy to see that we are removing the lot's of duplicate "DummyServer" from individual test cases and using the "BaseLdapServer" test-server instead. Thanks, Vyom On Fri, Mar 13, 2020 at 1:59 PM Chris Yin wrote: >

Re: [15] RFR: 8202117: com/sun/jndi/ldap/RemoveNamingListenerTest.java fails intermittently: Connection reset

Hi Chris, This looks fine to me too. Thanks for taking care of this issue. A potential issue I see is that the test might fail if "localhost" does not resolve to the loopback address - but you would likely get a "Connection refused" in that case. One possibility to get that out of the way

[15] RFR: 8202117: com/sun/jndi/ldap/RemoveNamingListenerTest.java fails intermittently: Connection reset

Hello, Please review following changes to try to fix intermittent failure of test com/sun/jndi/ldap/RemoveNamingListenerTest.java, thanks Bug: https://bugs.openjdk.java.net/browse/JDK-8202117 Webrev: http://cr.openjdk.java.net/~xyin/8202117/webrev.00/ According to failure logs, test already

Re: RFR: [small, docs] JDK-8240971 Fix CSS styles in some doc comments

This is really nice. Incidentally, it also makes https://bugs.openjdk.java.net/browse/JDK-8234395 less relevant. -Pavel > On 12 Mar 2020, at 20:50, Jonathan Gibbons > wrote: > > Please review a simple fix regarding the non-standard use of some CSS in some > doc comments. > > From the

Re: RFR [15/java.xml] 8240982 Incorrect copyright header in BCEL 6.4.1 sources

+1 > On Mar 13, 2020, at 1:32 PM, Joe Wang wrote: > > Please review a quick fix for the missing commas after the 2nd year in the > copyright header: > > diff --git > a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/Const.java >

Re: [15] 8235792: LineNumberReader.getLineNumber() behavior is inconsistent with respect to EOF

An updated webrev is at [1] and a CSR has been filed [2]. Thanks, Brian [1] http://cr.openjdk.java.net/~bpb/8235792/webrev.01/ [2] https://bugs.openjdk.java.net/browse/JDK-8241020 > On Mar 6, 2020, at 11:13 AM, Brian Burkhalter > wrote: > > Thanks, Roger. I’ll let it hang until next week

Re: RFR [15/java.xml] 8240982 Incorrect copyright header in BCEL 6.4.1 sources

Looks good, Joe. Naoto On 3/13/20 10:32 AM, Joe Wang wrote: Please review a quick fix for the missing commas after the 2nd year in the copyright header: diff --git a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/Const.java

Re: RFR: 8238665: Add JFR event for direct memory statistics

Good suggestion, moved. Webrev: http://cr.openjdk.java.net/~ddong/8238665/webrev.03/ Thanks, Denghui Dong -- From:Alan Bateman Send Time:2020年3月12日(星期四) 00:36 To:董登辉(卓昂) ; Erik Gahlin Cc:hotspot-jfr-dev ; core-libs-dev

RFR [15] 8241014: Miscellaneous typos in documentation comments

Hello, Please review the change for https://bugs.openjdk.java.net/browse/JDK-8241014: http://cr.openjdk.java.net/~prappo/8241014/webrev.00/ This is a documentation cleanup. There are no code changes involved, and the changes in documentation are mostly trivial. The following packages are

Re: RFR: [small, docs] JDK-8240971 Fix CSS styles in some doc comments

At some point, we should separate JDK-specific definitions from javadoc-general definitions, using a separate stylesheet. -- Jon On 3/13/20 9:26 AM, Pavel Rappo wrote: This is really nice. Incidentally, it also makes https://bugs.openjdk.java.net/browse/JDK-8234395 less relevant. -Pavel

RFR [15/java.xml] 8240982 Incorrect copyright header in BCEL 6.4.1 sources

Please review a quick fix for the missing commas after the 2nd year in the copyright header: diff --git a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/Const.java b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/Const.java ---

[15] RFR: 8240626: Some of the java.time.chrono.Eras return empty display name for some styles and locales

Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8240626 The proposed chageset is located at: https://cr.openjdk.java.net/~naoto/8240626/webrev.00/ In some locales, CLDR only provides partial translations of era names, e.g., only HEISEI and REIWA

Re: RFR [15] 8241014: Miscellaneous typos in documentation comments

Looks fine. On 3/13/20 11:42 AM, Pavel Rappo wrote: Hello, Please review the change for https://bugs.openjdk.java.net/browse/JDK-8241014: http://cr.openjdk.java.net/~prappo/8241014/webrev.00/ This is a documentation cleanup. There are no code changes involved, and the changes in

Review Request JDK-8240975: Extend NativeLibraries to support explicit unloading

Webrev: http://cr.openjdk.java.net/~mchung/jdk15/webrevs/8240975/webrev.00/ This is a follow-up task for Panama to allow explicit unloading of native library after JDK-8228336.  `NativeLibraries` associated with a class loader has the capability to auto unload native libraries when the class

Re: RFR [15/java.xml] 8240982 Incorrect copyright header in BCEL 6.4.1 sources

Thanks Naoto, Lance! -Joe On 3/13/20 10:42 AM, Lance Andersen wrote: +1 On Mar 13, 2020, at 1:32 PM, Joe Wang > wrote: Please review a quick fix for the missing commas after the 2nd year in the copyright header: diff --git

Re: [15] RFR: 8240626: Some of the java.time.chrono.Eras return empty display name for some styles and locales

Hi Joe, Thank you for the review. Since those names are filled at the JDK build time, there is no way to confirm the localized ones are from the locale itself or its parents, unless parsing CLDR's source XML files in the test at the runtime. I think it is enough to just ensure there's no

RFC: 8132359: JarURLConnection.getJarFile() resource leak when file is not found

Hi, Based on these maillist threads: https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-March/065076.html https://mail.openjdk.java.net/pipermail/core-libs-dev/2019-November/063643.html I am looking for comments and suggestions, whether the following change to

Re: [15] RFR: 8240626: Some of the java.time.chrono.Eras return empty display name for some styles and locales

Hi Naoto, The existing tests verifies that a display name matches an expected value. I wonder if you'd want to do a bit more than the Boolean assertion with a similar approach as the existing test, that is, check that the fallback values/alias names match expected names. Best, Joe On

Re: [15] RFR: 8240626: Some of the java.time.chrono.Eras return empty display name for some styles and locales

Hi Naoto, I see. That makes sense. The change looks good to me. Best, Joe On 3/13/20 7:16 PM, naoto.s...@oracle.com wrote: Hi Joe, Thank you for the review. Since those names are filled at the JDK build time, there is no way to confirm the localized ones are from the locale itself or its