Re: RFR: 8188055: (ref) Add Reference.refersTo predicate

2020-04-13 Thread Kim Barrett
> On Apr 9, 2020, at 11:31 AM, Paul Sandoz wrote: > > Reference.java > — > > 335 * > 336 * @return The object to which this reference refers, or > 337 * {@code null} if this reference object has been cleared > > Add @see refersTo > > 338 */ > 339 @HotSpotInt

Re: Need sponsor to fix Javadoc warnings

2020-04-13 Thread Weijun Wang
The additional patch looks fine to me. Thanks, Max > On Apr 12, 2020, at 3:23 AM, Vipin Sharma wrote: > > Hi Pavel, > >> On Apr 9, 2020, at 2:45 AM, Pavel Rappo wrote: >> >> If your new patch addresses a similar type of problem, please send it in >> reply to this email, >> so that I could m

RFR: JDK-8241627: Updating ASM to 8.0 for JDK 15

2020-04-13 Thread Vicente Romero
Hi all, Please review this patch that updates the ASM version to appear in JDK15 (from 7.0 to 8.0). Version 8.0 is compatible with JDK14 plus it has several experimental APIs to cover records and sealed types. We have also updated a number of tests (mostly record oriented tests) to use the up

Re: JarFile.getVersionedEntry scalability with new release cadence

2020-04-13 Thread Eirik Bjørsnøs
I noticed that in JarFile.getEntry(name) , the first call to getEntry0(name) call is thrown away for cases where getVersionedEntry actually finds a versioned entry. public ZipEntry getEntry(String name) { JarFileEntry je = getEntry0(name); if (isMultiRelease()) { re

Re: 6202130: Need to handle UTF-8 values and break up lines longer than 72 bytes

2020-04-13 Thread Philipp Kunz
Hi Naoto, You are absolutely right to raise the question. I've also thought about this but haven't come up so far with a compellingly elegant solution, at least not yet. If only String.isLatin1 was public that would come in very handy. Character or anything else I looked at cannot tell if a string

Improving ZipFile.getEntry performance using Bloom filters

2020-04-13 Thread Eirik Bjørsnøs
Hi, While working on improvements to JarFile.getVersionedEntry, it occurred to me that the missing lookups we are removing there may be just one example of a more general issue. To get a better understanding of how ZipFile.getEntry is used, I added some PerfCounters for the number of hits and mis

Re: Improving ZipFile.getEntry performance using Bloom filters

2020-04-13 Thread Eirik Bjørsnøs
On Mon, Apr 13, 2020 at 9:26 PM Eirik Bjørsnøs wrote: This translates to a Petclinic startup improvement of 91 ms or 1.4 percent > (assuming single-threaded class loading here). > > I expect that this can be improved further with a more clever use of hash > functions. Specifically it would be gre