> 8253426: jpackage is unable to generate working EXE for add-launcher
> configurations.
> secondary launchers ignored module, main-jar, and main-class in launcher
> properties file because the LAUNCHER_DATA
> param was not removed from the set of params for each new add-module.
> testcase
On Thu, 24 Sep 2020 17:30:52 GMT, Lance Andersen wrote:
> Overall the changes look OK. in the java.sql set of classes, please updated
> the modified statements to also use {@code}
Hi @LanceAndersen, it was suggested by @RogerRiggs also. I have created a
separate bug JDK-8253612 to fix this
Hi Chris, Monica,
On 25/09/2020 1:47 am, Chris Plummer wrote:
As for the copyright in the new SA files, I believe it is incorrect and needs
to include Oracle. There are a number of
other non-SA files that are new and also have the same copyright issue.
If a file was created completely from
On Thu, 24 Sep 2020 23:39:51 GMT, Alexander Matveev
wrote:
>> Actually it will not work. I am running appImageCmd command before test
>> executes to generate app image. If I add it to
>> packageTest, jpackage will fail when trying to run command with app-image
>> and launchers.
>
> I will
On Tue, 22 Sep 2020 13:39:38 GMT, Aleksei Efimov wrote:
>> test/jdk/com/sun/jndi/ldap/DeadSSLLdapTimeoutTest.java line 171:
>>
>>> 169: System.err.println("Server socket. Failure to accept
>>> connection:");
>>> 170: e.printStackTrace();
>>> 171: }
>>
>> I
> https://bugs.openjdk.java.net/browse/JDK-8231591
>
> - Added MultiLauncherTwoPhaseTest which uses predefine app image with
> multiple launcher and tests to make sure installer
> will create shortcuts for all launchers.
> - Fixed Linux DesktopIntegration to create shortcuts for additional
On Thu, 24 Sep 2020 15:45:22 GMT, Vicente Romero wrote:
>> The classfile parser changes look good to me.
>
> I have modified the `@since`: 14 -> 16
[CSR: Record Classes](https://bugs.openjdk.java.net/browse/JDK-8253605)
-
PR: https://git.openjdk.java.net/jdk/pull/290
On Fri, 25 Sep 2020 01:08:52 GMT, Alexander Matveev
wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8231591
>>
>> - Added MultiLauncherTwoPhaseTest which uses predefine app image with
>> multiple launcher and tests to make sure installer
>> will create shortcuts for all launchers.
>> -
On 24/09/2020 09:59, Kim Barrett wrote:
If possible, my preference would be to avoid the pragma cruft and write the
code in such a way that gcc8/9 without asan doesn't warn, and gcc10 doesn't
warn with or without asan. I've kind of lost track in the discussion of all
the variants whether that's
On Thu, 24 Sep 2020 09:48:55 GMT, Thomas Schatzl wrote:
>> JDK-8246697 added -Xmx4g to test configurations. 32-bit VMs cannot do it.
>> @requires tests the OS RAM size, but you can
>> easily have the x86_32 host with more than 4G ram, yet JVM would fail to
>> acquire that heap size. Need to
On Thu, 24 Sep 2020 08:35:24 GMT, Aleksey Shipilev wrote:
> JDK-8246697 added -Xmx4g to test configurations. 32-bit VMs cannot do it.
> @requires tests the OS RAM size, but you can
> easily have the x86_32 host with more than 4G ram, yet JVM would fail to
> acquire that heap size. Need to
On Thu, 24 Sep 2020 10:02:13 GMT, Aleksey Shipilev wrote:
>> Lgtm.
>
> Trivial, right?
Trivial.
-
PR: https://git.openjdk.java.net/jdk/pull/331
> Continuing this review as a PR on github with the comments below
> incorporated. I expect there will be a few more
> iterations before integrating.
> On 06/09/2020 19:47, Alan Bateman wrote:
>> On 26/08/2020 15:24, Michael McMahon wrote:
>>>
>>> As I mentioned the other day, I wasn't able to
On Wed, 23 Sep 2020 17:41:49 GMT, Ian Graves wrote:
>> I'll shrink narrow those descriptions down to 80 characters.
>>
>> As to the abstract class, I think it'd make sense to have that implement
>> getUsage, getName, and getDescription --
>> essentially combine all of those very similar things
On Thu, 24 Sep 2020 08:35:24 GMT, Aleksey Shipilev wrote:
> JDK-8246697 added -Xmx4g to test configurations. 32-bit VMs cannot do it.
> @requires tests the OS RAM size, but you can
> easily have the x86_32 host with more than 4G ram, yet JVM would fail to
> acquire that heap size. Need to
On Thu, 24 Sep 2020 08:35:24 GMT, Aleksey Shipilev wrote:
> JDK-8246697 added -Xmx4g to test configurations. 32-bit VMs cannot do it.
> @requires tests the OS RAM size, but you can
> easily have the x86_32 host with more than 4G ram, yet JVM would fail to
> acquire that heap size. Need to
Hello Brent,
Thank you for sponsoring this change.
In the meantime, I triggered the pre-submit GitHub action job to run the
"tier1" tests for a duplicate branch of this PR. That completed
successfully https://github.com/jaikiran/jdk/actions/runs/269960940.
I'll wait for the reviews, before
JDK-8246697 added -Xmx4g to test configurations. 32-bit VMs cannot do it.
@requires tests the OS RAM size, but you can
easily have the x86_32 host with more than 4G ram, yet JVM would fail to
acquire that heap size. Need to check for
bitness explicitly.
Testing:
- [x] java/util/StringJoiner
> On Sep 23, 2020, at 2:10 AM, Eric Liu wrote:
>
> Hi Kim,
>
> Sorry for the delay.
>
> This patch removes a redundant string copy in NetworkInterface.c to avoid
> string-truncation
> warning. Other warnings we talked before, which are unable to completely fix
> in different version
> of
On Wed, 23 Sep 2020 23:05:06 GMT, Alexander Matveev
wrote:
>> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/PackageTest.java line 320:
>>
>>> 318: }
>>> 319:
>>> 320: public PackageTest addLauncherName(String name) {
>>
>> There is no need to make this function public and
> Hi,
>
> this is the continuation of the review of the implementation for:
>
> https://bugs.openjdk.java.net/browse/JDK-8227745
> https://bugs.openjdk.java.net/browse/JDK-8233915
>
> It allows for JIT optimizations based on escape analysis even if JVMTI agents
> acquire capabilities to access
On Mon, 14 Sep 2020 05:02:42 GMT, David Holmes wrote:
>> Richard Reingruber has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Changes based on dholmes' feedback.
>>
>> EscapeBarrier::sync_and_suspend_all():
>>
>> - Set suspend
8253379: [windows] Several jpackage tests failed with error code 1638
two windows specific test fixes in WindowsHelper:
1.) do not test that the parent directory of a windows menu shortcut is empty
after shortcut is uninstalled (there may
be other shortcuts using that directory) 2.) do not
On Mon, 14 Sep 2020 05:08:39 GMT, David Holmes wrote:
>> Richard Reingruber has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Changes based on dholmes' feedback.
>>
>> EscapeBarrier::sync_and_suspend_all():
>>
>> - Set suspend
> Continuing this review as a PR on github with the comments below
> incorporated. I expect there will be a few more
> iterations before integrating.
> On 06/09/2020 19:47, Alan Bateman wrote:
>> On 26/08/2020 15:24, Michael McMahon wrote:
>>>
>>> As I mentioned the other day, I wasn't able to
On Wed, 23 Sep 2020 03:34:29 GMT, Vicente Romero wrote:
>> Co-authored-by: Vicente Romero
>> Co-authored-by: Harold Seigel
>> Co-authored-by: Jonathan Gibbons
>> Co-authored-by: Brian Goetz
>> Co-authored-by: Maurizio Cimadamore
>> Co-authored-by: Joe Darcy
>> Co-authored-by: Chris Hegarty
On Wed, 23 Sep 2020 15:06:55 GMT, Jaikiran Pai wrote:
> Can I please get a review and a sponsor for a fix for
> https://bugs.openjdk.java.net/browse/JDK-8242882?
>
> As noted in that JBS issue, if the size of the Manifest entry in the jar
> happens to be very large (such that it exceeds
> the
On Thu, 24 Sep 2020 20:25:27 GMT, Andy Herrick wrote:
> 8253426: jpackage is unable to generate working EXE for add-launcher
> configurations.
> secondary launchers ignored module, main-jar, and main-class in launcher
> properties file because the LAUNCHER_DATA
> param was not removed from
On Tue, 22 Sep 2020 02:45:36 GMT, CoreyAshford
wrote:
> This patch set encompasses the following commits:
>
> - Adds a new HotSpot intrinsic candidate to the java.lang.Base64 class -
> decodeBlock(), and provides a flexible API for
> the intrinsic. The API is similar to the existing
This patch set encompasses the following commits:
- Adds a new HotSpot intrinsic candidate to the java.lang.Base64 class -
decodeBlock(), and provides a flexible API for
the intrinsic. The API is similar to the existing encodeBlock intrinsic.
- Adds the code in HotSpot to check and martial
On Thu, 24 Sep 2020 22:05:34 GMT, Alexander Matveev
wrote:
>> 8253379: [windows] Several jpackage tests failed with error code 1638
>> two windows specific test fixes in WindowsHelper:
>> 1.) do not test that the parent directory of a windows menu shortcut is
>> empty after shortcut is
On Thu, 24 Sep 2020 13:50:07 GMT, Alexey Semenyuk wrote:
>> But test calls AdditionalLauncher.applyTo(JPackageCommand cmd), which does
>> not have reference to PackageTest. Do you
>> know why we need two applyTo()?
>
> Just change the test code to call AdditionalLauncher.applyTo(PackageTest):
>
> Co-authored-by: Vicente Romero
> Co-authored-by: Harold Seigel
> Co-authored-by: Jonathan Gibbons
> Co-authored-by: Brian Goetz
> Co-authored-by: Maurizio Cimadamore
> Co-authored-by: Joe Darcy
> Co-authored-by: Chris Hegarty
> Co-authored-by: Jan Lahoda
Vicente Romero has updated the
8253426: jpackage is unable to generate working EXE for add-launcher
configurations.
secondary launchers ignored module, main-jar, and main-class in launcher
properties file because the LAUNCHER_DATA
param was not removed from the set of params for each new add-module. testcase
added in
On Thu, 24 Sep 2020 15:43:10 GMT, Chris Plummer wrote:
>> Monica Beckwith has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev
>> excludes the unrelated changes brought in by the merge/rebase. The pull
>> request contains 17 additional
On Thu, 24 Sep 2020 14:14:54 GMT, Andy Herrick wrote:
> 8253379: [windows] Several jpackage tests failed with error code 1638
> two windows specific test fixes in WindowsHelper:
> 1.) do not test that the parent directory of a windows menu shortcut is empty
> after shortcut is uninstalled
On Thu, 24 Sep 2020 23:35:15 GMT, Alexander Matveev
wrote:
>> Just change the test code to call AdditionalLauncher.applyTo(PackageTest):
>> `launcher1.applyTo(packageTest);
>> launcher2.applyTo(packageTest)`
>>
>> AdditionalLauncher.applyTo(JPackageCommand) is for non-packaging tests.
>
>
> Hi,
>
> Please help to review
> [JDK-8251188](https://bugs.openjdk.java.net/browse/JDK-8251188) fix which
> helps to improve LDAP
> tests stability. The list of changes: 1. Usages of wildcard address have been
> replaced with loopback address. This
> change includes addition of
On Thu, 24 Sep 2020 18:20:15 GMT, Vipin Sharma wrote:
> > Overall the changes look OK. in the java.sql set of classes, please updated
> > the modified statements to also use {@code}
>
> Hi @LanceAndersen, it was suggested by @RogerRiggs also. I have created a
> separate bug JDK-8253612 to fix
On Wed, 23 Sep 2020 17:26:44 GMT, Ian Graves wrote:
>> These changes update the jlink plugin command line documentation to tidy
>> them up into a more canonical form.
>>
>> The output generated by jlink from this change appears as follows:
>>
>>> build/macosx-x64/images/jdk/bin/jlink
> This is a continuation of
> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>
> Changes since then:
> * We've improved the write barrier as suggested by Andrew [1]
> * The define-guards around R18 have been changed to `R18_RESERVED`. This will
> be enabled
On Wed, 9 Sep 2020 07:38:38 GMT, Raffaello Giulietti
wrote:
>> Since this patch does not involve adding the intrinsic, maybe drop "(Needs
>> to be intrinsic)" from the synopsis?
>
> @shipilev I agree, but that's the title chosen by the reporter of the JBS
> issue. Not sure I can edit it
On Thu, 24 Sep 2020 14:04:22 GMT, Monica Beckwith wrote:
>> This is a continuation of
>> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>>
>> Changes since then:
>> * We've improved the write barrier as suggested by Andrew [1]
>> * The define-guards around
> Co-authored-by: Vicente Romero
> Co-authored-by: Harold Seigel
> Co-authored-by: Jonathan Gibbons
> Co-authored-by: Brian Goetz
> Co-authored-by: Maurizio Cimadamore
> Co-authored-by: Joe Darcy
> Co-authored-by: Chris Hegarty
> Co-authored-by: Jan Lahoda
Vicente Romero has updated the
> Co-authored-by: Vicente Romero
> Co-authored-by: Harold Seigel
> Co-authored-by: Jonathan Gibbons
> Co-authored-by: Brian Goetz
> Co-authored-by: Maurizio Cimadamore
> Co-authored-by: Joe Darcy
> Co-authored-by: Chris Hegarty
> Co-authored-by: Jan Lahoda
Vicente Romero has updated the
On Thu, 24 Sep 2020 04:52:22 GMT, David Holmes wrote:
>> Monica Beckwith has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update orderAccess_windows_aarch64.hpp
>>
>> changing from Acq-reL to Sequential Consistency to avoid compiler
On Thu, 24 Sep 2020 04:45:16 GMT, David Holmes wrote:
>> Monica Beckwith has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update orderAccess_windows_aarch64.hpp
>>
>> changing from Acq-reL to Sequential Consistency to avoid compiler
> This is a continuation of
> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>
> Changes since then:
> * We've improved the write barrier as suggested by Andrew [1]
> * The define-guards around R18 have been changed to `R18_RESERVED`. This will
> be enabled
On Wed, 23 Sep 2020 23:05:59 GMT, Yumin Qi wrote:
> This patch is a REDO for JDK-8253208 which was backed out since it caused
> runtime/cds/DeterministicDump.java failed,
> see JDK-8253495. Since the failure is another issue and only triggered by
> this patch, the test case now is put on
>
> Hi,
>
> this is the continuation of the review of the implementation for:
>
> https://bugs.openjdk.java.net/browse/JDK-8227745
> https://bugs.openjdk.java.net/browse/JDK-8233915
>
> It allows for JIT optimizations based on escape analysis even if JVMTI agents
> acquire capabilities to access
The javadoc for this class was added, but the constructor itsef is missed..
-
Commit messages:
- Update SwingEventMonitor.java
Changes: https://git.openjdk.java.net/jdk/pull/340/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=340=00
Issue:
On Sat, 19 Sep 2020 20:24:14 GMT, Vipin Sharma wrote:
>> Updated @exception with @throws for core-libs, it fixes all open sub-tasks
>> of JDK-8252536.
>>
>> Open Subtasks part of this fix are:
>> 1. JDK-8252537
>> 2. JDK-8252539
>> 3. JDK-8252540
>> 4. JDK-8252541
>>
>> Previous conversation
52 matches
Mail list logo
