Re: RFR: 8255989: Remove explicitly unascribed authorship from Java source files

2020-11-07 Thread Sergey Bylokhov
On Fri, 6 Nov 2020 20:11:24 GMT, Pavel Rappo wrote: > This PR proposes to remove > 1. JavaDoc `@author` tags with unclear semantics: `@author > unascribed|unattributed|unknown` > 2. A couple of astray Form Feed (a.k.a. FF, `\f`, `0xC`, or `^L`) characters Marked as reviewed by serb (Reviewer).

Re: RFR: 8066622 8066637: remove deprecated using java.io.File.toURL() in internal classes

2020-11-07 Thread Sebastian Ritter
On Sat, 7 Nov 2020 07:55:03 GMT, Sebastian Ritter wrote: > In result of Javadoc to do not use java.io.File.toURL() > Change use java.io.File.toURL().toURI() instead. 8066622 8066637: only for java.io.File.toURL - PR: https://git.openjdk.java.net/jdk/pull/1108

RFR: 8066622 8066637: remove deprecated using java.io.File.toURL() in internal classes

2020-11-07 Thread Sebastian Ritter
In result of Javadoc to do not use java.io.File.toURL() Change use java.io.File.toURL().toURI() instead. - Commit messages: - in result of Javadoc to java.io.File.toURL do use internal java.io.File.toURL().toURI instead Changes: https://git.openjdk.java.net/jdk/pull/1108/files We

Re: RFR: 8255150: Add utility methods to check long indexes and ranges [v3]

2020-11-07 Thread Vladimir Ivanov
On Fri, 6 Nov 2020 08:35:17 GMT, Roland Westrelin wrote: >> This change add 3 new methods in Objects: >> >> public static long checkIndex(long index, long length) >> public static long checkFromToIndex(long fromIndex, long toIndex, long >> length) >> public static long checkFromIndexSize(long f

Re: RFR: 8255989: Remove explicitly unascribed authorship from Java source files [v2]

2020-11-07 Thread Pavel Rappo
> This PR proposes to remove > 1. JavaDoc `@author` tags with unclear semantics: `@author > unascribed|unattributed|unknown` > 2. A couple of astray Form Feed (a.k.a. FF, `\f`, `0xC`, or `^L`) characters Pavel Rappo has updated the pull request with a new target base due to a merge or a rebase.

Re: RFR: 8255989: Remove explicitly unascribed authorship from Java source files [v2]

2020-11-07 Thread Pavel Rappo
On Sat, 7 Nov 2020 09:05:29 GMT, Sergey Bylokhov wrote: >> Pavel Rappo has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two additional >> commits

Integrated: 8255989: Remove explicitly unascribed authorship from Java source files

2020-11-07 Thread Pavel Rappo
On Fri, 6 Nov 2020 20:11:24 GMT, Pavel Rappo wrote: > This PR proposes to remove > 1. JavaDoc `@author` tags with unclear semantics: `@author > unascribed|unattributed|unknown` > 2. A couple of astray Form Feed (a.k.a. FF, `\f`, `0xC`, or `^L`) characters This pull request has now been integra

Fix: javax.xml.XMLEventReader produces incorrect START_DOCUMENT event

2020-11-07 Thread Marius Volkhart
Hello, I've submitted a PR https://github.com/openjdk/jdk/pull/1056 for what I believe to be a bug I found in the javax.xml module. An issue for this behavior does not exist in the bug tracker. The default implementation of javax.xml.stream.XMLEventReader produces a StartDocument event that alway

Re: RFR: 8255883: Avoid multiple GeneratedMethodAccessor for same NativeMethod… [v2]

2020-11-07 Thread Hui Shi
> …AccessorImpl object > > We met real problem when using protobuf with option optimized for code size, > detail in JBS https://bugs.openjdk.java.net/browse/JDK-8255883 > > Optimize solution is adding a new boolean field to detect concurrent method > accessor generation in same NativeMethodAcce

Re: RFR: 8255883: Avoid multiple GeneratedMethodAccessor for same NativeMethod… [v2]

2020-11-07 Thread Hui Shi
On Thu, 5 Nov 2020 14:59:56 GMT, Alan Bateman wrote: >> I do wonder if it makes sense to handle triple-state `int` here: "not yet >> generated", "generated", "in error"? So that we don't try to generate the >> accessor over and over again when it is in error? > > If we are changing NativeMethod