On Sun, 15 Nov 2020 23:25:22 GMT, Rafael Winterhalter
wrote:
>> A method's or constructor's owner type might carry annotations on its
>> potential type parameters but is never represented as parameterized type
>> what makes these parameters inaccessible at runtime, despite the presence of
>>
On Sun, 15 Nov 2020 07:25:30 GMT, Alan Bateman wrote:
>> After review PR/commit title is changed to align with JBS title to add ready
>> label
>
> Can you sync up your branch (the bot is saying that it's 140 commits behind
> the main line)? I can sponsor once it has been tested with an up to
> …AccessorImpl object
>
> We met real problem when using protobuf with option optimized for code size,
> detail in JBS https://bugs.openjdk.java.net/browse/JDK-8255883
>
> Optimize solution is adding a new boolean field to detect concurrent method
> accessor generation in same
On Mon, 9 Nov 2020 09:19:44 GMT, Jie Fu wrote:
> Hi all,
>
> May I get reviews for this change?
>
> com/sun/jndi/dns/ConfigTests/PortUnreachable.java fails occasionally on some
> of our testing platforms.
> The reason is that the hard coded Threshold (1000 ms) [1] is a little smaller
> than
On Mon, 16 Nov 2020 10:24:46 GMT, Aleksey Shipilev wrote:
> This looks fine to me.
Thanks @shipilev for your review.
Will push it tomorrow if there is no objection.
-
PR: https://git.openjdk.java.net/jdk/pull/1116
On Thu, 5 Nov 2020 02:52:05 GMT, Hui Shi wrote:
> …AccessorImpl object
>
> We met real problem when using protobuf with option optimized for code size,
> detail in JBS https://bugs.openjdk.java.net/browse/JDK-8255883
>
> Optimize solution is adding a new boolean field to detect concurrent
> If an annotation member type is changed in an incompatible manner, the
> `AnnotationParser` currently throws a `NullPointerException` if:
>
> - An enumeration-typed member is changed to be an annotation type or a
> `Class` type.
> - An annotation type is changed to be a non-annotation type.
>
On Mon, 16 Nov 2020 12:30:53 GMT, Maurizio Cimadamore
wrote:
> This simple patch fixes a build issue on Windows x86 introduced by the new
> scoped memory access changes. The culprit is a signature mismatch between hpp
> and cpp function definition.
Already handled by #1222 ?
-
> This patch contains the changes associated with the first incubation round of
> the foreign linker access API incubation
> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory
> access support (see JEP 393 [2] and associated pull request [3]).
>
> The main goal of this
This simple patch fixes a build issue on Windows x86 introduced by the new
scoped memory access changes. The culprit is a signature mismatch between hpp
and cpp function definition.
-
Commit messages:
- Fix build issue on Windows x86
Changes:
On Mon, 16 Nov 2020 12:30:53 GMT, Maurizio Cimadamore
wrote:
> This simple patch fixes a build issue on Windows x86 introduced by the new
> scoped memory access changes. The culprit is a signature mismatch between hpp
> and cpp function definition.
This pull request has been closed without
On Mon, 16 Nov 2020 13:30:06 GMT, Vicente Romero wrote:
> Please review the code for the second iteration of sealed classes. In this
> iteration we are:
>
> - Enhancing narrowing reference conversion to allow for stricter checking of
> cast conversions with respect to sealed type hierarchies
> A method's or constructor's owner type might carry annotations on its
> potential type parameters but is never represented as parameterized type what
> makes these parameters inaccessible at runtime, despite the presence of
> parameter type annotations.
Rafael Winterhalter has refreshed the
On Mon, 16 Nov 2020 10:29:48 GMT, Joel Borggrén-Franck
wrote:
>> Rafael Winterhalter has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR.
>
>
Please review the code for the second iteration of sealed classes. In this
iteration we are:
- Enhancing narrowing reference conversion to allow for stricter checking of
cast conversions with respect to sealed type hierarchies.
- Also local classes are not considered when determining implicitly
On Mon, 16 Nov 2020 11:23:47 GMT, Joel Borggrén-Franck
wrote:
>> Rafael Winterhalter has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR. The pull request
>>
On Mon, 16 Nov 2020 11:10:19 GMT, Rafael Winterhalter
wrote:
>> A method's or constructor's owner type might carry annotations on its
>> potential type parameters but is never represented as parameterized type
>> what makes these parameters inaccessible at runtime, despite the presence of
>>
> A method's or constructor's owner type might carry annotations on its
> potential type parameters but is never represented as parameterized type what
> makes these parameters inaccessible at runtime, despite the presence of
> parameter type annotations.
Rafael Winterhalter has updated the
On Mon, 16 Nov 2020 11:28:59 GMT, Joel Borggrén-Franck
wrote:
>> Looks good. I'll run some additional testing on the patch.
>
> I think it would be good to rebase on top of a recent jdk upstream before
> merging.
Rebased on HEAD/master.
-
PR:
> This patch contains the changes associated with the first incubation round of
> the foreign linker access API incubation
> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory
> access support (see JEP 393 [2] and associated pull request [3]).
>
> The main goal of this
On Mon, 9 Nov 2020 09:19:44 GMT, Jie Fu wrote:
> Hi all,
>
> May I get reviews for this change?
>
> com/sun/jndi/dns/ConfigTests/PortUnreachable.java fails occasionally on some
> of our testing platforms.
> The reason is that the hard coded Threshold (1000 ms) [1] is a little smaller
> than
On Mon, 16 Nov 2020 13:30:06 GMT, Vicente Romero wrote:
> Please review the code for the second iteration of sealed classes. In this
> iteration we are:
>
> - Enhancing narrowing reference conversion to allow for stricter checking of
> cast conversions with respect to sealed type hierarchies
Hello,
I've submitted a PR https://github.com/openjdk/jdk/pull/1056 for what I
believe to be a bug I found in the javax.xml module. An issue for this
behavior does not exist in the bug tracker, and I do not have a OpenJDK
account so I can't open an issue.
The default implementation of
… fix linux DTI
-
Commit messages:
- JDK-8255055: Create two phase test for case with different names, and fix
linux DTI
Changes: https://git.openjdk.java.net/jdk/pull/1229/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1229=00
Issue:
On Mon, 16 Nov 2020 15:15:02 GMT, Andy Herrick wrote:
> … fix linux DTI
Creating test for case of app-image created with one name, then used to create
installer with different name.
Fixing Linux desktop integrations for this case
-
PR: https://git.openjdk.java.net/jdk/pull/1229
> This patch contains the changes associated with the first incubation round of
> the foreign linker access API incubation
> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory
> access support (see JEP 393 [2] and associated pull request [3]).
>
> The main goal of this
A follow-up to JDK-8256106, this is adding two asserts to check that the API is
used as it should be, i.e. only on inactive FinalReferences. Also, in
Finalizer, where getInactive() is used, there is a null-check. The GC must
never clean the referent, and Java code doesn't clean it either, it
On Mon, 16 Nov 2020 20:12:37 GMT, Andy Herrick wrote:
>> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JPackageCommand.java line
>> 484:
>>
>>> 482: return TKit.getCurrentDefaultAppName();
>>> 483: }
>>> 484:
>>
>> I don't like the idea of introducing this method. Two
On Mon, 16 Nov 2020 22:28:08 GMT, Christoph Langer wrote:
> The test com/sun/jndi/dns/ConfigTests/PortUnreachable.java is not working on
> AIX.
>
> It tests that when a DNS server is unreachable it fails quickly with a
> PortUnreachableException due to ICMP Destination Unreachable packets
The test com/sun/jndi/dns/ConfigTests/PortUnreachable.java is not working on
AIX.
It tests that when a DNS server is unreachable it fails quickly with a
PortUnreachableException due to ICMP Destination Unreachable packets received
and not having to wait for the full timeout interval.
On Thu, 29 Oct 2020 15:59:51 GMT, Naoto Sato wrote:
> Hi,
>
> Please review the changes for the subject issue. This is to enhance the
> java.time package to support day periods, such as "in the morning", defined
> in CLDR. It will add a new pattern character 'B' and its supporting builder
>
On Mon, 16 Nov 2020 19:01:49 GMT, Alexey Semenyuk wrote:
>> … fix linux DTI
>
> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JPackageCommand.java line
> 484:
>
>> 482: return TKit.getCurrentDefaultAppName();
>> 483: }
>> 484:
>
> I don't like the idea of introducing this
On Mon, 9 Nov 2020 09:19:44 GMT, Jie Fu wrote:
> Hi all,
>
> May I get reviews for this change?
>
> com/sun/jndi/dns/ConfigTests/PortUnreachable.java fails occasionally on some
> of our testing platforms.
> The reason is that the hard coded Threshold (1000 ms) [1] is a little smaller
> than
On Mon, 16 Nov 2020 13:32:16 GMT, Aleksei Efimov wrote:
>> Hi all,
>>
>> May I get reviews for this change?
>>
>> com/sun/jndi/dns/ConfigTests/PortUnreachable.java fails occasionally on some
>> of our testing platforms.
>> The reason is that the hard coded Threshold (1000 ms) [1] is a little
On Mon, 16 Nov 2020 21:22:21 GMT, Andy Herrick wrote:
>> In these two scenarios what would be the name of the installer:
>> 1. phase 1: --name Foo; phase 2: --name Bar --app-image
>>
>> 2. phase 1: --name Foo; phase 2: --app-image
>>
>> Do we have tests for these two scenarios?
>
> In
On Wed, 11 Nov 2020 04:28:02 GMT, Alexander Matveev
wrote:
> This is regression from JDK-8242302 and for some reason removing -psn
> argument code was removed during refactoring. Fixed be adding removing -psn
> argument back. Also, test was added to test this functionality.
This pull request
On Mon, 16 Nov 2020 13:49:26 GMT, Alan Bateman wrote:
>> Please review the code for the second iteration of sealed classes. In this
>> iteration we are:
>>
>> - Enhancing narrowing reference conversion to allow for stricter checking of
>> cast conversions with respect to sealed type
> This is regression from JDK-8242302 and for some reason removing -psn
> argument code was removed during refactoring. Fixed be adding removing -psn
> argument back. Also, test was added to test this functionality.
Alexander Matveev has updated the pull request incrementally with one
On Mon, 16 Nov 2020 19:07:55 GMT, Alexey Semenyuk wrote:
>> Changes requested by asemenyuk (Committer).
>
> In these two scenarios what would be the name of the installer:
> 1. phase 1: --name Foo; phase 2: --name Bar --app-image
>
> 2. phase 1: --name Foo; phase 2: --app-image
>
> Do we
OperatingSystemMXBean was changed in jdk14 (see JDK-8226575):
New methods getTotalMemorySize and getFreeMemorySize were added, old
getTotalPhysicalMemorySize and getFreePhysicalMemorySize were deprecated.
The fix adds fallbacks for the values (i.e. if new methods fail, jconsole calls
old
On Tue, 17 Nov 2020 01:36:21 GMT, Alexander Matveev
wrote:
>> This is regression from JDK-8242302 and for some reason removing -psn
>> argument code was removed during refactoring. Fixed be adding removing -psn
>> argument back. Also, test was added to test this functionality.
>
> Alexander
On Mon, 16 Nov 2020 13:30:06 GMT, Vicente Romero wrote:
> Please review the code for the second iteration of sealed classes. In this
> iteration we are:
>
> - Enhancing narrowing reference conversion to allow for stricter checking of
> cast conversions with respect to sealed type hierarchies
On Tue, 17 Nov 2020 03:33:58 GMT, Jie Fu wrote:
>> Christoph Langer has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains one commit:
>>
>> Test jdk/com/sun/jndi/dns/ConfigTests/PortUnreachable.java does not work
>> on AIX
>
>
On Tue, 17 Nov 2020 05:02:07 GMT, Christoph Langer wrote:
>> The test com/sun/jndi/dns/ConfigTests/PortUnreachable.java is not working on
>> AIX.
>>
>> It tests that when a DNS server is unreachable it fails quickly with a
>> PortUnreachableException due to ICMP Destination Unreachable
> The test com/sun/jndi/dns/ConfigTests/PortUnreachable.java is not working on
> AIX.
>
> It tests that when a DNS server is unreachable it fails quickly with a
> PortUnreachableException due to ICMP Destination Unreachable packets received
> and not having to wait for the full timeout
On Mon, 16 Nov 2020 17:29:20 GMT, Roman Kennke wrote:
> A follow-up to JDK-8256106, this is adding two asserts to check that the API
> is used as it should be, i.e. only on inactive FinalReferences. Also, in
> Finalizer, where getInactive() is used, there is a null-check. The GC must
> never
On Mon, 16 Nov 2020 16:45:31 GMT, Maurizio Cimadamore
wrote:
>> This patch contains the changes associated with the first incubation round
>> of the foreign linker access API incubation
>> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory
>> access support (see JEP 393
On Mon, 16 Nov 2020 15:15:02 GMT, Andy Herrick wrote:
> … fix linux DTI
Changes requested by asemenyuk (Committer).
test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JPackageCommand.java line 484:
> 482: return TKit.getCurrentDefaultAppName();
> 483: }
> 484:
I don't like the
> Hi,
>
> Please review the changes for the subject issue. This is to enhance the
> java.time package to support day periods, such as "in the morning", defined
> in CLDR. It will add a new pattern character 'B' and its supporting builder
> method. The motivation and its spec are in this CSR:
>
> This patch contains the changes associated with the first incubation round of
> the foreign linker access API incubation
> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory
> access support (see JEP 393 [2] and associated pull request [3]).
>
> The main goal of this
On Mon, 16 Nov 2020 19:01:57 GMT, Alexey Semenyuk wrote:
>> … fix linux DTI
>
> Changes requested by asemenyuk (Committer).
In these two scenarios what would be the name of the installer:
1. phase 1: --name Foo; phase 2: --name Bar --app-image
2. phase 1: --name Foo; phase 2: --app-image
Do
51 matches
Mail list logo
