Integrated: 8258217: PriorityBlockingQueue constructor spec and behavior mismatch

2021-01-10 Thread Martin Buchholz
On Sat, 9 Jan 2021 23:41:24 GMT, Martin Buchholz wrote: > 8258217: PriorityBlockingQueue constructor spec and behavior mismatch This pull request has now been integrated. Changeset: 11d5b047 Author:Martin Buchholz URL: https://git.openjdk.java.net/jdk/commit/11d5b047 Stats: 1

Integrated: JDK-8258187 IllegalMonitorStateException in ArrayBlockingQueue

2021-01-10 Thread Martin Buchholz
On Sat, 9 Jan 2021 23:44:13 GMT, Martin Buchholz wrote: > JDK-8258187 IllegalMonitorStateException in ArrayBlockingQueue This pull request has now been integrated. Changeset: e7c17408 Author:Martin Buchholz URL: https://git.openjdk.java.net/jdk/commit/e7c17408 Stats: 30 lines in

Re: RFR: 8259518: Fixes for rare test failures due to 8246585: ForkJoin updates

2021-01-10 Thread Martin Buchholz
On Sun, 10 Jan 2021 12:01:44 GMT, Doug Lea wrote: >> 8259518: Fixes for rare test failures due to 8246585: ForkJoin updates > > Marked as reviewed by dl (Reviewer). The code is good, but this is actually a fix for JDK-8258187 IllegalMonitorStateException in ArrayBlockingQueue I will fiddle

Re: RFR: 8198540: Dynalink leaks memory when generating type converters [v7]

2021-01-10 Thread Peter Levart
On Sun, 10 Jan 2021 17:01:31 GMT, Attila Szegedi wrote: >> Yes, the pre-initialized fields to Map.of() are safe regardless of whether >> they are volatile or not (so I would keep them non-volatile to optimize >> fast-path). Because the BiClassValues instance is published safely to other >>

Re: RFR: JDK-8259395 Patching automatic module with additional packages re-creates module without "requires java.base" [v2]

2021-01-10 Thread Attila Szegedi
On Sun, 10 Jan 2021 16:35:17 GMT, Johannes Kuhn wrote: >> Simple fix - one line change: >> https://openjdk.github.io/cr/?repo=jdk=2000=00#sdiff-0. >> >> Most of the changes come from an additional test that fails without this fix: >> >> Error: Unable to load main class

Re: RFR: 8198540: Dynalink leaks memory when generating type converters [v7]

2021-01-10 Thread Attila Szegedi
On Sun, 10 Jan 2021 17:18:37 GMT, Peter Levart wrote: > How frequent are situations where the two classloaders are unrelated? I think they'd be extremely unlikely. The only user of these right now is Dynalink's type converter factory. I _can imagine_ a situation where there's a conversion

RFR: 8254973: CompletableFuture.ThreadPerTaskExecutor does not throw NPE in #execute

2021-01-10 Thread Martin Buchholz
8254973: CompletableFuture.ThreadPerTaskExecutor does not throw NPE in #execute - Commit messages: - JDK-8254973 Changes: https://git.openjdk.java.net/jdk/pull/2018/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2018=00 Issue:

Re: RFR: 8259518: Fixes for rare test failures due to 8246585: ForkJoin updates

2021-01-10 Thread Doug Lea
On Sat, 9 Jan 2021 23:44:13 GMT, Martin Buchholz wrote: > 8259518: Fixes for rare test failures due to 8246585: ForkJoin updates Marked as reviewed by dl (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2015

Re: RFR: 8198540: Dynalink leaks memory when generating type converters [v6]

2021-01-10 Thread Attila Szegedi
> _(NB: For this leak to occur, an application needs to be either creating and > discarding linkers frequently, or creating and discarding class loaders > frequently while creating Dynalink type converters for classes in them. > Neither is typical usage, although they can occur in dynamic code

Re: RFR: JDK-8259395 Patching automatic module with additional packages re-creates module without "requires java.base"

2021-01-10 Thread Alan Bateman
On Fri, 8 Jan 2021 09:38:40 GMT, Johannes Kuhn wrote: > Simple fix - one line change: > https://openjdk.github.io/cr/?repo=jdk=2000=00#sdiff-0. > > Most of the changes come from an additional test that fails without this fix: > > Error: Unable to load main class somelib.test.TestMain in

Re: RFR: JDK-8259395 Patching automatic module with additional packages re-creates module without "requires java.base"

2021-01-10 Thread Johannes Kuhn
On Sun, 10 Jan 2021 15:14:31 GMT, Alan Bateman wrote: >> Simple fix - one line change: >> https://openjdk.github.io/cr/?repo=jdk=2000=00#sdiff-0. >> >> Most of the changes come from an additional test that fails without this fix: >> >> Error: Unable to load main class

Re: RFR: JDK-8259395 Patching automatic module with additional packages re-creates module without "requires java.base" [v2]

2021-01-10 Thread Johannes Kuhn
> Simple fix - one line change: > https://openjdk.github.io/cr/?repo=jdk=2000=00#sdiff-0. > > Most of the changes come from an additional test that fails without this fix: > > Error: Unable to load main class somelib.test.TestMain in module somelib > java.lang.IllegalAccessError:

Re: RFR: 8198540: Dynalink leaks memory when generating type converters [v7]

2021-01-10 Thread Attila Szegedi
> _(NB: For this leak to occur, an application needs to be either creating and > discarding linkers frequently, or creating and discarding class loaders > frequently while creating Dynalink type converters for classes in them. > Neither is typical usage, although they can occur in dynamic code

Re: RFR: 8198540: Dynalink leaks memory when generating type converters [v7]

2021-01-10 Thread Attila Szegedi
On Fri, 8 Jan 2021 18:58:03 GMT, Peter Levart wrote: >> So, are you saying the solution where I kept the fields volatile and >> initialized them with `Map.of()` is safe? If so, that'd be good news; I'm >> inclined these days to write as much null-free code as possible :-) > > Yes, the

Re: RFR: 8258217: PriorityBlockingQueue constructor spec and behavior mismatch

2021-01-10 Thread Doug Lea
On Sat, 9 Jan 2021 23:41:24 GMT, Martin Buchholz wrote: > 8258217: PriorityBlockingQueue constructor spec and behavior mismatch Marked as reviewed by dl (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2014

Re: RFR: 8254973: CompletableFuture.ThreadPerTaskExecutor does not throw NPE in #execute

2021-01-10 Thread Doug Lea
On Sun, 10 Jan 2021 20:13:07 GMT, Martin Buchholz wrote: > 8254973: CompletableFuture.ThreadPerTaskExecutor does not throw NPE in > #execute Marked as reviewed by dl (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2018

Integrated: 8254973: CompletableFuture.ThreadPerTaskExecutor does not throw NPE in #execute

2021-01-10 Thread Martin Buchholz
On Sun, 10 Jan 2021 20:13:07 GMT, Martin Buchholz wrote: > 8254973: CompletableFuture.ThreadPerTaskExecutor does not throw NPE in > #execute This pull request has now been integrated. Changeset: 9154f643 Author:Martin Buchholz URL: https://git.openjdk.java.net/jdk/commit/9154f643

Withdrawn: JDK-8189198: Add "forRemoval = true" to Applet APIs

2021-01-10 Thread Andy Herrick
On Mon, 9 Nov 2020 13:56:33 GMT, Andy Herrick wrote: > JDK-8189198: Add "forRemoval = true" to Applet APIs This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/1127

Re: RFR: 8198540: Dynalink leaks memory when generating type converters [v7]

2021-01-10 Thread Peter Levart
On Sun, 10 Jan 2021 19:38:11 GMT, Attila Szegedi wrote: >> Hello Attila, >> This looks good to me. Just a question: How frequent are situations where >> the two classloaders are unrelated? > >> How frequent are situations where the two classloaders are unrelated? > > I think they'd be

Re: RFR: JDK-8259395 Patching automatic module with additional packages re-creates module without "requires java.base" [v3]

2021-01-10 Thread Johannes Kuhn
> Simple fix - one line change: > https://openjdk.github.io/cr/?repo=jdk=2000=00#sdiff-0. > > Most of the changes come from an additional test that fails without this fix: > > Error: Unable to load main class somelib.test.TestMain in module somelib > java.lang.IllegalAccessError: