On Mon, 1 Feb 2021 20:10:58 GMT, Ioi Lam wrote:
>> - JVM_GetInterfaceVersion() was used by "HotSpot Express" (HSX) which
>> allowed the same JDK library to use different version of HotSpot. However,
>> HSX is no longer supported so this API should be removed.
>> - Implementations of APIs such
On 01/02/2021 15:19, Johannes Kuhn wrote:
:
Thanks Rémi.
The problem here is that (according to Peter Levart tests), the cold
use of a MHMethodAccessor is 11x as expensive as using the native
accessor.
In some way, it sill makes sense to keep the native accessor around,
at least during
On Tue, 2 Feb 2021 02:58:30 GMT, Martin Buchholz wrote:
>>> A manual exploration of a new set of micros would naturally start with
>>> the default config, so if such a config runs forever, that would be poor
>>> ergonomics IMHO. I don't think such configurations should be checked in
>>> in an
> - Merge checkEncoding into the byte[]-based normalizedHash. The latter is
> only used from ZipFile.initCEN right after the checkEncoding today, so
> verifying this is equivalent is straightforward.
> - Factor out the logic to calculate hash, check encoding etc into the
> addEntry method to
On Sun, 31 Jan 2021 18:05:30 GMT, Lance Andersen wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Clarify comments, put normal path branch first in UTF8 checkedHash
>
> Hi Claes
>
> I gone through your changes a
Discovered it with ARM32 tier1 tests, which runs with -CompactStrings by
default. But the bug is actually generic:
$ CONF=linux-x86_64-server-fastdebug make run-test
TEST=java/lang/StringBuilder/Insert.java TEST_VM_OPTS="-XX:-CompactStrings"
test Insert.insertOffset(): failure
> Discovered it with ARM32 tier1 tests, which runs with -CompactStrings by
> default. But the bug is actually generic:
>
> $ CONF=linux-x86_64-server-fastdebug make run-test
> TEST=java/lang/StringBuilder/Insert.java TEST_VM_OPTS="-XX:-CompactStrings"
>
> test Insert.insertOffset(): failure
>
On Tue, 2 Feb 2021 13:23:16 GMT, Claes Redestad wrote:
> Should we add an explicit run with -CompactStrings to the Insert.java test?
> That'd have caught this issue sooner - perhaps already by the GA testing.
Yes, I thought about the same. Added and re-checked that it catches the
failure. (I
On Tue, 2 Feb 2021 11:14:12 GMT, Vladimir Kempik wrote:
> > > > Hello, hsdis is a separate out-of-tree project and is not part of this
> > > > jep.
> > >
> > >
> > > Unless there's something I'm missing it only requires a few lines of
> > > change to src/utils/hsdis/makefile (it already has
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
On 2/2/21 2:46 AM, Alan Bateman wrote:
On 01/02/2021 22:13, Daniel D.Daugherty wrote:
A trivial fix to put tools/jlink/plugins/CompressorPluginTest.java
back on the
ProblemList. It was removed in error (see the bug for the details).
Something fishy here, Sundar ran the test 500 times on the 3
On Tue, 2 Feb 2021 13:12:53 GMT, Aleksey Shipilev wrote:
> Discovered it with ARM32 tier1 tests, which runs with -CompactStrings by
> default. But the bug is actually generic:
>
> $ CONF=linux-x86_64-server-fastdebug make run-test
> TEST=java/lang/StringBuilder/Insert.java
On Tue, 2 Feb 2021 13:31:58 GMT, Aleksey Shipilev wrote:
>> Discovered it with ARM32 tier1 tests, which runs with -CompactStrings by
>> default. But the bug is actually generic:
>>
>> $ CONF=linux-x86_64-server-fastdebug make run-test
>> TEST=java/lang/StringBuilder/Insert.java
On Tue, 2 Feb 2021 03:59:00 GMT, Alexander Matveev wrote:
>> We did not able to run "hdiutil convert" due to hdiutil did not able to
>> acquire lock on DMG image file. In this condition we got "Resource busy"
>> from "hdiutil detach" and on repeated attempt we was getting "File Not
>> Found"
On Tue, 2 Feb 2021 11:56:12 GMT, Vladimir Kempik wrote:
> > > > Hello, hsdis is a separate out-of-tree project and is not part of this
> > > > jep.
> > >
> > >
> > > Unless there's something I'm missing it only requires a few lines of
> > > change to src/utils/hsdis/makefile (it already has
On Tue, 2 Feb 2021 03:07:08 GMT, Martin Buchholz wrote:
>> 8259074: regex benchmarks and tests
>
> Martin Buchholz has updated the pull request incrementally with one
> additional commit since the last revision:
>
> fix imports
Marked as reviewed by redestad (Reviewer).
-
PR:
On Tue, 2 Feb 2021 03:59:00 GMT, Alexander Matveev wrote:
>> We did not able to run "hdiutil convert" due to hdiutil did not able to
>> acquire lock on DMG image file. In this condition we got "Resource busy"
>> from "hdiutil detach" and on repeated attempt we was getting "File Not
>> Found"
On Tue, 2 Feb 2021 13:31:58 GMT, Aleksey Shipilev wrote:
>> Discovered it with ARM32 tier1 tests, which runs with -CompactStrings by
>> default. But the bug is actually generic:
>>
>> $ CONF=linux-x86_64-server-fastdebug make run-test
>> TEST=java/lang/StringBuilder/Insert.java
Thanks Alan.
For using MethodHandles and @CS methods: As far as I remember,
MethodHandle is also skipped on a stack walk for security. In my
prototype (where I did always use MethodHandles for Method.invoke)
MethodHandles.class.findStatic("lookup").invoke(null) did return a
Lookup with the
On Wed, 3 Feb 2021 04:01:51 GMT, Sergey Bylokhov wrote:
> Trivial cleanup, the "default" license header is removed in a few components.
Marked as reviewed by psadhukhan (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2368
JDK-8013527: calling MethodHandles.lookup on itself leads to errors
JDK-8257874: MethodHandle injected invoker doesn't have necessary private access
Johannes Kuhn is also a contributor to this patch.
A caller-sensitive method can behave differently depending on the identity
of its immediate
On Mon, 1 Feb 2021 18:40:54 GMT, Ioi Lam wrote:
> - JVM_GetInterfaceVersion() was used by "HotSpot Express" (HSX) which allowed
> the same JDK library to use different version of HotSpot. However, HSX is no
> longer supported so this API should be removed.
> - Implementations of APIs such as
On Tue, 2 Feb 2021 15:59:47 GMT, Gerard Ziemski wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed macos build
>
> Marked as reviewed by gziemski (Committer).
Thanks @gerard-ziemski @magicus @AlanBateman @lfoltan
On Wed, 3 Feb 2021 04:01:51 GMT, Sergey Bylokhov wrote:
> Trivial cleanup, the "default" license header is removed in a few components.
Trivial removal of template instructions.
-
Marked as reviewed by iris (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/2368
Hi Johannes,
I reconsidered the solution I implemented for JDK-8013527 that I
mentioned [1]. I finally had the time to get back to this. I see the
merit of your idea to bind directly to an alternate implementation of
MethodHandles::lookup taking an additional caller class parameter (but
On Tue, 2 Feb 2021 16:00:43 GMT, Gerard Ziemski wrote:
>> I am not sure if jni_utils.c is the right file (it defines the `JNU_XXX`
>> functions that are used by other shared libraries).
>>
>> There are other .c files that have trivial `DEF_JNI_OnLoad` functions (e.g.,
>>
Here is the original document (it's available in the jigsaw wiki)
How would you like it flushed out?
Cheers,
-- Jim
> On Jan 31, 2021, at 11:40 AM, Jim Laskey wrote:
>
> I’ve been handing out the original jimage docs on request. Surprisingly, it’s
> still accurate. Will dig up on Monday
On Mon, 1 Feb 2021 20:54:42 GMT, Ioi Lam wrote:
>> src/java.base/share/native/libjava/check_version.c line 33:
>>
>>> 31: DEF_JNI_OnLoad(JavaVM *vm, void *reserved)
>>> 32: {
>>> 33: return JNI_VERSION_1_2;
>>
>> This leaves an entire file with one trivial function implementation. Can we
On Tue, 2 Feb 2021 13:31:58 GMT, Aleksey Shipilev wrote:
>> Discovered it with ARM32 tier1 tests, which runs with -CompactStrings by
>> default. But the bug is actually generic:
>>
>> $ CONF=linux-x86_64-server-fastdebug make run-test
>> TEST=java/lang/StringBuilder/Insert.java
On Tue, 2 Feb 2021 13:31:58 GMT, Aleksey Shipilev wrote:
>> Discovered it with ARM32 tier1 tests, which runs with -CompactStrings by
>> default. But the bug is actually generic:
>>
>> $ CONF=linux-x86_64-server-fastdebug make run-test
>> TEST=java/lang/StringBuilder/Insert.java
On Mon, 1 Feb 2021 20:10:58 GMT, Ioi Lam wrote:
>> - JVM_GetInterfaceVersion() was used by "HotSpot Express" (HSX) which
>> allowed the same JDK library to use different version of HotSpot. However,
>> HSX is no longer supported so this API should be removed.
>> - Implementations of APIs such
$ CONF=linux-x86_64-server-fastdebug make run-test
TEST=java/lang/StringBuilder/HugeCapacity.java TEST_VM_OPTS=-XX:-CompactStrings
STDERR:
java.lang.OutOfMemoryError: Required length exceeds implementation limit
at
> https://bugs.openjdk.java.net/browse/JDK-8183372
Mahendra Chhipa has updated the pull request incrementally with one additional
commit since the last revision:
Using testNg Assert instead of assert.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2170/files
- new:
On Wed, 27 Jan 2021 12:43:40 GMT, Andy Herrick wrote:
> Fixing FileUtils.dirname() to skip over "/.".
Changes requested by asemenyuk (Committer).
src/jdk.jpackage/share/native/common/FileUtils.cpp line 57:
> 55: tstring dirname(const tstring ) {
> 56: tstring::size_type pos;
> 57: if
Trivial cleanup, the "default" license header is removed in a few components.
-
Commit messages:
- Initial fix
Changes: https://git.openjdk.java.net/jdk/pull/2368/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2368=00
Issue:
> https://bugs.openjdk.java.net/browse/JDK-8183372
Mahendra Chhipa has updated the pull request incrementally with one additional
commit since the last revision:
Generate the source files in JTWork directory.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2170/files
On Mon, 1 Feb 2021 14:06:32 GMT, Magnus Ihse Bursie wrote:
>>> Hello, hsdis is a separate out-of-tree project and is not part of this jep.
>>
>> Unless there's something I'm missing it only requires a few lines of change
>> to src/utils/hsdis/makefile (it already has support for macos x86_64)
On Tue, 2 Feb 2021 18:23:04 GMT, Gerard Ziemski wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/os/posix/signals_posix.cpp line 1297:
>
>> 1295: kern_return_t kr;
On Wed, 27 Jan 2021 23:03:55 GMT, Mahendra Chhipa
wrote:
>> test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java line 126:
>>
>>> 124: Path pkg1Dir = Paths.get(SRC_DIR + "/pkg1");
>>> 125: FileUtils.deleteFileTreeWithRetry(pkg1Dir);
>>> 126: }
>>
>> I'm not
On Tue, 2 Feb 2021 17:22:18 GMT, Kiran Sidhartha Ravikumar
wrote:
> Hi Guys,
>
> Please review integrating tzdata2021a to JDK.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8260356
>
> The fix has passed the regression and JCK tests. More information can be
> viewed at -
>
On Tue, 2 Feb 2021 15:32:16 GMT, Jim Laskey wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add the regression test case
>
> Marked as reviewed by jlaskey (Reviewer).
Thanks. GHA are green, `tier1`, `tier2`
On Wed, 27 Jan 2021 12:43:40 GMT, Andy Herrick wrote:
> Fixing FileUtils.dirname() to skip over "/.".
Aside of small change requested by @alexeysemenyukoracle looks fine.
-
Marked as reviewed by kizune (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/2260
On Tue, 2 Feb 2021 13:12:53 GMT, Aleksey Shipilev wrote:
> Discovered it with ARM32 tier1 tests, which runs with -CompactStrings by
> default. But the bug is actually generic:
>
> $ CONF=linux-x86_64-server-fastdebug make run-test
> TEST=java/lang/StringBuilder/Insert.java
Please review this simple fix that is removing the RECORDS enum constant from
the PreviewFeature.Feature enum, now that RECORDS are final in 16 this constant
can be safely removed.
Thanks,
Vicente
-
Commit messages:
- 8260959: remove RECORDS from PreviewFeature.Feature enum
On Tue, 2 Feb 2021 18:52:29 GMT, Gerard Ziemski wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> Changes requested by gziemski (Committer).
There were bunch of assembly code that
Hi Guys,
Please review integrating tzdata2021a to JDK.
JBS: https://bugs.openjdk.java.net/browse/JDK-8260356
The fix has passed the regression and JCK tests. More information can be viewed
at - https://mm.icann.org/pipermail/tz-announce/2021-January/65.html
Thanks,
Kiran
-
> Fixing FileUtils.dirname() to skip over "/.".
Andy Herrick has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains 86 additional commits since the
last
On Tue, 2 Feb 2021 17:10:15 GMT, Alexey Semenyuk wrote:
>> Andy Herrick has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 86 additional
>>
On Tue, 2 Feb 2021 21:00:00 GMT, Mahendra Chhipa
wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8183372
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Generate the source files in JTWork directory.
Looks good.
On Wed, 20 Jan 2021 17:27:43 GMT, Mahendra Chhipa
wrote:
> https://bugs.openjdk.java.net/browse/JDK-8183372
This pull request has now been integrated.
Changeset: 6dc3c6dc
Author:Mahendra Chhipa
Committer: Brent Christian
URL: https://git.openjdk.java.net/jdk/commit/6dc3c6dc
Stats:
On Tue, 2 Feb 2021 22:08:33 GMT, Mahendra Chhipa
wrote:
> JDK-8261003 : Bad Copyright header format after JDK-8183372
This pull request has now been integrated.
Changeset: 9af33392
Author:Mahendra Chhipa
Committer: Brent Christian
URL:
On Tue, 2 Feb 2021 22:08:33 GMT, Mahendra Chhipa
wrote:
> JDK-8261003 : Bad Copyright header format after JDK-8183372
Marked as reviewed by bchristi (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2365
On Tue, 2 Feb 2021 10:40:01 GMT, Claes Redestad wrote:
>> - Merge checkEncoding into the byte[]-based normalizedHash. The latter is
>> only used from ZipFile.initCEN right after the checkEncoding today, so
>> verifying this is equivalent is straightforward.
>> - Factor out the logic to
JDK-8261003 : Bad Copyright header format after JDK-8183372
-
Commit messages:
- JDK-8261003 : Bad Copyright header format after JDK-8183372
Changes: https://git.openjdk.java.net/jdk/pull/2365/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2365=00
Issue:
Previously, `ImageBufferCache` contains a ThreadLocal field which holds
strong reference to `ImageBufferCache$BufferReference.class`. When loaded
from `jrt-fs.jar`, this will keep `JrtFileSystemProvider$JrtFsLoader`
in memory forever and never being GCed.
The fix replace the old
On Tue, 2 Feb 2021 11:59:08 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Mon, 1 Feb 2021 23:41:38 GMT, Alexander Matveev wrote:
> We did not able to run "hdiutil convert" due to hdiutil did not able to
> acquire lock on DMG image file. In this condition we got "Resource busy" from
> "hdiutil detach" and on repeated attempt we was getting "File Not Found"
>
> Previously, `ImageBufferCache` contains a ThreadLocal field which holds
> strong reference to `ImageBufferCache$BufferReference.class`. When loaded
> from `jrt-fs.jar`, this will keep `JrtFileSystemProvider$JrtFsLoader`
> in memory forever and never being GCed.
>
> The fix replace the old
58 matches
Mail list logo
