On Wed, 3 Feb 2021 20:08:28 GMT, Mikael Vidstedt wrote:
>>> I wonder if this is the right choice
>>> ...
>>> ```
>>> OopStorageParIterPerf::~OopStorageParIterPerf() {
>>> ...
>>> ```
>>>
>>
>> The transition in OopStorageParIterPerf was made for gtest setup to execute
>> in WXWrite context.
We need to regenerate the exported nroff man pages to include the proper
version string. This will also bring in some recent textual updates to the man
pages.
-
Commit messages:
- 8261149: Initial nroff manpage update for JDK 17
Changes:
Hello Joe,
in the javadoc of acos() I think you should replace the mathematically
incorrect
* If the argument is {@linkplain Double#isInfinite infinite},
with something like
* If the argument is zero,
Also, in some places pi/2 is described as
pi/2, rounded,
which is more open to
On Thu, 4 Feb 2021 08:26:35 GMT, Mikael Vidstedt wrote:
> You read my mind, Andrew. Unless, of course, it's optimized to leverage the
> fact that it's thread-specific..
it's thread-specific
https://developer.apple.com/documentation/apple_silicon/porting_just-in-time_compilers_to_apple_silicon
On Wed, 3 Feb 2021 12:08:58 GMT, Claes Redestad wrote:
> This moves the tracing methods added to GenerateJLIClassesHelper in
> JDK-8252725 to MethodHandleStatics, which avoids loading at runtime some code
> meant for jlink.
This pull request has now been integrated.
Changeset: 83357b11
On Wed, 3 Feb 2021 13:21:33 GMT, Claes Redestad wrote:
> This patch refactors CleanerFactory and InnocuousThread so that we need to
> load fewer PrivilegedActions. This slightly reduce the number of classes we
> always load on bootstrap, slightly reducing static and dynamic footprint
>
On Wed, 3 Feb 2021 12:21:30 GMT, Claes Redestad wrote:
> This patch moves some sanity checking done in ClassLoader.java to the
> corresponding endpoints in native or VM code.
Changes requested by coleenp (Reviewer).
src/java.base/share/classes/java/lang/ClassLoader.java line 1259:
> 1257:
On Wed, 3 Feb 2021 19:49:30 GMT, Mandy Chung wrote:
>> This patch moves some sanity checking done in ClassLoader.java to the
>> corresponding endpoints in native or VM code.
>
> src/java.base/share/native/libjava/ClassLoader.c line 291:
>
>> 289: }
>> 290: // disallow slashes in input,
On Tue, 2 Feb 2021 22:56:55 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/share/runtime/stubRoutines.inline.hpp line 1:
>
>> 1: /*
>
>
On Thu, 4 Feb 2021 10:13:31 GMT, Magnus Ihse Bursie wrote:
> We need to regenerate the exported nroff man pages to include the proper
> version string. This will also bring in some recent textual updates to the
> man pages.
LGTM.
Thanks,
David
-
Marked as reviewed by dholmes
On Thu, 4 Feb 2021 12:54:43 GMT, Coleen Phillimore wrote:
>> This patch moves some sanity checking done in ClassLoader.java to the
>> corresponding endpoints in native or VM code.
>
> src/java.base/share/classes/java/lang/ClassLoader.java line 1259:
>
>> 1257: Class
> This PR is to introduce a new random number API for the JDK. The primary API
> is found in RandomGenerator and RandomGeneratorFactory. Further description
> can be found in the JEP https://openjdk.java.net/jeps/356 .
>
> javadoc can be found at
>
On Thu, 4 Feb 2021 13:11:47 GMT, Coleen Phillimore wrote:
>> src/java.base/share/native/libjava/ClassLoader.c line 291:
>>
>>> 289: }
>>> 290: // disallow slashes in input, change '.' to '/'
>>> 291: if (verifyFixClassname(clname)) {
>>
>> perhaps we should replace all use of
On Thu, 4 Feb 2021 10:13:31 GMT, Magnus Ihse Bursie wrote:
> We need to regenerate the exported nroff man pages to include the proper
> version string. This will also bring in some recent textual updates to the
> man pages.
This pull request has now been integrated.
Changeset: f7a6cff9
On Wed, 27 Jan 2021 12:43:40 GMT, Andy Herrick wrote:
> Fixing FileUtils.dirname() to skip over "/.".
This pull request has now been integrated.
Changeset: c1dea39d
Author:Andy Herrick
URL: https://git.openjdk.java.net/jdk/commit/c1dea39d
Stats: 10 lines in 1 file changed: 8
On Thu, 4 Feb 2021 10:13:31 GMT, Magnus Ihse Bursie wrote:
> We need to regenerate the exported nroff man pages to include the proper
> version string. This will also bring in some recent textual updates to the
> man pages.
Marked as reviewed by erikj (Reviewer).
-
PR:
This patch resolves a potential memory leak in
Java_java_lang_ClassLoader_defineClass0
I've not figured a good way to write a regression test, but manually verified
the leak and the fix by adding a microbenchmark that triggers the leak. When
run with `-XX:NativeMemoryTracking=summary
On Thu, 4 Feb 2021 09:49:17 GMT, Vladimir Kempik wrote:
> > You read my mind, Andrew. Unless, of course, it's optimized to leverage the
> > fact that it's thread-specific..
>
> it's thread-specific
>
>
On Wed, 3 Feb 2021 22:19:40 GMT, Alexander Matveev wrote:
>> Remove lines in WixSourceBuilder that adds directive to rm-rf the parent
>> dir(s) of the install-dir. These directories get removed anyway if they are
>> empty without these lines, and should be left alone if not empty after
>>
On Thu, 4 Feb 2021 14:27:53 GMT, Andrew Haley wrote:
> > > You read my mind, Andrew. Unless, of course, it's optimized to leverage
> > > the fact that it's thread-specific..
> >
> >
> > it's thread-specific
> >
On Wed, 3 Feb 2021 14:08:13 GMT, Andy Herrick wrote:
> Remove lines in WixSourceBuilder that adds directive to rm-rf the parent
> dir(s) of the install-dir. These directories get removed anyway if they are
> empty without these lines, and should be left alone if not empty after
> removing
On Wed, 3 Feb 2021 20:01:15 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Fri, 5 Feb 2021 02:25:15 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/classfile/dictionary.cpp line 145:
>>
>>> 143: #ifdef ASSERT
>>> 144: if (protection_domain == instance_klass()->protection_domain()) {
>>> 145: MutexLocker ml(ProtectionDomainSet_lock,
>>>
On Fri, 5 Feb 2021 02:28:31 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/classfile/systemDictionary.cpp line 503:
>>
>>> 501: } else {
>>> 502: log_debug(protectiondomain)("granted");
>>> 503: }
>>
>> Did you intend leaving this in?
>
> Yes, why not? It's very useful in
On Fri, 5 Feb 2021 01:45:58 GMT, David Holmes wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add comment and read NEVER field from System
>
> src/hotspot/share/classfile/dictionary.cpp line 145:
>
>> 143:
On Fri, 5 Feb 2021 02:37:54 GMT, Coleen Phillimore wrote:
>> This change does not call up to Java for checkPackageAccess if the security
>> manager is NULL, but still saves the protection domain in the pd_set for
>> that dictionary entry. If the option -Djava.security.manager=disallow is
>>
> This change does not call up to Java for checkPackageAccess if the security
> manager is NULL, but still saves the protection domain in the pd_set for that
> dictionary entry. If the option -Djava.security.manager=disallow is set,
> that means that there will never be a security manager and
On Wed, 3 Feb 2021 20:01:15 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Tue, 2 Feb 2021 22:09:58 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 363:
>
>> 361:
A subtask [JDK-8260559](https://bugs.openjdk.java.net/browse/JDK-8260559). This
is an enhancement to update jlink's usage of `Collections.toList()` to
`Stream.toList()`.
-
Commit messages:
- Converting jlink usage of Collections.toList() to Stream.toList
Changes:
On Thu, 4 Feb 2021 15:13:49 GMT, Anton Kozlov wrote:
>> Out of curiosity, have you looked at the performance of the W^X state
>> transition? In particular I'm wondering if the cost is effectively
>> negligible so doing it unconditionally on JVM entry is a no-brainer and just
>> easier/cleaner
> This change does not call up to Java for checkPackageAccess if the security
> manager is NULL, but still saves the protection domain in the pd_set for that
> dictionary entry. If the option -Djava.security.manager=disallow is set,
> that means that there will never be a security manager and
On Thu, 4 Feb 2021 02:32:31 GMT, Phil Race wrote:
> remove un-needed disabling now JNF has gone ..
This pull request has now been integrated.
Changeset: 3bb6a3d2
Author:Phil Race
URL: https://git.openjdk.java.net/jdk/commit/3bb6a3d2
Stats: 8 lines in 2 files changed: 0 ins; 8
On Wed, 3 Feb 2021 20:01:15 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Wed, 3 Feb 2021 20:01:15 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
Please review this fix. The bug was revealed while porting CLDR v39 into the
JDK, where they switch the Norwegian Bokmal from "nb" to "no". [1] Some
regression tests started failing with it because COMPAT provider's "nb"
resource was used according to the incorrect candidate locale order.
[1]
On Wed, 3 Feb 2021 20:01:15 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Wed, 3 Feb 2021 20:01:15 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Wed, 3 Feb 2021 20:01:15 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Wed, 3 Feb 2021 20:01:15 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Thu, 4 Feb 2021 22:17:12 GMT, Naoto Sato wrote:
> Please review this fix. The bug was revealed while porting CLDR v39 into the
> JDK, where they switch the Norwegian Bokmal from "nb" to "no". [1] Some
> regression tests started failing with it because COMPAT provider's "nb"
> resource was
On Thu, 4 Feb 2021 22:45:10 GMT, Ian Graves wrote:
> A subtask [JDK-8260559](https://bugs.openjdk.java.net/browse/JDK-8260559).
> This is an enhancement to update jlink's usage of `Collections.toList()` to
> `Stream.toList()`.
Looks fine, if any of these lists were being modified then I would
On Thu, 4 Feb 2021 15:53:24 GMT, Claes Redestad wrote:
> I'm not sure every platform have always agreed free(NULL) is a noop. I
> suspect all the currently supported ones do, though?
Its standard behavior.
Posix: https://pubs.opengroup.org/onlinepubs/009695399/functions/free.html "If
ptr is
On Thu, 4 Feb 2021 16:57:37 GMT, Thomas Stuefe wrote:
>> I'm not sure every platform have always agreed free(NULL) is a noop. I
>> suspect all the currently supported ones do, though?
>
>> I'm not sure every platform have always agreed free(NULL) is a noop. I
>> suspect all the currently
On Thu, 4 Feb 2021 16:14:57 GMT, Claes Redestad wrote:
>> This patch resolves a potential memory leak in
>> Java_java_lang_ClassLoader_defineClass0
>>
>> I've not figured a good way to write a regression test. A crude way to
>> manually verify the leak and the fix is provided by the added
On Thu, 4 Feb 2021 16:14:57 GMT, Claes Redestad wrote:
>> This patch resolves a potential memory leak in
>> Java_java_lang_ClassLoader_defineClass0
>>
>> I've not figured a good way to write a regression test. A crude way to
>> manually verify the leak and the fix is provided by the added
On Wed, 3 Feb 2021 20:08:28 GMT, Mikael Vidstedt wrote:
> Out of curiosity, have you looked at the performance of the W^X state
> transition?
Earlier it was possible to disable W^X protection (unfortunately, I don't know
a way to do this now). We compared Renaissance results with W^X
On Thu, 4 Feb 2021 14:23:56 GMT, Claes Redestad wrote:
> This patch resolves a potential memory leak in
> Java_java_lang_ClassLoader_defineClass0
>
> I've not figured a good way to write a regression test. A crude way to
> manually verify the leak and the fix is provided by the added
On Thu, 4 Feb 2021 15:48:16 GMT, Thomas Stuefe wrote:
>> This patch resolves a potential memory leak in
>> Java_java_lang_ClassLoader_defineClass0
>>
>> I've not figured a good way to write a regression test. A crude way to
>> manually verify the leak and the fix is provided by the added
> This patch resolves a potential memory leak in
> Java_java_lang_ClassLoader_defineClass0
>
> I've not figured a good way to write a regression test. A crude way to
> manually verify the leak and the fix is provided by the added microbenchmark
> that triggers the malloc in ClassLoader.c and
On Thu, 4 Feb 2021 16:14:57 GMT, Claes Redestad wrote:
>> This patch resolves a potential memory leak in
>> Java_java_lang_ClassLoader_defineClass0
>>
>> I've not figured a good way to write a regression test. A crude way to
>> manually verify the leak and the fix is provided by the added
On Thu, 4 Feb 2021 11:42:48 GMT, Magnus Ihse Bursie wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove condition that should have been fixed as part of 8257858
>
> Marked as reviewed by ihse (Reviewer).
Magnus
> remove un-needed disabling now JNF has gone ..
Phil Race has updated the pull request incrementally with one additional commit
since the last revision:
Remove condition that should have been fixed as part of 8257858
-
Changes:
- all:
On Thu, 4 Feb 2021 18:52:58 GMT, Phil Race wrote:
>> remove un-needed disabling now JNF has gone ..
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove condition that should have been fixed as part of 8257858
Looks good
> Recent revisions of the IEEE 754 floating-point standard have added guidance
> on how typical math library methods (sin, cos, tan, etc.) should behave in
> terms of their general quality of implementation as well as on special values.
>
> Other than the pow methods, for the recommended
On Tue, 2 Feb 2021 17:22:18 GMT, Kiran Sidhartha Ravikumar
wrote:
> Hi Guys,
>
> Please review integrating tzdata2021a to JDK.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8260356
>
> The fix has passed the regression and JCK tests. More information can be
> viewed at -
>
On Wed, 3 Feb 2021 14:08:13 GMT, Andy Herrick wrote:
> Remove lines in WixSourceBuilder that adds directive to rm-rf the parent
> dir(s) of the install-dir. These directories get removed anyway if they are
> empty without these lines, and should be left alone if not empty after
> removing
I have been reading previous threads, the original bug request, and exploring
the javadoc and implementation of toList() on Stream in JDK 16. I don’t want to
waste time rehashing previous discussions, but I want to understand and
prioritize the motivation of this change, and propose what I
Hi Raffaello,
Thanks for catching the spec error; fixed in a subsequent push.
Cheers,
-Joe
On 2/4/2021 3:22 AM, Raffaello Giulietti wrote:
Hello Joe,
in the javadoc of acos() I think you should replace the mathematically
incorrect
* If the argument is {@linkplain Double#isInfinite
59 matches
Mail list logo
