On Thu, 4 Feb 2021 13:14:16 GMT, Coleen Phillimore wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Consolidate verifyClassname and verifyFixClassname
>
> Changes requested by coleenp (Reviewer).
I tried to
> This patch moves some sanity checking done in ClassLoader.java to the
> corresponding endpoints in native or VM code.
Claes Redestad has updated the pull request incrementally with one additional
commit since the last revision:
Consolidate verifyClassname and verifyFixClassname
On Wed, 10 Feb 2021 20:30:02 GMT, Roger Riggs wrote:
>> This issue adds a new event to improve diagnostic information of Java
>> deserialization. The event captures the details of deserialization activity
>> from ObjectInputStream. The event details are similar to that of the serial
>>
> This issue adds a new event to improve diagnostic information of Java
> deserialization. The event captures the details of deserialization activity
> from ObjectInputStream. The event details are similar to that of the serial
> filter, but is agnostic of whether a filter is installed or not.
On Thu, 11 Feb 2021 08:04:55 GMT, Alan Bateman wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added a comment
>
> Marked as reviewed by alanb (Reviewer).
Thanks!
-
PR:
On Tue, 9 Feb 2021 15:40:03 GMT, Aleksey Shipilev wrote:
> `JVM_LatestUserDefinedLoader` is called normally from
> `ObjectInputStream.resolveClass` -> `VM.latestUserDefinedLoader0`. And it
> takes a measurable time to walk the stack. There is JDK-8173368 that wants to
> replace it with
> Could I get the following change reviewed please? It fixes a problem (in
> JEP380) on Windows where some file operations on Unix domain sockets were not
> working and led to the feature being disabled on Windows 2019 Server in JDK
> 16. So, the fix re-enables the feature on all versions of
On Wed, 10 Feb 2021 07:34:59 GMT, Aleksey Shipilev wrote:
>> `JVM_LatestUserDefinedLoader` is called normally from
>> `ObjectInputStream.resolveClass` -> `VM.latestUserDefinedLoader0`. And it
>> takes a measurable time to walk the stack. There is JDK-8173368 that wants
>> to replace it with
> This patch moves some sanity checking done in ClassLoader.java to the
> corresponding endpoints in native or VM code.
Claes Redestad has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the
On Wed, 10 Feb 2021 23:38:51 GMT, Naoto Sato wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add comment about removing the generic ISO2022.Decoder
>
> Thanks. The newly added comment to ISO2022 is helpful.
On Tue, 9 Feb 2021 12:54:12 GMT, Claes Redestad wrote:
> This refactor some `sun.nio.cs.ext` charsets, such as ISO-2022-CN-GB,
> ISO-2022-CN-CNS, ISO-2022-KR and a few others to use static rather than
> per-instance auxiliary decoders. Doing so reduce overheads of calling
>
On Mon, 8 Feb 2021 09:17:46 GMT, Aleksey Shipilev wrote:
> After JDK-8254702, SonarCloud instance complains about blocks like these:
> "Change this loop body so that it can be executed more than once."
>
> int initJvmlLauncherData(JvmlLauncherData* ptr) const {
> // Store path to
On Thu, 11 Feb 2021 14:27:19 GMT, Roger Riggs wrote:
>> Marked as reviewed by rriggs (Reviewer).
>
> As proposed, events are only created if there is a serialFilter in effect
> (and enabled by JFR configuration).
> Being able to create the events without a serialFilter in effect would be
>
> This issue adds a new event to improve diagnostic information of Java
> deserialization. The event captures the details of deserialization activity
> from ObjectInputStream. The event details are similar to that of the serial
> filter, but is agnostic of whether a filter is installed or not.
On Thu, 11 Feb 2021 15:28:07 GMT, Chris Hegarty wrote:
>> This issue adds a new event to improve diagnostic information of Java
>> deserialization. The event captures the details of deserialization activity
>> from ObjectInputStream. The event details are similar to that of the serial
>>
> This issue adds a new event to improve diagnostic information of Java
> deserialization. The event captures the details of deserialization activity
> from ObjectInputStream. The event details are similar to that of the serial
> filter, but is agnostic of whether a filter is installed or not.
On Thu, 11 Feb 2021 15:28:07 GMT, Chris Hegarty wrote:
>> This issue adds a new event to improve diagnostic information of Java
>> deserialization. The event captures the details of deserialization activity
>> from ObjectInputStream. The event details are similar to that of the serial
>>
On Thu, 11 Feb 2021 15:45:33 GMT, Daniel Fuchs wrote:
>> Chris Hegarty has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix failing test
>
> src/jdk.jfr/share/classes/jdk/jfr/events/DeserializationEvent.java line 42:
>
>> 40:
>> 41:
> This PR is to introduce a new random number API for the JDK. The primary API
> is found in RandomGenerator and RandomGeneratorFactory. Further description
> can be found in the JEP https://openjdk.java.net/jeps/356 .
>
> javadoc can be found at
>
On Thu, 11 Feb 2021 15:53:06 GMT, Chris Hegarty wrote:
>> This issue adds a new event to improve diagnostic information of Java
>> deserialization. The event captures the details of deserialization activity
>> from ObjectInputStream. The event details are similar to that of the serial
>>
On Thu, 11 Feb 2021 15:53:06 GMT, Chris Hegarty wrote:
>> This issue adds a new event to improve diagnostic information of Java
>> deserialization. The event captures the details of deserialization activity
>> from ObjectInputStream. The event details are similar to that of the serial
>>
On Thu, 11 Feb 2021 17:46:06 GMT, Roger Riggs wrote:
>> @kevinrushforth I think you are correct. This is actually mea culpa I think
>> as I had provided in a Slack thread a failed attempt at a patch for this
>> which contained this comment.
>
> So the words "other than" are too subtle?
It's a
On Thu, 11 Feb 2021 17:49:09 GMT, Kevin Rushforth wrote:
>> So the words "other than" are too subtle?
>
> It's a double negative, unless I'm reading it incorrectly: "other than
> pre-10.16" I interpret as "not pre-10.16" or "10.16".
`// Copy out the char* if running on version 10.x, where x <
A trivial fix to ProblemList
jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java
in order to reduce noise in the JDK17 CI.
-
Commit messages:
- 8261604: ProblemList jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java
Changes: https://git.openjdk.java.net/jdk/pull/2531/files
On Mac Os X, the OSVersionTest detected a difference in the version number
reported in the os.version property
and the version number provided by `sw_vers -productVersion`.
When the java runtime is built with XCode 11.3, the os.version is reported as
10.16
though the current version numbering
On Thu, 11 Feb 2021 17:14:35 GMT, Roger Riggs wrote:
> On Mac Os X, the OSVersionTest detected a difference in the version number
> reported in the os.version property
> and the version number provided by `sw_vers -productVersion`.
>
> When the java runtime is built with XCode 11.3, the
On Thu, 11 Feb 2021 04:37:34 GMT, Stuart Marks wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typos in javadoc tags found during review.
>
> src/java.base/share/classes/java/util/Comparator.java line 159:
>
>>
On Thu, 11 Feb 2021 17:55:13 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList
> jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java
> in order to reduce noise in the JDK17 CI.
This pull request has now been integrated.
Changeset: 75c8489c
Author:Daniel D. Daugherty
URL:
On Thu, 11 Feb 2021 18:04:31 GMT, Harold Seigel wrote:
>> A trivial fix to ProblemList
>> jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java
>> in order to reduce noise in the JDK17 CI.
>
> Looks good and trivial.
> Thanks, Harold
@hseigel - Thanks for the fast review!
-
PR:
On Thu, 11 Feb 2021 17:31:34 GMT, Kevin Rushforth wrote:
>> On Mac Os X, the OSVersionTest detected a difference in the version number
>> reported in the os.version property
>> and the version number provided by `sw_vers -productVersion`.
>>
>> When the java runtime is built with XCode 11.3,
On Thu, 11 Feb 2021 04:14:08 GMT, Stuart Marks wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typos in javadoc tags found during review.
>
> src/java.base/share/classes/java/lang/Comparable.java line 110:
>
>>
On Thu, 11 Feb 2021 17:38:42 GMT, Brian Burkhalter wrote:
>> src/java.base/macosx/native/libjava/java_props_macosx.c line 250:
>>
>>> 248:
>>> 249: NSString *nsVerStr;
>>> 250: // Copy out the char* if running on version other than
>>> pre-10.16 Mac OS (10.16 == 11.x)
>>
>>
On Thu, 11 Feb 2021 04:19:29 GMT, Stuart Marks wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typos in javadoc tags found during review.
>
> src/java.base/share/classes/java/lang/Object.java line 149:
>
>> 147:
On Thu, 11 Feb 2021 17:55:13 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList
> jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java
> in order to reduce noise in the JDK17 CI.
Looks good and trivial.
Thanks, Harold
-
Marked as reviewed by hseigel (Reviewer).
PR:
> On Mac Os X, the OSVersionTest detected a difference in the version number
> reported in the os.version property
> and the version number provided by `sw_vers -productVersion`.
>
> When the java runtime is built with XCode 11.3, the os.version is reported as
> 10.16
> though the current
On Thu, 11 Feb 2021 17:50:20 GMT, Brian Burkhalter wrote:
>> It's a double negative, unless I'm reading it incorrectly: "other than
>> pre-10.16" I interpret as "not pre-10.16" or "10.16".
>
> `// Copy out the char* if running on version 10.x[.y], where x < 16` ?
It will also do it if running
On Thu, 11 Feb 2021 18:34:54 GMT, Roger Riggs wrote:
>> On Mac Os X, the OSVersionTest detected a difference in the version number
>> reported in the os.version property
>> and the version number provided by `sw_vers -productVersion`.
>>
>> When the java runtime is built with XCode 11.3, the
On Fri, 12 Feb 2021 04:06:55 GMT, Naoto Sato wrote:
>> Please review this doc fix to j.l.Character, which now includes the table of
>> the history of supported Unicode versions. A corresponding CSR will be filed
>> accordingly.
>
> Naoto Sato has updated the pull request incrementally with one
On Wed, 3 Feb 2021 22:42:00 GMT, Ian Graves wrote:
> Updating the specification to reflect well-established behavior in Formatter
> when incorrect flags used for `%`.
Marked as reviewed by smarks (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2389
> A follow-up of sorts to JDK-8257086, this change aims to improve the
> discussion of the relationship between Object.equals and compareTo and
> compare methods. The not-consistent-with-equals natural ordering of
> BigDecimal get more explication too. While updating Object, I added some uses
On Thu, 11 Feb 2021 19:09:52 GMT, Kevin Rushforth wrote:
>> src/java.base/macosx/native/libjava/java_props_macosx.c line 262:
>>
>>> 260: // Copy out the char*
>>> 261: osVersionCStr = strdup([nsVerStr UTF8String]);
>>> 262: } else if
On Thu, 11 Feb 2021 17:14:35 GMT, Roger Riggs wrote:
> On Mac Os X, the OSVersionTest detected a difference in the version number
> reported in the os.version property
> and the version number provided by `sw_vers -productVersion`.
>
> When the java runtime is built with XCode 11.3, the
On Thu, 11 Feb 2021 18:53:08 GMT, Kevin Rushforth wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Correct double-negative in 'other than 10.16'
>
> src/java.base/macosx/native/libjava/java_props_macosx.c line 262:
On Thu, 11 Feb 2021 19:23:55 GMT, Roger Riggs wrote:
>> On Mac Os X, the OSVersionTest detected a difference in the version number
>> reported in the os.version property
>> and the version number provided by `sw_vers -productVersion`.
>>
>> When the java runtime is built with XCode 11.3, the
On Thu, 11 Feb 2021 19:23:55 GMT, Roger Riggs wrote:
>> On Mac Os X, the OSVersionTest detected a difference in the version number
>> reported in the os.version property
>> and the version number provided by `sw_vers -productVersion`.
>>
>> When the java runtime is built with XCode 11.3, the
On Thu, 28 Jan 2021 22:33:53 GMT, Liam Miller-Cushon wrote:
> Please review this fix to add `ElementType.MODULE` to the default list of
> annotation targets, to allow annotations without an explicit `@Target` to be
> used on module declarations.
This pull request has been closed without being
On Tue, 9 Feb 2021 13:31:25 GMT, Severin Gehwolf wrote:
>> This is an enhancement which solves two issues:
>>
>> 1. Multiple reads of relevant cgroup interface files. Now interface files
>> are only read once per file (just like Hotspot).
>> 2. Proxies creation of the impl specific subsystem
> On Mac Os X, the OSVersionTest detected a difference in the version number
> reported in the os.version property
> and the version number provided by `sw_vers -productVersion`.
>
> When the java runtime is built with XCode 11.3, the os.version is reported as
> 10.16
> though the current
On Fri, 12 Feb 2021 03:16:02 GMT, Jaikiran Pai wrote:
>> I'd let it sit for a bit in case others want to comment.
>
> Ping. Anymore reviews/suggestions from anyone?
Did you run this through the usual CI tests in all tiers?
-
PR: https://git.openjdk.java.net/jdk/pull/2326
On Fri, 12 Feb 2021 03:21:04 GMT, Brian Burkhalter wrote:
> Did you run this through the usual CI tests in all tiers?
Hello Brian,
Do you mean other than the ones that have been automatically run and passed in
the GitHub actions against this PR? I don't have a Windows box, but if there's
> Please review this doc fix to j.l.Character, which now includes the table of
> the history of supported Unicode versions. A corresponding CSR will be filed
> accordingly.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Removed
> Please review this clarification of the specification of the method
> `skip(long)` in `java.io.Reader` and its subclasses. Specifically, the
> behavior of the method is made clear for the case when the `Reader` is
> already at the end of its stream when the method is invoked. A corresponding
On Thu, 11 Feb 2021 12:44:54 GMT, Claes Redestad wrote:
>> This patch moves some sanity checking done in ClassLoader.java to the
>> corresponding endpoints in native or VM code.
>
> Claes Redestad has updated the pull request incrementally with one additional
> commit since the last revision:
Please review this doc fix to j.l.Character, which now includes the table of
the history of supported Unicode versions. A corresponding CSR will be filed
accordingly.
-
Commit messages:
- 8261621: Delegate Unicode history from JLS to j.l.Character
Changes:
On Fri, 12 Feb 2021 02:50:35 GMT, Naoto Sato wrote:
> Please review this doc fix to j.l.Character, which now includes the table of
> the history of supported Unicode versions. A corresponding CSR will be filed
> accordingly.
Looks fine to me.
-
Marked as reviewed by bpb
On Tue, 2 Feb 2021 02:41:10 GMT, Brian Burkhalter wrote:
>>> > The code change looks all right.
>>>
>>> Should I go ahead and integrate this?
>>
>> Actually, I didn't notice that this PR wasn't marked as reviewed. I'll wait
>> for the review(s) then.
>
> I'd let it sit for a bit in case
56 matches
Mail list logo
