On Fri, 12 Feb 2021 12:22:44 GMT, Vladimir Kempik wrote:
>> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 435:
>>
>>> 433: //||\ Java thread created by VM does not
>>> have glibc
>>> 434: //|glibc guard page| - guard, attached Java thread
On Tue, 2 Feb 2021 22:08:14 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 221:
>
>> 219:
On Fri, 5 Feb 2021 09:52:11 GMT, Michael McMahon wrote:
> Could I get the following change reviewed please? It fixes a problem (in
> JEP380) on Windows where some file operations on Unix domain sockets were not
> working and led to the feature being disabled on Windows 2019 Server in JDK
>
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
On Thu, 4 Feb 2021 22:54:42 GMT, Gerard Ziemski wrote:
>> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 363:
>>
>>> 361: address pc = os::Posix::ucontext_get_pc(uc);
>>> 362:
>>> 363: if (pc != addr && uc->context_esr == 0x924F) { //TODO: figure
>>> out what this value
On Tue, 2 Feb 2021 22:12:07 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 435:
>
>> 433: //
Hi Patrick,
"Iterable" is Ok as runtime type of the classical instanceof but not in a type
pattern where it is a raw type,
so
if (e instanceof Iterable elements) {
should be
if (e instanceof Iterable elements) {
regards,
Rémi
- Mail original -
> De: "Patrick Concannon"
> À:
On Thu, 4 Feb 2021 21:59:02 GMT, Gerard Ziemski wrote:
>> Anton Kozlov has updated the pull request incrementally with six additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos
>> - Add comments to WX transitions
>>
>>
On Tue, 2 Feb 2021 22:07:15 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 195:
>
>> 193: frame
On Tue, 9 Feb 2021 14:33:22 GMT, Matthias Baesken wrote:
> JDK-8261422: Adjust problematic String.format calls in
> jdk/internal/util/Preconditions.java outOfBoundsMessage
As we're potentially formatting any "Number" type here, theoretically floats
could be passed which would result in an
> Hi,
>
> Could someone please review my changeset for JDK-8252399: 'Update mapMulti
> documentation to use type test pattern instead of instanceof once JEP 375
> exits preview' ?
>
> This change updates the example code displayed in the API documentation for
> mapMulti to use the type test
On Fri, 12 Feb 2021 11:54:30 GMT, Daniel Fuchs wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8252399: Corrected Expand Iterable Example
>
> test/jdk/java/util/stream/examples/JavadocExamples.java line 59:
>
On Fri, 12 Feb 2021 10:19:03 GMT, Severin Gehwolf wrote:
>> Hi Severin,
>> Thanks for doing this! Sorry for taking so long to review this change. The
>> change looks good. Before pushing it, could you add a comment explaining
>> what the code in lines 185-194 of CgroupSubsystemFactory.java
On Thu, 11 Feb 2021 09:19:05 GMT, Michael McMahon wrote:
>> Could I get the following change reviewed please? It fixes a problem (in
>> JEP380) on Windows where some file operations on Unix domain sockets were
>> not working and led to the feature being disabled on Windows 2019 Server in
>>
On Wed, 3 Feb 2021 09:11:50 GMT, Andrew Haley wrote:
>> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 323:
>>
>>> 321: str(zr, Address(rthread, JavaThread::last_Java_pc_offset()));
>>> 322:
>>> 323: str(zr, Address(rthread,
>>> JavaFrameAnchor::saved_fp_address_offset()));
>>
On Thu, 11 Feb 2021 19:51:43 GMT, Harold Seigel wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains seven additional
>>
Hi,
Could someone please review my changeset for JDK-8252399: 'Update mapMulti
documentation to use type test pattern instead of instanceof once JEP 375 exits
preview' ?
This change updates the example code displayed in the API documentation for
mapMulti to use the type test pattern
On Thu, 4 Feb 2021 22:49:23 GMT, Gerard Ziemski wrote:
>> Anton Kozlov has updated the pull request incrementally with six additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos
>> - Add comments to WX transitions
>>
>>
On Fri, 12 Feb 2021 04:06:55 GMT, Naoto Sato wrote:
>> Please review this doc fix to j.l.Character, which now includes the table of
>> the history of supported Unicode versions. A corresponding CSR will be filed
>> accordingly.
>
> Naoto Sato has updated the pull request incrementally with one
On Tue, 2 Feb 2021 22:14:42 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 486:
>
>> 484:
On Fri, 12 Feb 2021 11:46:09 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my changeset for JDK-8252399: 'Update mapMulti
> documentation to use type test pattern instead of instanceof once JEP 375
> exits preview' ?
>
> This change updates the example code displayed
> Hi,
>
> Could someone please review my changeset for JDK-8252399: 'Update mapMulti
> documentation to use type test pattern instead of instanceof once JEP 375
> exits preview' ?
>
> This change updates the example code displayed in the API documentation for
> mapMulti to use the type test
> This is an enhancement which solves two issues:
>
> 1. Multiple reads of relevant cgroup interface files. Now interface files are
> only read once per file (just like Hotspot).
> 2. Proxies creation of the impl specific subsystem via `determineType()` as
> before, but now reads all relevant
> Hi,
>
> Could someone please review my changeset for JDK-8252399: 'Update mapMulti
> documentation to use type test pattern instead of instanceof once JEP 375
> exits preview' ?
>
> This change updates the example code displayed in the API documentation for
> mapMulti to use the type test
On Fri, 12 Feb 2021 16:26:09 GMT, Chris Hegarty wrote:
>> This issue adds a new event to improve diagnostic information of Java
>> deserialization. The event captures the details of deserialization activity
>> from ObjectInputStream. The event details are similar to that of the serial
>>
> Hi,
>
> Could someone please review my changeset for JDK-8252399: 'Update mapMulti
> documentation to use type test pattern instead of instanceof once JEP 375
> exits preview' ?
>
> This change updates the example code displayed in the API documentation for
> mapMulti to use the type test
On Fri, 12 Feb 2021 11:46:09 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my changeset for JDK-8252399: 'Update mapMulti
> documentation to use type test pattern instead of instanceof once JEP 375
> exits preview' ?
>
> This change updates the example code displayed
On Thu, 11 Feb 2021 16:02:09 GMT, Roger Riggs wrote:
>> Chris Hegarty has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Filter **C**onfigured
>
> Marked as reviewed by rriggs (Reviewer).
Speaking to Erik offline, he suggested to split
> This issue adds a new event to improve diagnostic information of Java
> deserialization. The event captures the details of deserialization activity
> from ObjectInputStream. The event details are similar to that of the serial
> filter, but is agnostic of whether a filter is installed or not.
On Fri, 12 Feb 2021 16:03:09 GMT, Roger Riggs wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8247918: Change'ns' to 'n' in the skip doc
>
> src/java.base/share/classes/java/io/LineNumberReader.java line 270:
On Thu, 11 Feb 2021 17:14:35 GMT, Roger Riggs wrote:
> On Mac Os X, the OSVersionTest detected a difference in the version number
> reported in the os.version property
> and the version number provided by `sw_vers -productVersion`.
>
> When the java runtime is built with XCode 11.3, the
> Please review this clarification of the specification of the method
> `skip(long)` in `java.io.Reader` and its subclasses. Specifically, the
> behavior of the method is made clear for the case when the `Reader` is
> already at the end of its stream when the method is invoked. A corresponding
On Tue, 9 Feb 2021 12:35:27 GMT, Chris Hegarty wrote:
> This issue adds a new event to improve diagnostic information of Java
> deserialization. The event captures the details of deserialization activity
> from ObjectInputStream. The event details are similar to that of the serial
> filter,
I would be all right with that.
> On Feb 12, 2021, at 9:45 AM, liach
> wrote:
>
> On Fri, 12 Feb 2021 16:11:58 GMT, Roger Riggs wrote:
>
>>> Brian Burkhalter has updated the pull request incrementally with one
>>> additional commit since the last revision:
>>>
>>> 8247918: Change'ns' to
On Fri, 12 Feb 2021 16:26:09 GMT, Chris Hegarty wrote:
>> This issue adds a new event to improve diagnostic information of Java
>> deserialization. The event captures the details of deserialization activity
>> from ObjectInputStream. The event details are similar to that of the serial
>>
On Fri, 12 Feb 2021 16:13:04 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed empty tag
>
> src/java.base/share/classes/java/lang/Character.java line 86:
>
>> 84: * Unicode 10.0
>>
On Fri, 15 Jan 2021 07:14:49 GMT, Richard Fussenegger
wrote:
>> Often an enhancement is created when there's an idea of an improvement but
>> no resources to do the research and develop a justification. That work has
>> to be done when someone has time. Usually ideas are discussed on one of
On Fri, 12 Feb 2021 15:51:59 GMT, Roger Riggs wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8247918: Change'ns' to 'n' in the skip doc
>
> src/java.base/share/classes/java/io/StringReader.java line 108:
>
On Fri, 12 Feb 2021 04:06:55 GMT, Naoto Sato wrote:
>> Please review this doc fix to j.l.Character, which now includes the table of
>> the history of supported Unicode versions. A corresponding CSR will be filed
>> accordingly.
>
> Naoto Sato has updated the pull request incrementally with one
On Fri, 12 Feb 2021 16:26:09 GMT, Chris Hegarty wrote:
>> This issue adds a new event to improve diagnostic information of Java
>> deserialization. The event captures the details of deserialization activity
>> from ObjectInputStream. The event details are similar to that of the serial
>>
On Wed, 3 Feb 2021 22:42:00 GMT, Ian Graves wrote:
> Updating the specification to reflect well-established behavior in Formatter
> when incorrect flags used for `%`.
This pull request has now been integrated.
Changeset: 350303d4
Author:Ian Graves
Committer: Stuart Marks
URL:
On Fri, 12 Feb 2021 01:18:53 GMT, Brian Burkhalter wrote:
>> Please review this clarification of the specification of the method
>> `skip(long)` in `java.io.Reader` and its subclasses. Specifically, the
>> behavior of the method is made clear for the case when the `Reader` is
>> already at
On Fri, 12 Feb 2021 16:26:09 GMT, Chris Hegarty wrote:
>> This issue adds a new event to improve diagnostic information of Java
>> deserialization. The event captures the details of deserialization activity
>> from ObjectInputStream. The event details are similar to that of the serial
>>
On Fri, 12 Feb 2021 16:11:58 GMT, Roger Riggs wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8247918: Change'ns' to 'n' in the skip doc
>
> The use of @ inheritdoc causes some unexpected changes in the
On Wed, 10 Feb 2021 14:08:22 GMT, PROgrm_JARvis
wrote:
>>> Hi Claes,
>>> Would flattening the state of MD5 bring any further improvements?
>>> [plevart@92bf48f](https://github.com/plevart/jdk/commit/92bf48ff58f0ce9648e49466dbf1befebbf49083)
>>
>> I think it might, marginally, but it seemed to
> Hi,
>
> Could someone please review my changeset for JDK-8252399: 'Update mapMulti
> documentation to use type test pattern instead of instanceof once JEP 375
> exits preview' ?
>
> This change updates the example code displayed in the API documentation for
> mapMulti to use the type test
On Fri, 12 Feb 2021 21:32:04 GMT, Andrey Turbanov
wrote:
>> ## java/net/MulticastSocket/SetLoopbackMode.java
>>
>> make test
>> TEST="jtreg:test/jdk/java/net/MulticastSocket/SetLoopbackMode.java"
>>
>>
>> STDOUT:
>> IPv6 can be used
>> Default network interface: null
On Fri, 12 Feb 2021 21:04:54 GMT, Andrey Turbanov
wrote:
>> I rebased my changes onto master. (commit
>> 837bd8930d0a010110f1318b947c036609d3aa33)
>> and checked tier2 and tier3.
>> What I got:
>>
>> ==
>> Test summary
>> ==
On Mon, 8 Feb 2021 16:39:55 GMT, Julia Boes wrote:
>> The other security-related code changes look good to me.
>
> I've updated the issue summary to better reflect the changes, the PR summary
> should be renamed accordingly.
> As mentioned earlier, have you run the tests for the affected
On Fri, 12 Feb 2021 21:03:04 GMT, Andrey Turbanov
wrote:
>> I've updated the issue summary to better reflect the changes, the PR summary
>> should be renamed accordingly.
>> As mentioned earlier, have you run the tests for the affected areas? Here's
>> some information on how to do that:
>>
On Thu, 11 Feb 2021 04:12:06 GMT, Stuart Marks wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typos in javadoc tags found during review.
>
> src/java.base/share/classes/java/lang/Comparable.java line 90:
>
>>
On Fri, 12 Feb 2021 21:53:13 GMT, Andrey Turbanov
wrote:
>> ## java/nio/file/Files/CopyAndMove.java
>>
>> make test TEST="jtreg:java/nio/file/Files/CopyAndMove.java"
>>
>> STDOUT:
>> Seed from RandomFactory = 704532001916725417L
>> STDERR:
>> dir1:
>>
On Tue, 9 Feb 2021 16:04:02 GMT, stefan-zobel
wrote:
>> I haven't written the class Preconditions.java, this question should
>> probably go to the authors .
>> I found the String.format syntax a bit unusual, should this be rewritten ?
>
> AFAIK, Preconditions was introduced in
>
Adds a property similar to 'isStandalone' in JDK-8249867.
Please note that the test received an auto-format. The material changes were
the two tests marked with bug id 8260858 and related data and methods.
-
Commit messages:
- JDK-8260858: Implementation specific property
> Hi,
>
> Could someone please review my changeset for JDK-8252399: 'Update mapMulti
> documentation to use type test pattern instead of instanceof once JEP 375
> exits preview' ?
>
> This change updates the example code displayed in the API documentation for
> mapMulti to use the type test
On Fri, 12 Feb 2021 17:03:57 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/lang/Character.java line 86:
>>
>>> 84: * Unicode 10.0
>>> 85: * Java SE 9
>>> 86: * Unicode 8.0
>>
>> Do we really need the history in the API docs? Will will update this table
>> if there is a
On Thu, 11 Feb 2021 04:22:18 GMT, Stuart Marks wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typos in javadoc tags found during review.
>
> src/java.base/share/classes/java/lang/Object.java line 236:
>
>> 234:
On Fri, 12 Feb 2021 21:06:24 GMT, Andrey Turbanov
wrote:
>> Then I tried to run tests separately:
>> ## java/io/File/GetXSpace.java
>>
>>
>> make test TEST="jtreg:test/jdk/java/io/File/GetXSpace.java"
>>
>> STDERR:
>> java.nio.file.InvalidPathException: Illegal char <:> at index
On Fri, 12 Feb 2021 20:29:28 GMT, Joe Darcy wrote:
>> This was requested by Alex, and I thought it sounded reasonable and
>> informative. I think if an MR upgrades the supported Unicode version, it
>> should be listed here.
>
> Should some acknowledgement be made to the changes in Unicode
On Fri, 12 Feb 2021 22:28:33 GMT, Joe Darcy wrote:
>> src/java.base/share/classes/java/lang/Object.java line 236:
>>
>>> 234: * be a concise but informative representation that is easy for a
>>> 235: * person to read.
>>> 236: * It is recommended that all subclasses override this
> A follow-up of sorts to JDK-8257086, this change aims to improve the
> discussion of the relationship between Object.equals and compareTo and
> compare methods. The not-consistent-with-equals natural ordering of
> BigDecimal get more explication too. While updating Object, I added some uses
On Fri, 12 Feb 2021 22:12:30 GMT, Joe Darcy wrote:
>> src/java.base/share/classes/java/lang/Comparable.java line 90:
>>
>>> 88: * of the {@code equals} method and the equivalence classes defined by
>>> 89: * the quotient of the {@code compareTo} method are the same.
>>> 90: *
>>
>> I think
On Fri, 12 Feb 2021 22:52:06 GMT, Joe Darcy wrote:
>> A follow-up of sorts to JDK-8257086, this change aims to improve the
>> discussion of the relationship between Object.equals and compareTo and
>> compare methods. The not-consistent-with-equals natural ordering of
>> BigDecimal get more
On Fri, 12 Feb 2021 21:12:14 GMT, Andrey Turbanov
wrote:
>> ## java/net/MulticastSocket/MulticastAddresses.java
>>
>> make test
>> TEST="jtreg:test/jdk/java/net/MulticastSocket/MulticastAddresses.java"
>>
>> STDOUT:
>> Test: /224.80.80.80 ni: name:eth1 (PANGP Virtual Ethernet
On Thu, 11 Feb 2021 04:09:16 GMT, Stuart Marks wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typos in javadoc tags found during review.
>
> src/java.base/share/classes/java/lang/Comparable.java line 68:
>
>>
On Fri, 12 Feb 2021 02:10:02 GMT, Coleen Phillimore wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Consolidate verifyClassname and verifyFixClassname
>
> This more limited cleanup looks good.
This patch
> A follow-up of sorts to JDK-8257086, this change aims to improve the
> discussion of the relationship between Object.equals and compareTo and
> compare methods. The not-consistent-with-equals natural ordering of
> BigDecimal get more explication too. While updating Object, I added some uses
On Fri, 12 Feb 2021 22:39:55 GMT, Roger Riggs wrote:
>> Added "The string output is not necessary stable over time." The particulars
>> of the toString contract of a given class will depend on the class of course.
>
> Perhaps "necessary" -> "necessarily"
Good catch Roger; will change to
"The
On Thu, 11 Feb 2021 04:44:08 GMT, Stuart Marks wrote:
>> src/java.base/share/classes/java/math/BigDecimal.java line 97:
>>
>>> 95: * contrast, the {@link equals equals} method requires both the
>>> 96: * numerical value and representation to be the same for equality to
>>> 97: * hold.
>>
>>
On Sat, 30 Jan 2021 14:35:50 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which proposes to fix the issue
> reported in https://bugs.openjdk.java.net/browse/JDK-8260401?
>
> As noted in that issue, when the constructor of
> `java.util.prefs.WindowsPreferences` runs
On Thu, 11 Feb 2021 04:17:48 GMT, Stuart Marks wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typos in javadoc tags found during review.
>
> src/java.base/share/classes/java/lang/Object.java line 135:
>
>> 133:
On Fri, 12 Feb 2021 03:34:54 GMT, Jaikiran Pai wrote:
>> Did you run this through the usual CI tests in all tiers?
>
>> Did you run this through the usual CI tests in all tiers?
>
> Hello Brian,
>
> Do you mean other than the ones that have been automatically run and passed
> in the GitHub
On Fri, 12 Feb 2021 23:40:51 GMT, Brian Burkhalter wrote:
>> Can I please get a review for this change which proposes to fix the issue
>> reported in https://bugs.openjdk.java.net/browse/JDK-8260401?
>>
>> As noted in that issue, when the constructor of
>> `java.util.prefs.WindowsPreferences`
On Sat, 30 Jan 2021 14:35:50 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which proposes to fix the issue
> reported in https://bugs.openjdk.java.net/browse/JDK-8260401?
>
> As noted in that issue, when the constructor of
> `java.util.prefs.WindowsPreferences` runs
> Implement three optimiztations for Reader.read(CharBuffer)
>
> * Add a code path for heap buffers in Reader#read to use the backing array
> instead of allocating a new one.
> * Change the code path for direct buffers in Reader#read to limit the
> intermediate allocation to
On Wed, 10 Feb 2021 21:58:02 GMT, Brian Burkhalter wrote:
>> That would be possible. It would help in cases where a large Reader is read
>> into one or several relatively small off-heap CharBuffers, requiring
>> multiple #read calls. This can only be done when the caller is able to work
>>
76 matches
Mail list logo
