On Fri, 30 Jul 2021 17:22:59 GMT, Lance Andersen wrote:
>> Hi,
>>
>> As discussed in the
>> https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-July/079621.html
>> thread, this is the revised patch to address the use of '.' and '..' within
>> Zip FS
>>
>> Zip FS needs to use "." and "
On Fri, 30 Jul 2021 12:09:30 GMT, Alan Bateman wrote:
> Just on naming, the existing channel implementations use "dst" for the
> destination and "wbc" (not "oc") for writable byte channels. Just mentioning
> it so that the new code can be kept consistent where possible.
I have renamed `dest` t
> This PR-*draft* is **work in progress** and an invitation to discuss a
> possible solution for issue
> [JDK-8265891](https://bugs.openjdk.java.net/browse/JDK-8265891). It is *not
> yet* intended for a final review.
>
> As proposed in JDK-8265891, this PR provides an implementation for
> `Cha
> This PR-*draft* is **work in progress** and an invitation to discuss a
> possible solution for issue
> [JDK-8265891](https://bugs.openjdk.java.net/browse/JDK-8265891). It is *not
> yet* intended for a final review.
>
> As proposed in JDK-8265891, this PR provides an implementation for
> `Cha
> This PR-*draft* is **work in progress** and an invitation to discuss a
> possible solution for issue
> [JDK-8265891](https://bugs.openjdk.java.net/browse/JDK-8265891). It is *not
> yet* intended for a final review.
>
> As proposed in JDK-8265891, this PR provides an implementation for
> `Cha
On Sat, 31 Jul 2021 13:12:54 GMT, Markus KARG
wrote:
>> Is this loop correct for the case that the channel gets truncated? In that
>> case transferTo will return 0 as no bytes will be transferred and I'm
>> concerned this code will go into an infinite loop.
>>
>> Also can you can check that I
> This PR-*draft* is **work in progress** and an invitation to discuss a
> possible solution for issue
> [JDK-8265891](https://bugs.openjdk.java.net/browse/JDK-8265891). It is *not
> yet* intended for a final review.
>
> As proposed in JDK-8265891, this PR provides an implementation for
> `Cha
On Sat, 31 Jul 2021 14:39:02 GMT, Markus KARG
wrote:
>>> Just on naming, the existing channel implementations use "dst" for the
>>> destination and "wbc" (not "oc") for writable byte channels. Just
>>> mentioning it so that the new code can be kept consistent where possible.
>>
>> I have rena
On Sat, 31 Jul 2021 15:58:07 GMT, Markus KARG
wrote:
>>> Is this loop correct for the case that the channel gets truncated? In that
>>> case transferTo will return 0 as no bytes will be transferred and I'm
>>> concerned this code will go into an infinite loop.
>>
>> Good catch, indeed missed
> Hi all,
>
> could you please review this big tedious and trivial(-ish) patch which moves
> `sun.hotspot.WhiteBox` and related classes to `jdk.test.whitebox` package?
>
> the majority of the patch is the following substitutions:
> - `s~sun/hotspot/WhiteBox~jdk/test/whitebox/WhiteBox~g`
> - `s
On Sat, 31 Jul 2021 20:42:10 GMT, Igor Ignatyev wrote:
>> Hi all,
>>
>> could you please review this big tedious and trivial(-ish) patch which moves
>> `sun.hotspot.WhiteBox` and related classes to `jdk.test.whitebox` package?
>>
>> the majority of the patch is the following substitutions:
>>
On Sat, 31 Jul 2021 17:33:50 GMT, Alan Bateman wrote:
> I need to look at it closely but I suspect this introduces a potential
> overflow. Also if output stream is backed by a SocketChannel configured
> non-blocking then FC::transferTo may return 0 so I assume there is a
> potential infinite l
On Thu, 29 Jul 2021 06:33:38 GMT, David Holmes wrote:
>> Short: this patch makes NMT available in custom-launcher scenarios and
>> during gtests. It simplifies NMT initialization. It adds a lot of
>> NMT-specific testing, cleans them up and makes them sideeffect-free.
>>
>> -
>>
>> NM
13 matches
Mail list logo
