On Wed, 15 Sep 2021 10:29:36 GMT, Aleksey Shipilev wrote:
> Happens with Zero tests:
>
>
> $ CONF=linux-x86_64-zero-fastdebug make exploded-test
> TEST=compiler/codecache/CheckSegmentedCodeCache.java
> ...
>
> java.lang.NullPointerException: Cannot invoke
>
On Wed, 15 Sep 2021 10:29:36 GMT, Aleksey Shipilev wrote:
> Happens with Zero tests:
>
>
> $ CONF=linux-x86_64-zero-fastdebug make exploded-test
> TEST=compiler/codecache/CheckSegmentedCodeCache.java
> ...
>
> java.lang.NullPointerException: Cannot invoke
>
On Thu, 9 Sep 2021 09:21:59 GMT, Matthias Baesken wrote:
> https://bugs.openjdk.java.net/browse/JDK-8266490
> extended the OSContainer API in order to also support the pids controller of
> cgroups. However only pids.max output was added with 8266490.
> There is a second parameter pids.current ,
On Wed, 1 Sep 2021 01:05:32 GMT, Mandy Chung wrote:
>> This reimplements core reflection with method handles.
>>
>> For `Constructor::newInstance` and `Method::invoke`, the new implementation
>> uses `MethodHandle`. For `Field` accessor, the new implementation uses
>> `VarHandle`.For the
On Wed, 1 Sep 2021 01:05:32 GMT, Mandy Chung wrote:
>> This reimplements core reflection with method handles.
>>
>> For `Constructor::newInstance` and `Method::invoke`, the new implementation
>> uses `MethodHandle`. For `Field` accessor, the new implementation uses
>> `VarHandle`.For the
On Wed, 15 Sep 2021 10:16:36 GMT, Aleksey Shipilev wrote:
> This currently manifests if you run Zero with compiler/codecache/cli tests
> (part of tier1):
>
>
> $ CONF=linux-x86_64-zero-fastdebug make exploded-test
> TEST=compiler/codecache/cli/
>
> STDERR:
> java.lang.RuntimeException:
On Wed, 15 Sep 2021 10:16:36 GMT, Aleksey Shipilev wrote:
> This currently manifests if you run Zero with compiler/codecache/cli tests
> (part of tier1):
>
>
> $ CONF=linux-x86_64-zero-fastdebug make exploded-test
> TEST=compiler/codecache/cli/
>
> STDERR:
> java.lang.RuntimeException:
On Wed, 15 Sep 2021 16:13:56 GMT, Daniel Fuchs wrote:
>> src/java.base/share/classes/java/util/Properties.java line 932:
>>
>>> 930: if (entries instanceof Collections.SynchronizedSet ss
>>> 931: && ss.c instanceof EntrySet) {
>>> 932: entries =
On 16/09/21 4:05 am, Roger Riggs wrote:
On Wed, 15 Sep 2021 21:46:59 GMT, Stuart Marks wrote:
src/java.base/share/classes/java/util/Properties.java line 819:
817: *
818: * If the {@systemProperty java.util.Properties.storeDate} is set and
819: * is non-empty (as determined
On Thu, 16 Sep 2021 13:29:09 GMT, wxiang
wrote:
>> There is a bug for URLClassPath.findResources with JarIndex.
>> Currently, there was agreement on dropping the support from the
>> URLClassLoader implementation but it was suggested that it should be
>> disabled for a release or two before
> There is a bug for URLClassPath.findResources with JarIndex.
> Currently, there was agreement on dropping the support from the
> URLClassLoader implementation but it was suggested that it should be disabled
> for a release or two before the code is removed.
> A system property can be used to
On Thu, 16 Sep 2021 11:08:17 GMT, Alan Bateman wrote:
>> wxiang has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> add isEmpty check
>
> src/java.base/share/classes/jdk/internal/loader/URLClassPath.java line 949:
>
>> 947:
On Thu, 16 Sep 2021 10:14:47 GMT, Julia Boes wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an implementation class whose main
On Wed, 15 Sep 2021 10:02:19 GMT, Aleksey Shipilev wrote:
> As the follow-up for Zero-specific JDK-8273494, we might want to clean up
> build system logic for all VM variants: stop impersonating "server" VMs for
> all of them. This basically leaves "core" and "custom" variants to be handled
>
On Wed, 15 Sep 2021 15:09:45 GMT, Arno Zeller wrote:
>> See the bug report for more details. I would appreciate if people with their
>> corporate testing systems would run this through their systems to avoid
>> surprises. (ping @RealCLanger, @iignatev).
>
> I haven't recognized problems I can
On Thu, 19 Aug 2021 15:15:31 GMT, Aleksey Shipilev wrote:
> See the bug report for more details. I would appreciate if people with their
> corporate testing systems would run this through their systems to avoid
> surprises. (ping @RealCLanger, @iignatev).
Marked as reviewed by iignatyev
On Wed, 15 Sep 2021 22:32:33 GMT, Roger Riggs wrote:
>> This is a clever way to detect whether the `entrySet()` method has been
>> overridden to return something other than the entry-set provided by the
>> Properties class... but I'm wondering if it's too clever. Does anyone who
>> overrides
On Mon, 13 Sep 2021 19:57:14 GMT, Andrey Turbanov
wrote:
> 8273710: Remove redundant stream() call before forEach in jdk.jdeps
Marked as reviewed by shade (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5498
On Mon, 13 Sep 2021 19:57:14 GMT, Andrey Turbanov
wrote:
> 8273710: Remove redundant stream() call before forEach in jdk.jdeps
This pull request has now been integrated.
Changeset: 7e92abe7
Author:Andrey Turbanov
Committer: Aleksey Shipilev
URL:
> The intermittent test in java/lang/ProcessBuilder/Basic.java has identified
> unexpected messages from a child Java VM
> as the cause of the test failure. Attempts to control the output of the
> child VM have failed, the VM is unrepentant .
>
> There is no functionality in the child except
On Thu, 16 Sep 2021 03:44:24 GMT, Remilia Scarlet
wrote:
>> The test assumes that it always runs on 64-bit platform and
>> classes_nocoops.jsa is always created.
>> It's a test bug. The test should only expect classes_nocoops.jsa exists if
>> it's running on a supported 64-bit platform.
>>
On Thu, 16 Sep 2021 17:48:35 GMT, Calvin Cheung wrote:
> The fix in the test case seems fine to me.
This test may fail in other cases. We should prepare for those cases in this
fix:
if (!Platform.isDefaultCDSArchiveSupported() && !Platform.isAArch64()))
throw new SkippedException("not a
On Thu, 16 Sep 2021 03:44:24 GMT, Remilia Scarlet
wrote:
>> The test assumes that it always runs on 64-bit platform and
>> classes_nocoops.jsa is always created.
>> It's a test bug. The test should only expect classes_nocoops.jsa exists if
>> it's running on a supported 64-bit platform.
>>
On Thu, 16 Sep 2021 17:53:25 GMT, Mandy Chung wrote:
> > The fix in the test case seems fine to me.
>
> This test may fail in other cases. We should prepare for those cases in this
> fix:
>
> ```
> if (!Platform.isDefaultCDSArchiveSupported() && !Platform.isAArch64()))
> throw new
On Thu, 1 Jul 2021 12:19:53 GMT, Сергей Цыпанов
wrote:
>> In some JDK classes there's still the following hashCode() implementation:
>>
>> long objNum;
>>
>> public int hashCode() {
>> return (int) objNum;
>> }
>>
>> This outdated expression should be replaced with Long.hashCode(long) as
> Sorting:
>
> - adopt radix sort for sequential and parallel sorts on int/long/float/double
> arrays (almost random and length > 6K)
> - fix tryMergeRuns() to better handle case when the last run is a single
> element
> - minor javadoc and comment changes
>
> Testing:
> - add new data inputs
I also wonder if it makes sense to either only serve files with public
permissions, or at least Filter some critical files like .ssh/* and *.jks.
Those command-line servers are often started „accidentially“ in the home
directory.
--
http://bernd.eckenfels.net
> The test assumes that it always runs on 64-bit platform and
> classes_nocoops.jsa is always created.
> It's a test bug. The test should only expect classes_nocoops.jsa exists if
> it's running on a supported 64-bit platform.
> However, for unknown target platform, it's unknown if it's 64-bit
On Fri, 17 Sep 2021 01:52:30 GMT, Mandy Chung wrote:
>> Remilia Scarlet has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR. The pull request
>> contains one new
I like it, but I think you don’t Need the %n linebreak (at least the other fail
message has none)
--
http://bernd.eckenfels.net
Von: core-libs-dev im Auftrag von Roger
Riggs
Gesendet: Donnerstag, September 16, 2021 6:13 PM
An: core-libs-dev@openjdk.java.net
On Fri, 17 Sep 2021 01:47:05 GMT, Remilia Scarlet
wrote:
>> The test assumes that it always runs on 64-bit platform and
>> classes_nocoops.jsa is always created.
>> It's a test bug. The test should only expect classes_nocoops.jsa exists if
>> it's running on a supported 64-bit platform.
>>
On Fri, 17 Sep 2021 01:47:05 GMT, Remilia Scarlet
wrote:
>> The test assumes that it always runs on 64-bit platform and
>> classes_nocoops.jsa is always created.
>> It's a test bug. The test should only expect classes_nocoops.jsa exists if
>> it's running on a supported 64-bit platform.
>>
> The test assumes that it always runs on 64-bit platform and
> classes_nocoops.jsa is always created.
> It's a test bug. The test should only expect classes_nocoops.jsa exists if
> it's running on a supported 64-bit platform.
> However, for unknown target platform, it's unknown if it's 64-bit
On Fri, 17 Sep 2021 02:17:09 GMT, Remilia Scarlet
wrote:
>> The test assumes that it always runs on 64-bit platform and
>> classes_nocoops.jsa is always created.
>> It's a test bug. The test should only expect classes_nocoops.jsa exists if
>> it's running on a supported 64-bit platform.
>>
> The commit in this PR implements the proposal for enhancement that was
> discussed in the core-libs-dev mailing list recently[1], for
> https://bugs.openjdk.java.net/browse/JDK-8231640
>
> At a high level - the `store()` APIs in `Properties` have been modified to
> now look for the
On Thu, 16 Sep 2021 19:40:19 GMT, Kartik Ohri
wrote:
>> Hi all!
>>
>> Please review this PR to add a benchmark comparing the performance of
>> Arrays.mismatch intrinsic in the JDK with that of the Vector API. Kindly
>> refer to this [thread] on panama-dev regarding some initial discussion
On Mon, 6 Sep 2021 09:39:58 GMT, Alan Bateman wrote:
> No objection to removing this legacy/unused code but I think it would be
> useful to useful to have the JBS issue or the PR summary provide a bit more
> context. As I see it, this is just one piece of the overall cleanup and I
> assume
On Thu, 16 Sep 2021 13:32:08 GMT, wxiang
wrote:
>> There is a bug for URLClassPath.findResources with JarIndex.
>> Currently, there was agreement on dropping the support from the
>> URLClassLoader implementation but it was suggested that it should be
>> disabled for a release or two before
> Hi all!
>
> Please review this PR to add a benchmark comparing the performance of
> Arrays.mismatch intrinsic in the JDK with that of the Vector API. Kindly
> refer to this [thread] on panama-dev regarding some initial discussion about
> this benchmark. I have attached the [results] of the
> The commit in this PR implements the proposal for enhancement that was
> discussed in the core-libs-dev mailing list recently[1], for
> https://bugs.openjdk.java.net/browse/JDK-8231640
>
> At a high level - the `store()` APIs in `Properties` have been modified to
> now look for the
On Mon, 13 Sep 2021 18:05:55 GMT, Paul Sandoz wrote:
>> Hi all!
>>
>> Please review this PR to add a benchmark comparing the performance of
>> Arrays.mismatch intrinsic in the JDK with that of the Vector API. Kindly
>> refer to this [thread] on panama-dev regarding some initial discussion
> Hi all!
>
> Please review this PR to add a benchmark comparing the performance of
> Arrays.mismatch intrinsic in the JDK with that of the Vector API. Kindly
> refer to this [thread] on panama-dev regarding some initial discussion about
> this benchmark. I have attached the [results] of the
On Thu, 16 Sep 2021 22:49:38 GMT, Paul Sandoz wrote:
>> Kartik Ohri has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update benchmark according to code review
>
>
On Wed, 25 Aug 2021 15:52:06 GMT, Igor Ignatyev wrote:
>> See the bug report for more details. I would appreciate if people with their
>> corporate testing systems would run this through their systems to avoid
>> surprises. (ping @RealCLanger, @iignatev).
>
> the testing in our infra returned
On Fri, 17 Sep 2021 05:47:20 GMT, Alan Bateman wrote:
> No objection from me. If issues arise then I assume it can be discussed again
> and we can figure out something that works for whatever CI or environment
> where it is problematic.
Yes, I think if tests start to fail, we look into
On Thu, 16 Sep 2021 01:29:12 GMT, wxiang
wrote:
>> There is a bug for URLClassPath.findResources with JarIndex.
>> Currently, there was agreement on dropping the support from the
>> URLClassLoader implementation but it was suggested that it should be
>> disabled for a release or two before
On Thu, 16 Sep 2021 09:39:25 GMT, Jan Lahoda wrote:
> Marking the test headful if OK - but should `headful` also be added to the
> keys in `test/langtools/TEST.ROOT`? (I am not quite sure how that works.)
AFAICS, this test is in `jdk`, so it is covered by `jdk/TEST.ROOT`. I tested it
with and
This is a GUI test, and it should be `@headful`.
Additional testing:
- [x] Test still runs in default, and does not run with `!headful`
-
Commit messages:
- Fix
Changes: https://git.openjdk.java.net/jdk/pull/5544/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=5544=00
On Thu, 16 Sep 2021 09:13:15 GMT, Aleksey Shipilev wrote:
> This is a GUI test, and it should be `@headful`.
>
> Additional testing:
> - [x] Test still runs in default, and does not run with `!headful`
Marking the test headful if OK - but should `headful` also be added to the keys
in
On Wed, 1 Sep 2021 01:05:32 GMT, Mandy Chung wrote:
>> This reimplements core reflection with method handles.
>>
>> For `Constructor::newInstance` and `Method::invoke`, the new implementation
>> uses `MethodHandle`. For `Field` accessor, the new implementation uses
>> `VarHandle`.For the
On Thu, 16 Sep 2021 09:15:34 GMT, Daniel Fuchs wrote:
>> I can appreciate that and that is a fair point. I guess where I was
>> coming from was that the property is temporary and has to be explicitly
>> specified so ignoring the value seemed worth raising/discussing.
>>
>> Assuming the
> This change implements a simple web server that can be run on the
> command-line with `java -m jdk.httpserver`.
>
> This is facilitated by adding an entry point for the `jdk.httpserver` module,
> an implementation class whose main method is run when the above command is
> executed. This is
On Wed, 15 Sep 2021 19:41:11 GMT, Lance Andersen wrote:
>> I would dislike it if `-Djdk.net.URLClassPath.enableJarIndex=false` meant
>> true...
>
> I can appreciate that and that is a fair point. I guess where I was coming
> from was that the property is temporary and has to be explicitly
On Thu, 16 Sep 2021 01:29:12 GMT, wxiang
wrote:
>> There is a bug for URLClassPath.findResources with JarIndex.
>> Currently, there was agreement on dropping the support from the
>> URLClassLoader implementation but it was suggested that it should be
>> disabled for a release or two before
On Thu, 16 Sep 2021 01:29:12 GMT, wxiang
wrote:
>> There is a bug for URLClassPath.findResources with JarIndex.
>> Currently, there was agreement on dropping the support from the
>> URLClassLoader implementation but it was suggested that it should be
>> disabled for a release or two before
On Thu, 16 Sep 2021 09:33:44 GMT, wxiang
wrote:
>> Given that there is a precedence in this file:
>>
>>
>> p =
>> props.getProperty("jdk.net.URLClassPath.showIgnoredClassPathEntries");
>> DEBUG_CP_URL_CHECK = p != null ? p.equals("true") || p.isEmpty() :
>> false;
>>
>>
>>
56 matches
Mail list logo
