On Tue, 30 Nov 2021 23:35:08 GMT, Paul Sandoz wrote:
>> Remove Vector API scripts for building and running tests. `jtreg` should be
>> used instead.
>>
>> Also updated the test generation script to remove options that assume
>> mercurial as the code repository.
>
> Paul Sandoz has updated the
On Tue, 30 Nov 2021 11:25:48 GMT, Roman Kennke wrote:
>> The caches in ObjectStreamClass basically map WeakReference to
>> SoftReference, where the ObjectStreamClass also
>> references the same Class. That means that the cache entry, and thus the
>> class and its class-loader, will not get
On Wed, 1 Dec 2021 02:29:14 GMT, David Holmes wrote:
> Hi @shipilev , We need to have someone look at the impact of this on our CI.
> I don't think we run the tier4 group as defined in our tier 4 so we may not
> see those execution time savings that offset the extra cost to tier3.
OK, I can
On Tue, 30 Nov 2021 14:52:37 GMT, Alan Bateman wrote:
> Thread.stop is inherently unsafe and has been deprecated since Java 1.2
> (1998). It's time to terminally deprecate this method so it can be degraded
> and removed in the future.
>
> This PR does not propose any changes to the JVM TI
On Wed, 1 Dec 2021 01:37:55 GMT, John Neffenger wrote:
>> Andrew Leonard has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8276766: Enable jar and jmod to produce deterministic timestamped content
>>
>> Signed-off-by: Andrew Leonard
> Add a new --source-date (epoch seconds) option to jar and jmod to
> allow specification of time to use for created/updated jar/jmod entries. This
> then allows the ability to make the content deterministic.
>
> Signed-off-by: Andrew Leonard
Andrew Leonard has updated the pull request
On Wed, 1 Dec 2021 14:47:54 GMT, Roger Riggs wrote:
> Compilation warnings of the test library introduce noise in test output and
> should be addressed or suppressed.
> Changes include:
> - SuppressWarnings("deprecation") and SuppressWarnings("removal")
> - Adding type parameters to Raw
On Thu, 11 Nov 2021 13:59:51 GMT, Jim Laskey wrote:
> The modified ziggurat algorithm is not correctly implemented in
> `java.base/jdk/internal/util/random/RandomSupport.java`.
>
> Create a histogram of a million samples using 2000 uniform bins with the
> following range:
> Exponential
On Wed, 1 Dec 2021 14:21:51 GMT, Jim Laskey wrote:
> > Should there be a regression test here?
>
> I can ask the submitter to provide a new test based on his testing (new JBS
> issue.) The complexity of the test is beyond in house expertise.
Okay.
-
PR:
> Add a new --source-date (epoch seconds) option to jar and jmod to
> allow specification of time to use for created/updated jar/jmod entries. This
> then allows the ability to make the content deterministic.
>
> Signed-off-by: Andrew Leonard
Andrew Leonard has updated the pull request
> Here are the code changes for the "Deprecate finalizers in the standard Java
> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
> review.
>
> This change makes the indicated deprecations, and updates the API spec for
> JEP 421. It also updates the relevant
Before signing, unsign all executables and libraries (not just those in
runtime).
Also, run individual file sign and unsign commands in quiet mode.
Also, add test case to SigningAppImageTest to test that signing app that has
additional launcher works, and results in validly signed launcher and
On Tue, 23 Nov 2021 17:00:58 GMT, Naoto Sato wrote:
> This fix intends to honor the type (std/dst/generic) of parsed zone name for
> selecting the offset at the overlap. Corresponding CSR has also been drafted.
This pull request has now been integrated.
Changeset: a363b7b9
Author:Naoto
On Wed, 1 Dec 2021 17:38:54 GMT, Jim Laskey wrote:
>> The modified ziggurat algorithm is not correctly implemented in
>> `java.base/jdk/internal/util/random/RandomSupport.java`.
>>
>> Create a histogram of a million samples using 2000 uniform bins with the
>> following range:
>> Exponential
On Wed, 1 Dec 2021 18:02:05 GMT, Andrew Leonard wrote:
>> Add a new --source-date (epoch seconds) option to jar and jmod
>> to allow specification of time to use for created/updated jar/jmod entries.
>> This then allows the ability to make the content deterministic.
>>
>> Signed-off-by:
On Wed, 1 Dec 2021 19:59:57 GMT, Alexey Semenyuk wrote:
>> Before signing, unsign all executables and libraries (not just those in
>> runtime).
>> Also, run individual file sign and unsign commands in quiet mode.
>> Also, add test case to SigningAppImageTest to test that signing app that has
Update Public Suffix List data to the latest version at
https://github.com/publicsuffix/list.
-
Commit messages:
- 8255266: 2021-11-27 public suffix list update v 3c213aa
Changes: https://git.openjdk.java.net/jdk/pull/6643/files
Webrev:
> The modified ziggurat algorithm is not correctly implemented in
> `java.base/jdk/internal/util/random/RandomSupport.java`.
>
> Create a histogram of a million samples using 2000 uniform bins with the
> following range:
> Exponential range from 0 to 12. Gaussian range from -8 to 8.
>
>
The effects of invalid values of `jdk.serialFilter` and
`jdk.serialFilterFactory` properties are
incompletely specified. The behavior for invalid values of the properties is
different and
use an unconventional exception type, `ExceptionInInitializerError` and leave
the `OIF.Config` class
Addition of a configure option --with-cacerts-src='user cacerts folder' to
allow developers to specify their own cacerts PEM folder for generation of the
cacerts store using the deterministic openjdk GenerateCacerts tool.
Signed-off-by: Andrew Leonard
-
Commit messages:
-
On Wed, 1 Dec 2021 18:30:06 GMT, Andrew Leonard wrote:
> Addition of a configure option --with-cacerts-src='user cacerts folder' to
> allow developers to specify their own cacerts PEM folder for generation of
> the cacerts store using the deterministic openjdk GenerateCacerts tool.
>
>
> Here are the code changes for the "Deprecate finalizers in the standard Java
> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
> review.
>
> This change makes the indicated deprecations, and updates the API spec for
> JEP 421. It also updates the relevant
On Wed, 1 Dec 2021 14:25:52 GMT, Andy Herrick wrote:
> Before signing, unsign all executables and libraries (not just those in
> runtime).
> Also, run individual file sign and unsign commands in quiet mode.
> Also, add test case to SigningAppImageTest to test that signing app that has
>
On Tue, 30 Nov 2021 20:43:23 GMT, Roger Riggs wrote:
>> This is about the second line of defense; what happens when the developer
>> deliberately ignores the first error.
>> If the command line parameters are invalid it might be an option to call
>> `System.exit(1)` but there
>> is no
On Wed, 1 Dec 2021 13:49:42 GMT, Maurizio Cimadamore
wrote:
> There are some truncated statements in
> MemorySegment::get/MemorySegment::getAtIndex javadoc, more specifically in
> the `@throws` for `IndexOutOfBoundsException`.
Trivial fix for an apparent cut-and-paste error.
-
On Wed, 1 Dec 2021 11:06:12 GMT, Andrew Leonard wrote:
>> Add a new --source-date (epoch seconds) option to jar and jmod
>> to allow specification of time to use for created/updated jar/jmod entries.
>> This then allows the ability to make the content deterministic.
>>
>> Signed-off-by:
On Mon, 29 Nov 2021 17:07:52 GMT, Alan Bateman wrote:
>> @andrew-m-leonard I see you've add several APIs to ZipEntry in this PR. I
>> think this part will require discussion as it's not immediately clear that
>> we should over burden the ZipEntry API as proposed.
>
>> @AlanBateman yes, see
On Mon, 29 Nov 2021 17:41:34 GMT, Naoto Sato wrote:
>> This fix intends to honor the type (std/dst/generic) of parsed zone name for
>> selecting the offset at the overlap. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional
>
On Wed, 24 Nov 2021 08:54:08 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which adds `jlink.debug=true` system
> property while launching `jpackage` tests?
>
> The previous fix for this in https://github.com/openjdk/jdk/pull/6491 didn't
> take into account the part
On Thu, 18 Nov 2021 03:22:50 GMT, Tim Prinzing wrote:
> JDK-8276674 : Malformed Javadoc inline tags in JDK source in java/util/stream
Given that this PR affects files that aren't rooted under java/util/stream, I
would either rename the PR or exclude the unrelated files. If this PR is going
to
As a follow-up to #6375, this change refactors
java.io.ObjectInputStream.Caches#subclassAudits and
java.io.ObjectOutputStream.Caches#subclassAudits to use ClassValue instead of
SoftReference, similar to what we did in #6375 for
java.io.ObjectStreamClass.Caches#localDescs. Then we can now also
On Wed, 1 Dec 2021 05:35:11 GMT, Ravi Reddy wrote:
>> Hi all,
>>
>> Please review this fix for Infinite loop in ZipOutputStream.close().
>> The main issue here is when ever there is an exception during close
>> operations on GZip we are not setting the deflator to a finished state which
>> is
On Wed, 24 Nov 2021 08:54:08 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which adds `jlink.debug=true` system
> property while launching `jpackage` tests?
>
> The previous fix for this in https://github.com/openjdk/jdk/pull/6491 didn't
> take into account the part
> The caches in ObjectStreamClass basically map WeakReference to
> SoftReference, where the ObjectStreamClass also references
> the same Class. That means that the cache entry, and thus the class and its
> class-loader, will not get reclaimed, unless the GC determines that memory
> pressure is
On Wed, 15 Sep 2021 07:40:35 GMT, Ravi Reddy wrote:
> Hi all,
>
> Please review this fix for Infinite loop in ZipOutputStream.close().
> The main issue here is when ever there is an exception during close
> operations on GZip we are not setting the deflator to a finished state which
> is
On Tue, 30 Nov 2021 19:22:53 GMT, Paul Sandoz wrote:
> Remove Vector API scripts for building and running tests. `jtreg` should be
> used instead.
>
> Also updated the test generation script to remove options that assume
> mercurial as the code repository.
This pull request has now been
Compilation warnings of the test library introduce noise in test output and
should be addressed or suppressed.
Changes include:
- SuppressWarnings("deprecation") and SuppressWarnings("removal")
- Adding type parameters to Raw types
- Adding a hashCode method where equals was already present
On Wed, 1 Dec 2021 10:49:54 GMT, Peter Levart wrote:
> ...I think that you could remove now obsolete
> java.io.ObjectStreamClass.EntryFuture nested class. It's not used any more.
Done.
> It would be nice to follow-up this patch with patches that make use of
> ClassValue also for:
>
> *
There are some truncated statements in
MemorySegment::get/MemorySegment::getAtIndex javadoc, more specifically in the
`@throws` for `IndexOutOfBoundsException`.
-
Commit messages:
- Fix typos in MemorySegment dereference setters
Changes:
On Tue, 30 Nov 2021 22:23:01 GMT, Joe Darcy wrote:
> Should there be a regression test here?
I can ask the submitter to provide a new test based on his testing (new JBS
issue.) The complexity of the test is beyond in house expertise.
-
PR:
On Wed, 1 Dec 2021 14:25:52 GMT, Andy Herrick wrote:
> Before signing, unsign all executables and libraries (not just those in
> runtime).
> Also, run individual file sign and unsign commands in quiet mode.
> Also, add test case to SigningAppImageTest to test that signing app that has
>
On Wed, 1 Dec 2021 18:20:11 GMT, John Neffenger wrote:
> I'm testing it now. So far, it's working great!
>
> I found one boundary problem. The magic instant of `1980-01-01T00:00:00Z`
> triggers an extended header with the wrong time:
>
> ```
> file last modified on (DOS date/time):
On Wed, 1 Dec 2021 18:30:06 GMT, Andrew Leonard wrote:
> Addition of a configure option --with-cacerts-src='user cacerts folder' to
> allow developers to specify their own cacerts PEM folder for generation of
> the cacerts store using the deterministic openjdk GenerateCacerts tool.
>
>
> Before signing, unsign all executables and libraries (not just those in
> runtime).
> Also, run individual file sign and unsign commands in quiet mode.
> Also, add test case to SigningAppImageTest to test that signing app that has
> additional launcher works, and results in validly signed
On 11/7/21 9:44 PM, Jaikiran Pai wrote:
Hello Ioi,
On 02/11/21 12:13 am, Ioi Lam wrote:
Hi Jaikiran,
Thanks for writing the test case to explore the problems in this area.
Please see my comments below:
...
Generally speaking, CDS has two levels of archiving:
[1] archiving class metadata
- We need to unsign all executables and libraries in the app-image before
signing. (not just those in the runtime).
- Clean up excessive output by executing the individual file sign and
unsigning commands in quiet mode.
- Add conditions in SigningAppImageTest to test signing of additional
Hi all,
Please review this patch to address a failure at DST->STD offset transition.
The fix mirrors what was done for JDK-8190748
Best,
Lance
-
Commit messages:
- Patch for JDK-8277422
Changes: https://git.openjdk.java.net/jdk/pull/6648/files
Webrev:
**Background:**
In the Java Language, Enums can be tested for equality, so the constants in an
Enum type must be unique. Javac compiles an enum declaration like this:
public enum Day { SUNDAY, MONDAY ... }
to
public class Day extends java.lang.Enum {
public static final SUNDAY = new
On Wed, 1 Dec 2021 18:02:05 GMT, Andrew Leonard wrote:
>> Add a new --source-date (epoch seconds) option to jar and jmod
>> to allow specification of time to use for created/updated jar/jmod entries.
>> This then allows the ability to make the content deterministic.
>>
>> Signed-off-by:
On Wed, 1 Dec 2021 12:18:05 GMT, Roman Kennke wrote:
>> The caches in ObjectStreamClass basically map WeakReference to
>> SoftReference, where the ObjectStreamClass also
>> references the same Class. That means that the cache entry, and thus the
>> class and its class-loader, will not get
On Wed, 1 Dec 2021 21:35:01 GMT, Andy Herrick wrote:
> - We need to unsign all executables and libraries in the app-image before
> signing. (not just those in the runtime).
> - Clean up excessive output by executing the individual file sign and
> unsigning commands in quiet mode.
> - Add
On Wed, 1 Dec 2021 14:25:52 GMT, Andy Herrick wrote:
> Before signing, unsign all executables and libraries (not just those in
> runtime).
> Also, run individual file sign and unsign commands in quiet mode.
> Also, add test case to SigningAppImageTest to test that signing app that has
>
On Tue, 30 Nov 2021 14:52:37 GMT, Alan Bateman wrote:
> Thread.stop is inherently unsafe and has been deprecated since Java 1.2
> (1998). It's time to terminally deprecate this method so it can be degraded
> and removed in the future.
>
> This PR does not propose any changes to the JVM TI
On Wed, 1 Dec 2021 21:50:46 GMT, Andrew Leonard wrote:
> I can adjust the --date value validation to be > 1980-01-01T00:00:00Z ?
I know, nit picky, right? I'll take no offense if you ignore it. The thing
is, everyone else implementing this feature gave that specific instant a wide
margin.
> On Nov 29, 2021, at 1:14 PM, Mandy Chung wrote:
>
> On Wed, 24 Nov 2021 12:32:32 GMT, Michael Hall wrote:
>
>> Would there be any need to scan class path at all? That would mean a module
>> would have a class path dependency wouldn't it?
>
> One reason of scanning the class path is to
On Tue, 30 Nov 2021 18:53:26 GMT, Joe Wang wrote:
> The result of Util.baseName(systemId) can be empty, causing the compiler to
> set an empty classname. Add a check to make sure it will not set the empty
> classname.
>
> Alternatively, it may report an error, but that would be disruptive. As
On Wed, 1 Dec 2021 19:23:59 GMT, Brent Christian wrote:
>> Here are the code changes for the "Deprecate finalizers in the standard Java
>> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
>> review.
>>
>> This change makes the indicated deprecations, and updates the API
On Wed, 24 Nov 2021 08:54:08 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which adds `jlink.debug=true` system
> property while launching `jpackage` tests?
>
> The previous fix for this in https://github.com/openjdk/jdk/pull/6491 didn't
> take into account the part
On Thu, 2 Dec 2021 02:00:11 GMT, Mikhailo Seledtsov
wrote:
>> Hi @shipilev ,
>> We need to have someone look at the impact of this on our CI. I don't think
>> we run the tier4 group as defined in our tier 4 so we may not see those
>> execution time savings that offset the extra cost to tier3.
On Wed, 1 Dec 2021 18:33:44 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this patch to address a failure at DST->STD offset transition.
> The fix mirrors what was done for JDK-8190748
>
>
> Best,
> Lance
Marked as reviewed by joehw (Reviewer).
-
PR:
On Tue, 2 Nov 2021 17:31:40 GMT, Joe Wang wrote:
> Add setProperty/getProperty methods to the XPath API so that properties can
> be supported in the future.
This pull request has now been integrated.
Changeset: b226ab99
Author:Joe Wang
URL:
On Wed, 1 Dec 2021 21:35:01 GMT, Andy Herrick wrote:
> - We need to unsign all executables and libraries in the app-image before
> signing. (not just those in the runtime).
> - Clean up excessive output by executing the individual file sign and
> unsigning commands in quiet mode.
> - Add
On Wed, 1 Dec 2021 12:21:00 GMT, Athijegannathan Sundararajan
wrote:
>> Can I please get a review of this change which adds `jlink.debug=true`
>> system property while launching `jpackage` tests?
>>
>> The previous fix for this in https://github.com/openjdk/jdk/pull/6491 didn't
>> take into
On Wed, 1 Dec 2021 02:29:14 GMT, David Holmes wrote:
>> OpenJDK tiered tests definitions have the catch-all `tier4` that runs all
>> tests not defined in the lower tiers. `hotspot:tier4` has lots of them,
>> mostly long-running vmTestbase tests, which take many hours even on a very
>>
On Tue, 30 Nov 2021 18:48:15 GMT, Aleksey Shipilev wrote:
> OpenJDK tiered tests definitions have the catch-all `tier4` that runs all
> tests not defined in the lower tiers. `hotspot:tier4` has lots of them,
> mostly long-running vmTestbase tests, which take many hours even on a very
>
> JDK-8276674 : Malformed Javadoc inline tags in JDK source in java/util/stream
Tim Prinzing has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains two commits:
- Merge branch 'master' into JDK-8276674
- Fixed @code and @link in some
66 matches
Mail list logo
