Re: RFR: 6478546: FileInputStream.read() throws OutOfMemoryError when there is plenty available [v5]

2022-06-09 Thread Brian Burkhalter
> Modify native multi-byte read-write code used by the `java.io` classes to > limit the size of the allocated native buffer thereby decreasing off-heap > memory footprint and increasing throughput. Brian Burkhalter has updated the pull request with a new target base due to a merge or a rebase.

RFR: 8288140: Avoid redundant Hashtable.get call in Signal.handle

2022-06-09 Thread Andrey Turbanov
https://github.com/openjdk/jdk/blob/bc28baeba9360991e9b7575e1fbe178d873ccfc1/src/java.base/share/classes/jdk/internal/misc/Signal.java#L177-L178 Instead of separate Hashtable.get/remove calls we can just use value returned by `remove`, It results in cleaner and a bit faster code. -

Integrated: JDK-8284858: Start of release updates for JDK 20

2022-06-09 Thread Joe Darcy
On Thu, 14 Apr 2022 05:09:14 GMT, Joe Darcy wrote: > Time to start getting ready for JDK 20... This pull request has now been integrated. Changeset: edff51e5 Author:Joe Darcy Committer: Erik Joelsson URL: https://git.openjdk.org/jdk/commit/edff51e5fdb5282830ecfb3792a88c7b28ca6557

Re: RFR: 8288140: Avoid redundant Hashtable.get call in Signal.handle

2022-06-09 Thread David M . Lloyd
On Thu, 9 Jun 2022 07:35:43 GMT, Andrey Turbanov wrote: > https://github.com/openjdk/jdk/blob/bc28baeba9360991e9b7575e1fbe178d873ccfc1/src/java.base/share/classes/jdk/internal/misc/Signal.java#L177-L178 > > Instead of separate Hashtable.get/remove calls we can just use value returned > by

Re: RFR: 8288011: StringConcatFactory: Split application of stringifiers [v2]

2022-06-09 Thread Mandy Chung
On Thu, 9 Jun 2022 16:04:43 GMT, Claes Redestad wrote: >> To take optimal advantage of the pre-existing optimization for repeated >> filters we could split the application of different types of stringifiers. >> >> The resulting difference in order of evaluation is not observable by >>

Re: RFR: 8285405: add test and check for negative argument to HashMap::newHashMap et al

2022-06-09 Thread Jaikiran Pai
On Mon, 6 Jun 2022 06:57:23 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which addresses > https://bugs.openjdk.java.net/browse/JDK-8285405? > > I've added the test for `LinkedHashMap.newLinkedHashMap(int)` in the existing > `test/jdk/java/util/LinkedHashMap/Basic.java`

Re: RFR: 8285405: add test and check for negative argument to HashMap::newHashMap et al

2022-06-09 Thread Stuart Marks
On Mon, 6 Jun 2022 06:57:23 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which addresses > https://bugs.openjdk.java.net/browse/JDK-8285405? > > I've added the test for `LinkedHashMap.newLinkedHashMap(int)` in the existing > `test/jdk/java/util/LinkedHashMap/Basic.java`

Re: RFR: 8283726: x86_64 intrinsics for compareUnsigned method in Integer and Long

2022-06-09 Thread Sandhya Viswanathan
On Wed, 8 Jun 2022 09:39:04 GMT, Quan Anh Mai wrote: >> Hi, >> >> This patch implements intrinsics for `Integer/Long::compareUnsigned` using >> the same approach as the JVM does for long and floating-point comparisons. >> This allows efficient and reliable usage of unsigned comparison in

RFR: 8287917: System.loadLibrary does not work on Big Sur if JDK is built with macOS SDK 10.15 and earlier

2022-06-09 Thread Yoshiki Sato
Please review this PR. SDK 10.15 and earlier reports os.version as 10.16 on Big Sur. This fix will check if dynamic linker support, which is supported from Big Sur, is available or not on the OS even if os.version is reported as 10.16 instead of 11. The os.version 10.16 doesn't include the

Re: RFR: 8287902: UnreadableRB case in MissingResourceCauseTest is not working reliably on Windows

2022-06-09 Thread Magnus Ihse Bursie
On Wed, 8 Jun 2022 17:43:49 GMT, Naoto Sato wrote: >> The test >> `test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTest.java` >> verifies different failure modes of resource bundles. One of the failures is >> that the runner class, `MissingResourceCauseTestRun.java`, creates a

Integrated: 8287903: Reduce runtime of java.math microbenchmarks

2022-06-09 Thread Claes Redestad
On Tue, 7 Jun 2022 12:34:25 GMT, Claes Redestad wrote: > - Reduce runtime by running fewer forks, fewer iterations, less warmup. All > micros tested in this group appear to stabilize very quickly. > - Refactor BigIntegers to avoid re-running some (most) micros over and over > with parameter

Re: RFR: 8287903: Reduce runtime of java.math microbenchmarks

2022-06-09 Thread Claes Redestad
On Tue, 7 Jun 2022 12:34:25 GMT, Claes Redestad wrote: > - Reduce runtime by running fewer forks, fewer iterations, less warmup. All > micros tested in this group appear to stabilize very quickly. > - Refactor BigIntegers to avoid re-running some (most) micros over and over > with parameter

RFR: JDK-8288094: cleanup old _MSC_VER handling

2022-06-09 Thread Matthias Baesken
We still handle at a number of places ancient historic _MSC_VER versions of Visual Studio releases e.g. pre VS2013 (VS2013 has _MSC_VER 1800). This should be cleaned up, as long as it is not 3rd party code that we don't want to adjust. Currently still supported ("valid") VS version are 2017+,

Re: RFR: 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved flags is used [v7]

2022-06-09 Thread Thiago Henrique Hüpner
> 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved > flags is used Thiago Henrique Hüpner has updated the pull request incrementally with one additional commit since the last revision: Update author - Changes: - all:

Re: RFR: 8287902: UnreadableRB case in MissingResourceCauseTest is not working reliably on Windows

2022-06-09 Thread Naoto Sato
On Tue, 7 Jun 2022 12:19:29 GMT, Magnus Ihse Bursie wrote: > The test > `test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTest.java` > verifies different failure modes of resource bundles. One of the failures is > that the runner class, `MissingResourceCauseTestRun.java`,

Re: RFR: 8287902: UnreadableRB case in MissingResourceCauseTest is not working reliably on Windows

2022-06-09 Thread Naoto Sato
On Wed, 8 Jun 2022 17:43:49 GMT, Naoto Sato wrote: >> The test >> `test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTest.java` >> verifies different failure modes of resource bundles. One of the failures is >> that the runner class, `MissingResourceCauseTestRun.java`, creates a

Re: RFR: 8285838: DST not applying properly with zone id offset set with TZ env variable [v7]

2022-06-09 Thread Naoto Sato
On Tue, 7 Jun 2022 14:15:55 GMT, Gaurav Chaudhari wrote: >> This fix ensures that when a lookup for a custom TZ code fails, and an >> attempt is made to find the GMT offset in order to get the current time, >> Daylight savings rules are applied correctly. > > Gaurav Chaudhari has updated the

Re: RFR: 8288011: StringConcatFactory: Split application of stringifiers [v2]

2022-06-09 Thread Claes Redestad
> To take optimal advantage of the pre-existing optimization for repeated > filters we could split the application of different types of stringifiers. > > The resulting difference in order of evaluation is not observable by > conventional means since all reference type share the same object >

Re: Add java.util.Objects.dump to facilitate quick debugging

2022-06-09 Thread -
My main concerns are about security, that many object details, while useful to viewers, should not be accessible by any code under any circumstances. Having any code able to print all field content of any object sounds extremely dangerous. In my opinion, we can use a MethodHandles.Lookup as a