Re: Review request for 6829503

2009-04-18 Thread Mandy Chung
David, Thanks for the review. Whether the application shutdown hooks should always be invoked first is a good question. The Console shutdown hook is added to restore the console after prompting for a password to fix: 6363043 Console will not return to original state when the process is

Re: Review request for 6829503

2009-04-18 Thread Xueming Shen
Mandy Chung wrote: David, Thanks for the review. Whether the application shutdown hooks should always be invoked first is a good question. The Console shutdown hook is added to restore the console after prompting for a password to fix: 6363043 Console will not return to original state when

Re: Review request for 6829503

2009-04-18 Thread Alan Bateman
Mandy Chung wrote: 6829503: addShutdownHook fails if called after shutdown has commenced. Webrev at: http://cr.openjdk.java.net/~mchung/6829503/webrev.00/ I change the Shutdown#add method to take the registerShutdownInProgress parameter. If set to true, the specified shutdown hook is

Re: Review request for 6829503

2009-04-18 Thread Martin Buchholz
On Fri, Apr 17, 2009 at 22:53, Mandy Chung mandy.ch...@sun.com wrote: Hi Martin, Thanks for the quick review. Users should only add their shutdown hooks via the System.addShutdownHook() method.   java.lang.Shutdown is an implementation class for registering internal hooks besides

Re: Review request for 6829503

2009-04-18 Thread Martin Buchholz
On Sat, Apr 18, 2009 at 06:20, Rémi Forax fo...@univ-mlv.fr wrote: The other solution is to provide a way in the API to test if shutdown hooks have been started or not. In that case, all application codes that start a shutdown hook like Console.readPassword() can check if shudown hooks run

Re: Correlating LogRecord ThreadIDs with run-of-the-mill Thread ids

2009-04-18 Thread Martin Buchholz
The current state of this change follows. Swamy, please review. # HG changeset patch # User martin # Date 1240096219 25200 # Node ID 8b326aebb981265a99ed96355efe28f8c1b0a0c0 # Parent 536bac6e2774d9ff8a319d5276dddc87b7994650 6278014:java.util.logging.LogRecord.getThreadID() should provide real