6888701 - Change all template java source files to a .java-template file suffix

2009-11-09 Thread Ulf Zibis
IMO you should add jdk/make/tools/CharsetMapping/*.java to the fix of Bug 6888701. Additionally, I don't understand, why there is differing strategy for location of templates. E.g. jdk/make/tools/CharsetMapping/*.java files could be in jdk/src/share/classes/sun/nio/cs/. -Ulf

Re: 6888701 - Change all template java source files to a .java-template file suffix

2009-11-09 Thread Kelly O'Hair
Ulf Zibis wrote: IMO you should add jdk/make/tools/CharsetMapping/*.java to the fix of Bug 6888701. Perhaps... I was mainly after fixing the naming convention in the src/ directory, and I somehow missed these files in the make/tools area. The files in jdk/make/tools/GenerateCharacter

Re: 6888701 - Change all template java source files to a .java-template file suffix

2009-11-09 Thread Ulf Zibis
Am 09.11.2009 20:12, Kelly O'Hair schrieb: Ulf Zibis wrote: IMO you should add jdk/make/tools/CharsetMapping/*.java to the fix of Bug 6888701. Perhaps... I was mainly after fixing the naming convention in the src/ directory, and I somehow missed these files in the make/tools area. The

final transient fields serialization

2009-11-09 Thread Pawel Veselov
Hi, it again caught my attention, and I though that may be there is something that can be done about this. The issue is obvious -- having 'final transient' instance fields makes little sense if the object is ever serialized. Logically, there may be perfect reasoning behind making an instance

Re: final transient fields serialization

2009-11-09 Thread David M. Lloyd
On 11/09/2009 03:30 PM, Pawel Veselov wrote: Hi, it again caught my attention, and I though that may be there is something that can be done about this. The issue is obvious -- having 'final transient' instance fields makes little sense if the object is ever serialized. Logically, there may be

Adding constant for line.separator and friends

2009-11-09 Thread Martin Buchholz
(In response to Joe, who once asked me for little things to add to the core libraries) Lots of classes need to use System.getProperty(line.separator). Many don't do it right because you need to use a doPrivileged block whenever you read a system property. Yet it is no secret - you can divine the

Re: Adding constant for line.separator and friends

2009-11-09 Thread Max (Weijun) Wang
Really necessary? These three system properties are already allowed in the sandbox. $ cat lib/security/java.policy permission java.util.PropertyPermission file.separator, read; permission java.util.PropertyPermission path.separator, read; permission

Review request for 6899607: Update java.util.prefs.FileSystemPreferences to use PlatformLogger

2009-11-09 Thread Mandy Chung
Sherman, I modified src/windows/classes/java/util/prefs/WindowsPreferences.java to use sun.util.logging.PlatformLogger in the fix for 6882376 but missed src/solaris/classes/java/util/prefs/FileSystemPreferences.java. This fix is to update java.util.prefs.FileSystemPreferences to use

Re: Adding constant for line.separator and friends

2009-11-09 Thread Martin Buchholz
More lobbying Here's how many source files in the JDK access this system property. $ rg 'line.separator' | wc -l 43 Some use doPrivileged, some don't. Some cache statically, some cache in an object, some don't cache at all. Martin

Re: Review request for 6899607: Update java.util.prefs.FileSystemPreferences to use PlatformLogger

2009-11-09 Thread Xueming Shen
looks fine. Mandy Chung wrote: Sherman, I modified src/windows/classes/java/util/prefs/WindowsPreferences.java to use sun.util.logging.PlatformLogger in the fix for 6882376 but missed src/solaris/classes/java/util/prefs/FileSystemPreferences.java. This fix is to update

Re: Adding constant for line.separator and friends

2009-11-09 Thread Joe Darcy
Martin Buchholz wrote: (In response to Joe, who once asked me for little things to add to the core libraries) Lots of classes need to use System.getProperty(line.separator). Many don't do it right because you need to use a doPrivileged block whenever you read a system property. Yet it is no

Re: Adding constant for line.separator and friends

2009-11-09 Thread Martin Buchholz
On Mon, Nov 9, 2009 at 20:14, Joe Darcy joe.da...@sun.com wrote: Martin Buchholz wrote: Hi Martin, Given that these values are not true constants since they vary across platforms, I think it is misleading to make them look like constant by having them be public static final fields with

Re: Adding constant for line.separator and friends

2009-11-09 Thread Mark Reinhold
Date: Mon, 09 Nov 2009 20:29:51 -0800 From: Martin Buchholz marti...@google.com ... Since line.separator is the most popular system property, and other system properties like java.home have vague security implications that would suggest they must be protected by a security manager, we

hg: jdk7/tl/jdk: 6899607: Update java.util.prefs.FileSystemPreferences to use PlatformLogger

2009-11-09 Thread mandy . chung
Changeset: ab681c7e811a Author:mchung Date: 2009-11-09 21:32 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ab681c7e811a 6899607: Update java.util.prefs.FileSystemPreferences to use PlatformLogger Summary: Update java.util.prefs.FileSystemPreferences to use PlatformLogger

Re: Adding constant for line.separator and friends

2009-11-09 Thread Martin Buchholz
On Mon, Nov 9, 2009 at 21:54, Mark Reinhold m...@sun.com wrote: Date: Mon, 09 Nov 2009 20:29:51 -0800 From: Martin Buchholz marti...@google.com ... Since line.separator is the most popular system property, and other system properties like java.home have vague security implications

Re: final transient fields serialization

2009-11-09 Thread Rémi Forax
Le 10/11/2009 00:38, David M. Lloyd a écrit : On 11/09/2009 03:30 PM, Pawel Veselov wrote: Hi, it again caught my attention, and I though that may be there is something that can be done about this. The issue is obvious -- having 'final transient' instance fields makes little sense if the

Re: Adding constant for line.separator and friends

2009-11-09 Thread Rémi Forax
Le 10/11/2009 08:07, Martin Buchholz a écrit : On Mon, Nov 9, 2009 at 21:54, Mark Reinhold m...@sun.com mailto:m...@sun.com wrote: Date: Mon, 09 Nov 2009 20:29:51 -0800 From: Martin Buchholz marti...@google.com mailto:marti...@google.com ... Since