Hello.
Please review the more precise wording added to java.lang.reflect.Field
to address bug
6543593 (reflect) Clarify private final field mutability
http://cr.openjdk.java.net/~darcy/6543593.0/
Full patch below.
In describing when IllegalAccessException is thrown, Field now uses
Hi Joe,
I'm not sure exactly what Bill was complaining about here, but using the
same phrasing as Method and Constructor is a good thing. However, as the
CR pertains in particular to the issue of final fields, I think for the
setXXX cases the @exception** IllegalAccessException javadoc should
Hi David.
David Holmes wrote:
Hi Joe,
I'm not sure exactly what Bill was complaining about here,
His specific issue was addressed by the diff
* pIf the underlying field is final, the method throws an
- * {@code IllegalAccessException} unless
- * {@code setAccessible(true)} has
Xueming Shen wrote:
Dave, Alan,
Here is the final webrev based on Dave's patch and the jdk1.5 code
that does not
have the change for 6206933. JPRT job result suggests no new testing
failure and
my non-scientific benchmark test (to use GZIPOu/InputStream to
compress/
decompress the rt.jar)
Joe Darcy wrote:
Fair enough. How about just for the setter methods
+ * @exception IllegalAccessExceptionif this {@code Field} object
+ * enforces Java language access control and the
underlying
+ * field is inaccessible or is final.
I think a comma
Alan Bateman wrote:
Joe Darcy wrote:
Fair enough. How about just for the setter methods
+ * @exception IllegalAccessExceptionif this {@code Field}
object
+ * enforces Java language access control and the
underlying
+ * field is inaccessible or is
Changeset: 734144b6b22f
Author:bpatel
Date: 2011-04-04 10:14 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/734144b6b22f
7010344: Some of the html files do not have element a in right context.
Reviewed-by: jjg
!
This looks good.
Since accessibility is mutable I wonder if the wording should be:
* @exception IllegalAccessExceptionif this {@code Field} object is
* enforcing Java language access control and the underlying
* field is either inaccessible or final.
Mike Duigou wrote:
This looks good.
Since accessibility is mutable I wonder if the wording should be:
* @exception IllegalAccessExceptionif this {@code Field} object is
* enforcing Java language access control and the underlying
* field is either
Joe Darcy wrote:
How about for the setters
* @exception IllegalAccessExceptionif this {@code Field} object
* enforces Java language access control and the
underlying
* field is either inaccessible or final.
Updated webrev at
Changeset: abb29a6bc9f3
Author:darcy
Date: 2011-04-04 11:22 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/abb29a6bc9f3
6543593: (reflect) Clarify private final field mutability
Reviewed-by: dholmes, alanb, mduigou
! src/share/classes/java/lang/reflect/Constructor.java
!
Changeset: 59f43e232481
Author:sherman
Date: 2011-04-04 11:30 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/59f43e232481
6751338: ZIP inflater/deflater performance
Summary: To use GetPrimitiveArrayCritical for bye array access
Reviewed-by: bristor, alanb
!
Changeset: 7916df9c99be
Author:alanb
Date: 2011-04-04 18:10 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/7916df9c99be
7029979: (fs) Path.toRealPath(boolean) should be toRealPath(LinkOption...)
Reviewed-by: mcimadamore, jjg
!
Hello core-libs friends,
Background:
Earlier in the jdk7 development setting of LD_LIBRARY_PATH was purged
in the launcher, this is a good thing!, Joe has an excellent blog which
explains
the rational etc. etc. here:
http://blogs.sun.com/darcy/entry/purging_ld_library_path
More background:
On 4/4/2011 3:31 PM, David Holmes wrote:
Joe Darcy said the following on 04/04/11 17:46:
David Holmes wrote:
[snip]
** shouldn't all those @exception tags get converted to @throws?
That would certainly be my style recommendation, but I wasn't looking
to make that change at the
15 matches
Mail list logo
