Code review request for 6998871 Support making the Throwable.stackTrace field immutable

2011-04-07 Thread Joe Darcy
Hello. Returning to some earlier work, I've developed a proposed fix for 6998871 Support making the Throwable.stackTrace field immutable http://cr.openjdk.java.net/~darcy/6998871.2/ One constructor of Throwable now takes an additional boolean argument to make the stack trace information

RE: Code review request for 6998871 Support making the Throwable.stackTrace field immutable

2011-04-07 Thread Dmytro Sheyko
Just wonder what is the purpose of dummy parameter in native fillInStackTrace method. Couldn't we simply rename it (e.g. to fillInStackTrace0) Date: Wed, 6 Apr 2011 23:29:02 -0700 From: joe.da...@oracle.com To: core-libs-dev@openjdk.java.net Subject: Code review request for 6998871 Support

Re: Code review request for 6998871 Support making the Throwable.stackTrace field immutable

2011-04-07 Thread David Holmes
Dmytro Sheyko said the following on 04/07/11 17:50: Just wonder what is the purpose of dummy parameter in native fillInStackTrace method. Couldn't we simply rename it (e.g. to fillInStackTrace0) Using an overload instead of renaming the native method was initially done to avoid having to

Re: How can I get all emails from this mailing list

2011-04-07 Thread Dalibor Topic
On 3/2/11 9:55 AM, Charles Lee wrote: Is there any place, which is like http://markmail.org/, holding all the mailing from openjdk mailing list? http://markmail.org/search/?q=list%3Anet.java.openjdk cheers, dalibor topic -- Oracle http://www.oracle.com Dalibor Topic | Java F/OSS Ambassador

Re: Need reviewers: Update of jaxp 1.4.5 source drop bundle

2011-04-07 Thread Dalibor Topic
On 3/3/11 3:01 AM, Dr Andrew John Hughes wrote: How do we know what the actual changes are between these tarballs? Is there some JAXP repository somewhere these are derived from, with appropriate tagging? Afaik, the JAXP API and implementation are supplied by the upstream JAXP developers in

RE: Code review request for 6998871 Support making the Throwable.stackTrace field immutable

2011-04-07 Thread Dmytro Sheyko
Thanks. Got it. Date: Thu, 7 Apr 2011 18:03:42 +1000 From: david.hol...@oracle.com To: dmytro_she...@hotmail.com CC: joe.da...@oracle.com; core-libs-dev@openjdk.java.net Subject: Re: Code review request for 6998871 Support making the Throwable.stackTrace field immutable Dmytro Sheyko

Re: Suspected regression: fix for 6735255 causes delay in GC of ZipFile InputStreams, increase in heap demand

2011-04-07 Thread Neil Richards
On Mon, 2011-04-04 at 09:04 +1000, David Holmes wrote: 1. If a call to close() occurs around the same time as finalization occurs then the finalizer thread will set inFinalizer to true, at which point the thread executing close() can see it is true and so may skip the releaseInflater(inf)

Re: Need reviewers: Update of jaxp 1.4.5 source drop bundle

2011-04-07 Thread Dr Andrew John Hughes
On 07/04/2011, Dalibor Topic dalibor.to...@oracle.com wrote: On 3/3/11 3:01 AM, Dr Andrew John Hughes wrote: How do we know what the actual changes are between these tarballs? Is there some JAXP repository somewhere these are derived from, with appropriate tagging? Afaik, the JAXP API and

Review request for removal of lint warnings in DriverManager, CR 7034656

2011-04-07 Thread Lance Andersen - Oracle
Hi all, This is a request for a review of the changes to remove the lint warnings for DriverManager. The diff is at http://cr.openjdk.java.net/~lancea/7034656/. Thank you. Regards, Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network

Re: Need reviewers: Update of jaxp 1.4.5 source drop bundle

2011-04-07 Thread Dalibor Topic
On 4/7/11 3:49 PM, Dr Andrew John Hughes wrote: On 07/04/2011, Dalibor Topic dalibor.to...@oracle.com wrote: On 3/3/11 3:01 AM, Dr Andrew John Hughes wrote: How do we know what the actual changes are between these tarballs? Is there some JAXP repository somewhere these are derived from, with

Re: Review request for removal of lint warnings in DriverManager, CR 7034656

2011-04-07 Thread Alan Bateman
Lance Andersen - Oracle wrote: Hi all, This is a request for a review of the changes to remove the lint warnings for DriverManager. The diff is at http://cr.openjdk.java.net/~lancea/7034656/. Looks okay to me. -Alan

Re: Code review request for 6998871 Support making the Throwable.stackTrace field immutable

2011-04-07 Thread Rémi Forax
On 04/07/2011 08:29 AM, Joe Darcy wrote: Hello. Returning to some earlier work, I've developed a proposed fix for 6998871 Support making the Throwable.stackTrace field immutable http://cr.openjdk.java.net/~darcy/6998871.2/ One constructor of Throwable now takes an additional boolean

Re: Review request for removal of lint warnings in DriverManager, CR 7034656

2011-04-07 Thread Rémi Forax
On 04/07/2011 04:12 PM, Alan Bateman wrote: Lance Andersen - Oracle wrote: Hi all, This is a request for a review of the changes to remove the lint warnings for DriverManager. The diff is at http://cr.openjdk.java.net/~lancea/7034656/. Looks okay to me. -Alan So am I. Rémi

hg: jdk7/tl/jdk: 7034657: Update Creative Commons license URL in legal notices

2011-04-07 Thread chris . hegarty
Changeset: 31619dfa6a4a Author:dl Date: 2011-04-07 15:06 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/31619dfa6a4a 7034657: Update Creative Commons license URL in legal notices Reviewed-by: chegar ! src/share/classes/java/util/AbstractQueue.java !

Re: Review request for removal of lint warnings in DriverManager, CR 7034656

2011-04-07 Thread Kelly O'Hair
And the big man in the sky opens his book of good deeds, looks up Lance, and adds 4/7/2011 - Lance fixed warning errors. ;^) Thanks! -kto On Apr 7, 2011, at 6:48 AM, Lance Andersen - Oracle wrote: Hi all, This is a request for a review of the changes to remove the lint warnings for

hg: jdk7/tl/jdk: 7034656: Address lint warnings for DriverManager

2011-04-07 Thread lance . andersen
Changeset: 5137806a3e34 Author:lancea Date: 2011-04-07 11:25 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5137806a3e34 7034656: Address lint warnings for DriverManager Reviewed-by: alanb, forax, ohair ! src/share/classes/java/sql/DriverManager.java

hg: jdk7/tl/jdk: 7029048: (launcher) fence the launcher against LD_LIBRARY_PATH

2011-04-07 Thread kumar . x . srinivasan
Changeset: d8dfd1a0bd8d Author:ksrini Date: 2011-04-07 12:06 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d8dfd1a0bd8d 7029048: (launcher) fence the launcher against LD_LIBRARY_PATH Reviewed-by: mchung, ohair ! src/share/bin/jli_util.h ! src/solaris/bin/java_md.c !

Re: Need reviewer: 7034700: simple fix

2011-04-07 Thread Kelly O'Hair
Looks fine to me. -kto On Apr 7, 2011, at 12:05 PM, Kumar Srinivasan wrote: Hi, This fixes a build issue in non-product builds, with the fix for 7033954. During the pack200 build the wrong mapfile is picked up due to the idiosyncrasy of the makefile. Thus the fix is simply and explicitly

Re: Suspected regression: fix for 6735255 causes delay in GC of ZipFile InputStreams, increase in heap demand

2011-04-07 Thread David Holmes
Hi Neil, Neil Richards said the following on 04/07/11 23:30: On Mon, 2011-04-04 at 09:04 +1000, David Holmes wrote: 1. If a call to close() occurs around the same time as finalization occurs then the finalizer thread will set inFinalizer to true, at which point the thread executing close()

advice review requested for 6896297, race condition in rmid causing JCK failure

2011-04-07 Thread Stuart Marks
Hi Core-Libs developers, I'd like to solicit some advice and discussion about this bug and a potential fix I'm cooking for it. Here is the bug report; it contains details about the problem and my analysis of it: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6896297 and here's a webrev

Re: Suspected regression: fix for 6735255 causes delay in GC of ZipFile InputStreams, increase in heap demand

2011-04-07 Thread Xueming Shen
Neil, It appears it might not be necessary to do the finalize() in ZipFileInflaterInputStream. The ZipFileInflaterInputStream itself does not directly hold any native resource by itself that needs to be released at the end of its life circle, if not closed explicitly. The native resource/

Re: advice review requested for 6896297, race condition in rmid causing JCK failure

2011-04-07 Thread David Holmes
Hi Stuart, I can't answer your specific questions as I'm not familiar with the RMI infrastructure either. Taking the lock in writeObject and moving group.unregister out of the sync block to avoid deadlock seems reasonable. The main question to ask with such a move is whether the temporary

Re: Code review request for 6998871 Support making the Throwable.stackTrace field immutable

2011-04-07 Thread Joe Darcy
Hi Rémi. Rémi Forax wrote: On 04/07/2011 08:29 AM, Joe Darcy wrote: Hello. Returning to some earlier work, I've developed a proposed fix for 6998871 Support making the Throwable.stackTrace field immutable http://cr.openjdk.java.net/~darcy/6998871.2/ One constructor of Throwable now

Re: Code review request for 6998871 Support making the Throwable.stackTrace field immutable

2011-04-07 Thread Mandy Chung
On 04/07/11 16:26, Joe Darcy wrote: Revised webrev: http://cr.openjdk.java.net/~darcy/6998871.3/ Looks good. Mandy

Re: Codereview request for 7033561: Missing Unicode Script aliases

2011-04-07 Thread Yuka Kamiya
Hi Sherman, The fix looks good to me. Thanks, -- Yuka (11/04/07 5:16), Xueming Shen wrote: It appears the aliases mapping for Character.UnicodeScript is not updated accordingly when we upgraded the Unicode support to 6.0 for JDK7. The difference between the previous version (5.2) and 6.0

hg: jdk7/tl/jdk: 7034700: (unpack200) build fails with fastdebug builds

2011-04-07 Thread kumar . x . srinivasan
Changeset: 587e968b03ee Author:ksrini Date: 2011-04-07 17:08 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/587e968b03ee 7034700: (unpack200) build fails with fastdebug builds Reviewed-by: ohair ! make/com/sun/java/pack/Makefile

Re: Code review request for 6998871 Support making the Throwable.stackTrace field immutable

2011-04-07 Thread Joe Darcy
Joe Darcy wrote: Hi Rémi. Rémi Forax wrote: On 04/07/2011 08:29 AM, Joe Darcy wrote: Hello. Returning to some earlier work, I've developed a proposed fix for 6998871 Support making the Throwable.stackTrace field immutable http://cr.openjdk.java.net/~darcy/6998871.2/ One constructor