Am 29.08.2011 02:02, schrieb David Holmes:
On 29/08/2011 5:35 AM, Sebastian Sickelmann wrote:
Hi, here is a webrev[1] for some cleanup that i want to integrated in
tl-repositories.
Alan Bateman had scanned the changes and gave me some good input[3] for
further discussion here:
The changes to
* Rama Pulavarthi:
Just porting the fix along with tests from Open JDK 6 workspace,
that's why I kept the old date. Does it need to be changed? This test
was added then following the convention of other tests. I will check
other tests in JDK 7 to see if it needs any update.
I see that the
I reviewed the security part. In general, it looks fine. But sometimes,
from my very personal view, the exception-chain might be over used. For
example, the following code:
try {
md = MessageDigest.getInstance(SHA);
} catch (NoSuchAlgorithmException nsae) {
throw new
Changeset: 02c2d38f4271
Author:xuelei
Date: 2011-08-29 05:55 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/02c2d38f4271
7059542: JNDI name operations should be locale independent
Reviewed-by: weijun
! src/share/classes/com/sun/jndi/ldap/ClientId.java
!
Changeset: d1c04dac850d
Author:mullan
Date: 2011-08-29 12:22 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d1c04dac850d
7024771: \\ in attribute value part of X500Principal constructor parameter
makes strange effect
Reviewed-by: vinnie
!
Hi,
Sorry for the delay, was on vacation...comment inlined.
Hi, here is a webrev[1] for some cleanup that i want to integrated in
tl-repositories.
Alan Bateman had scanned the changes and gave me some good input[3]
for further discussion here:
The changes to java.util.concurrent should go
Hi Sebastian,
I will help to push the patch, if people all agreed the changes proposed.
I pulled your patch and generated the webrev at
http://cr.openjdk.java.net/~sherman/7084245/webrev
with couple changes from your original patch.
(1) Undo the changes in DecimalFormat.java and Format.java.
