Hello Olivier.
Olivier Lagneau wrote:
Please review The implementation of a fast-path algorithm for
optimizing the
DecimalFormat(double, ...) call stack.
The webrev is here :
http://cr.openjdk.java.net/~alanb/7050528/webrev.01
As described in the CR evaluation and suggested fix,
the speed-up
On 13/09/11 18:26, Alan Bateman wrote:
Michael McMahon wrote:
Can I get the following webrev reviewed please?
http://cr.openjdk.java.net/~michaelm/7051946/webrev.1/
I scanned this briefly (I haven't done a detailed code review) but one
initial comment is that Runtime.exec will now throw
Mandy Chung wrote:
6915797: Remove sun.tools.jar.JarImageSource that is not used
7090178: Move java.util.XMLUtils to another package to avoid split
package
Webrev at:
http://cr.openjdk.java.net/~mchung/6915797/webrev.00/
The synopsis says it all.
Mostly looks okay to me too. A few
Michael McMahon wrote:
We could add a sentence to the existing @throws clause for IAE.
So it would say If |command| is empty, or on some platforms, may be
thrown if command contains illegal characters.
I'm reluctant to be more precise than that, since as far as I know,
there doesn't appear
Changeset: 04672e957da0
Author:mchung
Date: 2011-09-14 08:33 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/04672e957da0
6915797: Remove sun.tools.jar.JarImageSource that is not used
7090178: Move java.util.XMLUtils to another package to avoid split package
Reviewed-by:
Changeset: 2a8072c7cf99
Author:darcy
Date: 2011-09-14 11:32 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2a8072c7cf99
6879143: java.math.BigInteger misses the xxxValueExact methods
Reviewed-by: alanb
! src/share/classes/java/math/BigInteger.java
+
Changeset: 0f3da6af9799
Author:jjg
Date: 2011-09-14 12:07 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0f3da6af9799
7080267: Call to toString() from an ExpressionStatementTree doesn't take in
consideration the ; at the end
Reviewed-by: mcimadamore
!
Changeset: 1807fc3fd33c
Author:jjg
Date: 2011-09-14 12:14 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1807fc3fd33c
7090249: IllegalStateException from Trees.getScope when called from JSR 199
Reviewed-by: mcimadamore
!
Hello.
Please review the simple patch below to add an omitted @since tag to the
SafeVargs annotation type, which was added to the platform as part of
Project Coin in JDK 7.
Thanks,
-Joe
--- a/src/share/classes/java/lang/SafeVarargs.java
+++ b/src/share/classes/java/lang/SafeVarargs.java
@@
Looks good!
On Sep 14 2011, at 12:38 , Joe Darcy wrote:
Hello.
Please review the simple patch below to add an omitted @since tag to the
SafeVargs annotation type, which was added to the platform as part of Project
Coin in JDK 7.
Thanks,
-Joe
---
Changeset: 84da01e00e6c
Author:darcy
Date: 2011-09-14 13:09 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/84da01e00e6c
7088500: there is no @since tag on SafeVarargs
Reviewed-by: mduigou
! src/share/classes/java/lang/SafeVarargs.java
Changeset: a6e2c1840ea1
Author:jjg
Date: 2011-09-14 15:49 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a6e2c1840ea1
7090700: fix for 7080267 breaks two tests
Reviewed-by: ksrini
! src/share/classes/com/sun/tools/javac/tree/JCTree.java
Changeset: 826ae6a2f27d
Author:jjg
Date: 2011-09-14 18:26 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/826ae6a2f27d
7068437: Regression: Filer.getResource(SOURCE_OUTPUT, ...) no longer works in
JDK 7 w/o -s
Reviewed-by: darcy
!
13 matches
Mail list logo
