Re: Patch to expand tz checking scope in TimeZone_md.c

2011-11-09 Thread Jonathan Lu
On 11/04/2011 01:26 PM, David Holmes wrote: On 4/11/2011 2:53 PM, David Holmes wrote: On 4/11/2011 2:13 PM, Masayoshi Okutsu wrote: Probably the difference isn't documented. I tried Solaris 10 and Ubuntu 10.03. The difference still exists. Solaris 10: $ unset TZ $ date Fri Nov 4 13:04:45 JST

Re: Garbage collection race condition before final checks

2011-11-09 Thread Alan Bateman
On 08/11/2011 15:35, Gary Adams wrote: Here's another intermittent bug that is attributed to the garbage collection of the loggers before the final static check can be applied in the test. CR#7067691 : java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest.java failing intermittently I

Re: A method with return type size_t returns negative value

2011-11-09 Thread Jing Lv
Hello Alan, (Sorry that haven't check this for months) I check with the bug 7030624 but see no progress now. What's the current status? Shall we go on with a simple patch to fix the problem? On 2011/7/21 21:32, Alan Bateman wrote: Jing LV wrote: Ping, anyone notice this? :) My plan is

Re: Garbage collection race condition before final checks

2011-11-09 Thread Gary Adams
On 11/8/11 11:13 PM, Mandy Chung wrote: Gary, Thanks for picking up this bug and fixing this intermittent issue. PlatformLoggingMXBeanTest.java in the same directory has the same issue. It'd be good to fix that with the same CR. These tests were copied from

Fwd: Re: Miscellaneous minor patches: javadoc typos, javac warnings, etc.

2011-11-09 Thread Alan Bateman
Does anyone have cycles to review and sponsor the Core and SQL clean-ups? They should be trivial to review and push as one change-set, leaving the client area changes for review on the 2d or other list. -Alan. Original Message Subject: Re: Miscellaneous minor patches:

Re: Miscellaneous minor patches: javadoc typos, javac warnings, etc.

2011-11-09 Thread Lance Andersen - Oracle
I looked at the core and sql changes and they are fine. I will great a bug for these and submit the change-set. Best lance On Nov 9, 2011, at 6:30 AM, Alan Bateman wrote: Does anyone have cycles to review and sponsor the Core and SQL clean-ups? They should be trivial to review and push as

Code Review 7107516: LinkedBlockingQueue/Deque.drainTo(Collection, int) returns 'maxElements' if its value is negative

2011-11-09 Thread Chris Hegarty
According to the specification for BlockingQueue.drainTo(Collection c, int maxElements), this method should return the number of elements transferred. However the implementation of this method for LinkedBlockingQueue and LinkedBlockingDeque when given a negative number returns the given

Re: Code Review 7107516: LinkedBlockingQueue/Deque.drainTo(Collection, int) returns 'maxElements' if its value is negative

2011-11-09 Thread Chris Hegarty
On 09/11/2011 16:44, Mike Duigou wrote: The change looks good. The creation of node instances could use diamond. ie. Yes, this was my initial reaction too. Since Doug's CVS is also built with JDK6 I guess he cannot take advantage of new 7 features. I just tried to keep in sync rather than

Re: Fwd: Re: Miscellaneous minor patches: javadoc typos, javac warnings, etc.

2011-11-09 Thread Phil Race
Martin, Please do register on 2d-dev and propose the 2D changes there. The hashcode change definitely needs discussion, I think there may be views on the NaN comparison as my understanding is that this is supposed to always be not equal. Could be a spec. change for the class if its

Re: Miscellaneous minor patches: javadoc typos, javac warnings, etc.

2011-11-09 Thread Martin Desruisseaux
Hello Phil Le 09/11/11 18:37, Phil Race a écrit : Please do register on 2d-dev and propose the 2D changes there. Registration done, I will post in a few minutes. The hashcode change definitely needs discussion, I think there may be views on the NaN comparison as my understanding is that

Re: Race condition in ThreadGroup stop test

2011-11-09 Thread Gary Adams
Captured the latest round of comments - more readable initialization - allow sleep interruption to terminate main thread - added current CR# to @bug tag 24/** 25 * @test 26 * @bug 4176355 7084033 27 * @summary Stopping a ThreadGroup that contains the

Re: Timing bugs

2011-11-09 Thread Gary Adams
Here's an update diff for the elapsed time check. - added current CR# to @bug tag - moved capture of start time to after creation of the latches so only the schedule*() and the await() calls are included in the elapsed time check. jdk/test/java/util/Timer/Args.java /* *

Re: Garbage collection race condition before final checks

2011-11-09 Thread Gary Adams
Here's an updated diff : - added current CR# to the @bug tag - made logger1 and logger2 instance variables - renamed test instance variable lmxbeantest - removed excessive diagnostic print outs --- a/test/java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest.java +++

Re: Race condition in TimerTask KillThread test

2011-11-09 Thread Gary Adams
Here's a revised diff for the KillThread timing problem : - added current CR# to @bug tag - capture the thread from the timer task - wait for the timertask thread to be visible to the main thread then join the thread before fall through to attempt the second timertask schedule

Re: Garbage collection race condition before final checks

2011-11-09 Thread Alan Bateman
On 09/11/2011 19:26, Gary Adams wrote: Here's an updated diff : - added current CR# to the @bug tag - made logger1 and logger2 instance variables - renamed test instance variable lmxbeantest - removed excessive diagnostic print outs Looks fine to me except that we might find a

Re: Garbage collection race condition before final checks

2011-11-09 Thread Mandy Chung
On 11/9/2011 1:18 PM, Alan Bateman wrote: On 09/11/2011 19:26, Gary Adams wrote: Here's an updated diff : - added current CR# to the @bug tag - made logger1 and logger2 instance variables - renamed test instance variable lmxbeantest - removed excessive diagnostic print outs Looks

Re: Code Review 7107516: LinkedBlockingQueue/Deque.drainTo(Collection, int) returns 'maxElements' if its value is negative

2011-11-09 Thread David Holmes
On 10/11/2011 3:03 AM, Chris Hegarty wrote: On 09/11/2011 16:44, Mike Duigou wrote: The change looks good. The creation of node instances could use diamond. ie. Yes, this was my initial reaction too. Since Doug's CVS is also built with JDK6 I guess he cannot take advantage of new 7

Re: Race condition in ThreadGroup stop test

2011-11-09 Thread David Holmes
Gary, Did you test that this still fails on a JDK without the fix? AFAICS you must start the threads in the correct order so that in the original bad code the first thread in the ThreadGroup that would be stopped is first. Hence 64// Launch two threads as part of the same

Re: Race condition in TimerTask KillThread test

2011-11-09 Thread David Holmes
Hi Gary, On 10/11/2011 5:36 AM, Gary Adams wrote: Here's a revised diff for the KillThread timing problem : - added current CR# to @bug tag I don't think that is correct. AFAIK the @bug indicates what bug this test is testing the fix for, not which bugs modified the test. (Ditto for your

Re: Timing bugs

2011-11-09 Thread David Holmes
Hi Gary, Functional changes look okay to me. Thanks, David On 10/11/2011 5:21 AM, Gary Adams wrote: Here's an update diff for the elapsed time check. - added current CR# to @bug tag - moved capture of start time to after creation of the latches so only the schedule*() and the await() calls