Hi all,
Thanks for all the comments!
I've updated the patch for the following recommended changes:
1. ServiceConfigurationError instead of ConfigurationError
2. Use factory class, class.forName section removed
3. Use load method without specifying classloader
4. To be clear on how the process
On 2012/6/21 20:16, David Holmes wrote:
Hi Eric,
On 21/06/2012 8:57 PM, Eric Wang wrote:
Hi David,
Thanks for your review, I have updated the code by following your
suggestion. please see the attachment.
I'm not sure whether there's a better way to guarantee object finalized
by GC definitely
Hi All,
First of all, if the jdbc problem has a better mailing list to post
please tell me.
I find that javax.sql.rowset.serial.SerialBlob is not fully implemented
in OpenJDK 8. Methods
public InputStream getBinaryStream(long pos,long length) throws
SQLException
public void
Hi, Rob,
src/solaris/native/java/lang/UNIXProcess_md.c:
You never check the return code of kill(2). kill() may fail if you
have no permission to kill the process (EPERM), or if the process id
is invalid, maybe it has already been reaped. In both cases an
exception would be nice, or if you decide
Hi David,
I think the test
if (n 0) {
should not be in siftDown* but should be done at all callsites,
by example in heapify, you can hoist the test outside of the loop.
In dequeue, it's a matter of style but the 'else' is not needed anymore.
Otherwise the changes looks ok for me.
Rémi
On
On 25/06/2012 09:56, Thomas Stüfe wrote:
Hi, Rob,
src/solaris/native/java/lang/UNIXProcess_md.c:
You never check the return code of kill(2). kill() may fail if you
have no permission to kill the process (EPERM), or if the process id
is invalid, maybe it has already been reaped. In both cases
On 24/06/2012 13:57, Rob McKenna wrote:
Hi folks,
5th, and hopefully final review has been posted to:
http://cr.openjdk.java.net/~robm/4244896/webrev.05/
http://cr.openjdk.java.net/%7Erobm/4244896/webrev.05/
Let me know if there are any comments or concerns, and thanks a lot
for the help
Hi Remi,
On 25/06/2012 7:01 PM, Rémi Forax wrote:
Hi David,
I think the test
if (n 0) {
should not be in siftDown* but should be done at all callsites,
by example in heapify, you can hoist the test outside of the loop.
I originally had it at the call-site (it already exists in a number of
On 22/06/2012 23:15, Mike Duigou wrote:
:
- The CharSequences returned by subSequence would follow only the general
CharSequence rules for equals()/hashCode(). Any current usages of the result of
subSequence for equals() or hashing, even though it's not advised, would break.
We could add
On 25/06/2012 08:38, Joe Wang wrote:
Hi all,
Thanks for all the comments!
I've updated the patch for the following recommended changes:
1. ServiceConfigurationError instead of ConfigurationError
2. Use factory class, class.forName section removed
3. Use load method without specifying
On 06/25/2012 01:17 PM, David Holmes wrote:
Hi Remi,
On 25/06/2012 7:01 PM, Rémi Forax wrote:
Hi David,
I think the test
if (n 0) {
should not be in siftDown* but should be done at all callsites,
by example in heapify, you can hoist the test outside of the loop.
I originally had it at the
Hi all,
Apologies for the delay. So it was simply a case of human error in
missing that last fallthrough (we wanted to double check that our
warnings script wasn't failing, hence the delay in getting back to
you). I've respun the patch with the extra SuppressWarning.
Hopefully the patch is
Hi Alan and Jason,
On 06/23/12 11:28, Alan Bateman wrote:
On 23/06/2012 02:01, Jason Uh wrote:
This fix was for regression tests failing on Mac OS X on remotely
executed environments. The changed tests now run in headless mode and
have been taken off the Problem List.
Webrev:
Changeset: 4a4a04bfeece
Author:chegar
Date: 2012-06-25 14:19 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4a4a04bfeece
7176784: Windows authentication not working on some computers
Reviewed-by: michaelm
!
Hi Joe,
What happens if there is a space character or other characters in the string
that should be encoded ?
http://greenbytes.de/tech/webdav/rfc2396.html#rfc.section.2.4.3
I suspect escapeNonUSAscii is slightly misleading, it should be really called
something like
H Joe,
I just focused on javax.xml.datatype and assumed the rest follows the same
pattern :-)
Like Alan i am still not sure about swallowing the ServiceConfigurationError.
It enables something that did not work before so i guess it does not take
anything away, if choose that this should be
On 6/25/2012 5:14 AM, Alan Bateman wrote:
On 25/06/2012 08:38, Joe Wang wrote:
Hi all,
Thanks for all the comments!
I've updated the patch for the following recommended changes:
1. ServiceConfigurationError instead of ConfigurationError
2. Use factory class, class.forName section removed
3.
On 25/06/2012 18:03, Joe Wang wrote:
:
I'm not sure about catching and ignoring the
ServiceConfigurationError (or keep on trucking as Paul termed it in
one of the replies). The existing specification reads Any Exception
thrown during the instantiation process is wrapped as a
On 6/25/2012 9:34 AM, Paul Sandoz wrote:
H Joe,
I just focused on javax.xml.datatype and assumed the rest follows the same
pattern :-)
Yeah, they are mostly similar, except Schema and XPath that do a little
extra check.
Like Alan i am still not sure about swallowing the
Hopefully, this will address most, if not all of the suggestions made to
date.
Jim
diff -r f37afaa214e9 src/share/classes/java/lang/StringBuffer.java
--- a/src/share/classes/java/lang/StringBuffer.javaMon Jun 25
14:22:42 2012 -0400
+++ b/src/share/classes/java/lang/StringBuffer.java
Hi,
I'm looking for a code review around the following corba changes. It
turns out that we've a few bug fixes in corba area for jdk6 that were
never forward ported to jdk7 or 8. The port is pretty much identical to
what was used in JDK6. Some formatting and diamond operator changes
Hi Jim,
maybe you like to read some more comments...
I'm not sure, wich would be better, but IMO should be used consistent:
{@code append()}
{@code append}
I think, the double quotes belong to the code for {@code start} etc. -- {@code
start}
I do not understand, why you change from
Yes be ensure was certainly not intended. Thanks for catching that slip-up.
Also, source sequence was intended. I'll check out the inconsistencies so
that we can nail this down on the next iteration.
Thanks,
Jim
- Original Message -
From: ulf.zi...@cosoco.de
To:
23 matches
Mail list logo
