Thanks for cleaning up those spaces Dan. The changes look fine.
Sorry for the extra trouble!
- Kurchi
On 8/28/12 10:22 PM, Dan Xu wrote:
It is funny. :) I have searched all source codes under jdk and removed
spaces for the similar cases.
Please review the new version of change at,
http://cr.
I made a simple fix to clean up build warnings in java.sql package. The
change can be reviewed at
http://cr.openjdk.java.net/~dxu/7193683/webrev.01/. Thanks!
-Dan
It is funny. :) I have searched all source codes under jdk and removed
spaces for the similar cases.
Please review the new version of change at,
http://cr.openjdk.java.net/~dxu/7193406/webrev.03/.
Thanks for your comment!
-Dan
On 08/28/2012 05:32 PM, Kurchi Hazra wrote:
Irony of the day -
Changeset: c4c69b4d9ace
Author:weijun
Date: 2012-08-29 11:03 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c4c69b4d9ace
7184815: [macosx] Need to read Kerberos config in files
Reviewed-by: valeriep
! src/share/classes/sun/security/krb5/Config.java
Irony of the day - those changes were done by me!
(http://cr.openjdk.java.net/~khazra/7157893/webrev.02/) :D
They were probably a mistake/oversight. I guess the better way is
without those extra spaces. See
http://docs.oracle.com/javase/tutorial/java/javaOO/annotations.html.
If you have tim
I also thought the space was not needed. But when I made the changes, I
found that many similar codes had the space when two or more warning
types need to be suppressed. For example, java/util/Collections.java,
java/util/Arrays.java, java/util/ComparableTimSort.java, and etc. If
only one warni
I will update the change with your suggestion. Thanks!
-Dan
On 08/28/2012 04:52 PM, Ulf Zibis wrote:
Thanks for your feedback Dan.
But I still think, the link to the javadoc of a class should not be
labelled by a variable name.
So maybe use:
212 * Converts the buffer's contents into
I don't think you need the space before "unchecked" and the one after
"rawtypes" in lines 128 and 147 in
http://cr.openjdk.java.net/~dxu/7193406/webrev.02/src/share/classes/java/util/PropertyResourceBundle.java.sdiff.html.
- Kurchi
On 8/28/2012 4:57 PM, Dan Xu wrote:
Thanks for all your good
Thanks for all your good suggestions!
I have updated my changes, which revoke changes to makefiles and put
@SuppressWarnings outside methods instead of introducing local variables
for small methods.
The webrev is at http://cr.openjdk.java.net/~dxu/7193406/webrev.02/. Thanks!
-Dan
On 08/27/2
Thanks for your feedback Dan.
But I still think, the link to the javadoc of a class should not be labelled by
a variable name.
So maybe use:
212 * Converts the buffer's contents into a string by decoding the bytes
using
213 * the {@link java.nio.charset.Charset}, specified by it's n
Thanks for your comments, Ulf.
I looked at the definitions of @link and @linkplain again. And I find
that this nested situation can be easily avoided by replacing @linkplain
with @link as the following,
{@link java.nio.charset.Charset charset}
I will update my changes.
-Dan
On 08/28/
Am 28.08.2012 11:45, schrieb Alan Bateman:
On 27/08/2012 21:48, Dan Xu wrote:
This change is to fix the java doc font issue for ByteArrayOutputStream class. In current
javadoc, contents change to the wrong font starting from toString(String charsetName) in
ByteArrayOutputStream.html, which can
On 8/28/2012 1:19 AM, Paul Sandoz wrote:
Hi Joe,
On Aug 28, 2012, at 7:35 AM, Joe Wang wrote:
--
datatype/FactoryFinder.java:
244 } catch (ServiceConfigurationError e) {
245 throw new DatatypeConfigurationException(e.getMessage(),
e.getCause());
You are munging th
Hi David,
Thank you for reviewing my changes.
I tried using {@code } in my change, but it did not work correctly as
the tag will be nested. And it will show "{@code charset}" in the
generated java doc instead of "charset". And works fine in
the nested situation.
I also uploaded the generat
Changeset: bfd5ecb1b4aa
Author:dcubed
Date: 2012-08-28 09:40 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bfd5ecb1b4aa
7194608: add VerifyLocalVariableTableOnRetransformTest.sh to Problem.list
Reviewed-by: alanb
! test/ProblemList.txt
Changeset: 8b90182f2b33
Author:mullan
Date: 2012-08-28 08:43 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8b90182f2b33
7192896: Reason of CertPathValidatorException should be
UNDETERMINED_REVOCATION_STATUS if OCSP request failed
Reviewed-by: xuelei
! src/share/classes/sun
Changeset: c5099c988cce
Author:alanb
Date: 2012-08-28 11:12 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c5099c988cce
6962637: TEST_BUG: java/io/File/MaxPathLength.java may fail in busy system
Reviewed-by: dholmes, alanb
Contributed-by: Eric Wang
! test/ProblemList.txt
!
On 27/08/2012 21:48, Dan Xu wrote:
This change is to fix the java doc font issue for
ByteArrayOutputStream class. In current javadoc, contents change to
the wrong font starting from toString(String charsetName) in
ByteArrayOutputStream.html, which can be viewed at
http://docs.oracle.com/javase
Changeset: 997e0d6238b7
Author:jjg
Date: 2012-08-28 10:31 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/997e0d6238b7
7194035: update tests for upcoming changes for jtreg
Reviewed-by: alanb, sspitsyn
! test/sun/tools/common/ApplicationSetup.sh
! test/sun/tools/jps/jps-Vvml_2
Changeset: 06d0478023ca
Author:jjg
Date: 2012-08-28 10:29 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/06d0478023ca
7194032: update tests for upcoming changes for jtreg
Reviewed-by: alanb, iris
! test/java/rmi/activation/Activatable/extLoadedImpl/ext.sh
! test/java/rmi/reg
Changeset: fe496675b5e7
Author:weijun
Date: 2012-08-28 17:25 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fe496675b5e7
7194472: FileKeyTab.java test fails on Windows
Reviewed-by: alanb
! test/sun/security/krb5/auto/FileKeyTab.java
Hi Joe,
On Aug 28, 2012, at 7:35 AM, Joe Wang wrote:
>>
>> --
>>
>> datatype/FactoryFinder.java:
>>
>> 244 } catch (ServiceConfigurationError e) {
>> 245 throw new DatatypeConfigurationException(e.getMessage(),
>> e.getCause());
>>
>> You are munging the message of the
On 28/08/2012 03:52, Eric Wang wrote:
Hi David, Amy & Alan
Thanks for your review, Based on your comments I have updated the fix
again, Can you please review again?
http://dl.dropbox.com/u/90659131/fixes/6962637/webrev/index.html
Thanks,
Eric
I think this is fine and I don't see any reason no
Approved.
regards,
Sean.
On 28/08/2012 01:32, Kurchi Hazra wrote:
This is a request for approval to backport the fix for 7184287 rom 8
to 7u8.
Bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7184287
Webrev:http://cr.openjdk.java.net/~khazra/7184287/7u8/webrev.00/
This had been revie
24 matches
Mail list logo
