Re: 7099119: Remove unused dlinfo local variable in launcher code

2012-11-29 Thread Alan Bateman
On 29/11/2012 07:17, Shi Jun wrote: Hi all, Previously 7099119 is fixed in the following changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dd55467dd1f2, but this change is lost during the Mac port merging changes 7113349 and 7146424. Hereby I raise this thread again. Webrev:

Re: Code review request 8004134: More ProblemList.txt updates (11/2012)

2012-11-29 Thread Alan Bateman
On 29/11/2012 07:02, Amy Lu wrote: We have a few test failures on nightly testing, they are failing for known issues and should be excluded until issue is resolved. Please review: https://dl.dropbox.com/u/5812451/yl153753/8004134/webrev.00/index.html Thanks, Amy This looks okay to me.

RFR (XS) CR 8004141: UnsafeStaticFieldAccessorImpl#base should be final

2012-11-29 Thread Aleksey Shipilev
Hi, Submitted the original issue found by Peter Levart [1] as CR 8004141. Peter had suggested the trivial change [2] to fix this. Please review. Thanks, Aleksey. [1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-November/012498.html [2]

Re: RFR (XS) CR 8004141: UnsafeStaticFieldAccessorImpl#base should be final

2012-11-29 Thread Chris Hegarty
Looks fine to me Aleksey. Let me know if you need a sponsor to get this into jdk8. -Chris. On 11/29/2012 11:05 AM, Aleksey Shipilev wrote: Hi, Submitted the original issue found by Peter Levart [1] as CR 8004141. Peter had suggested the trivial change [2] to fix this. Please review.

Re: RFR (XS) CR 8004141: UnsafeStaticFieldAccessorImpl#base should be final

2012-11-29 Thread Aleksey Shipilev
I do, since I do not have the commit rights into OpenJDK repos. Thanks! -Aleksey. On 11/29/2012 03:19 PM, Chris Hegarty wrote: Looks fine to me Aleksey. Let me know if you need a sponsor to get this into jdk8. -Chris. On 11/29/2012 11:05 AM, Aleksey Shipilev wrote: Hi, Submitted the

Re: RFR (XS) CR 8004141: UnsafeStaticFieldAccessorImpl#base should be final

2012-11-29 Thread Alan Bateman
On 29/11/2012 11:05, Aleksey Shipilev wrote: Hi, Submitted the original issue found by Peter Levart [1] as CR 8004141. Peter had suggested the trivial change [2] to fix this. Please review. Thanks, Aleksey. [1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-November/012498.html

Re: RFR (XS) CR 8004141: UnsafeStaticFieldAccessorImpl#base should be final

2012-11-29 Thread Aleksey Shipilev
On 11/29/2012 03:22 PM, Alan Bateman wrote: It looks fine, are you looking for a sponsor? Thanks. Chris had already volunteered for this. -Aleksey.

Re: RFR: 8003380 - Compiler warnings in logging test code

2012-11-29 Thread Chris Hegarty
and pushed... http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2b829a5a46ee -Chris. On 11/28/2012 06:51 PM, Jim Gish wrote: Since we don't yet have a resolution on this, I modified the test code in question to remove the @SuppressWarnings(unused) and actually removed the unused references (and

Re: Request for Review : CR#8004015 : Add interface extends and defaults for basic functional interfaces

2012-11-29 Thread Chris Hegarty
On 11/29/2012 05:50 AM, David Holmes wrote: ... I don't agree that we need to describe what the default implementation does, for two reasons: 1. Normal methods don't usually specify how they are implemented - it is an implementation detail. The default simply indicates that this method does

hg: jdk8/tl/jdk: 8004141: UnsafeStaticFieldAccessorImpl#base should be final

2012-11-29 Thread chris . hegarty
Changeset: d91e6cb1da41 Author:shade Date: 2012-11-29 17:03 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d91e6cb1da41 8004141: UnsafeStaticFieldAccessorImpl#base should be final Reviewed-by: chegar, alanb Contributed-by: peter.lev...@gmail.com !

hg: jdk8/tl/jdk: 2 new changesets

2012-11-29 Thread mike . duigou
Changeset: bf6ceb6b8f80 Author:mduigou Date: 2012-11-29 14:07 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bf6ceb6b8f80 7175464: entrySetView field is never updated in NavigableSubMap Summary: The method entrySet() in AscendingSubMap and DescendingSubMap failed to cache

hg: jdk8/tl: 8004131: move jdi tests out of core testset

2012-11-29 Thread stuart . marks
Changeset: ab1ab9b148dd Author:smarks Date: 2012-11-28 17:31 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/ab1ab9b148dd 8004131: move jdi tests out of core testset Reviewed-by: alanb, chegar ! make/jprt.properties

Re: Code Review Request: 7197662: (prefs) java/util/prefs/AddNodeChangeListener.java fails by timeout or by couldn't get file lock

2012-11-29 Thread Kurchi Hazra
Apologies for the extreme delay. I added the bug id, and checked that setting the userRoot=. will result in the JTwork/scratch directory being used to store the preferences. I think we had concluded that othervm is the correct choice for running a test when setting the

Re: Request for Review : CR#8004015 : Add interface extends and defaults for basic functional interfaces

2012-11-29 Thread David Holmes
On 30/11/2012 12:44 AM, Chris Hegarty wrote: On 11/29/2012 05:50 AM, David Holmes wrote: ... I don't agree that we need to describe what the default implementation does, for two reasons: 1. Normal methods don't usually specify how they are implemented - it is an implementation detail. The

Re: 7099119: Remove unused dlinfo local variable in launcher code

2012-11-29 Thread Shi Jun
On 11/29/2012 6:40 PM, Alan Bateman wrote: On 29/11/2012 07:17, Shi Jun wrote: Hi all, Previously 7099119 is fixed in the following changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dd55467dd1f2, but this change is lost during the Mac port merging changes 7113349 and 7146424. Hereby I

hg: jdk8/tl/jdk: 7155168: java/util/TimeZone/Bug6912560.java: expected Asia/Tokyo

2012-11-29 Thread staffan . larsen
Changeset: 55f8ddc2f9c6 Author:sla Date: 2012-11-30 08:17 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/55f8ddc2f9c6 7155168: java/util/TimeZone/Bug6912560.java: expected Asia/Tokyo Reviewed-by: okutsu ! test/java/util/TimeZone/Bug6912560.java