Re: RFR: 8019551: Make BaseStream public

2013-07-08 Thread Paul Sandoz
On Jul 9, 2013, at 12:56 AM, Henry Jen wrote: > Hi, > > Please review webrev at > > http://cr.openjdk.java.net/~henryjen/ccc/8019551/0/webrev/ > > This webrev makes BaseStream interface public and has AbstractPipeline > implements BaseStream. > Looks good. Paul.

Re: PermGen leak

2013-07-08 Thread David Holmes
On 8/07/2013 4:35 PM, feng l.liu wrote: Hello Experts, I am building up a test tool with ant, but I encountered so many DelegatingClassLoaders that put pressures on PermGen. I know that DelegatingClassLoaders are caused by java reflection. Google search show some posts indicating generation of

Re: Build error with GCC4.8 on Fedora19

2013-07-08 Thread Dan Xu
Adding build-dev mailing list. On 07/08/2013 09:54 PM, Yasu wrote: > Sorry, I forgot to attach a patch: > > -- > > diff -r 52454985425d makefiles/CompileNativeLibraries.gmk > --- a/makefiles/CompileNativeLibraries.gmk Mon Jul 08 19:24:22 2013 -0700 > +++ b/makefiles/CompileNativeLibraries.gmk

hg: jdk8/tl/jdk: 8020095: Fix doclint warnings in java.util.regex

2013-07-08 Thread joe . darcy
Changeset: eab8f4e29f5e Author:darcy Date: 2013-07-08 22:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eab8f4e29f5e 8020095: Fix doclint warnings in java.util.regex Reviewed-by: mchung ! src/share/classes/java/util/regex/MatchResult.java ! src/share/classes/java/util/reg

Re: JDK 8 code review request for JDK-8020095: Fix doclint warnings in java.util.regex

2013-07-08 Thread Joe Darcy
On 07/08/2013 10:23 PM, Mandy Chung wrote: On 7/8/2013 7:10 PM, Joe Darcy wrote: Hello, Please review my changes to resolve (almost all of): JDK-8020095 Fix doclint warnings in java.util.regex http://cr.openjdk.java.net/~darcy/8020095.0/ I think line 32 in Matcher.java should be {@

Re: JDK 8 code review request for JDK-8020095: Fix doclint warnings in java.util.regex

2013-07-08 Thread Mandy Chung
On 7/8/2013 7:10 PM, Joe Darcy wrote: Hello, Please review my changes to resolve (almost all of): JDK-8020095 Fix doclint warnings in java.util.regex http://cr.openjdk.java.net/~darcy/8020095.0/ I think line 32 in Matcher.java should be {@linkplain ...} instead of {@link ...} /*

Re: JDK 8 code review request for JDK-8020095: Fix doclint warnings in java.util.regex

2013-07-08 Thread Joe Darcy
PS Updated webrev so that the ... structure don't have an empty "..." portion. http://cr.openjdk.java.net/~darcy/8020095.1/ -Joe On 07/08/2013 07:10 PM, Joe Darcy wrote: Hello, Please review my changes to resolve (almost all of): JDK-8020095 Fix doclint warnings in java.util.regex

Build error with GCC4.8 on Fedora19

2013-07-08 Thread Yasu
Sorry, I forgot to attach a patch: -- diff -r 52454985425d makefiles/CompileNativeLibraries.gmk --- a/makefiles/CompileNativeLibraries.gmk Mon Jul 08 19:24:22 2013 -0700 +++ b/makefiles/CompileNativeLibraries.gmk Tue Jul 09 13:41:12 2013 +0900 @@ -1987,7 +1987,7 @@ ifneq ($(OPENJDK_TARGET_OS

Build error with GCC4.8 on Fedora19

2013-07-08 Thread Yasu
Hi, I tried to build JDK8 with GCC4.8 on Fedora19. However, build process has been failed as following: -- /usr/src/OpenJDK/tl/jdk/src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c: In function ‘Java_sun_nio_fs_UnixNativeDispatcher_getgrnam0’: /usr/src/OpenJDK/tl/jdk/src/solaris/native/su

hg: jdk8/tl/jdk: 8020091: Fix HTML doclint issues in java.io

2013-07-08 Thread jason . uh
Changeset: 52454985425d Author:juh Date: 2013-07-08 19:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/52454985425d 8020091: Fix HTML doclint issues in java.io Reviewed-by: darcy ! src/share/classes/java/io/DataInput.java ! src/share/classes/java/io/FileInputStream.java !

Re: [8] Request for review: 8020091: Fix HTML doclint issues in java.io

2013-07-08 Thread Jason Uh
Yikes. Just realized I copied the wrong list. My apologies, all. Thanks for the review, Joe! Jason On 07/08/2013 06:37 PM, Joseph Darcy wrote: Hi Jason; Looks good; approved to go back. Thanks, -Joe On 7/8/2013 5:17 PM, Jason Uh wrote: Hi Joe, Please review this changeset, which fixes th

JDK 8 code review request for JDK-8020095: Fix doclint warnings in java.util.regex

2013-07-08 Thread Joe Darcy
Hello, Please review my changes to resolve (almost all of): JDK-8020095 Fix doclint warnings in java.util.regex http://cr.openjdk.java.net/~darcy/8020095.0/ Full text of the patch also included below. For some reason I have not been able to determine, even with the patch, one error re

Re: RFR: JAXP 1.5 for JDK8/7u40: 8016648: FEATURE_SECURE_PROCESSING set to true or false causes SAXParseException to be thrown

2013-07-08 Thread huizhe wang
Hi, I've updated webrev with improved property management, and quality backed by 320 test cases. Thanks Daniel for the help expanding the test suite! Here's the webrev: http://cr.openjdk.java.net/~joehw/jdk8/8016648/webrev/ -Joe On 7/5/2013 6:48 PM, huizhe wang wrote: On 7/5/2013 1:32 AM,

RFR: 8019551: Make BaseStream public

2013-07-08 Thread Henry Jen
Hi, Please review webrev at http://cr.openjdk.java.net/~henryjen/ccc/8019551/0/webrev/ This webrev makes BaseStream interface public and has AbstractPipeline implements BaseStream. The discussion on make this public can be found at http://mail.openjdk.java.net/pipermail/lambda-libs-spec-expert

Final patch for 8014319: Faster division of large integers

2013-07-08 Thread Tim Buktu
Hi, I hope everyone had a good July 4 weekend. I updated the patch for 8014319 (i.e. phase 3 of the BigInteger work). The patch still consists of three files; they can be found at https://gist.github.com/tbuktu/1576025/raw/f93093a412eac86d8d81e03b8b9135eb827f2a84/BigInteger.java.phase3 https://g

RFR 7122142 : (ann) Race condition between isAnnotationPresent and getAnnotations

2013-07-08 Thread Peter Levart
Helo, I need a Reviewer for the following patch: http://cr.openjdk.java.net/~plevart/jdk8-tl/AnnotationType/webrev.05/ This fixes deadlock situation described in bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7122142 The in-depth evaluation of the patch is described in the introd

Re: RFR: 8017141: java.util/stream Spliterators from sequential sources should not catch OOME

2013-07-08 Thread Mandy Chung
On 7/8/2013 11:31 AM, Henry Jen wrote: On 07/04/2013 12:01 AM, Paul Sandoz wrote: On Jul 4, 2013, at 12:51 AM, Henry Jen wrote: Hi, Please review the webrev at http://cr.openjdk.java.net/~henryjen/tl/8017141.0/webrev/ Note that the same change has already been fixed/pushed forrelevant im

Re: RFR: 8017141: java.util/stream Spliterators from sequential sources should not catch OOME

2013-07-08 Thread Henry Jen
On 07/08/2013 11:54 AM, Remi Forax wrote: > On 07/08/2013 08:31 PM, Henry Jen wrote: >> On 07/04/2013 12:01 AM, Paul Sandoz wrote: >>> On Jul 4, 2013, at 12:51 AM, Henry Jen wrote: Hi, Please review the webrev at http://cr.openjdk.java.net/~henryjen/tl/8017141.0/webrev/ >>

Re: RFR (2nd): 8015315: Stream.concat methods

2013-07-08 Thread Henry Jen
On 07/04/2013 12:46 AM, Paul Sandoz wrote: > On Jul 4, 2013, at 9:31 AM, Henry Jen wrote: >> Hi, >> >> I updated the test, and split the ConcatTest.java so we don't encounter >> the ClassNotFoundException issue on test-ng. >> >> Please review the webrev at >> >> http://cr.openjdk.java.net/~henryje

Re: RFR: 8017141: java.util/stream Spliterators from sequential sources should not catch OOME

2013-07-08 Thread Remi Forax
On 07/08/2013 08:31 PM, Henry Jen wrote: On 07/04/2013 12:01 AM, Paul Sandoz wrote: On Jul 4, 2013, at 12:51 AM, Henry Jen wrote: Hi, Please review the webrev at http://cr.openjdk.java.net/~henryjen/tl/8017141.0/webrev/ Note that the same change has already been fixed/pushed forrelevant i

Re: RFR: 8017141: java.util/stream Spliterators from sequential sources should not catch OOME

2013-07-08 Thread Henry Jen
On 07/04/2013 12:01 AM, Paul Sandoz wrote: > On Jul 4, 2013, at 12:51 AM, Henry Jen wrote: >> Hi, >> >> Please review the webrev at >> >> http://cr.openjdk.java.net/~henryjen/tl/8017141.0/webrev/ >> > > Note that the same change has already been fixed/pushed forrelevant > implementations in j.u.

Re: RFR [8016838] java/lang/instrument/RedefineBigClass.sh needs modification

2013-07-08 Thread Seán Coffey
On 08/07/13 17:55, Ivan Gerasimov wrote: Thanks, Seán! I located the build in which the memleak was first introduced -- it is jdk8-b69 (hs25-b13). I've updated the bug http://bugs.sun.com/view_bug.do?bug_id=8019845 with this. So what is the correct procedure to go forward now? Should I upda

Re: RFR 8019395 Consolidate StreamSupport.{stream, parallelStream} into a single method

2013-07-08 Thread Paul Sandoz
I updated the patch and fixed JavaDoc issues to StreamSupport based on feedback from Henry. Changes can be seen here: http://hg.openjdk.java.net/lambda/lambda/jdk/rev/be7d33d54613 Paul. On Jul 8, 2013, at 5:22 PM, Paul Sandoz wrote: > Hi, > > This patch reduced the methods on j.u.stream.S

Re: RFR [8016838] java/lang/instrument/RedefineBigClass.sh needs modification

2013-07-08 Thread Ivan Gerasimov
Thanks, Seán! I located the build in which the memleak was first introduced -- it is jdk8-b69 (hs25-b13). I've updated the bug http://bugs.sun.com/view_bug.do?bug_id=8019845 with this. So what is the correct procedure to go forward now? Should I update the webrev to include changes to the pro

Re: RFR - Changes to address CCC 8014135: Support for statically linked agents

2013-07-08 Thread BILL PITTORE
On 7/4/2013 12:41 PM, Alan Bateman wrote: On 03/07/2013 22:17, BILL PITTORE wrote: These changes address bug 8014135 which adds support for statically linked agents in the VM. This is a followup to the recent JNI spec changes that addressed statically linked JNI libraries( 8005716). The JEP fo

Re: @CallerSensitive as public API ?

2013-07-08 Thread David M. Lloyd
On 6/25/13 5:42 PM, Mandy Chung wrote: On 6/25/13 3:04 PM, David Lloyd wrote: We have a use case within our security manager implementation that *can* be solved with the existing getClassContext method, which returns the whole stack, except we don't *need* the whole stack, just one specific fra

PermGen leak

2013-07-08 Thread feng l.liu
Hello Experts, I am building up a test tool with ant, but I encountered so many DelegatingClassLoaders that put pressures on PermGen. I know that DelegatingClassLoaders are caused by java reflection. Google search show some posts indicating generation of DelegatingClassLoader will be depress

Re: @CallerSensitive as public API ?

2013-07-08 Thread David Lloyd
We have a use case within our security manager implementation that *can* be solved with the existing getClassContext method, which returns the whole stack, except we don't *need* the whole stack, just one specific frame. Maybe SecurityManager is a good place for this API? As an aside, getClas

Re: @CallerSensitive as public API ?

2013-07-08 Thread David Lloyd
I would say the opposite is true; the Class is safe but the ClassLoader is privileged. Getting a ClassLoader from a Class requires a security permission when a security manager is present. -- - DML On Jun 25, 2013, at 8:57 PM, Peter Levart wrote: > > On 06/25/2013 09:24 PM, Mandy Chung wro

RFR 8020040: Improve and generalize the F/J tasks to handle right or left-balanced trees

2013-07-08 Thread Paul Sandoz
Hi, This patch, contributed by Doug Lea, improves stream resource management of F/J tasks when processing right-balanced (or more accurately right-heavy) trees (e.g. those created from sequential sources): http://cr.openjdk.java.net/~psandoz/tl/JDK-8020040-tasks/webrev/ It took us a while bu

Re: Possible HashMap update

2013-07-08 Thread Doug Lea
On 07/05/13 04:55, Paul Sandoz wrote: I played with these in the lambda repo. I needed to make the following additional change for things to compile: --- a/src/share/classes/java/io/ExpiringCache.javaFri Jul 05 10:04:00 2013 +0200 +++ b/src/share/classes/java/io/ExpiringCache.javaFri

RFR 8019395 Consolidate StreamSupport.{stream, parallelStream} into a single method

2013-07-08 Thread Paul Sandoz
Hi, This patch reduced the methods on j.u.stream.StreamSupport from 16 to 8: http://cr.openjdk.java.net/~psandoz/tl/JDK-8019395-StreamSupport/webrev/ Instead of methods stream/parallelStream, and inStream/intParallelStream etc, there is just stream, and intStream etc, that take a boolean valu

hg: jdk8/tl/nashorn: 20 new changesets

2013-07-08 Thread sundararajan . athijegannathan
Changeset: 313bdcd2fd22 Author:sundar Date: 2013-07-03 00:08 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/313bdcd2fd22 8019629: void operator should always evaluate to undefined Reviewed-by: jlaskey ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/interna

hg: jdk8/tl/jdk: 8010734: NPG: The test MemoryTest.java needs to be updated to support metaspace

2013-07-08 Thread jesper . wilhelmsson
Changeset: 715d00c95fb2 Author:ehelin Date: 2013-07-08 11:30 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/715d00c95fb2 8010734: NPG: The test MemoryTest.java needs to be updated to support metaspace Reviewed-by: alanb ! test/ProblemList.txt ! test/java/lang/management/Memo

Re: Non Inherited repeated annotations should not be searched from child Class

2013-07-08 Thread Joel Borggren-Franck
Hi, Thanks for reporting this. As Alex wrote on the spec list [1] he has clarified the spec. There is a bug filed for this but I don't have time to work on it at the moment. I'll get around to fixing it in the not too distant future though. [1]: http://mail.openjdk.java.net/pipermail/enhanced-m

Re: RFR: 8016341 java/lang/ref/OOMEInReferenceHandler.java failing intermittently

2013-07-08 Thread Chris Hegarty
On 8 Jul 2013, at 03:33, David Holmes wrote: > Still looking for a reviewer for this please. The test change looks ok to me. -Chris > Thanks, > David > > On 5/07/2013 9:22 AM, David Holmes wrote: >> Hi Peter, >> >> On 2/07/2013 5:19 PM, Peter Levart wrote: >>> Looking at original code once

Re: RFR: 8016341 java/lang/ref/OOMEInReferenceHandler.java failing intermittently

2013-07-08 Thread David Holmes
On 8/07/2013 5:49 PM, Peter Levart wrote: On 07/08/2013 09:19 AM, David Holmes wrote: In testing it though I simply exposed the remaining flaws in the ReferenceHandler code. We can still kill the ReferenceHandler thread with an OOME when it tries to load the Cleaner class (running with a 5M heap

Re: RFR: 8015317: Optional.filter, map, and flatMap

2013-07-08 Thread Paul Sandoz
On Jul 5, 2013, at 11:37 PM, Henry Jen wrote: > Hi, > > Please review the webrev at > > http://cr.openjdk.java.net/~henryjen/ccc/8015317.0/webrev/ > Looks OK to me. Paul. > Which adds following method to Optional, > > public static Optional ofNullable(T value) {} > public Optional filter

Re: RFR: 8016341 java/lang/ref/OOMEInReferenceHandler.java failing intermittently

2013-07-08 Thread Peter Levart
On 07/08/2013 09:19 AM, David Holmes wrote: Hi Peter, On 8/07/2013 5:01 PM, Peter Levart wrote: On 07/05/2013 01:22 AM, David Holmes wrote: Hi Peter, On 2/07/2013 5:19 PM, Peter Levart wrote: Looking at original code once again, I think this was actually a bug. The WeakReference instance con

Re: RFR: 8016341 java/lang/ref/OOMEInReferenceHandler.java failing intermittently

2013-07-08 Thread David Holmes
Hi Peter, On 8/07/2013 5:01 PM, Peter Levart wrote: On 07/05/2013 01:22 AM, David Holmes wrote: Hi Peter, On 2/07/2013 5:19 PM, Peter Levart wrote: Looking at original code once again, I think this was actually a bug. The WeakReference instance constructed in (old) line 82, can be GCed right

Re: RFR: 8016341 java/lang/ref/OOMEInReferenceHandler.java failing intermittently

2013-07-08 Thread Peter Levart
On 07/05/2013 01:22 AM, David Holmes wrote: Hi Peter, On 2/07/2013 5:19 PM, Peter Levart wrote: Looking at original code once again, I think this was actually a bug. The WeakReference instance constructed in (old) line 82, can be GCed right away, since nobody is using the local variable after a