Hi Brian,
In the javadoc change, is there a reason for
[1, 12],
rather than just
[1, 12],
?
The update should discuss how normal (that is non-subnormal) values are
handled with reduced precision.
The change should include tests of the newly specified behavior.
Cheers,
-Joe
On 0
Looks fine.
Thanks,
-Joe
On 07/17/2013 04:19 PM, Jason Uh wrote:
Thanks, Mike.
I'll add that before I push.
On 7/17/13 4:00 PM, Mike Duigou wrote:
Looks good to me.
You could add {@code} around true in ObjectStreamField
Mike
On Jul 17 2013, at 15:40 , Jason Uh wrote:
Hi Joe,
Could I p
Hello,
In Random.java, I would prefer if the size manipulation of the
exponent was removed instead of
373 * All 224
possible {@code float} values
just
373 * All 224 possible {@code float} values.
Also, I think the changes in Scanner would be better of the JLS-style
grammar syn
Changeset: 1e533c1bfb01
Author:jjg
Date: 2013-07-17 19:12 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1e533c1bfb01
8020313: doclint doesn't reset HTML anchors correctly
Reviewed-by: mcimadamore
! src/share/classes/com/sun/tools/doclint/Checker.java
+ test/tools/docl
Changeset: 1476d54fdc61
Author:jjg
Date: 2013-07-17 19:16 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1476d54fdc61
8020664: doclint gives incorrect warnings on normal package statements
Reviewed-by: mcimadamore
! src/share/classes/com/sun/tools/doclint/DocLint.java
Changeset: 80e75aa6a707
Author:jjg
Date: 2013-07-17 18:18 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/80e75aa6a707
8014636: TestLiteralCodeInPre fails on windows
Reviewed-by: ksrini
! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java
! src/s
Hi Joe,
I've updated the webrev
http://cr.openjdk.java.net/~bpb/8020641/
to include the minor changes pointed out by Tim
http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-July/019033.html
Thanks,
Brian
On Jul 16, 2013, at 11:26 PM, Joe Darcy wrote:
> This latest version looks good t
I'm not familiar with the JSR 166 CVS so perhaps someone with more history
could enlighten me. Otherwise, I would think that any such sync would be the
subject of a separate issue.
On Jul 17, 2013, at 2:42 PM, Martin Buchholz wrote:
> I believe most doclint warnings have already been fixed for
Thanks, Mike.
I'll add that before I push.
On 7/17/13 4:00 PM, Mike Duigou wrote:
Looks good to me.
You could add {@code} around true in ObjectStreamField
Mike
On Jul 17 2013, at 15:40 , Jason Uh wrote:
Hi Joe,
Could I please get a review of this change? This changeset fixes doclint issue
Looks good to me.
You could add {@code} around true in ObjectStreamField
Mike
On Jul 17 2013, at 15:40 , Jason Uh wrote:
> Hi Joe,
>
> Could I please get a review of this change? This changeset fixes doclint
> issues in java.io.
>
> Webrev: http://cr.openjdk.java.net/~juh/8020426/webrev.02/
Hi Joe,
Could I please get a review of this change? This changeset fixes doclint
issues in java.io.
Webrev: http://cr.openjdk.java.net/~juh/8020426/webrev.02/
Changes have been checked with specdiff.
Thanks,
Jason
This is the command which I have been using:
../build/macosx-x86_64-normal-server-fastdebug/jdk/bin/javac
-Xdoclint:all/protected -d /tmp -XDignore.symbol.file
src/share/classes/java/util/
On Jul 17, 2013, at 2:05 PM, Martin Buchholz wrote:
> To follow up, what standard of cleanliness is expec
Will do so once what has been posted is approved.
On Jul 17, 2013, at 2:00 PM, Martin Buchholz wrote:
> Queue.java and Deque.java are primarily maintained in Doug's CVS and should
> be updated there. Please remove them from this change.
>
> Doug and I will work on cleaning up doclint warnings
Hi Tim,
Thanks for pointing these out. The SIZE error is mine: overzealous use of
"replace all."
I am inclined to fold these updates into this subsequent patch
http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-July/019009.html
as it is simpler.
Brian
On Jul 17, 2013, at 1:53 PM, Tim
I noticed a couple of minor things.
In MutableBigInteger, I made an error in the javadoc where it says
+ * Has the same effect as {@code addend.leftShift(32*ints); add(b);}
+ * but doesn't change the value of {@code b}.
when it should be
+ * Has the same effect as {@code addend.leftS
Hi Joe,
The changes requested below have been made and the webrev updated accordingly:
http://cr.openjdk.java.net/~bpb/8020539/
The HTML for Scanner may be viewed here
http://cr.openjdk.java.net/~bpb/Scanner.html
Thanks,
Brian
On Jul 16, 2013, at 1:59 PM, Joe Darcy wrote:
> For the changes
Changeset: 8c4424890028
Author:amurillo
Date: 2013-06-28 02:33 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8c4424890028
8019302: new hotspot build - hs25-b40
Reviewed-by: jcoomes
! make/hotspot_version
Changeset: 8cff1de240de
Author:zgu
Date: 2013-06-25 17:2
Changeset: adf49c3ef83c
Author:katleman
Date: 2013-07-11 10:13 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/adf49c3ef83c
Added tag jdk8-b98 for changeset 15e5bb51bc0c
! .hgtags
Changeset: 74ec7b48e3be
Author:lana
Date: 2013-07-17 00:34 -0700
URL: http://hg
Changeset: 3f67804ab613
Author:katleman
Date: 2013-07-11 10:13 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/3f67804ab613
Added tag jdk8-b98 for changeset 3370fb6146e4
! .hgtags
Changeset: bdeef606be8e
Author:katleman
Date: 2013-07-11 10:13 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bdeef606be8e
Added tag jdk8-b98 for changeset ce5a90df517b
! .hgtags
Changeset: 39ec5d8a691b
Author:mcimadamore
Date: 2013-07-11 14:07 +0100
URL:
Changeset: 10a1ab9e20a4
Author:katleman
Date: 2013-07-11 10:13 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/10a1ab9e20a4
Added tag jdk8-b98 for changeset 542b7803f038
! .hgtags
Changeset: 81cbb18d558a
Author:lana
Date: 2013-07-17 00:36 -0700
URL: http:/
Changeset: 2c26ccf0a85b
Author:tbell
Date: 2013-07-08 07:20 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2c26ccf0a85b
8012925: [parfait] Missing return value in
jdk/src/macosx/native/sun/awt/AWTEvent.m
Reviewed-by: katleman, leonidr
Contributed-by: petr.pche...@oracle.com
Changeset: 8ef83d4b23c9
Author:katleman
Date: 2013-07-11 10:13 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/8ef83d4b23c9
Added tag jdk8-b98 for changeset b1fb4612a2ca
! .hgtags
Changeset: 0d0c983a817b
Author:tbell
Date: 2013-07-09 08:35 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/rev/0d0c983a817b
8009315: F# on PATH breaks Cygwin tools (mkdir, echo, mktemp ...)
Reviewed-by: erikj
! common/autoconf/generated-configure.sh
! common/autoconf/toolchain_windo
I don't know the difference between (*env)->NewStringUTF(env, buf) and
JNU_NewStringPlatform(env, buf). Does the JNU_NewStringPlatform()
function currently fail to process non-western locale? According to the
code, JNU_NewStringPlatform() is also trying to use the right encoding
for the give st
Hello all;
Paul is on vacation (well deserved) and Doug/Guy/others have been continuing to
work on SplittableRandom. As the code is continuing to evolve quickly I won't
immediately post an update to this list but encourage those interested to
follow along with updates either in the lambda repo:
Thanks,
Here is new version with Dan's correction:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8016579/webrev.02/
Regards,
-uta
On 7/16/2013 11:07 PM, Dan Xu wrote:
I agree. Is jdk_util.c or jni_util.c or any file under native/common/
a good place?
The fix looks good to me.
One sma
Changeset: 10711bd8bb2d
Author:jlahoda
Date: 2013-07-17 15:08 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/10711bd8bb2d
8020586: Warning produced for an incorrect file
Summary: Always using DeferredLintHandler.immediateHandler when processing
import classes
Reviewed-
Changeset: 44e27378f523
Author:mcimadamore
Date: 2013-07-17 14:04 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/44e27378f523
8012242: Lambda compatibility and checked exceptions
Summary: Inference variables in 'throws' clause with no constraints should be
inferred as
29 matches
Mail list logo
