Re: i18n dev RFR: 8077685: (tz) Support tzdata2015d

Looks good to me. Masayoshi On 4/29/2015 11:37 PM, Aleksej Efimov wrote: Hi, Please, review the fix for adding the latest tzdata2015d to JDK9. The JTREG and JPRT tests were executed. No failures were observed. Thank you, Aleksej [1] JBS: https://bugs.openjdk.java.net/browse/JDK-8077685 [2]

Re: RFR: JDK-8074003 java.time.zone.ZoneRules.getOffset(java.time.Instant) can be optimized

On 04/29/2015 05:35 PM, Roger Riggs wrote: Hi Peter, There should be two changesets; so pretend the truncation has been performed for this change. It maybe useful to backport the performance improvement to jdk 8 but the spec change will have to be in 9 (or wait for a maintenance release).

Re: RFR: 8077846: improve locking strategy for readConfiguration(), reset(), and initializeGlobalHandlers()

On 04/28/2015 05:46 PM, Peter Levart wrote: On 04/28/2015 04:57 PM, Daniel Fuchs wrote: Here's my attempt at simplifying this: http://cr.openjdk.java.net/~plevart/misc/LogManager.synchronization/webrev.01/ LogManager can be subclassed, and subclasses may override reset() for different

Re: RFR: JDK-8074003 java.time.zone.ZoneRules.getOffset(java.time.Instant) can be optimized

The approach works for me, and the patch is valid as is. Stephen On 30 April 2015 at 11:24, Peter Levart peter.lev...@gmail.com wrote: On 04/29/2015 05:35 PM, Roger Riggs wrote: Hi Peter, There should be two changesets; so pretend the truncation has been performed for this change. It

Re: RFR: 8077846: improve locking strategy for readConfiguration(), reset(), and initializeGlobalHandlers()

Hi Peter, Sorry I didn't reply to your last mail. I still intend to. more on the current mail below... On 30/04/15 13:08, Peter Levart wrote: On 04/28/2015 05:46 PM, Peter Levart wrote: On 04/28/2015 04:57 PM, Daniel Fuchs wrote: Here's my attempt at simplifying this:

Re: RFR [9] 8079075: some docs cleanup for CORBA - part 1

P.S. Sorry, not sure if changes like d62023 - {@literal d62023} (see, e.g., ValueBoxGen24.java) are what expected; please correct me if I'm wrong. But something should be done; otherwise d62023 is interpreted as an unknown HTML tag causing the errors. Thanks, Alexander On 30.04.2015 14:31,

Re: RFR: JDK-8074003 java.time.zone.ZoneRules.getOffset(java.time.Instant) can be optimized

Hi Peter, Yes, go ahead with the patch as is. Thanks, Roger On 4/30/2015 6:24 AM, Peter Levart wrote: On 04/29/2015 05:35 PM, Roger Riggs wrote: Hi Peter, There should be two changesets; so pretend the truncation has been performed for this change. It maybe useful to backport the

Re: RFR [9] 8079075: some docs cleanup for CORBA - part 1

Hi Alexander, Thanks for working through all these changes. 0) Is there an upstream version of any of this code? Making even cosmetic changes would make future versions harder to merge. 1) For files that we don't typically generate javadoc for, it is simpler to avoid adding unnecessary

Re: RFR: 8077846: improve locking strategy for readConfiguration(), reset(), and initializeGlobalHandlers()

On 28/04/15 17:46, Peter Levart wrote: On 04/28/2015 04:57 PM, Daniel Fuchs wrote: Here's my attempt at simplifying this: http://cr.openjdk.java.net/~plevart/misc/LogManager.synchronization/webrev.01/ LogManager can be subclassed, and subclasses may override reset() for different

Re: RFR [9] 8079075: some docs cleanup for CORBA - part 1

On 30/04/2015 14:47, Roger Riggs wrote: Hi Alexander, Thanks for working through all these changes. 0) Is there an upstream version of any of this code? Making even cosmetic changes would make future versions harder to merge. No. This was the case a long time ago but for many releases

RFR [9] 8040147: tidy warnings cleanup for javax.transaction

Hello, Could you please review the fix http://cr.openjdk.java.net/~avstepan/8040147/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8040147 Just a very minor fix of docs markup. Thanks, Alexander

Re: RFR [9] 8079075: some docs cleanup for CORBA - part 1

Hello Roger, Thank you for the notes; please see the updated webrev: http://cr.openjdk.java.net/~avstepan/8079075/webrev.01/ Regards, Alexander On 30.04.2015 16:47, Roger Riggs wrote: Hi Alexander, Thanks for working through all these changes. 0) Is there an upstream version of any of this

Re: RFR [9] 8079075: some docs cleanup for CORBA - part 1

Hi Alexander, The improvements look good to me. Thank you, Roger On 4/30/2015 12:35 PM, alexander stepanov wrote: Hello Roger, Thank you for the notes; please see the updated webrev: http://cr.openjdk.java.net/~avstepan/8079075/webrev.01/ Regards, Alexander On 30.04.2015 16:47, Roger

Re: RFR [9] 8079075: some docs cleanup for CORBA - part 1

Thanks! - Исходное сообщение - От: roger.ri...@oracle.com Кому: alexander.v.stepa...@oracle.com Копия: core-libs-dev@openjdk.java.net Отправленные: Четверг, 30 Апрель 2015 г 21:41:05 GMT +03:00 Москва, Санкт-Петербург, Волгоград Тема: Re: RFR [9] 8079075: some docs cleanup for CORBA -

Re: RFR: 8077846: improve locking strategy for readConfiguration(), reset(), and initializeGlobalHandlers()

On 04/30/2015 07:42 AM, Daniel Fuchs wrote: http://cr.openjdk.java.net/~dfuchs/webrev_8077846/webrev.00/ http://cr.openjdk.java.net/~plevart/misc/LogManager.synchronization/webrev.02/ I reviewed both of the above webrevs. TestConfigurationLock.java Copyright year should be 2015

Re: RFR: 8077846: improve locking strategy for readConfiguration(), reset(), and initializeGlobalHandlers()

On 04/30/2015 04:42 PM, Daniel Fuchs wrote: On 28/04/15 17:46, Peter Levart wrote: On 04/28/2015 04:57 PM, Daniel Fuchs wrote: Here's my attempt at simplifying this: http://cr.openjdk.java.net/~plevart/misc/LogManager.synchronization/webrev.01/ LogManager can be subclassed, and