Re: RFR of JDK-8174698: Fix @since in module-info.java in dev/corba repo

On 10/02/2017 03:29, Hamlin Li wrote: Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8174698 webrev: http://cr.openjdk.java.net/~mli/8174698/webrev.00/ Adding @since 9 to each of the java.* modules in the corba, jaxp and jaxws repos looks fine. -Alan

RFR of JDK-8174698: Fix @since in module-info.java in dev/corba repo

Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8174698 webrev: http://cr.openjdk.java.net/~mli/8174698/webrev.00/ Thank you -Hamlin

RFR of JDK-8174697: Fix @since in module-info.java in dev/jaxws repo

Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8174697 webrev: http://cr.openjdk.java.net/~mli/8174697/webrev.00/ Thank you -Hamlin

RFR of JDK-8174696: Fix @since in module-info.java in dev/jaxp repo

Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8174696 webrev: http://cr.openjdk.java.net/~mli/8174696/webrev.00/ Thank you -Hamlin

Re: RFR of JDK-8173957: Fix @since in module-info.java in dev/jdk repo

On 2017/2/9 20:22, Alan Bateman wrote: On 09/02/2017 07:24, Hamlin Li wrote: Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8173957 webrev: http://cr.openjdk.java.net/~mli/8173957/webrev.00/ Looks okay, it would be good to add it to the modules in the

Re: Update: RFR 8172974 [JAXP] XALAN: Wrong result when transforming namespace unaware StAX Input

Hi Christoph, The performance results showed two regressions, one on Linux and another Solaris SPARC, while at the same time a bit more than half of the results across 5 platforms were negative. This is unfortunate. We're too close to the release date, it's super sensitive for jaxp on the

[9] RFR: 8169715: jimage fails with IAE when attempts to inspect an empty file

Hi, Could please someone review the fix for JDK-8169715. The problem occurs when jimage tool is attempting to read an empty or incomplete image. The current implementation works with ByteBuffer and always relies on that there's enough data to inspect the image. This results in IAE inside

Re: RFR(XS): 8033909: Objects.requireNonNull(T, Supplier) doesn't specify what happens if the passed supplier is null itself

Adding Mike’s current email. -jeff > On Feb 9, 2017, at 10:18 AM, Volker Simonis wrote: > > Hi, > > I want to finally resolve this long standing issue (or close it as > "will not fix" if that's not possible): > >

Re: RFR - Update: 8168664 [JAXP] XALAN: xsl:element generates namespace prefixes if namespace is given as URI only

On 2/7/2017 11:28 PM, Langer, Christoph wrote: Hi Joe, welcome back. Thanks! This sounds reasonable. I’ll prepare a change for JDK10. Hopefully it'd open soon so that you don't have to keep it for too long. Best, Joe Thanks Christoph *From:*Joe Wang

RFR(XS): 8033909: Objects.requireNonNull(T, Supplier) doesn't specify what happens if the passed supplier is null itself

Hi, I want to finally resolve this long standing issue (or close it as "will not fix" if that's not possible): http://cr.openjdk.java.net/~simonis/webrevs/2017/8033909/ This change has already been discussed in length on the mailing list:

Re: [9] RFR 8170113: jimage extract to readonly directory causes MissingResourceException

Hi, looks ok for me. Simple and safe fix. —Andrey > On 9 Feb 2017, at 13:03, Denis Kononenko wrote: > > > Hi, > >> >> On 06/02/2017 10:27, Denis Kononenko wrote: >>> Hi, >>> >>> Could someone please review this very small fix. >>> >>> The class JImageTask >>

Re: JDK 9 RFR for JDK-8174241: ProblemList update for TestWsImport, JdbMethodExitTest and jimage tests

+1 > On Feb 9, 2017, at 4:32 AM, Amy Lu wrote: > > Please review the ProblemList.txt cleanup on updating bugid for several tests. > > javax/xml/ws/clientjar/TestWsImport.java8170370 generic-all > This test is in ProblemList, related bug JDK-8170370 has been resolved. Test

Re: RFR of JDK-8173957: Fix @since in module-info.java in dev/jdk repo

On 09/02/2017 07:24, Hamlin Li wrote: Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8173957 webrev: http://cr.openjdk.java.net/~mli/8173957/webrev.00/ Looks okay, it would be good to add it to the modules in the other repos while you're at it. -Alan

Re: RFR of JDK-8173957: Fix @since in module-info.java in dev/jdk repo

Hi Hamlin, This is fine. I am not sure why when I added the comments to the various module-info.java, I did not include @since. Best Lance > On Feb 9, 2017, at 2:24 AM, Hamlin Li wrote: > > Would you please review the below patch? > > bug:

Re: [9] RFR 8170113: jimage extract to readonly directory causes MissingResourceException

Hi, > > On 06/02/2017 10:27, Denis Kononenko wrote: > > Hi, > > > > Could someone please review this very small fix. > > > > The class JImageTask > (src/jdk.jlink/share/classes/jdk/tools/jimage/JImageTask.java) has > references to an info message by 'err.cannot.create.dir' key. > Unfortunately

JDK 9 RFR for JDK-8174241: ProblemList update for TestWsImport, JdbMethodExitTest and jimage tests

Please review the ProblemList.txt cleanup on updating bugid for several tests. javax/xml/ws/clientjar/TestWsImport.java8170370 generic-all This test is in ProblemList, related bug JDK-8170370 has been resolved. Test is going to be revisited in JDK-8173317

Re: RFR(s): 8174194: Several java/lang tests failing due to undeclared module dependencies.

Hi Mandy, Thank you for review and remarks. http://cr.openjdk.java.net/~skovalev/8174194/webrev.01/ 08.02.17 19:06, Mandy Chung wrote: On Feb 8, 2017, at 6:13 AM, Sergei Kovalev wrote: Thank you for review. On 08/02/17 13:51, Sergei Kovalev wrote: WebRev: