Re: RFR: 8195976: Add JNDI test javax/naming/dns/AttributeTests/GetAny.java

A reminder that this need a reviewer's approval, many thanks Regards, Chris > On 23 Jan 2018, at 6:14 PM, Chris Yin wrote: > > Thank you Alan, I just moved it to com/sun/jndi/dns/ as you suggested and > removed unused "@modules jdk.naming.dns/com.sun.jndi.dns”, updated

Re: [JDK 11] RFR 8195981: Move some tests to OpenJDK for jdk_lang test group

On 03/02/2018 2:36 AM, mandy chung wrote: On 2/2/18 7:02 AM, Amy Lu wrote: Please review the patch to move some tests to OpenJDK for jdk_lang test group. bug: https://bugs.openjdk.java.net/browse/JDK-8195981 webrev: http://cr.openjdk.java.net/~amlu/8195981/webrev.00/ I suggest to merge

Re: Cannot add attribute into main attributes of a jar if there is no version

duplicate of https://bugs.openjdk.java.net/browse/JDK-6910466? On 30.01.2018 02:44, Weijun Wang wrote: On Jan 30, 2018, at 8:57 AM, mandy chung wrote: On 1/29/18 4:22 PM, Weijun Wang wrote: Ping again. On Jan 22, 2018, at 1:12 PM, Weijun Wang

Re: RFR 8195059: Update java.net Socket and DatagramSocket implementations to use Cleaner

* Roger Riggs: > Updated in place. >   http://cr.openjdk.java.net/~rriggs/webrev-net-cleanup-8195059/ Doesn't this leak the file descriptor of SocketCleanable.register throws?