Re: RFR: 8197812: (ref) Data race in Finalizer

Hi Martin, On 02/14/18 02:30, Martin Buchholz wrote: Unlike most fixes to data races, this one should benefit performance. http://cr.openjdk.java.net/~martin/webrevs/jdk/Finalizer-data-race/ https://bugs.openjdk.java.net/browse/JDK-8197812 Nice catch (for java-tsan tool)! Although I think

Re: RFR: 8194154: JDK crashes parsing path string contains '//' on linux

HI, Brian Thanks, updated on same link. I don't have platforms other than linux so could not test on those platforms. BTW, tried jtreg, it seems the version has not modified to run with current jdk repo. Thanks Yumin On Tue, Feb 13, 2018 at 5:52 PM, Brian Burkhalter <

Re: RFR: 8194154: JDK crashes parsing path string contains '//' on linux

Hi, As for the test alone you could add the @requires annotation [1] @requires (os.family == "linux") | (os.family == "mac") | (os.family == "solaris") | (os.family == "aix") instead of programmatically exiting if the platform is not Windows. (I am assuming that this should be run on all Unix

RFR: 8197893: Mistaken type check in CheckedEntrySet.toArray

http://cr.openjdk.java.net/~martin/webrevs/jdk/CheckedEntrySet-toArray/ https://bugs.openjdk.java.net/browse/JDK-8197893

RFR: 8197812: (ref) Data race in Finalizer

Unlike most fixes to data races, this one should benefit performance. http://cr.openjdk.java.net/~martin/webrevs/jdk/Finalizer-data-race/ https://bugs.openjdk.java.net/browse/JDK-8197812

Re: RFR: 8194154: JDK crashes parsing path string contains '//' on linux

Hi, I have update the webrev: http://cr.openjdk.java.net/~minqi/8194154/webrev1/ In this version, as suggested by Alan(thanks!), property of "user.dir" is cached and behave like it is 'read only'. The change made to *inux as well as windows. Since property of "user.dir" is cached, any

Re: RFR: 8194154 patch for crash at File.getCanonicalPath()

Alan, In fact, if property "user.dir" is cached, the problem will go away without any changes to native or UnixFileSystem.java, since it won't canonicalize the string supplied from user. The output will be getProperty("user.dir") + "/" + file. (The result is not as expected, user can not

Re: Oracle Java 8u161 regression in XML Schema Factory

Hello, 2018-01-25 17:41 GMT+01:00 Seán Coffey : > > Classes nearer to those below were touched via JDK-8186080: Transform XML > interfaces > http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/cb84156d54b2 > http://hg.openjdk.java.net/jdk8u/jdk8u/jaxp/rev/08a44c164993 > >

Re: RFR 8190378: Java EE and CORBA modules removal

Hi David, I thought I did make that change. Let me go back and double check and if not, will push. My build worked fine but maybe I missed this in a merge. Best Lance > On Feb 13, 2018, at 8:05 AM, David Holmes wrote: > > Lance, > > In Docs.gmk you seem to have

Re: RFR: JDK-8021560,(str) String constructors that take ByteBuffer

On 2/13/18, 12:41 AM, Alan Bateman wrote: public int getBytes(byte[] dst, int offset, Charset cs); public int getBytes(byte[] dst, int offset, String csname); public int getBytes(ByteBuffer bytes, Charset cs); public int getBytes(ByteBuffer bytes, Charset csn); These four methods encode as

Re: [11] RFR: 8197829: Optimize CLDRCalendarDataProviderImpl::retrieveInteger

On 2018-02-13 17:51, Naoto Sato wrote: Hi Claes, Looks good to me. Thanks, Naoto! Please add noreg-perf tag to the issue. Done. /Claes

Re: [11] RFR: 8197829: Optimize CLDRCalendarDataProviderImpl::retrieveInteger

Hi Claes, Looks good to me. Please add noreg-perf tag to the issue. Naoto On 2/13/18 2:29 AM, Claes Redestad wrote: Hi, please review this improvement to the retrieveInteger method in CLDRCalendarDataProviderImpl. Bug: https://bugs.openjdk.java.net/browse/JDK-8197829 Webrev:

Re: RFR: 8041626: [Event Request] Shutdown reason

Hi Alan, > On 12 Feb 2018, at 09:02, Alan Bateman wrote: > > > > On 12/02/2018 07:07, David Holmes wrote: >> >>> Okay, I’ve removed the code related to the status field, certainly makes >>> the change a bit less intrusive. >>> >>> Updated webrev:

Re: RFR: 8041626: [Event Request] Shutdown reason

Hi David, > On 12 Feb 2018, at 08:07, David Holmes wrote: > > Hi Robin, > > On 10/02/2018 1:41 AM, Robin Westberg wrote: >> Hi David, >>> On 9 Feb 2018, at 05:22, David Holmes >>

Re: RFR: JDK-8021560,(str) String constructors that take ByteBuffer

On Tue, Feb 13, 2018 at 2:41 AM, Alan Bateman wrote: > On 13/02/2018 06:24, Xueming Shen wrote: >> >> Hi, >> >> Please help review the proposal to add following constructors and methods >> in String >> class to take ByteBuffer as the input and output data buffer. >> >>

Re: IllegalAccessException trying to load a ResourceBundle in 9u181

On 13/02/2018 14:05, Vitaly Davidovich wrote: Right, thanks Alan.  While we're on the subject, when do you expect java.base to be fully encapsulated? TBD.

Re: IllegalAccessException trying to load a ResourceBundle in 9u181

On Tue, Feb 13, 2018 at 8:57 AM, Alan Bateman wrote: > > > On 13/02/2018 13:03, Vitaly Davidovich wrote: > >> : >> So I tried calling getBundle(..., Object.class.getModule()), and that >> worked - great. Interestingly, I didn't have to add-opens (or add-export >> for

Re: IllegalAccessException trying to load a ResourceBundle in 9u181

On 13/02/2018 13:03, Vitaly Davidovich wrote: : So I tried calling getBundle(..., Object.class.getModule()), and that worked - great. Interestingly, I didn't have to add-opens (or add-export for that matter). Is that expected? It works because the sun.security.util.AuthResources resource

Re: RFR 8190378: Java EE and CORBA modules removal

Lance, In Docs.gmk you seem to have missed this: 445 446 # Setup generation of the Java SE API documentation (javadoc + modulegraph) 447 448 # The Java SE module scope is just java.se.ee and its transitive

Re: IllegalAccessException trying to load a ResourceBundle in 9u181

Hi Mandy, Thanks very much for your response. Some comments inline ... On Mon, Feb 12, 2018 at 7:44 PM, mandy chung wrote: > > > On 2/12/18 12:36 PM, Vitaly Davidovich wrote: > > Hi all, > > I'm not sure if core-libs is the right mailing list for jigsaw/modules >

Re: IllegalAccessException trying to load a ResourceBundle in 9u181

On Mon, Feb 12, 2018 at 8:14 PM, David Holmes wrote: > Hi Vitaly, > > See this thread: > > http://mail.openjdk.java.net/pipermail/jigsaw-dev/2018-Febru > ary/013584.html Thanks David! > > > David > > > On 13/02/2018 6:36 AM, Vitaly Davidovich wrote: > >> Hi all, >> >>

[11] RFR: 8197829: Optimize CLDRCalendarDataProviderImpl::retrieveInteger

Hi, please review this improvement to the retrieveInteger method in CLDRCalendarDataProviderImpl. Bug: https://bugs.openjdk.java.net/browse/JDK-8197829 Webrev: http://cr.openjdk.java.net/~redestad/8197829/jdk.00/ This deals with a tiny startup regression that appeared in 10+36 on some

Re: RFR: JDK-8021560,(str) String constructors that take ByteBuffer

On 13/02/2018 06:24, Xueming Shen wrote: Hi, Please help review the proposal to add following constructors and methods in String class to take ByteBuffer as the input and output data buffer. public String(ByteBuffer bytes, Charset cs); public String(ByteBuffer bytes, String csname); These

Re: RFR: JDK-8021560,(str) String constructors that take ByteBuffer

Is it necessary to add the "String csname" variants at this point in Java's lifetime? Don't most people use instances of Charset now? Stephen On 13 February 2018 at 06:24, Xueming Shen wrote: > Hi, > > Please help review the proposal to add following constructors and