Re: Floating Point and Arithmetic Changes for Java SE Lnguage

2018-03-07 Thread Mario Torre
I don’t remember ever having read another reply to this mailing list with so much interest in years! Cheers, Mario On Wed 7. Mar 2018 at 21:36, joe darcy wrote: > Legend has it that after the ancient Greek Hippasus shared with his > fellow travelers the elegant proof [1]

Re: Floating Point and Arithmetic Changes for Java SE Lnguage

2018-03-07 Thread joe darcy
Legend has it that after the ancient Greek Hippasus shared with his fellow travelers the elegant proof [1] that the square root of 2 is not a rational number, he was thrown off the ship by Pythagoreans outraged that such numbers should exist. Hippasus subsequently drowned. Whatever catharsis

Re: RFR 8182684: Further clarify InputStream#available()

2018-03-07 Thread Roger Riggs
+1, Thanks, Roger On 3/7/18 1:57 PM, Brian Burkhalter wrote: https://bugs.openjdk.java.net/browse/JDK-8182684 http://cr.openjdk.java.net/~bpb/8182684/webrev.00/ Unfortunately the change is somewhat obfuscated by reformatting. The main changes are the first sentence and the fourth paragraph.

Re: RFR 8199258: BigInteger.bitLength() should explicitly specify behavior when the value is zero

2018-03-07 Thread Lance Andersen
looks fine > On Mar 7, 2018, at 2:21 PM, Brian Burkhalter > wrote: > > https://bugs.openjdk.java.net/browse/JDK-8199258 > > A diff is included below. If this looks good then a CSR will follow. > > Thanks, > > Brian > > ---

Re: RFR 8199258: BigInteger.bitLength() should explicitly specify behavior when the value is zero

2018-03-07 Thread Roger Riggs
+1, looks fine. Roger On 3/7/2018 2:21 PM, Brian Burkhalter wrote: https://bugs.openjdk.java.net/browse/JDK-8199258 A diff is included below. If this looks good then a CSR will follow. Thanks, Brian --- a/src/java.base/share/classes/java/math/BigInteger.java +++

RFR 8199258: BigInteger.bitLength() should explicitly specify behavior when the value is zero

2018-03-07 Thread Brian Burkhalter
https://bugs.openjdk.java.net/browse/JDK-8199258 A diff is included below. If this looks good then a CSR will follow. Thanks, Brian --- a/src/java.base/share/classes/java/math/BigInteger.java +++ b/src/java.base/share/classes/java/math/BigInteger.java @@ -1,5 +1,5 @@ /* - * Copyright (c)

RFR 8182684: Further clarify InputStream#available()

2018-03-07 Thread Brian Burkhalter
https://bugs.openjdk.java.net/browse/JDK-8182684 http://cr.openjdk.java.net/~bpb/8182684/webrev.00/ Unfortunately the change is somewhat obfuscated by reformatting. The main changes are the first sentence and the fourth paragraph. A CSR will follow. Thanks, Brian

Re: RFR(XS) [closed] : 8198924: java/lang/StackWalker/LocalsAndOperands.java timeouts with Graal

2018-03-07 Thread Ekaterina Pavlova
Mandy, Brent, thanks for reviews. Removing @bug will not allow to find this testcase by bugid (jtreg -bug:). So, I think it is safe to omit only @summary. regards, -katya On 3/6/18 2:30 PM, Brent Christian wrote: Looks good, Katya - thanks. I agree with omitting @bug and @summary from the

Re: Reactive Streams utility API

2018-03-07 Thread Brian Goetz
To answer the questions at the bottom: the next step is to start working on this and get folks excited about contributing.  There's plenty of time for process later, but filing a JEP or creating a project shouldn't be a barrier to innovating. On 2/28/2018 10:33 PM, James Roper wrote: Hi all,

Re: Java SE Language Changes

2018-03-07 Thread Andrew Haley
On 07/03/18 03:46, A Z wrote: > Is there any route forward with these changes? I believe not. Java floating-point arithmetic is specified by IEEE-754. If you want something different, Java is not the language you are looking for. -- Andrew Haley Java Platform Lead Engineer Red Hat UK Ltd.

Re: RFR 8196298 Add null Reader and Writer with latest changes

2018-03-07 Thread Patrick Reinhart
I applied those changes here: http://cr.openjdk.java.net/~reinhapa/reviews/8196298/webrev.02 -Patrick > Am 06.03.2018 um 23:12 schrieb Brian Burkhalter : > > Yes, I think so and and also the parameter ‘csq' is allowed to be null so > Objects.requireNonNull(csq)