Re: 8143850: retrofit ArrayDeque to implement List

2018-08-03 Thread Stuart Marks
Thanks, Patrick! This is very helpful. Alex, others, (Meta: I've been at JVMLS and the OpenJDK Committers' Workshop all week, and I'm on vacation next week, so I don't have much time to discuss this right now. However, I am interested in moving this forward.) OK, so the API in this webrev

Re: Long chains created by direct Buffer::slice

2018-08-03 Thread Paul Sandoz
Got caught up with JVMLS this week… I searched but could not find a test, so i added one, see: http://cr.openjdk.java.net/~psandoz/jdk/JDK-8208362-direct-buffer-att/webrev/ Paul. > On Jul 27, 2018, at 12:35 PM,

Re: [12] (AIX) 8207744: Clean up inconsistent use of opendir/closedir versus opendir64/closedir64

2018-08-03 Thread Brian Burkhalter
HI Matthias, I think I fixed the dirent problem: thanks for pointing it out. http://cr.openjdk.java.net/~bpb/8207744/webrev.03/ The usual builds passed and tests are running. I think that there is some _ALLBSD_SOURCE cruft in UnixNativeDispatcher.c which could be cleaned up but we’ll leave

Re: JDK 12 RFR of JDK-8208782: Remove extra type in throws clause of SerialClob.writeObject

2018-08-03 Thread Lance Andersen
Hi Joe, Looks fine. Sorry I missed it also Best Lance > On Aug 3, 2018, at 5:47 PM, Joseph D. Darcy wrote: > > Hello, > > The fix for JDK-8208060, Additional corrections of serial-related > declarations, overlooked an extra type in the throws clause of >

JDK 12 RFR of JDK-8208782: Remove extra type in throws clause of SerialClob.writeObject

2018-08-03 Thread Joseph D. Darcy
Hello, The fix for JDK-8208060, Additional corrections of serial-related declarations, overlooked an extra type in the throws clause of javax.sql.rowset.serial.SerialClob.writeObject. The extra type should be removed. Patch below. Thanks, -Joe ---

Race condition when serializing SerializedRandomAccessList

2018-08-03 Thread Krystal Mok
Hi core-libs, I'd like to report a bug on race condition while serializing SerializedRandomAccessList / deserializing SerializedList. This seems to be a long standing bug, we've hit it on JDK8 and the same code is still there in JDK11's core-lib. In SerializedRandomAccessList.writeReplace(): [1]

RFR: JDK-8208634 : Add x-IBM-1129 charset

2018-08-03 Thread Nasser Ebrahim
Hello, Java was not launching on many AIX supported locales as the default charsets for those locales were not included in the java.base and Java could not access jdk.charsets during boot up. Most of those locales were addressed through the Oracle bugs JDK-8201540 [1] and JDK-8202329 [2].

Re: RFR: 8207851 JEP Draft: Support ByteBuffer mapped over non-volatile memory

2018-08-03 Thread Andrew Dinn
Round 3: This week Jonathan Halliday was able to access a machine which has both an NVM DIMM and CPU that implements the clflush and clwb instructions. He is currently preparing some benchmark figures for running transactions using a log stored in NVM. However, in order to get to that point we

Re: Add x-IBM-1129 charset

2018-08-03 Thread Nasser Ebrahim
> I've created JDK-8208634 [1] for x-IBM-1129 and will reply soon on the > other thread (as I think we do need infrastructure in the build to make > it easy to included/exclude charsets rather than having them be included > automatically on all builds). Thank you Alan for opening the bug for

Re: [12] (AIX) 8207744: Clean up inconsistent use of opendir/closedir versus opendir64/closedir64

2018-08-03 Thread Brian Burkhalter
Hi Matthias, No, I don’t know either whether this matters in reality but I will check it out. As long as I am fooling around in this area we might as well try to get it clean. Thanks, Brian On Aug 2, 2018, at 11:57 PM, Baesken, Matthias wrote: > Hi Brian , looks like the function > >

Re: System.java Development Question

2018-08-03 Thread mr rupplin
This is an OpenJDK 9 build. Can you explain? I'm very interested in getting all the details understood. Hey thanks! MR From: Alan Bateman Sent: Friday, August 3, 2018 9:38 AM To: mr rupplin; core-libs-dev@openjdk.java.net Subject: Re: System.java Development

Re: System.java Development Question

2018-08-03 Thread Alan Bateman
On 03/08/2018 06:22, mr rupplin wrote: : We get the following after running a trivial Java program: Exception in thread "main" java.lang.UnsatisfiedLinkError: java.lang.System.setMemoryAllocationListener0(Ljava/lang/memory/MemoryAllocationListener;)V at

System.java Development Question

2018-08-03 Thread mr rupplin
Hello. I'm not sure if there's a minor typo but I cannot find the error in it. Can you guys look? In System.c we have: JNIEXPORT void JNICALL Java_java_lang_System_setMemoryAllocationListener0(JNIEnv *env, jclass cla, jobject listener) { jfieldID fid =

Re: [12] RFR 8208279: Add 8 JNDI tests to com/sun/jndi/dns/EnvTests/

2018-08-03 Thread Chris Yin
Hi, Vyom Thank a lot for your review and comments, inline and update new webrev as below http://cr.openjdk.java.net/~xyin/8208279/webrev.02/ > On 3 Aug 2018, at 3:45 PM, vyom tewari wrote: > > Hi Chris, > > Overall looks good to me, couple of minor comment. > > 1-> ProviderUrlGen.java,

Re: [12] RFR 8208279: Add 8 JNDI tests to com/sun/jndi/dns/EnvTests/

2018-08-03 Thread vyom tewari
Hi Chris, Overall looks good to me, couple of minor comment. 1-> ProviderUrlGen.java, Line:100 Exception e can be replaced with specific  exceptions. 2-> In couple of  places we are calling "removeFromEnvironment" on context and spec says it will return "null" if the env is not set. I  see

RE: [12] (AIX) 8207744: Clean up inconsistent use of opendir/closedir versus opendir64/closedir64

2018-08-03 Thread Baesken, Matthias
Hi Brian , looks like the function struct dirent64 *readdir64 (DIR64 *DirectoryPointer); returns dirent64* ( according to https://www.ibm.com/support/knowledgecenter/no/ssw_aix_72/com.ibm.aix.basetrf1/opendir.htm ) and some of the files below still have dirent* on AIX ( at some