On 11/7/19 1:45 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
This changes the module name, and base package name from jdk.jpackage
to jdk.incubator.jpackage.
This
Hi Andy,
Agree with Alexey comments. Otherwise looks good.
Thanks,
Alexander
On 11/7/2019 2:44 PM, Andy Herrick wrote:
On 11/7/2019 5:38 PM, Alexey Semenyuk wrote:
I guess the link for the review is
https://cr.openjdk.java.net/~herrick/8233636/webrev.02
sry: yes webrev is
Hi,
Please review the webrev[1], contributed by Mat Carter. You can find the bug
details at JBS[2]. I have reviewed and tested the fix, I still need an official
review before I can push this.
Cheers,
Henry
[1] http://cr.openjdk.java.net/~henryjen/jdk/8231863.0/webrev/
[2]
On 11/7/2019 5:38 PM, Alexey Semenyuk wrote:
I guess the link for the review is
https://cr.openjdk.java.net/~herrick/8233636/webrev.02
sry: yes webrev is http://cr.openjdk.java.net/~herrick/8233636/webrev.02
I guess the link for the review is
https://cr.openjdk.java.net/~herrick/8233636/webrev.02
http://cr.openjdk.java.net/~herrick/8233636/webrev.02/test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JavaTool.java.sdiff.html:50
I'd suggest to replace
---
if (name.equals("jpackage"))
---
with more
Yep. :-) Too much juggling. Thank you.
> On Nov 7, 2019, at 5:23 PM, Brent Christian
> wrote:
>
> Should the new escapes be added to the table in the String.translateEscapes()
> JavaDoc?
>
> -Brent
>
> On 11/7/19 6:22 AM, Jim Laskey wrote:
>> Please review the following code changes.
Hi Joe,
> On Nov 5, 2019, at 6:04 PM, Joe Darcy wrote:
>
> Please review the changes to fix
>
> JDK-8233452: java.math.BigDecimal.sqrt() with RoundingMode.FLOOR results
> in incorrect result
> http://cr.openjdk.java.net/~darcy/8233452.0/
>
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
This changes the module name, and base package name from jdk.jpackage to
jdk.incubator.jpackage.
This removes the "provides" statement in
Should the new escapes be added to the table in the
String.translateEscapes() JavaDoc?
-Brent
On 11/7/19 6:22 AM, Jim Laskey wrote:
Please review the following code changes. Provides for the introduction of two new escape
sequences \ and \s. \ allows developers to
express unwieldy string
Looks good. -B
On 11/6/19 6:11 PM, naoto.s...@oracle.com wrote:
Here is the updated webrev:
https://cr.openjdk.java.net/~naoto/8232871/webrev.01/
Looks OK Joe.
> On Nov 7, 2019, at 2:01 PM, Joe Wang wrote:
>
> Please review a quick fix that reduces unnecessary object allocations.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8233686
> webrev: http://cr.openjdk.java.net/~joehw/jdk14/8233686/webrev/
>
> Thanks,
> Joe
>
Please review a quick fix that reduces unnecessary object allocations.
JBS: https://bugs.openjdk.java.net/browse/JDK-8233686
webrev: http://cr.openjdk.java.net/~joehw/jdk14/8233686/webrev/
Thanks,
Joe
HotSpot tests changes (using Thread.yield()) look good.
Thanks,
Vladimir
On 11/5/19 1:50 AM, Jan Lahoda wrote:
I've missed updates to some hotspot and jdk tests in the first patch. The problem are unqualified
invocations of Thread.yield(), which are no longer allowed (from the spec: JLS 3.9
Please review the following code changes. Provides for the introduction of two
new escape sequences \ and \s. \ allows
developers to express unwieldy string literals in a text block as a cluster of
short single line segments. The second is to allow developers to express ASCII
space, much like
14 matches
Mail list logo
