Alexander,
Icon can be configured on jpackage command line and should not be
overridden in custom overrides.wxi file. This is the reason why I didn't
put its description in the default overrides.wxi file.
JpIcon is just one of WiX variables to pass configuration data from
jpackage Java into
I can report that this question is no longer theoretical. As of this morning,
Apple began rejecting notarization of my disk images that had been code-signed
by jpackage for lacking secure timestamps and not using the hardened runtime.
So jpackage-signed applications are no longer accepted by
Hi Brian,
Pushed with recommend changes; webrev of final version:
http://cr.openjdk.java.net/~darcy/8233452.5
Thanks,
-Joe
On 1/14/2020 1:59 PM, Brian Burkhalter wrote:
Hi Joe,
This looks good modulo a few picayune things I noticed in the
implementation and test. Line numbers refer to
On 1/14/20 6:04 PM, naoto.s...@oracle.com wrote:
Hi Joe,
Thank you for the review. Please find my comments below:
On 1/14/20 3:35 PM, Joe Wang wrote:
Hi Naoto,
Since it's dealing with non-standard properties files, is there a
need to verify the files? The constructor (HijrahChronology)
Hi Joe,
Thank you for the review. Please find my comments below:
On 1/14/20 3:35 PM, Joe Wang wrote:
Hi Naoto,
Since it's dealing with non-standard properties files, is there a need
to verify the files? The constructor (HijrahChronology) does check
whether the id or type is empty. If there
Looks okay. I wonder how the word "source" got creeped in :-)
Mandy
On 1/14/20 5:51 PM, Brian Burkhalter wrote:
Oops: correction.
--- a/test/jdk/java/io/Reader/TransferTo.java
+++ b/test/jdk/java/io/Reader/TransferTo.java
@@ -6,15 +6,15 @@
* under the terms of the GNU General Public
Looks ok Brian
Best,
Lance
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Sent from my iPad
> On Jan 14, 2020, at 8:51 PM, Brian Burkhalter
> wrote:
>
> Oops: correction.
>
>
+1
Mandy
On 1/14/20 5:49 PM, Brian Burkhalter wrote:
Please review this trivial fix
--- a/test/jdk/java/io/Reader/TransferTo.java
+++ b/test/jdk/java/io/Reader/TransferTo.java
@@ -14,7 +14,7 @@
*
* You should have received a copy of the GNU General Public License version
* 2 along
Oops: correction.
--- a/test/jdk/java/io/Reader/TransferTo.java
+++ b/test/jdk/java/io/Reader/TransferTo.java
@@ -6,15 +6,15 @@
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
- * This code is distributed source the hope
Please review this trivial fix
--- a/test/jdk/java/io/Reader/TransferTo.java
+++ b/test/jdk/java/io/Reader/TransferTo.java
@@ -14,7 +14,7 @@
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
Hi Naoto,
Since it's dealing with non-standard properties files, is there a need
to verify the files? The constructor (HijrahChronology) does check
whether the id or type is empty. If there is no existing process to
validate, it's probably not worth it to spend time as it's rare and it's
Performance test results show no regression over the current build (15-b5).
-Joe
On 1/14/20 12:08 PM, Joe Wang wrote:
A performance test is running.
Hi Joe,
This looks good modulo a few picayune things I noticed in the implementation
and test. Line numbers refer to the updated version of each file.
1. Implementation
2: Newer copyright year 2020, of course.
2150: s/much many/many/.
2185: I suppose that this is in case targetPrecision
+1
Paul.
> On Jan 14, 2020, at 10:30 AM, Maurizio Cimadamore
> wrote:
>
> Another revision which addresses some additional CSR feedback:
>
> * SequenceLayout::withElementCount should throw if new element count < 0
> * MemoryLayout::hasSize should clarify that certain layout (e.g. ValueLayout)
Hi,
Please review an update to BCEL 6.4.1.
JBS: https://bugs.openjdk.java.net/browse/JDK-8235368
webrev: http://cr.openjdk.java.net/~joehw/jdk15/8235368/webrev/index.html
Similar approach as the last update:
1. Format
All format changes are kept as they are in the source in order to
Cgroup V2 is about to go mainstream this year for popular distros such as
Oracle Linux 8, Redhat Linux 8 and Fedora
so this fix it’s important to get into JDK 15 so we can start shaking out this
support.
Please take a look and helpsev get this change reviewed.
Thanks,
Bob Vandette
> Begin
> On Jan 13, 2020, at 4:04 AM, Severin Gehwolf wrote:
>
> Hi Bob,
>
> On Fri, 2020-01-10 at 11:50 -0500, Bob Vandette wrote:
>> Severin,
>>
>> The changes look ok to me. I assume you’ve run the container tests
>> on a cgroupv2 and cgroupv1 enabled system, right?
>
> Yes, I have.
>
>>
Another revision which addresses some additional CSR feedback:
* SequenceLayout::withElementCount should throw if new element count < 0
* MemoryLayout::hasSize should clarify that certain layout (e.g.
ValueLayout) always have a size
Webrev:
http://cr.openjdk.java.net/~mcimadamore/8235837_v3
Joe and Roger, thank you for your reviews.
security-libs guys, could you please take a look?
Thanks,
-- Igor
> On Jan 2, 2020, at 12:58 PM, Roger Riggs wrote:
>
> The core lib changes look ok.
>
> Roger
> On Jan 2, 2020, at 1:26 PM, Joe Darcy wrote:
>
> The removal of the existing
Hi,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8187987
The proposed CSR and changeset are located at:
CSR: https://bugs.openjdk.java.net/browse/JDK-8236810
Webrev: https://cr.openjdk.java.net/~naoto/8187987/webrev.00/
The spec of
(adding core-libs-dev)
Change looks good to me, but would like input from at least someone in
core-libs.
/Erik
On 2020-01-14 06:07, Baesken, Matthias wrote:
Hello, the following change enables the link-time section-gc for linux .
gcc and ld support enabling "garbage collection" of unused
Hi,
Looks good to me
Cheers
Christoph
From: Lance Andersen
Sent: Montag, 13. Januar 2020 21:26
To: Alan Bateman
Cc: Jaikiran Pai ; Langer, Christoph
; nio-...@openjdk.java.net;
core-libs-dev@openjdk.java.net
Subject: Re: RFR 7143743: (zipfs) Potential memory leak with zip provider
On
22 matches
Mail list logo
