Re: Review Request JDK-8240975: Extend NativeLibraries to support explicit unloading

Alan, Maurizio, New webrev: http://cr.openjdk.java.net/~mchung/jdk15/webrevs/8240975/webrev.02/ newJavaNativeInterfaceLibraries  creates a NativeLIbraries for loading JNI native libraries.   - native libraries are unloaded when the class loader is reclaimed.   - Support of linking of native

Re: [15] RFR: 8241130: com.sun.jndi.ldap.EventSupport.removeDeadNotifier: java.lang.NullPointerException

Thank you, Daniel Regards, Chris > On 19 Mar 2020, at 7:54 PM, Daniel Fuchs wrote: > > Hi Chris, > > On 19/03/2020 07:23, Chris Yin wrote: >> [...] Per javadoc from EventContext and EventDirContext interface which >> implemented by LdapCtx that will call EventSupport, "NamingException should

RFR JEP 338: Vector API (Incubator), JDK-8223347 Integration of Vector API (Incubator): Vector API

Hi, This email is intended to kick start the review of JEP 338: Vector API (Incubator). For ease of review we intend to split this up into separate parts for review of the Java API, Java implementation, Java unit tests, Java jmh tests, shared hotspot code, and platform specific hotspot

Re: RFR: JDK-8241310 Fix warnings in jdk buildtools

Hi Magnus, please try not to use @SuppressWarnings("unchecked") on methods, but on local variable instead to reduce the scope, you can introduce a local variable for that. In Bundle, your patch declare @SuppressWarnings("unchecked") on the method while you already have a local variable with a

Re: RFR: JDK-8241310 Fix warnings in jdk buildtools

Looks good to me. I love the WrapperGenerator using Vector and Hashtable! /Erik On 2020-03-19 09:53, Magnus Ihse Bursie wrote: The buildtools (java tools needed to be run during the build) have long been plagued by warnings, includuing deprecations and unchecked warnings, which cannot be

RFR: JDK-8241310 Fix warnings in jdk buildtools

The buildtools (java tools needed to be run during the build) have long been plagued by warnings, includuing deprecations and unchecked warnings, which cannot be silenced during the build. This patch fixes all buildtool warnings. Most of the warnings are fixed properly, but a few have had

Re: RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

Hi Alan, The mismatches are due to the combination of generated Stub and old stub source. I'll clean it up a bit before pushing.  As pretty static code it didn't seem worth much investment. Thanks, Roger On 3/19/20 3:39 AM, Alan Bateman wrote: On 18/03/2020 21:24, Roger Riggs wrote: Hi,

Re: [15] 8235792: LineNumberReader.getLineNumber() behavior is inconsistent with respect to EOF

Another webrev [1] which is adjusted from the previous one per the comments on the CSR [2] is available for review. The only change is to the class-level specification: --- a/src/java.base/share/classes/java/io/LineNumberReader.java +++

Re: [15] RFR: 8241130: com.sun.jndi.ldap.EventSupport.removeDeadNotifier: java.lang.NullPointerException

Hi Chris, On 19/03/2020 07:23, Chris Yin wrote: [...] Per javadoc from EventContext and EventDirContext interface which implemented by LdapCtx that will call EventSupport, "NamingException should be thrown if a problem was encountered" when add/remove NamingListener, that requires us to

RE: Sponsor Request: 8241097: java/math/BigInteger/largeMemory/SymmetricRangeTests.java requires -XX:+CompactStrings

Many thanks Brian Andrew Leonard Java Runtimes Development IBM Hursley IBM United Kingdom Ltd internet email: andrew_m_leon...@uk.ibm.com From: Brian Burkhalter To: Brent Christian , Andrew Leonard Cc: core-libs-dev@openjdk.java.net Date: 18/03/2020 21:30 Subject:

Re: RFR: 8238665: Add JFR event for direct memory statistics

Hi, > On Mar 18, 2020, at 11:46 PM, Alan Bateman wrote: > > > > On 13/03/2020 14:54, Denghui Dong wrote: >> Good suggestion, moved. >> Webrev: http://cr.openjdk.java.net/~ddong/8238665/webrev.03/ >> > This looks much better. > > What

Re: RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

On 18/03/2020 21:24, Roger Riggs wrote: Hi, Some small updates to the source files to minimize the changes to javadoc of the _Stub classes. All looks good but the updated ActivationGroup_Stub should probably get a one-pass to eliminate the inconsistencies, e.g. the new version imports some

Re: RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

On 2020-03-18 22:24, Roger Riggs wrote: Hi, Some small updates to the source files to minimize the changes to javadoc of the _Stub classes. And fixes to the points Magnus raises below. http://cr.openjdk.java.net/~rriggs/webrev-stubs-classes-8241073-4/ Looks good! Thank you for getting this

Re: [15] RFR: 8241130: com.sun.jndi.ldap.EventSupport.removeDeadNotifier: java.lang.NullPointerException

Hi, Daniel Thank you for reviewing this, inline > On 18 Mar 2020, at 7:24 PM, Daniel Fuchs wrote: > > Hi Chris, > > Thanks for taking care of this followup fix. > > I see at least three other places where `notifiers` is accessed > without a null check. It might be good to fix these three