Re: Review Request: 8238358: Implementation of JEP 371: Hidden Classes

On 4/17/20 16:52, Mandy Chung wrote: On 4/17/20 3:51 PM, Chris Plummer wrote: Hi Mandy, Thanks for updating the svc specs. Some comments below: In the JDWP spec update, you changed "JNI signature" to "type signature" in one place, but left it as "JNI signature" everywhere else. Should

Re: Review Request: 8238358: Implementation of JEP 371: Hidden Classes

On 4/17/20 3:51 PM, Chris Plummer wrote: Hi Mandy, Thanks for updating the svc specs. Some comments below: In the JDWP spec update, you changed "JNI signature" to "type signature" in one place, but left it as "JNI signature" everywhere else. Should they all be changed? JDWP signature

RFR 15 8243099: Adding ADQ support to JDK

Hello everyone, I would like to add support for the Application Device Queue (ADQ) technology to the JDK. The JBS entry and webrev were created for this improvement: JBS: https://bugs.openjdk.java.net/browse/JDK-8243099 Webrev: http://cr.openjdk.java.net/~sviswanathan/Vladimir/8243099/webrev.00/

Re: Review Request: 8238358: Implementation of JEP 371: Hidden Classes

On 4/16/20 9:45 AM, Mandy Chung wrote: On 4/14/20 11:51 AM, Paul Sandoz wrote: Looks good to me (not familiar with all the code areas. Minor suggestion: MethodHandles.java 1811  * ASCII periods. For the instance of {@link java.lang.Class} representing {@code C}: 1812  *

Re: RFR: JDK-8242302 : Refactor jpackage native code

Hi Alexey, Looks good. Thanks, Alexander On 4/16/20 10:37 AM, Andy Herrick wrote: OK - I approve. - I have tested on 2 platforms and it looks good. /Andy On 4/15/2020 4:13 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Refactor jpackage native code. - Improve code

Re: RFR: JDK-8241627: Updating ASM to 8.0 for JDK 15

ping, any other comment? are we ready to push this change? Vicente On 4/13/20 11:05 AM, Vicente Romero wrote: Hi all, Please review this patch that updates the ASM version to appear in JDK15 (from 7.0 to 8.0). Version 8.0 is compatible with JDK14 plus it has several experimental APIs to

Re: RFR 15: 8243010: Test support: Customizable Hex Printer

Hi Roger, I think tackling this via the new Developer’s guide project makes sense as it would help folks re-inventing the wheel and making it easier to find what already exists. Best Lance > On Apr 17, 2020, at 12:55 PM, Roger Riggs wrote: > > Hi Lance, > > The test library is a bit of a

Re: RFR 15: 8243010: Test support: Customizable Hex Printer

Hi Pavel, Thanks for the scan of potential replacements. I'll take a look and file followup issues for candidates for cleanup. Some are going to be sensitive to the specific formatting. Roger On 4/17/20 11:36 AM, Pavel Rappo wrote: On 17 Apr 2020, at 15:11, Roger Riggs wrote: Hi Pavel, On

Re: RFR 15: 8243010: Test support: Customizable Hex Printer

Hi Lance, The test library is a bit of a black box usually approached from the angle of existing tests. And unfortunately, there is a lower bar for documentation and API development. Perhaps an item to be looked at as part of the new developer guide project. Thanks, Roger On 4/17/20 11:34

Re: RFR: 8242959: Optimize ZipFile.getEntry by folding lookups for name and name+'/'

Hi Lance, thank you for reviewing! /Claes On 2020-04-17 17:23, Lance Andersen wrote: HI Claes, I think this looks good. Best Lance On Apr 17, 2020, at 7:33 AM, Claes Redestad > wrote: Hi, please review this patch to get rid of the back-to-back lookup of

Re: RFR 15: 8243010: Test support: Customizable Hex Printer

> On 17 Apr 2020, at 15:11, Roger Riggs wrote: > > Hi Pavel, > > On 4/17/20 8:27 AM, Pavel Rappo wrote: >> Hi Roger, >> >> First of all, many thanks for doing this. After skimming through that webrev >> I have two comments. >> >> 1. It might make sense to beef this up with more retrofitted

Re: RFR 15: 8243010: Test support: Customizable Hex Printer

Hi Roger, Thank you for creating this as it looks good. A couple of quick questions - Will the javadoc be hosted somewhere - Maybe I have not stumbled onto it yet, but is there a document/wiki somewhere that describes all of the useful test libraries vs discovering as you go? Best Lance >

Re: RFR: 8242959: Optimize ZipFile.getEntry by folding lookups for name and name+'/'

HI Claes, I think this looks good. Best Lance > On Apr 17, 2020, at 7:33 AM, Claes Redestad wrote: > > Hi, > > please review this patch to get rid of the back-to-back lookup of name > and name+'/' in ZipFile.getEntry. This is done by first adjusting the > hash function so that a trailing

Re: RFR 15: 8243010: Test support: Customizable Hex Printer

Hi Pavel, On 4/17/20 8:27 AM, Pavel Rappo wrote: Hi Roger, First of all, many thanks for doing this. After skimming through that webrev I have two comments. 1. It might make sense to beef this up with more retrofitted tests, so people could more clearly see how applicable this API is. If

Re: RFR 15: 8243010: Test support: Customizable Hex Printer

Hi Roger, First of all, many thanks for doing this. After skimming through that webrev I have two comments. 1. It might make sense to beef this up with more retrofitted tests, so people could more clearly see how applicable this API is. If you'd like I could help you with looking for those

Re: RFR 8242859: test/jdk/tools/jlink/JLinkTest.java uses nashorn module

+1 > On Apr 17, 2020, at 7:06 AM, sundararajan.athijegannat...@oracle.com wrote: > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8242859 > > Webrev: http://cr.openjdk.java.net/~sundar/8242859/webrev.00/ > > Relevant JLinkTest.java section deleted as part of nashorn

Type-parameterized complement to Object.equals(Object)

Hello, I need a sponsor for following JDK change. Summary --- Provide means for type safe comparison for equality by introducing type-parameterized interface `java.lang.Equable` with method `boolean equ(T)`. (The actual names of the interface and the method is subject to discussion.)

RFR: 8242959: Optimize ZipFile.getEntry by folding lookups for name and name+'/'

Hi, please review this patch to get rid of the back-to-back lookup of name and name+'/' in ZipFile.getEntry. This is done by first adjusting the hash function so that a trailing slash is not included in an entry's hash code, and adjusting appropriately when matching the arrays. This means we do

Re: RFR(S): 8242848: Improve performance of InflaterOutputStream.write()

Thanks everybody for looking at this change! Please find an updated webrev (with a new test and micro-benchmark) and my answers to your comments below: http://cr.openjdk.java.net/~simonis/webrevs/2020/8242848.01/ On Thu, Apr 16, 2020 at 6:40 AM Vyom Tiwari wrote: > Thanks for doing this, i

Re: RFR (T): 8242846: removed an empty file test/jdk/tools/jlink/plugins/OrderResourcesPluginTest.java

Hi, The original email is waiting for moderator approval. Subscribed to jigsaw-dev and resent the RFR (cc'ed core-libs-dev). Thanks, Ao Qi On Wed, Apr 15, 2020 at 10:11 PM Ao Qi wrote: > > Hi all, > > test/jdk/tools/jlink/plugins/OrderResourcesPluginTest.java was changed > to an empty file by

RFR 8242859: test/jdk/tools/jlink/JLinkTest.java uses nashorn module

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8242859 Webrev: http://cr.openjdk.java.net/~sundar/8242859/webrev.00/ Relevant JLinkTest.java section deleted as part of nashorn removal is as follows:

Re: RFR 8242860: test/jdk/tools/jlink/ModuleNamesOrderTest.java uses nashorn module

On 17/04/2020 07:21, sundararajan.athijegannat...@oracle.com wrote: Hi, nashorn modules were used only as an example in this test. Using jdk.jshell module instead to test known module dependencies in jlink produced images. Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8242860

Re: JDK-8160768: LdapDnsProviderService confined to application class loader

Am 2020-04-17 um 09:22 schrieb Alan Bateman: On 16/04/2020 11:05, Osipov, Michael wrote: That's exactly the point. I don't want to bundle it with the webapp, but with Tomcat only for all webapps. It will be added to CATALINA_HOME/lib along with a custom realm. Both are loaded with

Re: JDK-8160768: LdapDnsProviderService confined to application class loader

On 16/04/2020 11:05, Osipov, Michael wrote: That's exactly the point. I don't want to bundle it with the webapp, but with Tomcat only for all webapps. It will be added to CATALINA_HOME/lib along with a custom realm. Both are loaded with Tomcat's common.loader [1]. No, it does not load from

RFR 8242860: test/jdk/tools/jlink/ModuleNamesOrderTest.java uses nashorn module

Hi, nashorn modules were used only as an example in this test. Using jdk.jshell module instead to test known module dependencies in jlink produced images. Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8242860 Webrev: http://cr.openjdk.java.net/~sundar/8242860/webrev.00/