Re: [15] RFR: 8239383: Support for Unicode 13.0

Thanks for the review, Joe! On 5/13/20 2:58 PM, Joe Wang wrote: +1 They are from the reference files, but it's interesting to note the ranges in Blocks.txt (that Character.java follows) for Tangut Supplement (18D00..18D8F) and CJK Unified Ideographs Extension G (3..3134F) are slightly di

Re: [15] RFR: 8239383: Support for Unicode 13.0

On 5/13/2020 3:24 PM, naoto.s...@oracle.com wrote: Thanks for the review, Joe! On 5/13/20 2:58 PM, Joe Wang wrote: +1 They are from the reference files, but it's interesting to note the ranges in Blocks.txt (that Character.java follows) for Tangut Supplement (18D00..18D8F) and CJK Unified

Re: RFR: (CSR) JDK-8236688 Clarify String::stripIndent javadoc when string ends with line terminator

Hi, Jim I have a few comments on the new wording (hopefully my understanding is correct): ! * If the block ends with a LF{@code "\n"} or CR{@code "\r"} character, ! * then this implies the block closes in column 0 of the next line, and thus ! * implies an indent of 0. I feel like th

Re: [15] RFR: 8239383: Support for Unicode 13.0

+1 They are from the reference files, but it's interesting to note the ranges in Blocks.txt (that Character.java follows) for Tangut Supplement (18D00..18D8F) and CJK Unified Ideographs Extension G (3..3134F) are slightly different from those in the online pdf files (http://www.unicode.or

Re: RFR: JDK-8244576: [macos] Volume icon deleted by osascript for background image

Hi Andy, Looks good. Thanks, Alexander On 5/13/20 7:11 AM, Andy Herrick wrote: Please review jpackage fix for issue [1] at [2]. [1] - https://bugs.openjdk.java.net/browse/JDK-8244576 [2] - http://cr.openjdk.java.net/~herrick/8244576/webrev.01/ /Andy

RFR: JDK-8225056 VM support for sealed classes

f its permitted subclasses. * asm support for the PermittedSubclasses attribute Open Webrev: http://cr.openjdk.java.net/~vromero/8225056/webrev.00/index.html JBS bug: https://bugs.openjdk.java.net/browse/JDK-8225056 Java Language Spec changes: http://cr.openjdk.java.net/~gbierman/jep360/

Re: [8u] RFR: [JDK 8u] JapanEraNameCompatTest fails

Hi Andrew, Thanks for looking at this. On Wed, 2020-05-13 at 17:37 +0100, Andrew Hughes wrote: > On 13/05/2020 15:59, Severin Gehwolf wrote: > > Hi, > > > > Could somebody please review this fix for the failing > > JapanEraNameCompatTest.java test (part of tier1)? The reason why it's > > failing

Re: RFR: 8244936: Reduce JNI overhead of accessing FileDescriptor

On 2020-05-13 20:31, Alan Bateman wrote: On 13/05/2020 16:44, Claes Redestad wrote: Hi, compilers can't see though and optimize away the repeated GetObjectField calls in places such as in the io_util_md.h GET_FD macro: #define GET_FD(this, fid) \     (*env)->GetObjectField(env, (this), (fid

Re: RFR: 8244936: Reduce JNI overhead of accessing FileDescriptor

On 13/05/2020 16:44, Claes Redestad wrote: Hi, compilers can't see though and optimize away the repeated GetObjectField calls in places such as in the io_util_md.h GET_FD macro: #define GET_FD(this, fid) \     (*env)->GetObjectField(env, (this), (fid)) == NULL ? \     -1 : (*env)->GetIntFie

Re: RFR: 8244936: Reduce JNI overhead of accessing FileDescriptor

Hi Roger, On 2020-05-13 19:55, Roger Riggs wrote: Hi Claes, Looks fine. thank you for reviewing! /Claes Straightfoward since the offiset is already cached for other operations. Thanks, Roger

Re: Avoid getting hashCode of keys for empty ConcurrentHashMap

Thanks! I filed https://bugs.openjdk.java.net/browse/JDK-8244960 Looks like a good change. (But we are more time-limited than usual these days) On Wed, May 13, 2020 at 10:35 AM Christoph Dreis wrote: > > Hi, > > forgive me if this is not the correct list. I get confused where things about > jav

Re: RFR: 8244936: Reduce JNI overhead of accessing FileDescriptor

Hi Claes, Looks fine. Straightfoward since the offiset is already cached for other operations. Thanks, Roger On 5/13/20 11:44 AM, Claes Redestad wrote: Hi, compilers can't see though and optimize away the repeated GetObjectField calls in places such as in the io_util_md.h GET_FD macro: #def

Re: [15] RFR: 8239383: Support for Unicode 13.0

Hi Naoto, Looks fine. Lots of small changes but mostly in the Unicode reference files. Thanks, Roger On 5/7/20 5:59 PM, naoto.s...@oracle.com wrote: Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8239383 Its CSR and proposed changeset are loca

Avoid getting hashCode of keys for empty ConcurrentHashMap

Hi, forgive me if this is not the correct list. I get confused where things about java.util.concurrent should be posted. I found an optimization opportunity in ConcurrentHashMap that seems relatively straight-forward. When ConcurrentHashMap.get() is called on an empty map, the key's hashCode()

Re: [8u] RFR: [JDK 8u] JapanEraNameCompatTest fails

On 13/05/2020 15:59, Severin Gehwolf wrote: > Hi, > > Could somebody please review this fix for the failing > JapanEraNameCompatTest.java test (part of tier1)? The reason why it's > failing is that there are missing locale data for no and sr_Latn which > are exercised by the test. The original bac

Re: [15] RFR: 8239383: Support for Unicode 13.0

Ping. Naoto On 5/7/20 2:59 PM, naoto.s...@oracle.com wrote: Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8239383 Its CSR and proposed changeset are located at: https://bugs.openjdk.java.net/browse/JDK-8239504 https://cr.openjdk.java.net/~naot

RFR: 8244936: Reduce JNI overhead of accessing FileDescriptor

Hi, compilers can't see though and optimize away the repeated GetObjectField calls in places such as in the io_util_md.h GET_FD macro: #define GET_FD(this, fid) \ (*env)->GetObjectField(env, (this), (fid)) == NULL ? \ -1 : (*env)->GetIntField(env, (*env)->GetObjectField(env, (this),

Re: [8u] RFR(S): 8244548: JDK 8u: sun.misc.Version.jdkUpdateVersion() returns wrong result

On 12/05/2020 15:14, Severin Gehwolf wrote: > Hi Andrew, > > Thanks for looking at this. > > On Tue, 2020-05-12 at 14:07 +0100, Andrew Haley wrote: >> On 5/7/20 4:09 PM, Severin Gehwolf wrote: >>> jvm_version_info.jvm_version currently holds this quadruplet: >>> >>> Most significant 8 bits => maj

[8u] RFR: [JDK 8u] JapanEraNameCompatTest fails

Hi, Could somebody please review this fix for the failing JapanEraNameCompatTest.java test (part of tier1)? The reason why it's failing is that there are missing locale data for no and sr_Latn which are exercised by the test. The original backport of JDK-8219781 didn't include those as the changed

Re: RFR: JDK-8244576: [macos] Volume icon deleted by osascript for background image

Looks good. - Alexey On 5/13/2020 10:11 AM, Andy Herrick wrote: Please review jpackage fix for issue [1] at [2]. [1] - https://bugs.openjdk.java.net/browse/JDK-8244576 [2] - http://cr.openjdk.java.net/~herrick/8244576/webrev.01/ /Andy

RFR: JDK-8244576: [macos] Volume icon deleted by osascript for background image

Please review jpackage fix for issue [1] at [2]. [1] - https://bugs.openjdk.java.net/browse/JDK-8244576 [2] - http://cr.openjdk.java.net/~herrick/8244576/webrev.01/ /Andy

Re: RFR 8243491: Implementation of Foreign-Memory Access API (Second Incubator)

> On 13 May 2020, at 13:12, Maurizio Cimadamore > wrote: > > Another iteration which addresses the latest CSR comments (the CSR has now > been approved): > > * make MemorySegment::withAccessModes/hasAccessMode throw > IllegalArgumentException in cases where the provided mask is invalid (thi

Re: RFR 8243491: Implementation of Foreign-Memory Access API (Second Incubator)

Another iteration which addresses the latest CSR comments (the CSR has now been approved): * make MemorySegment::withAccessModes/hasAccessMode throw IllegalArgumentException in cases where the provided mask is invalid (this required a test tweak) * sprinkled a couple of references to the JLS i