Re: RFR: 8250646: hdiutil detach fix JDK-8245311 still fails sometimes

2020-07-31 Thread alexander . matveev
Hi Alexey, Without modifying some logic in Executor, yes stop is needed. After retryExecutor.stop(); is executed in MacDmgBundler we will still run command (same with abort), and this command will fail and exception will be thrown. Stop() is basically like abort, but exception is ignored.

Re: Language locales have different calendars than country locales in 9+

2020-07-31 Thread naoto . sato
On 7/31/20 3:08 PM, Bernd Eckenfels wrote: Hello, Is there a good description what calendar is actually used for a language-only locale? Is there a typical association of calendars with locales or is it a global default? If the unicode data does not have such a value, would it be better to

JDK 16 RFR of JDK-8250660: Clarify that WildcardType and AnnotatedWildcardType bounds methods return one

2020-07-31 Thread Joe Darcy
Hello, Please review the doc clarification below to address     8250660: Clarify that WildcardType and AnnotatedWildcardType bounds methods return one Thanks, -Joe diff -r b0553ba43ba1 src/java.base/share/classes/java/lang/reflect/AnnotatedWildcardType.java ---

Re: Language locales have different calendars than country locales in 9+

2020-07-31 Thread Bernd Eckenfels
Hello, Is there a good description what calendar is actually used for a language-only locale? Is there a typical association of calendars with locales or is it a global default? If the unicode data does not have such a value, would it be better to fall back to the next provider (like COMPAT)?

Re: Language locales have different calendars than country locales in 9+

2020-07-31 Thread naoto . sato
Hi Bernd, As you pointed out, the change you see here is the result of this change in JDK9: https://bugs.openjdk.java.net/browse/JDK-8008577 where the default locale provider was switched to CLDR. Although we don't describe those behavior changes in the spec (as it is regarded as l10n

Language locales have different calendars than country locales in 9+

2020-07-31 Thread Bernd Eckenfels
Hello, Just wanted to mention a thing I noticed when switching from 8 to 11. I knew before that the Locale data provider has changed, and I could notice that for example in the writing style for abbreviated words in dates. However something I did not expect is, that the definition of Calemdars

8249703: test/jdk/java/io/File/GetXSpace.java fails on macos

2020-07-31 Thread Brian Burkhalter
On macOS, the number of 1024 byte blocks appears to be incorrectly calculated by 'df' using integer division by 2 of the number of 512 byte blocks, resulting in a size smaller than the actual value when the number of blocks is odd. Possibly instead of having the IS_MAC and IS_WIN constants it

Re: RFR: 8250646: hdiutil detach fix JDK-8245311 still fails sometimes

2020-07-31 Thread Alexey Semenyuk
Alexander, Why introduce RetryExecutor.stop() method? Isn't RetryExecutor.abort() sufficient? - Alexey On 7/30/2020 8:10 PM, alexander.matv...@oracle.com wrote: Please review the jpackage fix for bug [1] at [2]. - DMG image can get detach even if "hdiutil detach" return resource busy

Re: [15] RFR(S) : 6501010 : test/java/io/File/GetXSpace.java fails on Windows

2020-07-31 Thread Brian Burkhalter
Hi Igor, No, I think JDK mainline is good, especially given that it is a test. Thanks, Brian > On Jul 30, 2020, at 7:44 PM, Igor Ignatyev wrote: > > thanks for your review. I've decided to push into jdk/jdk instead of jdk15. > please let me know if you think this patch needs to be in jdk15,

Re: RFR: 8250646: hdiutil detach fix JDK-8245311 still fails sometimes

2020-07-31 Thread Andy Herrick
looks good to me /Andy On 7/30/2020 8:10 PM, alexander.matv...@oracle.com wrote: Please review the jpackage fix for bug [1] at [2]. - DMG image can get detach even if "hdiutil detach" return resource busy error. Fixed by stopping trying detach if DMG already got detach. [1]

Re: [PING?] RFR(S): 8248910: NPE when freeing the memory for a slice from a buffer

2020-07-31 Thread Alan Bateman
On 31/07/2020 02:45, Yangfei (Felix) wrote: Ping... Any suggestions? Can you bring this to nio-dev for discussion? I don't know what "Randoop" is but it seems to be using sun.nio.ch.Util directly. I think I'd like to understand if there is a case where we would actually attempt to free a