On Wed, 21 Oct 2020 01:33:48 GMT, CoreyAshford
wrote:
>> Please, update
>> src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CheckGraalIntrinsics.java
>
>> Please, update
>> src/jdk.internal.vm.compiler/share/classes/org.graalvm.co
On Tue, 20 Oct 2020 08:17:27 GMT, Sergey Bylokhov wrote:
> In some files, the copyright text is styled as a JavaDoc comment.
> Most of the affected files are tests, only one product file is affected:
> src/java.sql/share/classes/javax/sql/package-info.java
>
> The chenge is trivial:
> - /**
>
On Tue, 20 Oct 2020 11:36:41 GMT, Jan Lahoda wrote:
>> test/langtools/tools/javac/patterns/LocalVariableTable.java line 29:
>>
>>> 27: * @summary Ensure the LV table entries are generated for bindings
>>> 28: * @modules jdk.jdeps/com.sun.tools.classfile
>>> 29: * @compile -g LocalVariableTabl
On Tue, 20 Oct 2020 12:03:39 GMT, Jan Lahoda wrote:
>> This is the current proposed patch for the upcoming JEP 394, for pattern
>> matching for instanceof.
>>
>> A summary of changes:
>> -making the feature permanent (non-preview)
>> -making the binding variables non-final (as per current speci
On Wed, 21 Oct 2020 02:28:30 GMT, Kim Barrett wrote:
>> Finally returning to this review that was started in April 2020. I've
>> recast it as a github PR. I think the security concern raised by Gil
>> has been adequately answered.
>> https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2020-A
> Finally returning to this review that was started in April 2020. I've
> recast it as a github PR. I think the security concern raised by Gil
> has been adequately answered.
> https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2020-April/029203.html
> https://mail.openjdk.java.net/pipermail/
On Tue, 20 Oct 2020 16:35:02 GMT, Mandy Chung wrote:
>>> @kimbarrett your reworded text is okay. I think "if it initially had some
>>> other referent value" can be dropped.
>>>
>>> For a `Reference` constructed with a `null` referent, we can clarify in the
>>> spec that such reference object w
> This patch set encompasses the following commits:
>
> - Adds a new HotSpot intrinsic candidate to the java.lang.Base64 class -
> decodeBlock(), and provides a flexible API for
> the intrinsic. The API is similar to the existing encodeBlock intrinsic.
> - Adds the code in HotSpot to check and
On Wed, 21 Oct 2020 01:25:33 GMT, Vladimir Kozlov wrote:
> Please, update
> src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CheckGraalIntrinsics.java
I will push the code, but I haven't been successful in running the test (see
ht
> This patch set encompasses the following commits:
>
> - Adds a new HotSpot intrinsic candidate to the java.lang.Base64 class -
> decodeBlock(), and provides a flexible API for
> the intrinsic. The API is similar to the existing encodeBlock intrinsic.
> - Adds the code in HotSpot to check and
On Mon, 12 Oct 2020 21:41:37 GMT, CoreyAshford
wrote:
>> This patch set encompasses the following commits:
>>
>> - Adds a new HotSpot intrinsic candidate to the java.lang.Base64 class -
>> decodeBlock(), and provides a flexible API for
>> the intrinsic. The API is similar to the existing en
On Tue, 20 Oct 2020 16:42:46 GMT, CoreyAshford
wrote:
> @CoreyAshford apologies i pointed to the "umbrella" test that runs Graal unit
> tests, the actual test is
> [CheckGraalIntrinsics](https://github.com/openjdk/jdk/blob/master/src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.h
On Tue, 20 Oct 2020 12:03:39 GMT, Jan Lahoda wrote:
>> This is the current proposed patch for the upcoming JEP 394, for pattern
>> matching for instanceof.
>>
>> A summary of changes:
>> -making the feature permanent (non-preview)
>> -making the binding variables non-final (as per current speci
On Tue, 20 Oct 2020 23:54:08 GMT, John Lin
wrote:
>> Hi Jon,
>>
>> Can you explain what this change is about: e.g. something like:
>>
>>> Updates the documentation of `Map::compute` to match its default
>>> implementation:
>>> The documentation of the default implementation of `Map::compute`
On Mon, 19 Oct 2020 17:26:56 GMT, Daniel Fuchs wrote:
>> This is from the mailing list:
>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2020-June/067190.html
>>
>> -
>> ### Progress
>> - [x] Change must not contain extraneous whitespace
>> - [x] Commit message must refer to an i
On Fri, 16 Oct 2020 19:38:45 GMT, Vipin Sharma wrote:
> ... is replaced with {@code ...} in java.sql classes.
> Please review and sponsor this change.
Hi Vipin
Thank you for tackling this update. There are a few required changes below. I
will also be going through the
generated javadoc to se
On Sun, 18 Oct 2020 15:09:31 GMT, Peter Levart wrote:
>> Hi Peter,
>>
>> This seems an attracting idea to keep the possibility of using lambdas.
>> However, the full privileged lookup of the
>> proxy class will be leaked to `InvocationHandlerWithLookup` implementation
>> which imposes securit
On Tue, 20 Oct 2020 21:49:37 GMT, Brent Christian wrote:
> Hi,
>
> The java/util/prefs/AddNodeChangeListener.java test fails once in a while in
> the automated test system. Previous
> failures were traced to machine configuration errors, but that does not
> appear to be the case this time.
>
On Tue, 20 Oct 2020 13:42:27 GMT, Fei Yang wrote:
>> Contributed-by: ard.biesheu...@linaro.org, dong...@huawei.com
>>
>> This added an intrinsic for SHA3 using aarch64 v8.2 SHA3 Crypto Extensions.
>> Reference implementation for core SHA-3 transform using ARMv8.2 Crypto
>> Extensions:
>> https:
On Sat, 17 Oct 2020 14:01:22 GMT, Andy Herrick wrote:
> …from installer name
> JDK-8254783: jpackage fails on Windows when application name differs from
> installer name
> When using --app-image, to create MSI installer, use the application name
> from AppImageData instead of the Msi
> installe
On Sat, 17 Oct 2020 14:01:22 GMT, Andy Herrick wrote:
> …from installer name
> JDK-8254783: jpackage fails on Windows when application name differs from
> installer name
> When using --app-image, to create MSI installer, use the application name
> from AppImageData instead of the Msi
> installe
Perfect - exactly as my local fix. I assigned bug to you and will do review of
your PR.
I am running tier1-3 testing and let you know results. Please, wait before
integration.
Thanks,
Vladimir K
On 10/20/20 2:44 PM, Viswanathan, Sandhya wrote:
Hi Vladimir,
I submitted a pull request an hour
Hi,
The java/util/prefs/AddNodeChangeListener.java test fails once in a while in
the automated test system. Previous
failures were traced to machine configuration errors, but that does not appear
to be the case this time.
My efforts to reproduce this failure have been unsuccessful. The only u
Hi Vladimir,
I submitted a pull request an hour or so ago as this was a P1 bug, feel free to
use that or ignore.
https://git.openjdk.java.net/jdk/pull/772
Best Regards,
Sandhya
-Original Message-
From: Vladimir Kozlov
Sent: Tuesday, October 20, 2020 2:40 PM
To: Viswanathan, Sandhya ;
Thank you, Sandhya
Very nice analysis.
I just finished running dsig/GenerationTests.java test multiply runs (to besure) on our systems and confirmed your
proposed fix:
bsfl(ch, tmp);
+ if (UseNewCode) {
+addptr(result, ch);
+ } else {
addl(result, ch);
+ }
It always fails with
On Fri, 16 Oct 2020 17:59:14 GMT, Andy Herrick wrote:
> JDK-8254843: Exception launching app on windows in some cases
> loading splashscreen.dll in WinLaunchercpp would load java.dll from path
> instead of runtime/bin causing jni launcher to
> crash. instead we just use what used to be the fallb
On Fri, 16 Oct 2020 17:59:14 GMT, Andy Herrick wrote:
> JDK-8254843: Exception launching app on windows in some cases
> loading splashscreen.dll in WinLaunchercpp would load java.dll from path
> instead of runtime/bin causing jni launcher to
> crash. instead we just use what used to be the fallb
On Sat, 17 Oct 2020 14:01:22 GMT, Andy Herrick wrote:
> …from installer name
> JDK-8254783: jpackage fails on Windows when application name differs from
> installer name
> When using --app-image, to create MSI installer, use the application name
> from AppImageData instead of the Msi
> installe
On Sat, 17 Oct 2020 14:01:22 GMT, Andy Herrick wrote:
> …from installer name
> JDK-8254783: jpackage fails on Windows when application name differs from
> installer name
> When using --app-image, to create MSI installer, use the application name
> from AppImageData instead of the Msi
> installe
On 10/12/20 7:08 PM, Marcono1234 wrote:
src/java.base/share/classes/java/util/HexFormat.java line 836:
834: * otherwise {@code false}
835: */
836: public boolean isHexDigit(int ch) {
Should this method be `static`? Or otherwise should it consider the
`uppercase()` setti
It's a bug in determining if a protected member inherited from a superclass is
in
a split package as its host class that it only checks on the package name.
The fix is simple and compare the runtime package of the lambda class (which
is in the same runtime package as the host class) with that of
On Mon, 19 Oct 2020 22:52:31 GMT, Roger Riggs wrote:
>> java.util.HexFormat utility:
>>
>> - Format and parse hexadecimal strings, with parameters for delimiter,
>> prefix, suffix and upper/lowercase
>> - Static factories and builder methods to create HexFormat copies with
>> modified parame
Hi Vladimir,
I analyzed the instruction dump yesterday to find out where the issue is. I
have attached it to the bug report as 8254790.asm:
https://bugs.openjdk.java.net/browse/JDK-8254790
The crash is reported at:
100: 450FB64C1810 movzx r9d, byte ptr [r8+rbx*1+0x10]
Which i
> This patch contains the changes associated with the first incubation round of
> the foreign linker access API incubation
> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory
> access support (see JEP 393 [2] and
> associated pull request [3]).
> The main goal of this API
On Mon, 19 Oct 2020 19:43:13 GMT, Paul Sandoz wrote:
> The zero methods on `IntVector` and all other specializations are missing
> documentation.
Looks good.
-
Marked as reviewed by vlivanov (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/748
Yes, I saw it too but I was not sure because we never hit the issue with
Unicode string index intrinsic.
An other thing is we see the failure only on MacOS.
I also want someone to decode asm dump I provided in bug to see actual
instructions where it happened.
Vladimir K
On 10/19/20 5:38 PM, V
On Tue, 20 Oct 2020 16:17:15 GMT, Paul Sandoz wrote:
>>> Please update
>>> [compiler/graalunit/HotspotTest.java](https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/compiler/graalunit/HotspotTest.java),
>>> and add the intrinsic signature.
>>
>> It looks like that is auto-generated, bu
On Tue, 20 Oct 2020 05:22:57 GMT, Kim Barrett wrote:
>> @kimbarrett your reworded text is okay. I think "if it initially had some
>> other referent value" can be dropped.
>>
>> For a `Reference` constructed with a `null` referent, we can clarify in the
>> spec that such reference object will
On Thu, 15 Oct 2020 17:58:29 GMT, CoreyAshford
wrote:
>> Please update
>> [compiler/graalunit/HotspotTest.java](https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/compiler/graalunit/HotspotTest.java),
>> and add the intrinsic signature.
>
>> Please update
>> [compiler/graalunit/Hotspo
On Tue, 20 Oct 2020 11:39:36 GMT, Kiran Sidhartha Ravikumar
wrote:
>> Hi Guys,
>>
>> Please review the integration of tzdata2020c to JDK.
>>
>> Details regarding the change can be viewed at -
>> https://mm.icann.org/pipermail/tz-announce/2020-October/60.html
>> Bug: https://bugs.openjdk.j
On Tue, 20 Oct 2020 08:17:27 GMT, Sergey Bylokhov wrote:
> In some files, the copyright text is styled as a JavaDoc comment.
> Most of the affected files are tests, only one product file is affected:
> src/java.sql/share/classes/javax/sql/package-info.java
>
> The chenge is trivial:
> - /**
>
On Tue, 20 Oct 2020 10:26:59 GMT, Chris Hegarty wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Correct length of StringBuilder in formatHex;
>> Correct bug in formatHex(char[], 2, 3) and add test for subranges of
On Tue, 20 Oct 2020 09:44:51 GMT, Chris Hegarty wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Correct length of StringBuilder in formatHex;
>> Correct bug in formatHex(char[], 2, 3) and add test for subranges of
On Tue, 20 Oct 2020 09:37:23 GMT, Chris Hegarty wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Correct length of StringBuilder in formatHex;
>> Correct bug in formatHex(char[], 2, 3) and add test for subranges of
On Tue, 20 Oct 2020 08:17:27 GMT, Sergey Bylokhov wrote:
> In some files, the copyright text is styled as a JavaDoc comment.
> Most of the affected files are tests, only one product file is affected:
> src/java.sql/share/classes/javax/sql/package-info.java
>
> The chenge is trivial:
> - /**
>
On Mon, 19 Oct 2020 14:14:50 GMT, Andy Herrick wrote:
>> I think we need a test for this use case.
>
>>
>>
>> I think we need a test for this use case.
>
> The automated test is complicated by the same incorrect assumptions in the
> test infrastructure (that installer name and
> app name are
> Contributed-by: ard.biesheu...@linaro.org, dong...@huawei.com
>
> This added an intrinsic for SHA3 using aarch64 v8.2 SHA3 Crypto Extensions.
> Reference implementation for core SHA-3 transform using ARMv8.2 Crypto
> Extensions:
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
On Tue, 20 Oct 2020 12:15:23 GMT, Jan Lahoda wrote:
>> This is an update to javac and javadoc, to introduce support for Preview
>> APIs, and generally improve javac and javadoc
>> behavior to more closely adhere to JEP 12.
>> The notable changes are:
>>
>> * adding support for Preview APIs (ja
On Fri, 16 Oct 2020 16:47:25 GMT, Erik Joelsson wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now
>> contains 35 commits:
>> - Merge branch 'JDK-8250768-dev' of https://github.com/lahodaj/jdk into
>> JDK-8250768
>> - M
> This is an update to javac and javadoc, to introduce support for Preview
> APIs, and generally improve javac and javadoc
> behavior to more closely adhere to JEP 12.
> The notable changes are:
>
> * adding support for Preview APIs (javac until now supported primarily only
> preview language f
On Tue, 20 Oct 2020 08:17:27 GMT, Sergey Bylokhov wrote:
> In some files, the copyright text is styled as a JavaDoc comment.
> Most of the affected files are tests, only one product file is affected:
> src/java.sql/share/classes/javax/sql/package-info.java
>
> The chenge is trivial:
> - /**
>
On 20/10/2020 5:51 pm, Kim Barrett wrote:
On Oct 20, 2020, at 3:21 AM, David Holmes wrote:
On 20/10/2020 5:01 pm, Kim Barrett wrote:
On Oct 20, 2020, at 2:09 AM, David Holmes wrote:
I think that can be addressed by considering a Reference created with a null
referent to be immediately clear
> Hi Guys,
>
> Please review the integration of tzdata2020c to JDK.
>
> Details regarding the change can be viewed at -
> https://mm.icann.org/pipermail/tz-announce/2020-October/60.html
> Bug: https://bugs.openjdk.java.net/browse/JDK-8254982
>
> Along with it, there is a test fix for
> htt
On Tue, 20 Oct 2020 03:09:27 GMT, Vicente Romero wrote:
>> This is the current proposed patch for the upcoming JEP 394, for pattern
>> matching for instanceof.
>>
>> A summary of changes:
>> -making the feature permanent (non-preview)
>> -making the binding variables non-final (as per current s
On Mon, 19 Oct 2020 19:38:57 GMT, Naoto Sato wrote:
>> Kiran Sidhartha Ravikumar has updated the pull request with a new target
>> base due to a merge or a rebase. The
>> incremental webrev excludes the unrelated changes brought in by the
>> merge/rebase. The pull request contains three
>> addi
On Mon, 12 Oct 2020 22:17:58 GMT, Marcono1234
wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Correct length of StringBuilder in formatHex;
>> Correct bug in formatHex(char[], 2, 3) and add test for subranges of
On Mon, 19 Oct 2020 22:52:31 GMT, Roger Riggs wrote:
>> java.util.HexFormat utility:
>>
>> - Format and parse hexadecimal strings, with parameters for delimiter,
>> prefix, suffix and upper/lowercase
>> - Static factories and builder methods to create HexFormat copies with
>> modified parame
On Tue, 20 Oct 2020 03:02:03 GMT, Vicente Romero wrote:
>> This is the current proposed patch for the upcoming JEP 394, for pattern
>> matching for instanceof.
>>
>> A summary of changes:
>> -making the feature permanent (non-preview)
>> -making the binding variables non-final (as per current s
On Mon, 19 Oct 2020 18:13:59 GMT, Vladimir Kozlov wrote:
>> Aleksey Shipilev has refreshed the contents of this pull request, and
>> previous commits have been removed. The
>> incremental views will show differences compared to the previous content of
>> the PR.
>
> Always run graalunit testing
In some files, the copyright text is styled as a JavaDoc comment.
Most of the affected files are tests, only one product file is affected:
src/java.sql/share/classes/javax/sql/package-info.java
The chenge is trivial:
- /**
+ /*
* Copyright (c)
-
Commit messages:
- Initial fix
On Mon, 19 Oct 2020 20:26:22 GMT, Vladimir Kozlov wrote:
> Always run graalunit testing with new intrinsics. You need to adjust Graal
> test:
> src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CheckGraalIntrinsics.java
Thanks for
> On Oct 20, 2020, at 3:21 AM, David Holmes wrote:
>
> On 20/10/2020 5:01 pm, Kim Barrett wrote:
>>> On Oct 20, 2020, at 2:09 AM, David Holmes wrote:
>>>
>>> I think that can be addressed by considering a Reference created with a
>>> null referent to be immediately cleared.
>> I think if it’s
On 20/10/2020 5:01 pm, Kim Barrett wrote:
On Oct 20, 2020, at 2:09 AM, David Holmes wrote:
On 20/10/2020 3:26 pm, Kim Barrett wrote:
On Tue, 20 Oct 2020 03:25:45 GMT, Mandy Chung wrote:
@kimbarrett your reworded text is okay. I think "if it initially had some other
referent value" can be dr
On Thu, 1 Oct 2020 07:07:24 GMT, John Lin
wrote:
> This is from the mailing list:
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2020-June/067213.html
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.java.net/jdk/pull/451
> On Oct 20, 2020, at 2:09 AM, David Holmes wrote:
>
> On 20/10/2020 3:26 pm, Kim Barrett wrote:
>> On Tue, 20 Oct 2020 03:25:45 GMT, Mandy Chung wrote:
>>> @kimbarrett your reworded text is okay. I think "if it initially had some
>>> other referent value" can be dropped.
>>>
>>> For a `Refere
65 matches
Mail list logo
