Re: RFR: JDK-8256844: Make NMT late-initializable

2021-07-29 Thread Kim Barrett
On Thu, 29 Jul 2021 22:53:42 GMT, Coleen Phillimore wrote: >> Short: this patch makes NMT available in custom-launcher scenarios and >> during gtests. It simplifies NMT initialization. It adds a lot of >> NMT-specific testing, cleans them up and makes them sideeffect-free. >> >> - >>

Re: RFR: JDK-8256844: Make NMT late-initializable

2021-07-29 Thread Kim Barrett
On Thu, 29 Jul 2021 22:52:07 GMT, Coleen Phillimore wrote: >> Short: this patch makes NMT available in custom-launcher scenarios and >> during gtests. It simplifies NMT initialization. It adds a lot of >> NMT-specific testing, cleans them up and makes them sideeffect-free. >> >> - >>

PhantomReferences

2021-07-29 Thread Hans Boehm
Here's another finalization-related issue, this time hopefully appropriate for this list. This was inspired by looking at the Ugawa, Jones, and Ritson paper from ISMM 2014, which I belatedly had a chance to look at. The java.lang.ref spec says: "An object is phantom reachable if it is neither

Re: RFR: 8251329: (zipfs) Files.walkFileTree walks infinitely if zip has dir named "." inside [v3]

2021-07-29 Thread Jaikiran Pai
On Thu, 29 Jul 2021 18:21:07 GMT, Lance Andersen wrote: >> Hi, >> >> As discussed in the >> https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-July/079621.html >> thread, this is the revised patch to address the use of '.' and '..' within >> Zip FS >> >> Zip FS needs to use "." and

Re: RFR: 8251329: (zipfs) Files.walkFileTree walks infinitely if zip has dir named "." inside [v4]

2021-07-29 Thread Lance Andersen
> Hi, > > As discussed in the > https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-July/079621.html > thread, this is the revised patch to address the use of '.' and '..' within > Zip FS > > Zip FS needs to use "." and ".." as links to the current and parent > directories and cannot

Re: RFR: 8265891: (ch) InputStream returned by Channels.newInputStream should override transferTo [v6]

2021-07-29 Thread Brian Burkhalter
On Thu, 29 Jul 2021 19:56:40 GMT, Markus KARG wrote: >> It's actually a matter of convention but I think it can remain as it is. > > Ok for me, otherwise just clearly tell me and I do change it. I think you can leave it unless someone else thinks otherwise. - PR:

RFR: 8271225: Add floorDivExact() method to java.lang.[Strict]Math

2021-07-29 Thread Brian Burkhalter
Add methods `floorDivExact(int,int)` and `floorDivExact(long,long)` to `java.lang.Math` and `java.lang.StrictMath`. - Commit messages: - 8271225: Add floorDivExact() method to java.lang.[Strict]Math Changes: https://git.openjdk.java.net/jdk/pull/4941/files Webrev:

Re: RFR: 8271225: Add floorDivExact() method to java.lang.[Strict]Math

2021-07-29 Thread Brian Burkhalter
On Thu, 29 Jul 2021 23:27:32 GMT, Brian Burkhalter wrote: > Add methods `floorDivExact(int,int)` and `floorDivExact(long,long)` to > `java.lang.Math` and `java.lang.StrictMath`. The `floorDivExact()` methods are identical to their `floorDiv()` counterparts aside from that they throw an

Re: RFR: JDK-8256844: Make NMT late-initializable

2021-07-29 Thread Coleen Phillimore
On Thu, 22 Jul 2021 14:58:47 GMT, Thomas Stuefe wrote: > Short: this patch makes NMT available in custom-launcher scenarios and during > gtests. It simplifies NMT initialization. It adds a lot of NMT-specific > testing, cleans them up and makes them sideeffect-free. > > - > > NMT

Re: RFR: 8251329: (zipfs) Files.walkFileTree walks infinitely if zip has dir named "." inside [v3]

2021-07-29 Thread Naoto Sato
On Thu, 29 Jul 2021 18:21:07 GMT, Lance Andersen wrote: >> Hi, >> >> As discussed in the >> https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-July/079621.html >> thread, this is the revised patch to address the use of '.' and '..' within >> Zip FS >> >> Zip FS needs to use "." and

Re: RFR: Merge jdk17 [v2]

2021-07-29 Thread Jesper Wilhelmsson
> Forwardport JDK 17 -> JDK 18 Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 358 commits: - Merge - 8271396: Spelling errors Reviewed-by: tschatzl, chegar, iris, psadhukhan, cjplummer - 8268019: C2:

Integrated: Merge jdk17

2021-07-29 Thread Jesper Wilhelmsson
On Thu, 29 Jul 2021 21:05:31 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 17 -> JDK 18 This pull request has now been integrated. Changeset: 048fb2cb Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/048fb2cb179234c403ee01ddc4acbdc4795c08ee Stats: 4

RFR: Merge jdk17

2021-07-29 Thread Jesper Wilhelmsson
Forwardport JDK 17 -> JDK 18 - Commit messages: - Merge - 8271489: (doc) Clarify Filter Factory example The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.java.net/?repo=jdk=4939=00.0 - jdk17:

[jdk17] Integrated: 8271489: (doc) Clarify Filter Factory example

2021-07-29 Thread Roger Riggs
On Thu, 29 Jul 2021 19:05:58 GMT, Roger Riggs wrote: > Improve the clarity of comments in the ObjectInputFilter FilterInThread > example. This pull request has now been integrated. Changeset: 286d3136 Author:Roger Riggs URL:

Re: RFR: 8265891: (ch) InputStream returned by Channels.newInputStream should override transferTo [v6]

2021-07-29 Thread Markus KARG
On Thu, 29 Jul 2021 16:42:35 GMT, Brian Burkhalter wrote: >> The JavaDocs in `InputStream::transferTo` *cleary* tell the caller that >> there is **no** guarantee of *any* specific behavior in that particular >> case: >>>The behavior for the case where the input and/or output stream is

Re: [jdk17] RFR: 8271489: (doc) Clarify Filter Factory example

2021-07-29 Thread Brian Burkhalter
On Thu, 29 Jul 2021 19:05:58 GMT, Roger Riggs wrote: > Improve the clarity of comments in the ObjectInputFilter FilterInThread > example. Marked as reviewed by bpb (Reviewer). - PR: https://git.openjdk.java.net/jdk17/pull/293

Re: [jdk17] RFR: 8271489: (doc) Clarify Filter Factory example

2021-07-29 Thread Naoto Sato
On Thu, 29 Jul 2021 19:05:58 GMT, Roger Riggs wrote: > Improve the clarity of comments in the ObjectInputFilter FilterInThread > example. Marked as reviewed by naoto (Reviewer). - PR: https://git.openjdk.java.net/jdk17/pull/293

Re: [jdk17] RFR: 8271489: (doc) Clarify Filter Factory example

2021-07-29 Thread Iris Clark
On Thu, 29 Jul 2021 19:05:58 GMT, Roger Riggs wrote: > Improve the clarity of comments in the ObjectInputFilter FilterInThread > example. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk17/pull/293

Re: [jdk17] RFR: 8271489: (doc) Clarify Filter Factory example

2021-07-29 Thread Kevin Rushforth
On Thu, 29 Jul 2021 19:05:58 GMT, Roger Riggs wrote: > Improve the clarity of comments in the ObjectInputFilter FilterInThread > example. Marked as reviewed by kcr (Author). - PR: https://git.openjdk.java.net/jdk17/pull/293

[jdk17] RFR: 8271489: (doc) Clarify Filter Factory example

2021-07-29 Thread Roger Riggs
Improve the clarity of comments in the ObjectInputFilter FilterInThread example. - Commit messages: - 8271489: (doc) Clarify Filter Factory example Changes: https://git.openjdk.java.net/jdk17/pull/293/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17=293=00 Issue:

Re: RFR: 8251329: (zipfs) Files.walkFileTree walks infinitely if zip has dir named "." inside [v3]

2021-07-29 Thread Lance Andersen
> Hi, > > As discussed in the > https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-July/079621.html > thread, this is the revised patch to address the use of '.' and '..' within > Zip FS > > Zip FS needs to use "." and ".." as links to the current and parent > directories and cannot

[jdk17] Withdrawn: 8271489: (doc) Clarify Filter Factory example

2021-07-29 Thread Roger Riggs
On Thu, 29 Jul 2021 16:36:21 GMT, Roger Riggs wrote: > Improve the clarity of comments in the ObjectInputFilter FilterInThread > example. This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk17/pull/292

Re: RFR: 8265891: (ch) InputStream returned by Channels.newInputStream should override transferTo [v6]

2021-07-29 Thread Brian Burkhalter
On Thu, 29 Jul 2021 08:12:23 GMT, Markus KARG wrote: >> src/java.base/share/classes/sun/nio/ch/ChannelInputStream.java line 179: >> >>> 177: for (long n = srcSize - srcPos; bytesWritten < n;) >>> 178: bytesWritten += src.transferTo(srcPos + bytesWritten, >>>

[jdk17] RFR: 8271489: (doc) Clarify Filter Factory example

2021-07-29 Thread Roger Riggs
Improve the clarity of comments in the ObjectInputFilter FilterInThread example. - Commit messages: - 8271489: (doc) Clarify Filter Factory example - 8270398: Enhance canonicalization - 8270404: Better canonicalization - Merge - Merge - 8263531: Remove unused buffer int -

Integrated: 8271396: Spelling errors

2021-07-29 Thread Emmanuel Bourg
On Wed, 3 Feb 2021 19:12:25 GMT, Emmanuel Bourg wrote: > This PR fixes the following spelling errors: > > choosen -> chosen > commad -> command > hiearchy -> hierarchy > leagacy -> legacy > minium -> minimum > subsytem -> subsystem > unamed -> unnamed This pull request has now

Re: RFR: 8271396: Spelling errors [v2]

2021-07-29 Thread Emmanuel Bourg
On Wed, 28 Jul 2021 17:12:04 GMT, Emmanuel Bourg wrote: >> This PR fixes the following spelling errors: >> >> choosen -> chosen >> commad -> command >> hiearchy -> hierarchy >> leagacy -> legacy >> minium -> minimum >> subsytem -> subsystem >> unamed -> unnamed > > Emmanuel

Re: RFR: 8271396: Spelling errors

2021-07-29 Thread Julia Boes
On Wed, 28 Jul 2021 17:23:51 GMT, Emmanuel Bourg wrote: >> @ebourg for future PRs please do not force push after the PR is out for >> review. Just push incremental commits normally. The Skara tooling will >> squash them all into a single commit. > > @kevinrushforth I'll do that, thank you for

Re: [External] : Re: jpackage MacOS Notarization

2021-07-29 Thread Andy Herrick
sorry - code looks for certificate key starting with: "Developer ID Application: " + in order to not have to put full user name in.  I missed that that with null user name that causes it to look for anything starting with "Developer ID Application: " (same thing with "Developer ID Installer:

Re: [External] : Re: jpackage MacOS Notarization

2021-07-29 Thread Daniel Peintner
Hi Andy, Since I don't know your setup I did not put anything there. '--mac-sign' is enough to use the defaults in my setup. It looks for the signing keys installed on my machine that start with "Developer ID Application " similar to '--mac-signing-key-user-name', 'Developer ID Application: '

Re: [External] : Re: jpackage MacOS Notarization

2021-07-29 Thread Andy Herrick
The 'build.gradle' in this branch has --mac-signing-key-user-name commented out.     installerOptions += [     '--mac-sign',     // '--mac-s'SIGNING_KEY_USER_NAME'igning-key-user-name', System.getenv('SIGNING_KEY_USER_NAME'),     //

Re: jpackage MacOS Notarization

2021-07-29 Thread Daniel Peintner
Kevin, Andy, Thanks for your quick response. Full support for notarization in jpackage was added in JDK 17. Can you > try an early access build of JDK 17 [1] and see if that works for you? > I did try JDK17-ea-32 also with the same result. Since I do understand it is difficult reproduce the

Re: RFR: 8265891: (ch) InputStream returned by Channels.newInputStream should override transferTo [v6]

2021-07-29 Thread Markus KARG
On Mon, 26 Jul 2021 23:59:05 GMT, Brian Burkhalter wrote: >> Markus KARG has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. > >

Re: RFR: 8265891: (ch) InputStream returned by Channels.newInputStream should override transferTo [v6]

2021-07-29 Thread Markus KARG
On Tue, 27 Jul 2021 00:57:02 GMT, Brian Burkhalter wrote: >> Markus KARG has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. > >

Re: RFR: JDK-8256844: Make NMT late-initializable

2021-07-29 Thread David Holmes
On Thu, 22 Jul 2021 14:58:47 GMT, Thomas Stuefe wrote: > Short: this patch makes NMT available in custom-launcher scenarios and during > gtests. It simplifies NMT initialization. It adds a lot of NMT-specific > testing, cleans them up and makes them sideeffect-free. > > - > > NMT