On Mon, 28 Mar 2022 09:56:22 GMT, Xiaohong Gong wrote:
>> The current vector `"NEG"` is implemented with substraction a vector by zero
>> in case the architecture does not support the negation instruction. And to
>> fit the predicate feature for architectures that support it, the masked
>>
On Mon, 28 Mar 2022 17:08:12 GMT, Lance Andersen wrote:
> With this fix, I believe
> [JDK-8282446](https://bugs.openjdk.java.net/browse/JDK-8282446) should also
> be addressed.
Thanks for mentioning this. I have uploaded another commit
> Please review this PR which is updating the ASM included in the JDK to ASM
> 9.2. This version should be included in JDK19. There are basically two
> commits here, one that was automatically generated and that mostly changes
> file headers etc and another one, smaller, that make changes to
On Sun, 27 Mar 2022 06:15:34 GMT, Vamsi Parasa wrote:
> Implements x86 intrinsics for compare() method in java.lang.Integer and
> java.lang.Long.
src/hotspot/cpu/x86/x86_64.ad line 12107:
> 12105: instruct compareSignedI_rReg(rRegI dst, rRegI op1, rRegI op2, rRegI
> tmp, rFlagsReg cr)
>
On Mon, 28 Mar 2022 10:55:30 GMT, Volker Simonis wrote:
>> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)`
>> to highlight that it might write more bytes than the returned number of
>> inflated bytes into the buffer `b`.
>>
>> The superclass `java.io.InputStream`
On Tue, 29 Mar 2022 01:07:33 GMT, Stuart Marks wrote:
> Pretty much just what it says.
Marked as reviewed by darcy (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8009
On Tue, 29 Mar 2022 01:07:33 GMT, Stuart Marks wrote:
> Pretty much just what it says.
Please review CSR request
[JDK-8283811](https://bugs.openjdk.java.net/browse/JDK-8283811).
-
PR: https://git.openjdk.java.net/jdk/pull/8009
Pretty much just what it says.
-
Commit messages:
- Make ObjectStreamClass final.
Changes: https://git.openjdk.java.net/jdk/pull/8009/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8009=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8283715
Stats: 1 line in 1
On Fri, 18 Feb 2022 19:47:09 GMT, Ian Graves wrote:
> Proposed change in behavior to correct inconsistencies between `\w` and `\b`
> metacharacters
This pull request has now been integrated.
Changeset: f01cce23
Author:Ian Graves
URL:
On Mon, 28 Mar 2022 21:20:00 GMT, Alisen Chung wrote:
> This reverts commit c0aecd15ae8d7abf37901f785fccaff2317c3b23.
This pull request has now been integrated.
Changeset: 634800a5
Author:Alisen Chung
Committer: Naoto Sato
URL:
On Mon, 28 Mar 2022 21:20:00 GMT, Alisen Chung wrote:
> This reverts commit c0aecd15ae8d7abf37901f785fccaff2317c3b23.
LGTM
-
Marked as reviewed by naoto (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8005
On Mon, 28 Mar 2022 21:06:35 GMT, Roger Riggs wrote:
>> While it is true for completeness, I would limit the addition of new method
>> as little as possible, because there are already several ways to obtain a
>> Locale object.
>
> As with other varargs method calls, it is possible to pass an
> Proposing to deprecate the constructors in the `java.util.Locale` class.
> There is already a factory method and a builder to return singletons, so
> there is no need to have constructors anymore unless one purposefully wants
> to create `ill-formed` Locale objects, which is discouraged. We
On Sun, 20 Mar 2022 12:45:34 GMT, Andrey Turbanov wrote:
> In a few places String.indexOf/lastIndexOf methods are called with default
> parameter for index: `0` for `indexOf`, length() for `lastIndexOf`.
> I propose to cleanup such calls. It makes code a bit easier to read. In case
> of
This reverts commit c0aecd15ae8d7abf37901f785fccaff2317c3b23.
-
Commit messages:
- Revert "8280400: JDK 19 L10n resource files update - msgdrop 10"
Changes: https://git.openjdk.java.net/jdk/pull/8005/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8005=00
Issue:
On Mon, 28 Mar 2022 21:20:00 GMT, Alisen Chung wrote:
> This reverts commit c0aecd15ae8d7abf37901f785fccaff2317c3b23.
I confirm that this is an exact backout of
[JDK-8280400](https://bugs.openjdk.java.net/browse/JDK-8280400).
-
Marked as reviewed by kcr (Author).
PR:
On Mon, 28 Mar 2022 16:00:14 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/util/Locale.java line 819:
>>
>>> 817: * @since 19
>>> 818: */
>>> 819: public static Locale of(String... fields) {
>>
>> Arguably, there should be `Locale.of` overloads taking 0 to 4
On Mon, 28 Mar 2022 18:09:29 GMT, Jim Laskey wrote:
>> We propose to provide a runtime anonymous carrier class object generator;
>> java.lang.runtime.Carrier. This generator class is designed to share
>> anonymous classes when shapes are similar. For example, if several clients
>> require
On Sun, 20 Mar 2022 13:20:31 GMT, Andrey Turbanov wrote:
> String.toString() calls doesn't make much sense. Only one place, where it
> could be used - to generate NPE. But in a few places of JDK codebase it's
> called, even when NPE will happen anyway.
> I propose to cleanup such places.
>
On Sun, 20 Mar 2022 12:45:34 GMT, Andrey Turbanov wrote:
> In a few places String.indexOf/lastIndexOf methods are called with default
> parameter for index: `0` for `indexOf`, length() for `lastIndexOf`.
> I propose to cleanup such calls. It makes code a bit easier to read. In case
> of
On Sun, 20 Mar 2022 12:45:34 GMT, Andrey Turbanov wrote:
> In a few places String.indexOf/lastIndexOf methods are called with default
> parameter for index: `0` for `indexOf`, length() for `lastIndexOf`.
> I propose to cleanup such calls. It makes code a bit easier to read. In case
> of
On Mon, 28 Mar 2022 17:50:25 GMT, Rémi Forax wrote:
> I suppose that you are raising commons.RemappingMethodAdapter and
> commons.RemappingAnnotationAdapter from the dead because you want to fix the
> code in jdk.jfr.internal.instrument later ?
correct, I would prefer the team maintaining
String.toString() calls doesn't make much sense. Only one place, where it could
be used - to generate NPE. But in a few places of JDK codebase it's called,
even when NPE will happen anyway.
I propose to cleanup such places.
Found by IntelliJ IDEA inspection `Redundant 'String' operation`.
In a few places String.indexOf/lastIndexOf methods are called with default
parameter for index: `0` for `indexOf`, length() for `lastIndexOf`.
I propose to cleanup such calls. It makes code a bit easier to read. In case of
`indexOf` it even could be faster, as there is separate intrinsic for
On Mon, 28 Mar 2022 18:51:30 GMT, Naoto Sato wrote:
>> Proposing to deprecate the constructors in the `java.util.Locale` class.
>> There is already a factory method and a builder to return singletons, so
>> there is no need to have constructors anymore unless one purposefully wants
>> to
On Mon, 28 Mar 2022 17:13:44 GMT, Lance Andersen wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> New unit test. IllegalArgumentException.
>
> test/jdk/java/util/Locale/TestOf.java line 79:
>
>> 77: @Test
> Proposing to deprecate the constructors in the `java.util.Locale` class.
> There is already a factory method and a builder to return singletons, so
> there is no need to have constructors anymore unless one purposefully wants
> to create `ill-formed` Locale objects, which is discouraged. We
On Wed, 9 Mar 2022 21:09:30 GMT, Alisen Chung wrote:
> msg drop for jdk19, Mar 9, 2022
This pull request has now been integrated.
Changeset: c0aecd15
Author:Alisen Chung
Committer: Naoto Sato
URL:
https://git.openjdk.java.net/jdk/commit/c0aecd15ae8d7abf37901f785fccaff2317c3b23
On Mon, 28 Mar 2022 17:21:40 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/java/util/zip/InflaterInputStream.java line 133:
>>
>>> 131: * Unlike the {@link InputStream#read(byte[],int,int) overridden
>>> method}
>>> 132: * of {@code InputStream}, this method might write
On Mon, Mar 28, 2022 at 7:33 PM Alan Bateman wrote:
>
> On 28/03/2022 11:02, Volker Simonis wrote:
> > :
> > As I wrote before, the extra data written into the output buffer isn't
> > sensitive because it can only originate from the history buffer (aka
> > "sliding window"). Also, this data is
> We propose to provide a runtime anonymous carrier class object generator;
> java.lang.runtime.Carrier. This generator class is designed to share
> anonymous classes when shapes are similar. For example, if several clients
> require objects containing two integer fields, then Carrier will
> We propose to provide a runtime anonymous carrier class object generator;
> java.lang.runtime.Carrier. This generator class is designed to share
> anonymous classes when shapes are similar. For example, if several clients
> require objects containing two integer fields, then Carrier will
On Mon, 28 Mar 2022 16:49:58 GMT, Vicente Romero wrote:
> Please review this PR which is updating the ASM included in the JDK to ASM
> 9.2. This version should be included in JDK19. There are basically two
> commits here, one that was automatically generated and that mostly changes
> file
On 28/03/2022 11:02, Volker Simonis wrote:
:
As I wrote before, the extra data written into the output buffer isn't
sensitive because it can only originate from the history buffer (aka
"sliding window"). Also, this data is already exposed today if the
`Inflater` class is being used stand-alone,
On Mon, 28 Mar 2022 15:01:30 GMT, Jaikiran Pai wrote:
>> Volker Simonis has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new
On Mon, 28 Mar 2022 17:02:33 GMT, Naoto Sato wrote:
>> Proposing to deprecate the constructors in the `java.util.Locale` class.
>> There is already a factory method and a builder to return singletons, so
>> there is no need to have constructors anymore unless one purposefully wants
>> to
On Mon, 28 Mar 2022 16:49:58 GMT, Vicente Romero wrote:
> Please review this PR which is updating the ASM included in the JDK to ASM
> 9.2. This version should be included in JDK19. There are basically two
> commits here, one that was automatically generated and that mostly changes
> file
> Proposing to deprecate the constructors in the `java.util.Locale` class.
> There is already a factory method and a builder to return singletons, so
> there is no need to have constructors anymore unless one purposefully wants
> to create `ill-formed` Locale objects, which is discouraged. We
Please review this PR which is updating the ASM included in the JDK to ASM 9.2.
This version should be included in JDK19.
TIA
-
Commit messages:
- additional adaptations after the automatic conversion
- 8282508: Updating ASM to 9.2 for JDK 19
Changes:
On Mon, 28 Mar 2022 10:35:04 GMT, Claes Redestad wrote:
> - Add capability to ignore fields explicitly when checking for immutability
> of classes in java.time
> - Use this to avoid a test failure due the new `rules` cache in `ZoneOffset`
> - Remove `TestZoneOffset` from problem list.
Marked
On Mon, 28 Mar 2022 11:52:38 GMT, Claes Redestad wrote:
> This address a minor inefficiency in that the `ZoneRules` of any `ZoneOffset`
> (and some `ZoneRegion`s) allocate `lastRulesCache` unnecessarily.
Marked as reviewed by naoto (Reviewer).
-
PR:
On Sun, 27 Mar 2022 08:45:01 GMT, ExE Boss wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed a build failure
>
> src/java.base/share/classes/java/util/Locale.java line 819:
>
>> 817: * @since 19
>> 818:
On Sat, 26 Mar 2022 11:30:53 GMT, Lance Andersen wrote:
> One suggestion As part of the PR, we should probably update
> test/jdk/java/util/Locale/LocaleTest.java. or perhaps add a new test for
> Locale.of() for completeness.
Thanks, Lance. Sure, I will add some new unit tests for the new
On Mon, 28 Mar 2022 10:35:04 GMT, Claes Redestad wrote:
> - Add capability to ignore fields explicitly when checking for immutability
> of classes in java.time
> - Use this to avoid a test failure due the new `rules` cache in `ZoneOffset`
> - Remove `TestZoneOffset` from problem list.
Update
On Tue, 18 Jan 2022 15:57:58 GMT, Roger Riggs wrote:
> The thread factory used to create the process reaper threads unnecessarily
> inherits the callers thread context classloader.
> The result is retention of the class loader.
>
> The thread factory used for the pool of process reaper threads
On Fri, 18 Mar 2022 15:23:27 GMT, Roger Riggs wrote:
>> The thread factory used to create the process reaper threads unnecessarily
>> inherits the callers thread context classloader.
>> The result is retention of the class loader.
>>
>> The thread factory used for the pool of process reaper
On Mon, 28 Mar 2022 10:55:30 GMT, Volker Simonis wrote:
>> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)`
>> to highlight that it might write more bytes than the returned number of
>> inflated bytes into the buffer `b`.
>>
>> The superclass `java.io.InputStream`
On Mon, 28 Mar 2022 13:11:37 GMT, Jim Laskey wrote:
>> We propose to provide a runtime anonymous carrier class object generator;
>> java.lang.runtime.Carrier. This generator class is designed to share
>> anonymous classes when shapes are similar. For example, if several clients
>> require
On Fri, 18 Mar 2022 15:23:27 GMT, Roger Riggs wrote:
>> The thread factory used to create the process reaper threads unnecessarily
>> inherits the callers thread context classloader.
>> The result is retention of the class loader.
>>
>> The thread factory used for the pool of process reaper
On Mon, 28 Mar 2022 11:44:56 GMT, Olga Mikhaltsova
wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refactored ArgCheck test to be more readable and easier to maintain and
>> backport
>
> @RogerRiggs when do you
On Mon, 28 Mar 2022 11:52:38 GMT, Claes Redestad wrote:
> This address a minor inefficiency in that the `ZoneRules` of any `ZoneOffset`
> (and some `ZoneRegion`s) allocate `lastRulesCache` unnecessarily.
LGTM
-
Marked as reviewed by rriggs (Reviewer).
PR:
> We propose to provide a runtime anonymous carrier class object generator;
> java.lang.runtime.Carrier. This generator class is designed to share
> anonymous classes when shapes are similar. For example, if several clients
> require objects containing two integer fields, then Carrier will
> We propose to provide a runtime anonymous carrier class object generator;
> java.lang.runtime.Carrier. This generator class is designed to share
> anonymous classes when shapes are similar. For example, if several clients
> require objects containing two integer fields, then Carrier will
This address a minor inefficiency in that the `ZoneRules` of any `ZoneOffset`
(and some `ZoneRegion`s) allocate `lastRulesCache` unnecessarily.
-
Commit messages:
- Merge branch 'master' into lastRulesCache
- Avoid allocating unused lastRulesCaches
Changes:
On Tue, 15 Mar 2022 21:11:31 GMT, Roger Riggs wrote:
>> Quoting related changes in https://bugs.openjdk.java.net/browse/JDK-8250568
>> modified the way that
>> process builder recognized argument strings, causing some arguments to be
>> doubly quoted and malformed.
>>
>> ProcessBuilder
On Fri, 25 Mar 2022 13:32:21 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which marks the `ThreadLocalRandom`
> class as `final`? Related JBS issue
> https://bugs.openjdk.java.net/browse/JDK-8283683.
>
> A CSR has been filed too
On Fri, 25 Mar 2022 13:32:21 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which marks the `ThreadLocalRandom`
> class as `final`? Related JBS issue
> https://bugs.openjdk.java.net/browse/JDK-8283683.
>
> A CSR has been filed too
On Mon, 28 Mar 2022 10:18:32 GMT, Lance Andersen wrote:
> Hi Volker,
>
> I believe your PR should point to the [JBS
> issue](https://bugs.openjdk.java.net/browse/JDK-8282648) in the title, which
> references the CSR and not the CSR directly in the title.
Sorry, you're right of course :)
> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)` to
> highlight that it might write more bytes than the returned number of
> inflated bytes into the buffer `b`.
>
> The superclass `java.io.InputStream` specifies that `read(byte[] b, int off,
> int len)` will leave
- Add capability to ignore fields explicitly when checking for immutability of
classes in java.time
- Use this to avoid a test failure due the new `rules` cache in `ZoneOffset`
- Remove `TestZoneOffset` from problem list.
-
Commit messages:
- TestZoneOffset::test_immutable should
On Mon, 28 Mar 2022 09:37:58 GMT, Volker Simonis wrote:
> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)` to
> highlight that it might write more bytes than the returned number of
> inflated bytes into the buffer `b`.
>
> The superclass `java.io.InputStream`
On Mon, Mar 28, 2022 at 10:53 AM Alan Bateman wrote:
>
> On 22/03/2022 12:28, Volker Simonis wrote:
> > :
> > I don't really understand this concern? Do you mean what happens if
> > another thread is changing the content of the output buffer during an
> > inflate? I think such a use case has
> The current vector `"NEG"` is implemented with substraction a vector by zero
> in case the architecture does not support the negation instruction. And to
> fit the predicate feature for architectures that support it, the masked
> vector `"NEG" ` is implemented with pattern `"v.not(m).add(1,
Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)` to
highlight that it might write more bytes than the returned number of inflated
bytes into the buffer `b`.
The superclass `java.io.InputStream` specifies that `read(byte[] b, int off,
int len)` will leave the content
On Fri, 4 Mar 2022 17:44:44 GMT, Ludovic Henry wrote:
>> Despite the hash value being cached for Strings, computing the hash still
>> represents a significant CPU usage for applications handling lots of text.
>>
>> Even though it would be generally better to do it through an enhancement to
>>
On 22/03/2022 12:28, Volker Simonis wrote:
:
I don't really understand this concern? Do you mean what happens if
another thread is changing the content of the output buffer during an
inflate? I think such a use case has never been well-defined and
amending the specification won't change anything
On Tue, 15 Mar 2022 02:47:20 GMT, Xiaohong Gong wrote:
> > Note that in terms of Java semantics, negation of floating point values
> > needs to be implemented as subtraction from negative zero rather than
> > positive zero:
> > double negate(double arg) {return -0.0 - arg; }
> > This is to
On Mon, 28 Mar 2022 07:43:29 GMT, Jie Fu wrote:
>> Xiaohong Gong has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add a superclass for vector negation
>
> src/hotspot/share/opto/vectornode.cpp line 1592:
>
>> 1590:
>> 1591: // Generate
On Tue, 22 Mar 2022 09:58:23 GMT, Xiaohong Gong wrote:
>> The current vector `"NEG"` is implemented with substraction a vector by zero
>> in case the architecture does not support the negation instruction. And to
>> fit the predicate feature for architectures that support it, the masked
>>
On Mon, 28 Mar 2022 07:40:48 GMT, Jie Fu wrote:
>> The compiler can get the real type info from `Op_NegVI` that can also handle
>> the `BYTE ` and `SHORT ` basic type. I just don't want to add more new IRs
>> which also need more match rules in the ad files.
>>
>>> Is there any performance
On Mon, 21 Mar 2022 01:19:57 GMT, Xiaohong Gong wrote:
> The compiler can get the real type info from `Op_NegVI` that can also handle
> the `BYTE ` and `SHORT ` basic type. I just don't want to add more new IRs
> which also need more match rules in the ad files.
>
> > Is there any performance
71 matches
Mail list logo
