On Mon, 2 May 2022 15:00:07 GMT, Roger Riggs wrote:
>> Ichiroh Takiguchi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8285517: System.getenv() returns unexpected value if environment variable
>> has non ASCII character
>
> Can you cl
On Fri, 6 May 2022 15:13:38 GMT, Roger Riggs wrote:
>> Ichiroh Takiguchi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8285517: System.getenv() returns unexpected value if environment variable
>> has non ASCII character
>
> test/jdk/j
> On JDK19 with Linux ja_JP.eucjp locale,
> System.getenv() returns unexpected value if environment variable has Japanese
> EUC characters.
> It seems this issue happens because of JEP 400.
> Arguments for ProcessBuilder have same kind of issue.
Ichiroh Takiguchi has updated the pull request incr
> This is the implementation of JEP 425: Virtual Threads (Preview).
>
> We will refresh this PR periodically to pick up changes and fixes from the
> loom repo.
>
> Most of the new mechanisms in the HotSpot VM are disabled by default and
> require running with `--enable-preview` to enable.
>
>
On Fri, 6 May 2022 14:59:26 GMT, Paul Sandoz wrote:
>> Make sense! Thanks for the explanation!
>
> Doh! of course. This is not the first and will not be the last time i get
> caught out by the 2-slot requirement.
> It may be useful to do this:
>
> Node* mask_arg = is_store ? argument(8) : argum
On Fri, 6 May 2022 23:30:44 GMT, Jonathan Gibbons wrote:
> Please review a small doc fix to update incorrect use of `{@link}` on arrays
> of primitive types.
Looks fine in and of itself, but not sure how it will interact with the
(presumed) integration of JEP 424: "Foreign Function & Memory AP
On Fri, 6 May 2022 23:30:44 GMT, Jonathan Gibbons wrote:
> Please review a small doc fix to update incorrect use of `{@link}` on arrays
> of primitive types.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8584
On Thu, 5 May 2022 16:49:07 GMT, Mark Powers wrote:
> JDK-6725221 Standardize obtaining boolean properties with defaults
Sorry for the confusion.
The original intent of this bug 14 years ago was to standardize the seclibs
code where simple getProperty calls were needed in the context of an
Ac
On Fri, 6 May 2022 23:30:44 GMT, Jonathan Gibbons wrote:
> Please review a small doc fix to update incorrect use of `{@link}` on arrays
> of primitive types.
Marked as reviewed by mchung (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8584
Please review a small doc fix to update incorrect use of `{@link}` on arrays of
primitive types.
-
Commit messages:
- JDK-8286347: incorrect use of `{@link}`
Changes: https://git.openjdk.java.net/jdk/pull/8584/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8584&range=
On Fri, 6 May 2022 21:46:58 GMT, Martin Buchholz wrote:
>> --- a/test/jdk/java/util/concurrent/tck/ForkJoinPool19Test.java
>> +++ b/test/jdk/java/util/concurrent/tck/ForkJoinPool19Test.java
>> @@ -55,7 +55,7 @@ public class ForkJoinPool19Test extends JSR166TestCase {
>> }
>>
>> public
On Thu, 21 Apr 2022 00:48:00 GMT, Stuart Marks wrote:
>> Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare
>> values by identity. Updated API documentation of these two methods
>> ([Preview](https://cr.openjdk.java.net/~liach/8178355/IdentityHashMap.html#remove(java.la
On Wed, 4 May 2022 20:27:04 GMT, lennartfricke wrote:
> Provide micro-benchmark for comparison
Seems reasonable to me. plus(long, long) already has this optimisation.
-
Marked as reviewed by scolebourne (Author).
PR: https://git.openjdk.java.net/jdk/pull/8542
> Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare
> values by identity. Updated API documentation of these two methods
> ([Preview](https://cr.openjdk.java.net/~liach/8178355/IdentityHashMap.html#remove(java.lang.Object,java.lang.Object)))
> to mention such behavior.
On Fri, 6 May 2022 21:28:45 GMT, Martin Buchholz wrote:
>> Tests in this file are not being executed. I think you need:
>>
>> --- a/test/jdk/java/util/concurrent/tck/ForkJoinPool19Test.java
>> +++ b/test/jdk/java/util/concurrent/tck/ForkJoinPool19Test.java
>> @@ -55,7 +55,7 @@ public class Fork
On Fri, 6 May 2022 20:25:10 GMT, Martin Buchholz wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix doc types
>
> test/jdk/java/util/concurrent/tck/ForkJoinPool19Test.java line 496:
>
>> 494:
>> 495: /**
>> 496:
On Fri, 6 May 2022 21:27:53 GMT, Martin Buchholz wrote:
>> test/jdk/java/util/concurrent/tck/ForkJoinPool19Test.java line 496:
>>
>>> 494:
>>> 495: /**
>>> 496: * Implictly closing a new pool using try-with-resources
>>> terminates it
>>
>> Typo "Implictly" - twice
>
> Tests in this
> Changes ForkJoinPool.close spec and code to trap close as a no-op if called
> on common pool
Doug Lea has updated the pull request incrementally with one additional commit
since the last revision:
Fix doc types
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8577/fil
On Fri, 6 May 2022 14:29:06 GMT, Ichiroh Takiguchi
wrote:
>> test/jdk/java/lang/System/i18nEnvArg.java line 110:
>>
>>> 108: String s = System.getenv(EUC_JP_TEXT);
>>> 109: ByteArrayOutputStream baos = new ByteArrayOutputStream();
>>> 110: PrintStream ps = ne
On Fri, 6 May 2022 20:03:35 GMT, Naoto Sato wrote:
>> Ichiroh Takiguchi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8285517: System.getenv() returns unexpected value if environment variable
>> has non ASCII character
>
> src/java.ba
On Fri, 6 May 2022 15:05:57 GMT, Doug Lea wrote:
> Changes ForkJoinPool.close spec and code to trap close as a no-op if called
> on common pool
test/jdk/java/util/concurrent/tck/ForkJoinPool19Test.java line 496:
> 494:
> 495: /**
> 496: * Implictly closing a new pool using try-with-r
On Fri, 6 May 2022 14:33:50 GMT, Shruthi wrote:
>> Removing the Duplicate keys present in XSLTErrorResources.java and
>> XPATHErrorResources.java
>>
>> The bug report for the same: https://bugs.openjdk.java.net/browse/JDK-8285097
>
> Shruthi has updated the pull request incrementally with one a
On Fri, 6 May 2022 14:23:00 GMT, Ichiroh Takiguchi
wrote:
>> On JDK19 with Linux ja_JP.eucjp locale,
>> System.getenv() returns unexpected value if environment variable has
>> Japanese EUC characters.
>> It seems this issue happens because of JEP 400.
>> Arguments for ProcessBuilder have same k
On Fri, 22 Apr 2022 03:37:27 GMT, Stuart Marks wrote:
> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
> in the bug report that breaks `IdentityHashMap` now causes several cases in
> this new test to fail. There's more that could be done, but the new tests
> cover
> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
> in the bug report that breaks `IdentityHashMap` now causes several cases in
> this new test to fail. There's more that could be done, but the new tests
> cover most of the core functions of `IdentityHashMap`. Unfort
On Fri, 6 May 2022 16:59:16 GMT, Lance Andersen wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add some assertions for entrySet.equals and keySet.equals
>
> I think you have done a nice job on the coverage.
>
> I
On Thu, 5 May 2022 16:49:07 GMT, Mark Powers wrote:
> JDK-6725221 Standardize obtaining boolean properties with defaults
The xtoolkit change is fine. I've not looked at anything else
You'll clearly need multiple reviewers for this one.
-
Marked as reviewed by prr (Reviewer).
PR: h
On Fri, 6 May 2022 15:05:57 GMT, Doug Lea wrote:
> Changes ForkJoinPool.close spec and code to trap close as a no-op if called
> on common pool
Changes look good, it will need a CSR.
-
PR: https://git.openjdk.java.net/jdk/pull/8577
On Thu, 5 May 2022 16:49:07 GMT, Mark Powers wrote:
> JDK-6725221 Standardize obtaining boolean properties with defaults
src/java.base/share/classes/java/lang/reflect/AccessibleObject.java line 777:
> 775: if (!printStackPropertiesSet && VM.initLevel() >= 1) {
> 776: printSt
JDK-6725221 Standardize obtaining boolean properties with defaults
-
Commit messages:
- Merge
- first iteration
Changes: https://git.openjdk.java.net/jdk/pull/8559/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8559&range=00
Issue: https://bugs.openjdk.java.net/brow
On Fri, 6 May 2022 14:30:10 GMT, Maurizio Cimadamore
wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflecting review feedback.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java line 752:
>
>>
On Thu, 5 May 2022 18:11:54 GMT, Vicente Romero wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflecting review feedback.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java line 4217:
>
>> 4215:
On Fri, 6 May 2022 15:44:22 GMT, Gavin Bierman wrote:
> > From the JLS specdiff
> > > If the type R names a generic record class then it is a compile-time
> > > error if R is not a parameterized type.
> >
> >
> > The following snippet raises a `MatchException`. Shouldn't it be a
> > compile-t
On Fri, 6 May 2022 14:09:24 GMT, Jan Lahoda wrote:
>> 8262889: Compiler implementation for Record Patterns
>>
>> A first version of a patch that introduces record patterns into javac as a
>> preview feature. For the specification, please see:
>> http://cr.openjdk.java.net/~gbierman/jep427+405/j
On Wed, 4 May 2022 19:16:14 GMT, Stuart Marks wrote:
>> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
>> in the bug report that breaks `IdentityHashMap` now causes several cases in
>> this new test to fail. There's more that could be done, but the new tests
>> co
On Fri, 6 May 2022 16:48:11 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-424 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull request
On Fri, 6 May 2022 06:41:31 GMT, Matthias Baesken wrote:
>> The isMusl method had to be handled in
>> test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java .
>> Additionally, the vm.musl predicate seem not to be available in the
>> langtools tests.
>
> Matthias Baesken has upd
On Wed, 4 May 2022 03:01:19 GMT, Ichiroh Takiguchi
wrote:
>> Do we need to verify the intermediate byte encoding? Could we simply compare
>> the text given to environ.put() in Start process and System.getenv() in
>> Verify process match?
>
> Hello @naotoj .
> I think if 2nd process' encoder (l
On Fri, 6 May 2022 14:23:00 GMT, Ichiroh Takiguchi
wrote:
>> On JDK19 with Linux ja_JP.eucjp locale,
>> System.getenv() returns unexpected value if environment variable has
>> Japanese EUC characters.
>> It seems this issue happens because of JEP 400.
>> Arguments for ProcessBuilder have same k
On Thu, 5 May 2022 16:13:59 GMT, Naoto Sato wrote:
> Trivial fix to 3rd party copyright notices.
This pull request has now been integrated.
Changeset: 1277f5d8
Author:Naoto Sato
URL:
https://git.openjdk.java.net/jdk/commit/1277f5d84e9c2863595396a471a61d83f8a0298c
Stats: 100 line
On Wed, 4 May 2022 20:27:04 GMT, lennartfricke wrote:
> Provide micro-benchmark for comparison
Hi, thanks for the contribution!
How big a speed-up are you observing?
Keeping the optimization in `plusSeconds` rather than moving it to `plus(long,
long)` means expressions like `instant.plusMil
On Fri, 6 May 2022 06:39:59 GMT, XenoAmess wrote:
> > It would be nice if such a test could be written, but as it stands I think
> > that `Wrappers.java` test is too simplistic.
>
> Would adding `Wrappers.java` a method-name white-list mechanism suitable in
> this situation?
It should really
On Fri, 6 May 2022 11:51:46 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-424 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk
On Wed, 4 May 2022 20:27:04 GMT, lennartfricke wrote:
> Provide micro-benchmark for comparison
Hi, please send an e-Mail to dalibor.to...@oracle.com so that I can mark your
account as verified.
-
PR: https://git.openjdk.java.net/jdk/pull/8542
Provide micro-benchmark for comparison
-
Commit messages:
- 8286163: micro-optimize Instant.plusSeconds
Changes: https://git.openjdk.java.net/jdk/pull/8542/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8542&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-82
On Fri, 6 May 2022 14:09:24 GMT, Jan Lahoda wrote:
>> 8262889: Compiler implementation for Record Patterns
>>
>> A first version of a patch that introduces record patterns into javac as a
>> preview feature. For the specification, please see:
>> http://cr.openjdk.java.net/~gbierman/jep427+405/j
On Fri, 6 May 2022 08:40:40 GMT, Raffaello Giulietti
wrote:
>> Hello,
>>
>> here's a PR for a patch submitted on March 2020
>> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was
>> a thing.
>>
>> The patch has been edited to adhere to OpenJDK code conventions about
On Fri, 6 May 2022 11:32:25 GMT, Claes Redestad wrote:
> A few untested and unused methods in `VerifyType` which can be removed.
> (Possibly used by native JSR 292 implementations in JDK 7).
Looks fine.
-
Marked as reviewed by bpb (Reviewer).
PR: https://git.openjdk.java.net/jdk/
Changes ForkJoinPool.close spec and code to trap close as a no-op if called on
common pool
-
Commit messages:
- Override close as explicit no-op for common pool
Changes: https://git.openjdk.java.net/jdk/pull/8577/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8577&ran
On Fri, 6 May 2022 04:49:39 GMT, Xiaohong Gong wrote:
>> offset is long so uses two argument slots (5 and 6).
>> mask is argument (7).
>> offsetInRange is argument(8).
>
> Make sense! Thanks for the explanation!
Doh! of course. This is not the first and will not be the last time i get
caught o
On Wed, 20 Apr 2022 15:48:54 GMT, Tyler Steele wrote:
>> Shruthi has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Replace the ER_RTF_NOT_SUPPORTED_XRTREEFRAGSELECTWRAPPER key in
>> XPATHErrorResources language files
>
> src/java.xml/shar
On Mon, 2 May 2022 07:39:39 GMT, Shruthi wrote:
>> Shruthi has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updating last modified tag and XRTreeFragSelectWrapper.java
>
> `/integrate`
LGTM. Nicely done @shruacha1234
-
PR:
On Fri, 6 May 2022 14:33:50 GMT, Shruthi wrote:
>> Removing the Duplicate keys present in XSLTErrorResources.java and
>> XPATHErrorResources.java
>>
>> The bug report for the same: https://bugs.openjdk.java.net/browse/JDK-8285097
>
> Shruthi has updated the pull request incrementally with one a
On Fri, 6 May 2022 14:09:24 GMT, Jan Lahoda wrote:
>> 8262889: Compiler implementation for Record Patterns
>>
>> A first version of a patch that introduces record patterns into javac as a
>> preview feature. For the specification, please see:
>> http://cr.openjdk.java.net/~gbierman/jep427+405/j
On Wed, 4 May 2022 08:00:08 GMT, Matthias Baesken wrote:
>> Currently we set _WIN32_WINNT at various places in the codebase; this is
>> used to target a minimum Windows version we want to support. See also for
>> more detailled information :
>> https://docs.microsoft.com/en-us/windows/win32/win
> Removing the Duplicate keys present in XSLTErrorResources.java and
> XPATHErrorResources.java
>
> The bug report for the same: https://bugs.openjdk.java.net/browse/JDK-8285097
Shruthi has updated the pull request incrementally with one additional commit
since the last revision:
Replace the
On Thu, 5 May 2022 01:34:48 GMT, Naoto Sato wrote:
>> Ichiroh Takiguchi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8285517: System.getenv() returns unexpected value if environment variable
>> has non ASCII character
>
> test/jdk/ja
On Mon, 2 May 2022 15:00:07 GMT, Roger Riggs wrote:
>> Ichiroh Takiguchi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8285517: System.getenv() returns unexpected value if environment variable
>> has non ASCII character
>
> Can you cl
On Fri, 6 May 2022 14:09:24 GMT, Jan Lahoda wrote:
>> 8262889: Compiler implementation for Record Patterns
>>
>> A first version of a patch that introduces record patterns into javac as a
>> preview feature. For the specification, please see:
>> http://cr.openjdk.java.net/~gbierman/jep427+405/j
> On JDK19 with Linux ja_JP.eucjp locale,
> System.getenv() returns unexpected value if environment variable has Japanese
> EUC characters.
> It seems this issue happens because of JEP 400.
> Arguments for ProcessBuilder have same kind of issue.
Ichiroh Takiguchi has updated the pull request incr
> 8262889: Compiler implementation for Record Patterns
>
> A first version of a patch that introduces record patterns into javac as a
> preview feature. For the specification, please see:
> http://cr.openjdk.java.net/~gbierman/jep427+405/jep427+405-20220426/specs/patterns-switch-record-patterns-j
On Mon, 14 Mar 2022 19:12:29 GMT, iaroslavski wrote:
>> Sorting:
>>
>> - adopt radix sort for sequential and parallel sorts on
>> int/long/float/double arrays (almost random and length > 6K)
>> - fix tryMergeRuns() to better handle case when the last run is a single
>> element
>> - minor javad
On Wed, 4 May 2022 08:00:08 GMT, Matthias Baesken wrote:
>> Currently we set _WIN32_WINNT at various places in the codebase; this is
>> used to target a minimum Windows version we want to support. See also for
>> more detailled information :
>> https://docs.microsoft.com/en-us/windows/win32/win
On Wed, 4 May 2022 10:03:13 GMT, Maurizio Cimadamore
wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java line 4180:
>>
>>> 4178: type = attribTree(tree.var.vartype, env, varInfo);
>>> 4179: } else {
>>> 4180: type = resultInfo.pt;
>>
>> L
On Fri, 6 May 2022 08:42:12 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/jdk/internal/reflect/Reflection.java line 120:
>>
>>> 118: // if there is no caller class, act as if the call came from
>>> an unnamed module
>>> 119: Module module = currentClass != null
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull request
On Fri, 6 May 2022 10:51:33 GMT, Jan Lahoda wrote:
>> I now believe that the check is needed to properly classify patterns based
>> on the type of the i-th component. That said, not sure this should be a
>> subtyping check, or a type equality
>
> A good question. Consider code like:
>
> pr
A few untested and unused methods in `VerifyType` which can be removed.
(Possibly used by native JSR 292 implementations in JDK 7).
-
Commit messages:
- Remove unused methods in sun.invoke.util.VerifyType
Changes: https://git.openjdk.java.net/jdk/pull/8570/files
Webrev: https://we
On Thu, 5 May 2022 15:17:11 GMT, Maurizio Cimadamore
wrote:
>> You are right. It is the ii) which iteratively checks the component pattern
>> list L.
>
> I now believe that the check is needed to properly classify patterns based on
> the type of the i-th component. That said, not sure this sho
On Thu, 5 May 2022 05:47:47 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> Patch adds the planned support for new vector operations and APIs targeted
>> for [JEP 426: Vector API (Fourth
>> Incubator).](https://bugs.openjdk.java.net/browse/JDK-8280173)
>>
>> Following is the brief summary of chang
On Wed, 4 May 2022 08:00:08 GMT, Matthias Baesken wrote:
>> Currently we set _WIN32_WINNT at various places in the codebase; this is
>> used to target a minimum Windows version we want to support. See also for
>> more detailled information :
>> https://docs.microsoft.com/en-us/windows/win32/win
On Wed, 4 May 2022 08:00:08 GMT, Matthias Baesken wrote:
>> Currently we set _WIN32_WINNT at various places in the codebase; this is
>> used to target a minimum Windows version we want to support. See also for
>> more detailled information :
>> https://docs.microsoft.com/en-us/windows/win32/win
On Fri, 6 May 2022 06:48:46 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview).
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the HotSpot VM are disabled by default an
On Thu, 5 May 2022 11:57:34 GMT, Aggelos Biboudis
wrote:
>> 8262889: Compiler implementation for Record Patterns
>>
>> A first version of a patch that introduces record patterns into javac as a
>> preview feature. For the specification, please see:
>> http://cr.openjdk.java.net/~gbierman/jep42
On Thu, 5 May 2022 21:28:32 GMT, Mandy Chung wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> * Clarify what happens when SymbolLookup::loaderLookup is invoked from JNI
>> * Tweak restricted method check to
> Hello,
>
> here's a PR for a patch submitted on March 2020
> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was a
> thing.
>
> The patch has been edited to adhere to OpenJDK code conventions about
> multi-line (block) comments. Nothing in the code proper has changed,
On Thu, 5 May 2022 18:54:49 GMT, Alan Bateman wrote:
> We mailed porters-dev in Sep 2021 to give a heads up that this feature would
> require porting work so it shouldn't be a surprise. We have been open to
> including other ports with the initial integration but it was never a goal to
> have
> Hello,
>
> here's a PR for a patch submitted on March 2020
> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was a
> thing.
>
> The patch has been edited to adhere to OpenJDK code conventions about
> multi-line (block) comments. Nothing in the code proper has changed,
On Wed, 4 May 2022 09:08:28 GMT, Matthias Baesken wrote:
> Does this mean that not setting _WIN32_WINNT means :any API is allowed" ?
Hi David , I did one more try with my current setup (VS2017 on a Win10
notebook). I did not set _WIN32_WINNT.
My little test program
#include
#include
int m
> Hello,
>
> here's a PR for a patch submitted on March 2020
> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was a
> thing.
>
> The patch has been edited to adhere to OpenJDK code conventions about
> multi-line (block) comments. Nothing in the code proper has changed,
81 matches
Mail list logo
